Fixes for a lot bug tickets. (Sorry for lame comment)

[mailer.git] / inc / modules / admin / overview-inc.php

diff --git a/inc/modules/admin/overview-inc.php b/inc/modules/admin/overview-inc.php
index 65432430c4508356a5dc07e2826e8330ef56ddf0..ee772bbdb7c975523e348fe13cadaf4eac3bce22 100644 (file)
--- a/inc/modules/admin/overview-inc.php
+++ b/inc/modules/admin/overview-inc.php
@@ -117,13 +117,13 @@ ORDER BY userid DESC, task_type DESC, subject, task_created DESC",
        return $JOBS_DONE;
 }
 
-//
-function OUTPUT_SELECTED_TASKS($_POST, $result_tasks) {
+// Outputs selected tasks
+function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
        global $_CONFIG, $NOTES;
-       if ((isset($_POST['assign'])) && (count($_POST['task']) > 0)) {
+       if ((isset($POST['assign'])) && (count($POST['task']) > 0)) {
                // Assign / do tasks
                $OUT = ""; $SW = 2;
-               foreach ($_POST['task'] as $id => $sel) {
+               foreach ($POST['task'] as $id => $sel) {
                        $result_task = SQL_QUERY_ESC("SELECT id, userid, task_type, subject, text, task_created, status, assigned_admin FROM "._MYSQL_PREFIX."_task_system WHERE id=%s AND (assigned_admin='%s' OR (assigned_admin='0' AND status='NEW')) LIMIT 1",
                                array(bigintval($id), GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
                        if (SQL_NUMROWS($result_task) == 1) {
@@ -244,12 +244,13 @@ function OUTPUT_SELECTED_TASKS($_POST, $result_tasks) {
 
                                                // Close task but not already closes or deleted or update tasks
                                                if (($status != "CLOSED") && ($status != "DELETED") && ($type != "EXTENSION_UPDATE")) {
+                                                       // Solve the task
                                                        RUN_FILTER('solve_task', $tid);
                                                } // END - if
                                        }
                                        break;
 
-                               case "EXTENSION_UPDATE":
+                               case "EXTENSION_UPDATE": // Extension update
                                        // Extension updates are installed automatically
                                        $OUT .= "<FONT class=\"admin_failed medium\">".ADMIN_EXTENSION_UPDATED."</FONT>\n";
 
@@ -274,7 +275,7 @@ function OUTPUT_SELECTED_TASKS($_POST, $result_tasks) {
                                        if (EXT_IS_ACTIVE("payout")) {
                                                // Extension is installed so let him send a notification to the user
                                                $result_pay = SQL_QUERY_ESC("SELECT id FROM "._MYSQL_PREFIX."_user_payouts WHERE userid=%s AND payout_timestamp=%s LIMIT 1",
-                                                array(bigintval($uid), bigintval($created)), __FILE__, __LINE__);
+                                                       array(bigintval($uid), bigintval($created)), __FILE__, __LINE__);
                                                list($pid) = SQL_FETCHROW($result_pay);
                                                SQL_FREERESULT($result_pay);
 
@@ -359,17 +360,17 @@ function OUTPUT_SELECTED_TASKS($_POST, $result_tasks) {
                // Load final template
                LOAD_TEMPLATE("admin_overview_list");
        } else {
-               if ((isset($_POST['task'])) && ((sizeof($_POST['task']) > 0) || ($_POST['task'][0] == "1"))) {
+               if ((isset($POST['task'])) && ((sizeof($POST['task']) > 0) || ($POST['task'][0] == "1"))) {
                        // Only unassign / delete tasks when there are selected tasks posted
-                       if (!empty($_POST['unassign'])) {
+                       if (!empty($POST['unassign'])) {
                                // Unassign from tasks
-                               foreach ($_POST['task'] as $id => $sel) {
+                               foreach ($POST['task'] as $id => $sel) {
                                        SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_task_system SET assigned_admin=0 WHERE id=%s AND assigned_admin=%s LIMIT 1",
                                                array(bigintval($id), GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
                                }
-                       } elseif (isset($_POST['del'])) {
+                       } elseif (isset($POST['del'])) {
                                // Delete tasks
-                               foreach ($_POST['task'] as $id => $sel) {
+                               foreach ($POST['task'] as $id => $sel) {
                                        SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM "._MYSQL_PREFIX."_task_system WHERE id=%s AND assigned_admin IN (%s,0) LIMIT 1",
                                                array(bigintval($id), GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
                                }