Previous fix fixed, a lot constants rewritten (unfinished)

[mailer.git] / inc / modules / admin / what-admins_mails.php

diff --git a/inc/modules/admin/what-admins_mails.php b/inc/modules/admin/what-admins_mails.php
index 7089670e0ee48f6fa7024cbf01c005d96ca35235..45ad9068406ab4a4b41e92b8b5a5b90f11f5467b 100644 (file)
--- a/inc/modules/admin/what-admins_mails.php
+++ b/inc/modules/admin/what-admins_mails.php
@@ -32,13 +32,13 @@
  ************************************************************************/
 
 // Some security stuff...
-if ((ereg(basename(__FILE__), $_SERVER['PHP_SELF'])) || (!IS_ADMIN()))
-{
+if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
        $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
        require($INC);
 }
+
 // Add description as navigation point
-ADD_DESCR("admin", basename(__FILE__));
+ADD_DESCR("admin", __FILE__);
 
 if (isset($_POST['edit']))
 {
@@ -49,26 +49,26 @@ if (isset($_POST['edit']))
                // Add option for userlog
                $cacheArray['admins'] = ADD_OPTION_LINES("admins", "id", "login", "", "email");
                $SW = 2; $rowNameS = "";
-               foreach ($_POST['sel'] as $template=>$sel)
+               foreach ($_POST['sel'] as $template => $sel)
                {
                        // First of all load data from DB
-                       $result = SQL_QUERY_ESC("SELECT admin_id, id FROM "._MYSQL_PREFIX."_admins_mails WHERE mail_template='%s' ORDER BY id",
+                       $result = SQL_QUERY_ESC("SELECT admin_id, id FROM `{!_MYSQL_PREFIX!}_admins_mails` WHERE mail_template='%s' ORDER BY `id`",
                         array($template), __FILE__, __LINE__);
-                       $OUT = ""; $aid = "0"; $aid2 = "0";
+                       $OUT = ""; $aid = 0; $aid2 = 0;
                        while (list($aid, $id) = SQL_FETCHROW($result))
                        {
-                               $OUT .= "<SELECT name=\"admin_id[".$id."]\" size=\"1\" class=\"admin_select\">
-<OPTION value=\"0\"";
+                               $OUT .= "<select name=\"admin_id[".$id."]\" size=\"1\" class=\"admin_select\">
+<option value=\"0\"";
                                if ($aid == "0") $OUT .= " selected default";
-                               $OUT .=">".ADMINS_ALL_ADMINS."</OPTION>\n";
+                               $OUT .=">".ADMINS_ALL_ADMINS."</option>\n";
                                if (EXT_IS_ACTIVE("userlog"))
                                {
-                                       $OUT .= "<OPTION value=\"-1\"";
+                                       $OUT .= "<option value=\"-1\"";
                                        if ($aid == "-1") $OUT .= " selected default";
-                                       $OUT .= ">".ADMINS_TO_USERLOG."</OPTION>\n";
+                                       $OUT .= ">".ADMINS_TO_USERLOG."</option>\n";
                                }
                                $OUT .= ADD_OPTION_LINES("admins", "id", "login", $aid, "email");
-                               $OUT .= "</SELECT><br />\n";
+                               $OUT .= "</select><br />\n";
                                $aid2 = $aid; $id2 = $id;
                        }
 
@@ -110,8 +110,8 @@ if (isset($_POST['edit']))
 {
        // Load all assigned mails
        $result = SQL_QUERY("SELECT DISTINCT m.id, m.admin_id, a.login, m.mail_template
-FROM "._MYSQL_PREFIX."_admins_mails AS m
-LEFT JOIN "._MYSQL_PREFIX."_admins AS a
+FROM `{!_MYSQL_PREFIX!}_admins_mails` AS m
+LEFT JOIN `{!_MYSQL_PREFIX!}_admins` AS a
 ON m.admin_id=a.id
 WHERE (m.admin_id=a.id OR m.admin_id < 1) AND m.mail_template != ''
 ORDER BY m.admin_id, m.mail_template", __FILE__, __LINE__);
@@ -122,55 +122,56 @@ ORDER BY m.admin_id, m.mail_template", __FILE__, __LINE__);
                if (isset($_POST['change']))
                {
                        // Ok, update database
-                       foreach ($_POST['admin_id'] as $id=>$aid)
+                       foreach ($_POST['admin_id'] as $id => $aid)
                        {
                                // Secure IDs
                                $id  = bigintval($id);
                                $aid = bigintval($aid);
 
                                // Update entry
-                               $result = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_admins_mails SET admin_id=%s WHERE id=%s ORDER BY id LIMIT 1",
-                                array($aid, $id), __FILE__, __LINE__);
+                               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_admins_mails` SET admin_id=%s WHERE id=%s ORDER BY `id` LIMIT 1",
+                                       array($aid, $id), __FILE__, __LINE__);
 
                                if (($aid < 1) && (!empty($_POST['template'][$id])))
                                {
                                        // Remove any other admin entries
-                                       $result = SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM "._MYSQL_PREFIX."_admins_mails WHERE mail_template='%s' AND id != '%s'",
-                                        array($_POST['template'][$id], $id), __FILE__, __LINE__);
+                                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_admins_mails` WHERE mail_template='%s' AND id != '%s'",
+                                               array($_POST['template'][$id], $id), __FILE__, __LINE__);
                                }
                                if ($_POST['admin_new'][$_POST['template'][$id]] > 0)
                                {
                                        // Add new admin
-                                       $result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_admins_mails (admin_id, mail_template) VALUES ('%s', '%s')",
-                                        array($aid, $_POST['template'][$id]), __FILE__, __LINE__);
+                                       SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_admins_mails` (admin_id, mail_template) VALUES ('%s','%s')",
+                                               array($aid, $_POST['template'][$id]), __FILE__, __LINE__);
                                }
                        }
 
                        // Query again...
-                       $result = SQL_QUERY("SELECT DISTINCT m.id, m.admin_id, a.login, m.mail_template FROM "._MYSQL_PREFIX."_admins_mails AS m, "._MYSQL_PREFIX."_admins AS a WHERE m.admin_id=a.id OR m.admin_id < 1 ORDER BY m.admin_id", __FILE__, __LINE__);
+                       $result = SQL_QUERY("SELECT DISTINCT m.id, m.admin_id, a.login, m.mail_template FROM `{!_MYSQL_PREFIX!}_admins_mails` AS m, `{!_MYSQL_PREFIX!}_admins` AS a WHERE m.admin_id=a.id OR m.admin_id < 1 ORDER BY m.admin_id", __FILE__, __LINE__);
                }
 
                // List found entries
                $SW = 2; $OUT = "";
-               while(list($id, $aid, $admin, $templ) = SQL_FETCHROW($result))
+               while (list($id, $aid, $admin, $templ) = SQL_FETCHROW($result))
                {
                        if ($aid > 0)
                        {
                                // Admin assigned
-                               $admin_link = "<A href=\"".URL."/modules.php?module=admin&amp;what=admins_contct&amp;admin=".$aid."\">".$admin."</A>";
+                               $admin_link = "<a href=\"{!URL!}/modules.php?module=admin&amp;what=admins_contct&amp;admin=".$aid."\">".$admin."</a>";
                        }
                         elseif ($aid == 0)
                        {
                                // All admins
-                               $admin_link = "<I>".ADMINS_ALL_ADMINS."</I>";
+                               $admin_link = "<em>".ADMINS_ALL_ADMINS."</em>";
                        }
                         elseif (($aid == -1) && (EXT_IS_ACTIVE("usrlog")))
                        {
                                // To userlog
-                               $admin_link = "<I>".ADMINS_TO_USERLOG."</I>";
+                               $admin_link = "<em>".ADMINS_TO_USERLOG."</em>";
                        }
                        $content = array(
                                'sw'   => $SW,
+                               'id'   => $id,
                                'tpl'  => $templ,
                                'alnk' => $admin_link
                        );