New naming convention applied to many functions, see #118 for details

[mailer.git] / inc / modules / admin / what-config_admins.php

diff --git a/inc/modules/admin/what-config_admins.php b/inc/modules/admin/what-config_admins.php
index eb0ab1447064940e223fd2a840989f12034bd852..24b9126b76f63ab4ce7dea31ec16cca845e09da4 100644 (file)
--- a/inc/modules/admin/what-config_admins.php
+++ b/inc/modules/admin/what-config_admins.php
@@ -38,22 +38,22 @@
 
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
-       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
        require($INC);
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", __FILE__);
+ADD_DESCR('admin', __FILE__);
 
 $SEL = 0;
-if (REQUEST_ISSET_POST('sel')) $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
+if (REQUEST_ISSET_POST('sel')) $SEL = countPostSelection();
 
 if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
        // Edit ACLs
-       $OUT = ""; $SW = 2;
+       $OUT = ''; $SW = 2;
        foreach (REQUEST_POST('sel') as $id => $selected) {
                // Load data for the ID
-               $result = SQL_QUERY_ESC("SELECT admin_id, action_menu, what_menu, access_mode FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE id=%s LIMIT 1",
+               $result = SQL_QUERY_ESC("SELECT admin_id, action_menu, what_menu, access_mode FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE `id`=%s LIMIT 1",
                 array(bigintval($id)), __FILE__, __LINE__);
                list($aid, $act, $wht, $mode) = SQL_FETCHROW($result);
                SQL_FREERESULT($result);
@@ -62,10 +62,10 @@ if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
                $content = array(
                        'sw'               => $SW,
                        'id'               => $id,
-                       'admins_selection' => ADD_OPTION_LINES("admins", "id", "login", $aid, "default_acl"),
+                       'admins_selection' => generateOptionList('admins', "id", "login", $aid, "default_acl"),
                        'action_selection' => ADMIN_MENU_SELECTION("action", $act, $id),
                        'what_selection'   => ADMIN_MENU_SELECTION("what", $wht, $id),
-                       'mode_options'     => ADD_OPTION_LINES(
+                       'mode_options'     => generateOptionList(
                                "/ARRAY/",
                                array("allow", "deny"),
                                array(constant('ADMINS_ALLOW_MODE'), constant('ADMINS_DENY_MODE')),
@@ -88,7 +88,7 @@ if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
                $id = bigintval($id);
 
                // Update entries
-               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_admins_acls` SET admin_id=%s, action_menu='%s', what_menu='%s', access_mode='%s' WHERE id=%s LIMIT 1",
+               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_admins_acls` SET admin_id=%s, action_menu='%s', what_menu='%s', access_mode='%s' WHERE `id`=%s LIMIT 1",
                        array(
                                REQUEST_POST('admin', $id),
                                REQUEST_POST('action_menu', $id),
@@ -99,34 +99,34 @@ if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
        }
 
        // Update cache when installed
-       if (EXT_IS_ACTIVE("cache")) {
+       if (EXT_IS_ACTIVE('cache')) {
                if ($GLOBALS['cache_instance']->loadCacheFile("admins_acls")) $GLOBALS['cache_instance']->destroyCacheFile();
 
                // Purge menu cache
-               CACHE_PURGE_ADMIN_MENU(REQUEST_POST('admin', $id));
+               cachePurgeAdminMenu(REQUEST_POST('admin', $id));
        }
 
        // Entries changed
-       LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_ADMINS_ENTRIES_CHANGED'));
+       LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_ADMINS_ENTRIES_CHANGED'));
 } elseif ((REQUEST_ISSET_POST('del')) && ($SEL > 0)) {
        // Delete ACLs
-       $OUT = ""; $SW = 2;
+       $OUT = ''; $SW = 2;
        foreach (REQUEST_POST('sel') as $id => $selected) {
                // Load data for the ID
-               $result = SQL_QUERY_ESC("SELECT admin_id, action_menu, what_menu, access_mode FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE id=%s LIMIT 1",
+               $result = SQL_QUERY_ESC("SELECT admin_id, action_menu, what_menu, access_mode FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE `id`=%s LIMIT 1",
                        array(bigintval($id)), __FILE__, __LINE__);
                list($admin, $act, $wht, $mode) = SQL_FETCHROW($result);
                SQL_FREERESULT($result);
 
                // Prepare variables
-               if (empty($act)) $act = "---";
-               if (empty($wht)) $wht = "---";
+               if (empty($act)) $act = '---';
+               if (empty($wht)) $wht = '---';
 
                // Get admin mode
                $mode = constant('ADMINS_'.strtoupper($mode).'_MODE');
 
                // Generate link
-               $admin = GENERATE_AID_LINK($admin);
+               $admin = generateAdminLink($admin);
 
                // Prepare data for the row template
                $content = array(
@@ -149,29 +149,29 @@ if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
 } elseif ((REQUEST_ISSET_POST('remove')) && ($SEL > 0)) {
        // Remove entries
        foreach (REQUEST_POST('sel') as $id => $selected) {
-               SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE id=%s LIMIT 1",
+               SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE `id`=%s LIMIT 1",
                        array(bigintval($id)),__FILE__, __LINE__);
        }
 
        // Update cache when installed
-       if (EXT_IS_ACTIVE("cache")) {
+       if (EXT_IS_ACTIVE('cache')) {
                if ($GLOBALS['cache_instance']->loadCacheFile("admins_acls")) $GLOBALS['cache_instance']->destroyCacheFile();
 
                // @TODO This causes the whole (!) menu cache being rebuild
-               CACHE_PURGE_ADMIN_MENU();
+               cachePurgeAdminMenu();
        }
 
        // Entries deleted
-       LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_ADMINS_ENTRIES_DELETED'));
+       LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_ADMINS_ENTRIES_DELETED'));
 } elseif (REQUEST_ISSET_POST(('add'))) {
        // Check if everything is fine...
-       $mode = GET_ADMIN_DEFAULT_ACL(bigintval(REQUEST_POST('admin_id')));
+       $mode = getAdminDefaultAcl(bigintval(REQUEST_POST('admin_id')));
 
        // Default ACL is false
        $ACL = false;
        if (REQUEST_ISSET_POST(('what_menu'))) {
                // Check parent ACL
-               $ACL = ADMINS_CHECK_ACL(GET_ACTION("admin", REQUEST_POST('what_menu')), "");
+               $ACL = adminsCheckAdminAcl(getModeAction('admin', REQUEST_POST('what_menu')), '');
        }
 
        if ($mode != REQUEST_POST('mode') || ($ACL)) {
@@ -179,8 +179,8 @@ if ((REQUEST_ISSET_POST('edit')) && ($SEL > 0)) {
                $BOTH = ((REQUEST_ISSET_POST(('action_menu'))) && (REQUEST_ISSET_POST(('what_menu'))));
                if (((REQUEST_ISSET_POST(('action_menu'))) || (REQUEST_ISSET_POST(('what_menu')))) && (!$BOTH)) {
                        // Main or sub menu selected
-                       $result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE admin_id=%s AND action_menu='%s' AND what_menu='%s' LIMIT 1",
-                        array(bigintval(REQUEST_POST('admin_id')), REQUEST_POST('action_menu'), REQUEST_POST('what_menu')), __FILE__, __LINE__);
+                       $result = SQL_QUERY_ESC("SELECT `id` FROM `{!_MYSQL_PREFIX!}_admins_acls` WHERE admin_id=%s AND action_menu='%s' AND what_menu='%s' LIMIT 1",
+                               array(bigintval(REQUEST_POST('admin_id')), REQUEST_POST('action_menu'), REQUEST_POST('what_menu')), __FILE__, __LINE__);
                        if (SQL_NUMROWS($result) == 0) {
                                // Finally add the new ACL
                                SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_admins_acls` (admin_id, action_menu, what_menu, access_mode)
@@ -194,11 +194,11 @@ VALUES ('%s','%s','%s','%s')",
                                $content = getMessage('ADMIN_ADMINS_ACL_SAVED');
 
                                // Update cache when installed
-                               if (EXT_IS_ACTIVE("cache")) {
+                               if (EXT_IS_ACTIVE('cache')) {
                                        if ($GLOBALS['cache_instance']->loadCacheFile("admins_acls")) $GLOBALS['cache_instance']->destroyCacheFile();
 
                                        // Purge cache
-                                       CACHE_PURGE_ADMIN_MENU(REQUEST_POST('admin_id'), REQUEST_POST('action_menu'), REQUEST_POST('what_menu'));
+                                       cachePurgeAdminMenu(REQUEST_POST('admin_id'), REQUEST_POST('action_menu'), REQUEST_POST('what_menu'));
                                } // END - if
                        } else {
                                // ACL does already exist!
@@ -217,17 +217,17 @@ VALUES ('%s','%s','%s','%s')",
        }
 
        // Display message
-       LOAD_TEMPLATE("admin_settings_saved", false, $content);
+       LOAD_TEMPLATE('admin_settings_saved', false, $content);
 } else {
        // List all ACLs
        $result_acls = SQL_QUERY("SELECT id, admin_id, action_menu, what_menu, access_mode FROM `{!_MYSQL_PREFIX!}_admins_acls` ORDER BY admin_id, id", __FILE__, __LINE__);
        if (SQL_NUMROWS($result_acls) > 0) {
                // List ACLs
-               $OUT = ""; $SW = 2;
+               $OUT = ''; $SW = 2;
                while ($content = SQL_FETCHARRAY($result_acls)) {
                        // Prepare variables
-                       if (empty($content['action_menu'])) $content['action_menu'] = "---";
-                       if (empty($content['what_menu']))   $content['what_menu']   = "---";
+                       if (empty($content['action_menu'])) $content['action_menu'] = '---';
+                       if (empty($content['what_menu']))   $content['what_menu']   = '---';
 
                        // Get mode
                        $content['access_mode'] = constant('ADMINS_'.strtoupper($content['access_mode']).'_MODE');
@@ -236,7 +236,7 @@ VALUES ('%s','%s','%s','%s')",
                        $content = array(
                                'sw'     => $SW,
                                'id'     => $content['id'],
-                               'admin'  => GENERATE_AID_LINK($content['admin_id']),
+                               'admin'  => generateAdminLink($content['admin_id']),
                                'action' => $content['action_menu'],
                                'what'   => $content['what_menu'],
                                'mode'   => $content['access_mode'],
@@ -256,11 +256,11 @@ VALUES ('%s','%s','%s','%s')",
        }
 
        // Prepare some constants for the template
-       define('_ADMINS_SELECTION', ADD_OPTION_LINES("admins", "id", "login", "", "default_acl"));
+       define('_ADMINS_SELECTION', generateOptionList('admins', "id", "login", '', "default_acl"));
        define('_ACTION_SELECTION', ADMIN_MENU_SELECTION("action"));
        define('_WHAT_SELECTION'  , ADMIN_MENU_SELECTION("what"));
        define('_MODE_OPTIONS'    ,
-               ADD_OPTION_LINES(
+               generateOptionList(
                        "/ARRAY/",
                        array("allow", "deny"),
                        array(