A lot while() conditions rewritten to SQL_FETCHARRAY(), see bug #107, @TODO tags...

[mailer.git] / inc / modules / admin / what-del_transfer.php

diff --git a/inc/modules/admin/what-del_transfer.php b/inc/modules/admin/what-del_transfer.php
index 5df9d0123ddae436cae973a2f691685dba0c8c4a..2f3d8e8f060a4a294a8510217be3bae0208c1f9c 100644 (file)
--- a/inc/modules/admin/what-del_transfer.php
+++ b/inc/modules/admin/what-del_transfer.php
@@ -32,8 +32,7 @@
  ************************************************************************/
 
 // Some security stuff...
-if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']) || (!IS_ADMIN()))
-{
+if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']) || (!IS_ADMIN())) {
        $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
        require($INC);
 }
@@ -41,74 +40,75 @@ if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']) || (!IS_ADMIN()))
 // Add description as navigation point
 ADD_DESCR("admin", __FILE__);
 
-if (REQUEST_ISSET_POST('del'))
-{
+if (REQUEST_ISSET_POST('del')) {
        // Delete entries from tables
        $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
-       if ($SEL > 0)
-       {
+       if ($SEL > 0) {
+               // Init SQLs
+               INIT_SQLS();
+
                // Delete entries...
-               foreach (REQUEST_POST('sel') as $id => $sel)
-               {
-                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_user_transfers_in` WHERE trans_id=%s LIMIT 1",
-                               array(bigintval($id)), __FILE__, __LINE__);
-                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_user_transfers_out` WHERE trans_id=%s LIMIT 1",
-                               array(bigintval($id)), __FILE__, __LINE__);
-               }
+               foreach (REQUEST_POST('sel') as $id => $sel) {
+                       ADD_SQL(SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_user_transfers_in` WHERE trans_id=%s LIMIT 1",
+                               array(bigintval($id)), __FILE__, __LINE__, false));
+                       ADD_SQL(SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_user_transfers_out` WHERE trans_id=%s LIMIT 1",
+                               array(bigintval($id)), __FILE__, __LINE__, false));
+               } // END - foreach
+
+               // Run all SQLs
+               runFilterChain('run_sqls');
        }
 }
 
 // We only need outgoing transfers
 $result = SQL_QUERY("SELECT userid, to_uid, trans_id, points, reason, time_trans FROM `{!_MYSQL_PREFIX!}_user_transfers_out` ORDER BY trans_id", __FILE__, __LINE__);
 $total = 0;
-if (SQL_NUMROWS($result) > 0)
-{
+if (SQL_NUMROWS($result) > 0) {
        // Output rows
        $OUT = ""; $SW = 2;
-       while (list($uid1, $uid2, $idx, $points, $reason, $stamp) = SQL_FETCHROW($result))
-       {
+       while ($content = SQL_FETCHARRAY($result)) {
                // Prepare data for the row template
+               // @TODO Rewritings: idx->trans_id in template
                $content = array(
                        'sw'       => $SW,
-                       'idx'      => $idx,
-                       'stamp'    => MAKE_DATETIME($stamp, "3"),
-                       'uid_from' => ADMIN_USER_PROFILE_LINK($uid1),
-                       'uid_to'   => ADMIN_USER_PROFILE_LINK($uid1),
-                       'reason'   => $reason,
-                       'points'   => TRANSLATE_COMMA($points),
+                       'idx'      => $content['trans_id'],
+                       'stamp'    => MAKE_DATETIME($content['time_trans'], "3"),
+                       'uid_from' => ADMIN_USER_PROFILE_LINK($content['userid']),
+                       'uid_to'   => ADMIN_USER_PROFILE_LINK($content['to_uid']),
+                       'reason'   => $content['reason'],
+                       'points'   => TRANSLATE_COMMA($content['points']),
                );
 
                // Load row template
                $OUT .= LOAD_TEMPLATE("admin_del_transfer_row", true, $content);
 
                // Sum points and switch colors
-               $total += $points; $SW = 3 - $SW;
+               $total += $content['points']; $SW = 3 - $SW;
        }
 
        // Free memory
        SQL_FREERESULT($result);
-}
- else
-{
+} else {
        // Nothing for in and out
        $OUT = "<tr>
   <td colspan=\"6\" align=\"center\" class=\"bottom2\" height=\"70\">
-    ".LOAD_TEMPLATE("admin_settings_saved", true, TRANSFER_NO_INOUT_TRANSFERS)."
+    ".LOAD_TEMPLATE("admin_settings_saved", true, getMessage('TRANSFER_NO_INOUT_TRANSFERS'))."
   </td>
 </tr>";
 }
 
 // ... and add them to a constant for the template
+// @TODO Rewrite all these constants
 define('__TRANSFER_ROWS', $OUT);
 
 // Remeber total amount
 define('__TRANSFER_TOTAL_VALUE', $total);
 
 // Set title
-define('__TRANSFER_TITLE', TRANSFER_LIST_ALL);
+define('__TRANSFER_TITLE', getMessage('TRANSFER_LIST_ALL'));
 
 // Show delete button here
-define('__TRANSFER_DELETE', "<input type=\"reset\" class=\"admin_reset\" value=\"".UNDO_SELECTIONS."\" />&nbsp;*&nbsp;<input type=\"submit\" name=\"del\" class=\"admin_delete\" value=\"".TRANSFER_DELETE."\" />");
+define('__TRANSFER_DELETE', "<input type=\"reset\" class=\"admin_reset\" value=\"{--UNDO_SELECTIONS--}\" />&nbsp;*&nbsp;<input type=\"submit\" name=\"del\" class=\"admin_delete\" value=\"{--TRANSFER_DELETE--}\" />");
 
 // Load final template
 LOAD_TEMPLATE("admin_list_transfer");