Huge rewrite of default parameters, ext-network continued:

[mailer.git] / inc / modules / admin / what-extensions.php

diff --git a/inc/modules/admin/what-extensions.php b/inc/modules/admin/what-extensions.php
index 407bd62158ae06eaf55da06192032d27427b2007..88811b38b0c92c8625b64c2e1bb32385d4a08f98 100644 (file)
--- a/inc/modules/admin/what-extensions.php
+++ b/inc/modules/admin/what-extensions.php
@@ -46,7 +46,7 @@ addMenuDescription('admin', __FILE__);
 
 // Normally we want the overview of all registered extensions
 $do = 'overview';
-$SEL = 0;
+$SEL = '0';
 
 // Are some extensions submitted?
 if (isPostRequestElementSet('sel')) {
@@ -57,7 +57,7 @@ if (isPostRequestElementSet('sel')) {
 if (isGetRequestElementSet('reg_ext')) {
        // We are about to register a new extension
        $do = 'register'; $ext_id = bigintval(getRequestElement('reg_ext'));
-       // The ID comes from task management and it is - of course - *not* the extension's name!
+       // The id comes from task management and it is - of course - *not* the extension's name!
 } elseif ((isPostRequestElementSet('change')) && ($SEL > 0) && (!isDemoModeActive())) {
        // De-/activate extensions
        foreach (postRequestElement('sel') as $ext_id => $active) {
@@ -66,10 +66,10 @@ if (isGetRequestElementSet('reg_ext')) {
                        // Keep this extension active!
                } else {
                        // De/activate extension
-                       $ACT = 'N'; getExtensionMode('deactivate');
+                       $ACT = 'N'; setExtensionMode('deactivate');
                        if ($active != 'Y') { $ACT = 'Y'; setExtensionMode('activate'); }
                        SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_extensions` SET `ext_active`='".$ACT."' WHERE `id`=%s AND `ext_active`='%s' LIMIT 1",
-                       array(bigintval($ext_id), $active), __FILE__, __LINE__);
+                               array(bigintval($ext_id), $active), __FILE__, __LINE__);
 
                        // Run embeded SQL commands
                        doExtensionSqls($ext_id, getExtensionMode());
@@ -79,15 +79,15 @@ if (isGetRequestElementSet('reg_ext')) {
        // Change settings like CSS file load
        if (isPostRequestElementSet(('modify'))) {
                // Change entries
-               $cache_update = 0;
+               $cache_update = '0';
                foreach (postRequestElement('sel') as $ext_id => $sel) {
-                       // Secure ID
+                       // Secure id
                        $ext_id = bigintval($ext_id);
 
                        // Change this extension?
                        if ($sel == 1) {
                                // Load mode is modify
-                               getExtensionMode('modify');
+                               setExtensionMode('modify');
 
                                // Get entry for 'active'
                                $active = postRequestElement('active', $ext_id);
@@ -215,9 +215,9 @@ if (isGetRequestElementSet('reg_ext')) {
        $do = 'delete';
 } elseif ((isPostRequestElementSet('remove')) && ($SEL > 0) && (!isDemoModeActive())) {
        // Remove extensions from DB (you have to delete all files manually!)
-       $cache_update = 0;
+       $cache_update = '0';
        foreach (postRequestElement('sel') as $ext_id => $active) {
-               // Secure ID number
+               // Secure id number
                $ext_id = bigintval($ext_id);
 
                // Is this extension selected and id valid?
@@ -304,16 +304,16 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
                // Free result
                SQL_FREERESULT($result);
 
-               // Is the ID number valid and the task was found?
+               // Is the id number valid and the task was found?
                if (($ext_id > 0) && ($task_found == 1)) {
-                       // ID is valid so begin with registration, we first want to it's real name from task management (subject column)
+                       // id is valid so begin with registration, we first want to it's real name from task management (subject column)
                        $result = SQL_QUERY_ESC("SELECT `subject` FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `id`=%s LIMIT 1",
                                array(bigintval($ext_id)), __FILE__, __LINE__);
                        list($subj) = SQL_FETCHROW($result);
                        SQL_FREERESULT($result);
 
                        // Disable cache update by default
-                       $cache_update = 0;
+                       $cache_update = '0';
                        if (!empty($subj)) {
                                // Extract extension's name from subject...
                                $ext_name = trim(substr($subj, 1, strpos($subj, ':') - 1));
@@ -326,7 +326,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
                                        // ... so we can finally register and load it in registration mode
                                        if (registerExtension($ext_name, $ext_id)) {
                                                // Errors?
-                                               if (getTotalFatalErrors() == 0) {
+                                               if (getTotalFatalErrors() == '0') {
                                                        // Extension was found and successfully registered
                                                        loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSION_REGISTERED'), $ext_name));
 
@@ -370,11 +370,11 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__);
                                // Extension was not found in task management
                                loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ID_404'));
                        }
-               } elseif ($task_found == 0) {
+               } elseif ($task_found == '0') {
                        // No longer assigned or old task
                        loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ASSIGED'));
                } else {
-                       // ID is invalid
+                       // id is invalid
                        loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_INVALID'));
                }
                break;