A lot while() conditions rewritten to SQL_FETCHARRAY(), see bug #107, @TODO tags...

[mailer.git] / inc / modules / admin / what-list_sponsor.php

diff --git a/inc/modules/admin/what-list_sponsor.php b/inc/modules/admin/what-list_sponsor.php
index fa00a1cc30ee6040504f436788aa2a00a66a0c04..f7c4601ce9830e45a4af6c2722cd5e2536bff177 100644 (file)
--- a/inc/modules/admin/what-list_sponsor.php
+++ b/inc/modules/admin/what-list_sponsor.php
@@ -40,12 +40,12 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 // Add description as navigation point
 ADD_DESCR("admin", __FILE__);
 
-if (!empty($_GET['id'])) {
+if (REQUEST_ISSET_GET(('id'))) {
        // Show detailed informations to a sponsor
        $result = SQL_QUERY_ESC("SELECT company, position, gender, surname, family, street_nr1, street_nr2, zip, city, country, phone, fax, cell, email, url, tax_ident, status, sponsor_created, last_online, last_change, receive_warnings, points_amount, points_used, remote_addr, warning_interval, refid, ref_count
 FROM `{!_MYSQL_PREFIX!}_sponsor_data`
 WHERE id='%s' LIMIT 1",
- array(bigintval($_GET['id'])), __FILE__, __LINE__);
+ array(bigintval(REQUEST_GET('id'))), __FILE__, __LINE__);
 
        if (SQL_NUMROWS($result) == 1) {
                // Load sponsor details
@@ -59,14 +59,15 @@ WHERE id='%s' LIMIT 1",
 
                // Check for sponsor's orders (only count)
                $result_orders = SQL_QUERY_ESC("SELECT COUNT(id) FROM `{!_MYSQL_PREFIX!}_sponsor_orders` WHERE sponsorid='%s'",
-                array(bigintval($_GET['id'])), __FILE__, __LINE__);
+                array(bigintval(REQUEST_GET('id'))), __FILE__, __LINE__);
                list($orders) = SQL_FETCHROW($result_orders);
                SQL_FREERESULT($result_orders);
                if (empty($orders)) $orders = 0;
 
                // Prepare all data for the template
+               // @TODO Rewrite this huge amount of constants
                //  Sponsor's ID
-               define('__SPONSOR_ID'         , $_GET['id']);
+               define('__SPONSOR_ID'         , REQUEST_GET('id'));
                //  Company's data
                define('__SPONSOR_COMPANY'    , $DATA['company']);
                define('__SPONSOR_POSITION'   , $DATA['position']);
@@ -109,12 +110,12 @@ WHERE id='%s' LIMIT 1",
                LOAD_TEMPLATE("admin_list_sponsor_details");
        } else {
                // Sponsor not found
-               LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_404'), $_GET['id']));
+               LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_404'), REQUEST_GET('id')));
        }
-} elseif (!empty($_GET['rid'])) {
+} elseif (REQUEST_ISSET_GET(('rid'))) {
        // Search for sponsor
        $result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_sponsor_data` WHERE id='%s' LIMIT 1",
-        array(bigintval($_GET['rid'])), __FILE__, __LINE__);
+        array(bigintval(REQUEST_GET('rid'))), __FILE__, __LINE__);
        if (SQL_NUMROWS($result) == 1) {
                // Free memory
                SQL_FREERESULT($result);
@@ -123,7 +124,7 @@ WHERE id='%s' LIMIT 1",
                $result = SQL_QUERY_ESC("SELECT id, gender, surname, family, email, status, sponsor_created, last_online, points_amount, points_used, remote_addr, ref_count
 FROM `{!_MYSQL_PREFIX!}_sponsor_data`
 WHERE refid='%s' ORDER BY `id`",
- array(bigintval($_GET['rid'])), __FILE__, __LINE__);
+ array(bigintval(REQUEST_GET('rid'))), __FILE__, __LINE__);
 
                if (SQL_NUMROWS($result) > 0) {
                        // List refs now
@@ -131,11 +132,11 @@ WHERE refid='%s' ORDER BY `id`",
                        SQL_FREERESULT($result);
                } else {
                        // No refs made so far
-                       LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_REFS_404'), "<a href=\"{!URL!}/modules.php?module=admin&amp;what=list_sponsor&amp;id=".bigintval($_GET['rid'])."\">".bigintval($_GET['rid'])."</a>"));
+                       LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_REFS_404'), "<a href=\"{!URL!}/modules.php?module=admin&amp;what=list_sponsor&amp;id=".bigintval(REQUEST_GET('rid'))."\">".bigintval(REQUEST_GET('rid'))."</a>"));
                }
        } else {
                // Sponsor not found
-               LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_404'), bigintval($_GET['rid'])));
+               LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_SPONSOR_404'), bigintval(REQUEST_GET('rid'))));
        }
 } else {
        // List all sponsors
@@ -144,20 +145,21 @@ FROM `{!_MYSQL_PREFIX!}_sponsor_data` ORDER BY `id`", __FILE__, __LINE__);
        if (SQL_NUMROWS($result_main) > 0) {
                // At least one sponsor found!
                $OUT = ""; $SW = 2;
-               while (list($id, $gender, $sname, $fname, $email, $status, $created, $last, $amount, $used, $ip) = SQL_FETCHROW($result_main)) {
+               while ($content = SQL_FETCHARRAY($result_main)) {
                        // Transfer data to array
+                       // @TODO Rewritings: sname->surname,fname->family,ip->remote_addr in template
                        $content = array(
-                               'id'      => $id,
+                               'id'      => $content['id'],
                                'sw'      => $SW,
-                               'gender'   => TRANSLATE_GENDER($gender),
-                               'sname'   => $sname,
-                               'fname'   => $fname,
-                               'email'   => "mailto:".$email,
-                               'status'  => SPONSOR_TRANSLATE_STATUS($status),
-                               'created' => MAKE_DATETIME($created, "2"),
-                               'last'    => MAKE_DATETIME($last, "2"),
-                               'points'  => TRANSLATE_COMMA($amount - $used),
-                               'ip'      => $ip,
+                               'gender'  => TRANSLATE_GENDER($content['gender']),
+                               'sname'   => $content['surname'],
+                               'fname'   => $content['family'],
+                               'email'   => "mailto:".$content['email'],
+                               'status'  => SPONSOR_TRANSLATE_STATUS($content['status']),
+                               'created' => MAKE_DATETIME($content['sponsor_created'], "2"),
+                               'last'    => MAKE_DATETIME($content['last_online'], "2"),
+                               'points'  => TRANSLATE_COMMA($content['points_amount'] - $content['points_used']),
+                               'ip'      => $content['remote_addr'],
                        );
 
                        // Load row template
@@ -167,6 +169,8 @@ FROM `{!_MYSQL_PREFIX!}_sponsor_data` ORDER BY `id`", __FILE__, __LINE__);
 
                // Free memory
                SQL_FREERESULT($result_main);
+
+               // @TODO Rewrite this constant
                define('__SPONSOR_ROWS', $OUT);
 
                // Load final template