config.php partly solved, see #117

[mailer.git] / inc / modules / admin / what-logs.php

diff --git a/inc/modules/admin/what-logs.php b/inc/modules/admin/what-logs.php
index b546fc0760c057adfe499b6624fd1b07472bed41..df3a5872f02f9c5d6c38b599fb337d4d18d37575 100644 (file)
--- a/inc/modules/admin/what-logs.php
+++ b/inc/modules/admin/what-logs.php
@@ -45,15 +45,15 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 // Add description as navigation point
 ADD_DESCR('admin', __FILE__);
 
-if (REQUEST_ISSET_GET(('access'))) {
+if (REQUEST_ISSET_GET('access')) {
        // Secure input and construct FQFN
        $access = SQL_ESCAPE(strip_tags(REQUEST_GET('access')));
        $target = sprintf("%slogs/%s", constant('PATH'), $access);
 
        // Is the file valid and readable?
-       if (FILE_READABLE($target)) {
+       if (isFileReadable($target)) {
                // Load it directly
-               $content = READ_FILE($target);
+               $content = readFromFile($target);
 
                // Save old content
                $OUTPUT = ob_get_contents();
@@ -62,15 +62,15 @@ if (REQUEST_ISSET_GET(('access'))) {
                clearOutputBuffer();
 
                // Set header
-               if (substr($access, -3, 3) == "log") {
+               if (substr($access, -3, 3) == 'log') {
                        // Output header
-                       header("Content-Type: text/plain");
-               } elseif (substr($access, -3, 3) == ".gz") {
+                       sendHeader('Content-Type: text/plain');
+               } elseif (substr($access, -3, 3) == '.gz') {
                        // @TODO Fix content-type here
-                       header("Content-Type: text/plain");
-               } elseif (substr($access, -3, 3) == ".bz2") {
+                       sendHeader('Content-Type: text/plain');
+               } elseif (substr($access, -3, 3) == '.bz2') {
                        // @TODO Fix content-type here
-                       header("Content-Type: text/plain");
+                       sendHeader('Content-Type: text/plain');
                } else {
                        // Restore old content
                        OUTPUT_HTML($OUTPUT);
@@ -89,14 +89,16 @@ if (REQUEST_ISSET_GET(('access'))) {
        }
 } else {
        // List access logfiles
-       $dir = constant('PATH') . getConfig('logs_base') . "/";
+       $dir = constant('PATH') . getConfig('logs_base') . '/';
+
+       // Is the directory there?
        if (isDirectory($dir)) {
                // logs directory does exist
                OUTPUT_HTML("<ol>");
-               $handle = opendir($dir) or app_die(__FILE__, __LINE__, "Cannot open directory ".getConfig('logs_base')."!");
+               $handle = opendir($dir) or app_die(__FILE__, __LINE__, 'Cannot open directory '.getConfig('logs_base') . '!');
                while ($file = readdir($handle)) {
                        // We currenly only like files with "access" as prefix, should be more flexible!
-                       if (substr($file, 0, 6) == "access") {
+                       if (substr($file, 0, 6) == 'access') {
                                // Okay, let us print it out
                                OUTPUT_HTML("<li><a href=\"{!URL!}/modules.php?module=admin&amp;what=".$GLOBALS['what']."&amp;access=".urlencode($file)."\">".$file."</a></li>");
                        }