More SQL rewrites, TODO: Put all table and column names in backticks (`)

[mailer.git] / inc / modules / admin / what-mem_add.php

diff --git a/inc/modules/admin/what-mem_add.php b/inc/modules/admin/what-mem_add.php
index 1f4002f6d61a955d29cb98e065b803c68712329b..b83d9d013071b8528d47c7c50ea1fe968313b5ea 100644 (file)
--- a/inc/modules/admin/what-mem_add.php
+++ b/inc/modules/admin/what-mem_add.php
@@ -33,13 +33,13 @@
  ************************************************************************/
 
 // Some security stuff...
-if ((ereg(basename(__FILE__), $_SERVER['PHP_SELF'])) || (!IS_ADMIN()))
-{
+if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
        $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
        require($INC);
 }
+
 // Add desciption as navigation point
-ADD_DESCR("admin", basename(__FILE__));
+ADD_DESCR("admin", __FILE__);
 
 // Check if the admin has entered title and what-php file name...
 if ((empty($_POST['title'])) && (isset($_POST['ok'])))
@@ -53,7 +53,7 @@ if (!isset($_POST['ok']))
        $menus = array(); $titles = array(); $below = array();
 
        // Get all available main menus
-       $result = SQL_QUERY("SELECT action, title, sort FROM "._MYSQL_PREFIX."_member_menu WHERE (what='' OR what IS NULL) ORDER BY sort", __FILE__, __LINE__);
+       $result = SQL_QUERY("SELECT action, title, sort FROM `"._MYSQL_PREFIX."_member_menu` WHERE (what='' OR what IS NULL) ORDER BY sort", __FILE__, __LINE__);
        if (SQL_NUMROWS($result) > 0)
        {
                // Read menu structure
@@ -74,7 +74,7 @@ if (!isset($_POST['ok']))
 
                // Remove double eintries
                $prev = ""; $dmy = $menus; $dmy2 = $titles; $dmy3 = $below;
-               foreach ($menus as $key=>$value)
+               foreach ($menus as $key => $value)
                {
                        if ($value == $prev)
                        {
@@ -90,9 +90,9 @@ if (!isset($_POST['ok']))
                }
                $menus = $dmy; $titles = $dmy2; $below = $dmy3;
                // Load sub menus :)
-               foreach ($menus as $key_main=>$value_main)
+               foreach ($menus as $key_main => $value_main)
                {
-                       $result = SQL_QUERY_ESC("SELECT what, title, sort FROM "._MYSQL_PREFIX."_member_menu WHERE action='%s' AND what != '' ORDER BY sort",
+                       $result = SQL_QUERY_ESC("SELECT what, title, sort FROM `"._MYSQL_PREFIX."_member_menu` WHERE action='%s' AND what != '' ORDER BY sort",
                         array($value_main), __FILE__, __LINE__);
                        if (SQL_NUMROWS($result) > 0)
                        {
@@ -119,7 +119,7 @@ if (!isset($_POST['ok']))
 
                                // Remove double eintries
                                $prev = ""; $dmy = $menus[$value_main]; $dmy2 = $titles[$value_main]; $dmy3 = $below[$value_main];
-                               foreach ($menus[$value_main] as $key=>$value)
+                               foreach ($menus[$value_main] as $key => $value)
                                {
                                        if ($value == $prev)
                                        {
@@ -139,14 +139,14 @@ if (!isset($_POST['ok']))
 
        $OUT = "<SELECT class=\"admin_select\" name=\"sort\" size=\"1\">
       <OPTION value=\"\">".IS_FIRST_MENU."</OPTION>";
-       foreach ($below as $key=>$m)
+       foreach ($below as $key => $m)
        {
                if (is_array($m))
                {
-                       foreach ($m as $key2=>$m2)
+                       foreach ($m as $key2 => $m2)
                        {
                                $OUT .= "      <OPTION value=\"".$m2."\">".$titles[$key][$key2];
-                               foreach ($menus as $k=>$v)
+                               foreach ($menus as $k => $v)
                                {
                                        if (($v == $key) && (!is_array($v)))
                                        {
@@ -175,9 +175,7 @@ if (!isset($_POST['ok']))
        // Insert new menu entry
        if (!empty($_POST['menu']))
        {
-               $result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_member_menu
-(action, what, title, visible, locked, sort)
-VALUES('%s', '%s', '%s', '%s', '%s', '%s')",
+               $result = SQL_QUERY_ESC("INSERT INTO `"._MYSQL_PREFIX."_member_menu` (`action`,`what`,`title`,`visible`,`locked`,`sort`) VALUES ('%s','%s','%s','%s','%s','%s')",
  array(
        $_POST['menu'],
        $_POST['name'],
@@ -189,9 +187,7 @@ VALUES('%s', '%s', '%s', '%s', '%s', '%s')",
        }
         else
        {
-               $result = SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_member_menu
-(action, title, visible, locked, sort)
-VALUES('%s', '%s', '%s', '%s', '%s')",
+               $result = SQL_QUERY_ESC("INSERT INTO `"._MYSQL_PREFIX."_member_menu` (`action`,`title`,`visible`,`locked`,`sort`) VALUES ('%s','%s','%s','%s','%s')",
  array(
        $_POST['name'],
        $_POST['title'],