More fixes from bugtracker issues, thanks to profi-concept

[mailer.git] / inc / modules / admin / what-refbanner.php

diff --git a/inc/modules/admin/what-refbanner.php b/inc/modules/admin/what-refbanner.php
index c2ec5fe322adabeaea0c20a8c5c4987077923deb..7de1f9d38e6e6c960ba03093c257ca3b08798d4d 100644 (file)
--- a/inc/modules/admin/what-refbanner.php
+++ b/inc/modules/admin/what-refbanner.php
@@ -40,15 +40,18 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 // Add description as navigation point
 ADD_DESCR("admin", __FILE__);
 
+// Init variable
 $SEL = 0;
-if ((empty($_POST['url'])) || (empty($_POST['alternate'])))
-{
+
+// Some sanity-check
+if ((empty($_POST['url'])) || (empty($_POST['alternate']))) {
        unset($_POST['ok']);
 }
+
+// Check selection count
 if (!empty($_POST['sel'])) $SEL = SELECTION_COUNT($_POST['sel']);
 
-if (isset($_POST['ok']))
-{
+if (isset($_POST['ok'])) {
        // Fix older calls from add-new-banner-form
        if (empty($_GET['mode'])) $_GET['mode'] = "add";
        $SQL = "";
@@ -57,24 +60,20 @@ if (isset($_POST['ok']))
        case "add":
                // Check if banner is already added
                $result = SQL_QUERY_ESC("SELECT id FROM "._MYSQL_PREFIX."_refbanner WHERE url='%s' LIMIT 1",
-                array($_POST['url']), __FILE__, __LINE__);
-               if (SQL_NUMROWS($result) == 0)
-               {
+                       array($_POST['url']), __FILE__, __LINE__);
+               if (SQL_NUMROWS($result) == 0) {
                        // Add banner
                        SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_refbanner (url, alternate, visible)
 VALUES ('%s','%s','%s')",
- array($_POST['url'], $_POST['alternate'], $_POST['visible']), __FILE__, __LINE__);
-               }
-                else
-               {
+                               array($_POST['url'], $_POST['alternate'], $_POST['visible']), __FILE__, __LINE__);
+               } else {
                        // Free memory
                        SQL_FREERESULT($result);
                }
                break;
 
        case "edit": // Update banner
-               foreach ($_POST['sel'] as $id => $sel)
-               {
+               foreach ($_POST['sel'] as $id => $sel) {
                        // Secure ID
                        $id = bigintval($id);
 
@@ -84,22 +83,17 @@ VALUES ('%s','%s','%s')",
                }
                break;
        }
-       if (SQL_AFFECTEDROWS() == 1)
-       {
-               $content = "<SPAN class=\"admin_done\">".SETTINGS_SAVED."</SPAN>";
-       }
-        else
-       {
+
+       if (SQL_AFFECTEDROWS() == 1) {
+               $content = SETTINGS_SAVED;
+       } else {
                $content = "<SPAN class=\"admin_failed\">".SETTINGS_NOT_SAVED."</SPAN>";
        }
        LOAD_TEMPLATE("admin_settings_saved", false, $content);
-}
- elseif (($SEL > 0) && (isset($_POST['edit'])))
-{
+} elseif (($SEL > 0) && (isset($_POST['edit']))) {
        // Edit banner
        $SW = ""; $OUT = "";
-       foreach ($_POST['sel'] as $id => $sel)
-       {
+       foreach ($_POST['sel'] as $id => $sel) {
                // Load data
                $result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM "._MYSQL_PREFIX."_refbanner WHERE id=%s LIMIT 1",
                 array(bigintval($id)), __FILE__, __LINE__);
@@ -123,9 +117,7 @@ VALUES ('%s','%s','%s')",
 
        // Load main template
        LOAD_TEMPLATE("admin_refbanner_edit");
-}
- else
-{
+} else {
        if (($SEL > 0) && (isset($_POST['del'])))
        {
                // Delete banner