Some fixes for surfbar extension (#123), double->single, misc cleanups/fixes

[mailer.git] / inc / modules / admin / what-refbanner.php

diff --git a/inc/modules/admin/what-refbanner.php b/inc/modules/admin/what-refbanner.php
index c60def4c5b81c47ff7b483b7aeee0bc23bc9a474..cbeb3d53d4e3f1604af3895a5d8c672fa8089faa 100644 (file)
--- a/inc/modules/admin/what-refbanner.php
+++ b/inc/modules/admin/what-refbanner.php
@@ -10,7 +10,12 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Alle Banner fuer die Ref-Links verwalten         *
  * -------------------------------------------------------------------- *
- *                                                                      *
+ * $Revision::                                                        $ *
+ * $Date::                                                            $ *
+ * $Tag:: 0.2.1-FINAL                                                 $ *
+ * $Author::                                                          $ *
+ * Needs to be in all Files and every File needs "svn propset           *
+ * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2008 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
@@ -33,60 +38,60 @@
 
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
-       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
        require($INC);
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", __FILE__);
+ADD_DESCR('admin', __FILE__);
 
 // Init variable
 $SEL = 0;
 
 // Some sanity-check
-if ((!REQUEST_ISSET_POST(('url'))) || (!REQUEST_ISSET_POST(('alternate')))) {
+if ((!REQUEST_ISSET_POST('url')) || (!REQUEST_ISSET_POST(('alternate')))) {
        REQUEST_UNSET_POST('ok');
 }
 
 // Check selection count
-if (REQUEST_ISSET_POST('sel')) $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
+if (REQUEST_ISSET_POST('sel')) $SEL = countPostSelection();
 
-if (IS_FORM_SENT()) {
+if (isFormSent()) {
        // Fix older calls from add-new-banner-form
-       if (!REQUEST_ISSET_GET(('mode'))) REQUEST_SET_GET('mode', "add");
-       $sql = "";
+       if (!REQUEST_ISSET_GET('mode')) REQUEST_SET_GET('mode', 'add');
+       $sql = '';
        switch (REQUEST_GET('mode'))
        {
-       case "add":
-               // Check if banner is already added
-               $result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE url='%s' LIMIT 1",
+               case 'add':
+                       // Check if banner is already added
+                       $result = SQL_QUERY_ESC("SELECT `id` FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE url='%s' LIMIT 1",
                        array(REQUEST_POST('url')), __FILE__, __LINE__);
-               if (SQL_NUMROWS($result) == 0) {
-                       // Add banner
-                       SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_refbanner` (url, alternate, visible)
+                       if (SQL_NUMROWS($result) == 0) {
+                               // Add banner
+                               SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_refbanner` (url, alternate, visible)
 VALUES ('%s','%s','%s')",
                                array(REQUEST_POST('url'), REQUEST_POST('alternate'), REQUEST_POST('visible')), __FILE__, __LINE__);
-               } else {
-                       // Free memory
-                       SQL_FREERESULT($result);
-               }
-               break;
-
-       case "edit": // Update banner
-               foreach (REQUEST_POST('sel') as $id => $sel) {
-                       // Secure ID
-                       $id = bigintval($id);
-
-                       // Update entry
-                       SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET url='%s', alternate='%s', `visible`='%s' WHERE id=%s LIMIT 1",
+                       } else {
+                               // Free memory
+                               SQL_FREERESULT($result);
+                       }
+                       break;
+
+               case 'edit': // Update banner
+                       foreach (REQUEST_POST('sel') as $id => $sel) {
+                               // Secure ID
+                               $id = bigintval($id);
+
+                               // Update entry
+                               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET url='%s', alternate='%s', `visible`='%s' WHERE `id`=%s LIMIT 1",
                                array(
-                                       REQUEST_POST('url', $id),
-                                       REQUEST_POST('alternate', $id),
-                                       REQUEST_POST('visible'),
-                                       $id
+                               REQUEST_POST('url', $id),
+                               REQUEST_POST('alternate', $id),
+                               REQUEST_POST('visible'),
+                               $id
                                ), __FILE__, __LINE__);
-               }
-               break;
+                       }
+                       break;
        }
 
        if (SQL_AFFECTEDROWS() == 1) {
@@ -94,14 +99,14 @@ VALUES ('%s','%s','%s')",
        } else {
                $content = "<span class=\"admin_failed\">{--SETTINGS_NOT_SAVED--}</span>";
        }
-       LOAD_TEMPLATE("admin_settings_saved", false, $content);
+       LOAD_TEMPLATE('admin_settings_saved', false, $content);
 } elseif (($SEL > 0) && (REQUEST_ISSET_POST('edit'))) {
        // Edit banner
-       $SW = ""; $OUT = "";
+       $SW = 2; $OUT = '';
        foreach (REQUEST_POST('sel') as $id => $sel) {
                // Load data
-               $result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
-                       array(bigintval($id)), __FILE__, __LINE__);
+               $result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
+               array(bigintval($id)), __FILE__, __LINE__);
                list($url, $alt, $vis) = SQL_FETCHROW($result);
                SQL_FREERESULT($result);
 
@@ -111,7 +116,7 @@ VALUES ('%s','%s','%s')",
                        'id'  => $id,
                        'url' => $url,
                        'alt' => $alt,
-                       'vis' => ADD_SELECTION("yn", $vis   , "visible"),
+                       'vis' => ADD_SELECTION('yn', $vis   , "visible"),
                );
 
                // Load row template and switch color
@@ -128,17 +133,17 @@ VALUES ('%s','%s','%s')",
        if (($SEL > 0) && (REQUEST_ISSET_POST('del'))) {
                // Delete banner
                foreach (REQUEST_POST('sel') as $id => $sel) {
-                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
-                               array(bigintval($id)), __FILE__, __LINE__);
+                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
+                       array(bigintval($id)), __FILE__, __LINE__);
                }
        }
 
        // Referal levels
        $result = SQL_QUERY("SELECT id, url, alternate, visible, counter, clicks FROM `{!_MYSQL_PREFIX!}_refbanner` ORDER BY url",
-               __FILE__, __LINE__);
+       __FILE__, __LINE__);
        if (SQL_NUMROWS($result) > 0) {
                // Make referal banner editable and deletable
-               $OUT = ""; $SW = 2;
+               $OUT = ''; $SW = 2;
                while ($content = SQL_FETCHARRAY($result)) {
                        // Preapre data for the row
                        // @TODO Rewritings: alt->alternate,cnt->counter,clx->clicks in template
@@ -147,7 +152,7 @@ VALUES ('%s','%s','%s')",
                                'id'  => $content['id'],
                                'url' => $content['url'],
                                'alt' => $content['alternate'],
-                               'vis' => TRANSLATE_YESNO($content['visible']),
+                               'vis' => translateYesNo($content['visible']),
                                'cnt' => $content['counter'],
                                'clx' => $content['clicks']
                        );