Our convention says if(-else) blocks should not be put in one line

[mailer.git] / inc / modules / admin / what-repair_gmnu.php

diff --git a/inc/modules/admin/what-repair_gmnu.php b/inc/modules/admin/what-repair_gmnu.php
index a817e85a83455d0ba66a1d8c09e088c54e8f860d..cff162ad9df99e1bac4ea321dc3b2584c7e793c4 100644 (file)
--- a/inc/modules/admin/what-repair_gmnu.php
+++ b/inc/modules/admin/what-repair_gmnu.php
@@ -45,20 +45,21 @@ if ((!defined('__SECURITY')) || (!isAdmin())) {
 // Add description as navigation point
 addMenuDescription('admin', __FILE__);
 
-$ACTIONS = array();
+$actions = array();
+
 // First fix all main menus (what = '')...
 $result_fix = SQL_QUERY("SELECT `id`, `action` FROM `{?_MYSQL_PREFIX?}_guest_menu` WHERE (`what`='' OR `what` IS NULL) AND `action` != 'logout' ORDER BY `sort` ASC", __FILE__, __LINE__);
-$cnt = '0'; $REP = '0';
+$cnt = '0'; $repairedWeights = '0';
 while ($content = SQL_FETCHARRAY($result_fix)) {
        // Store act value for later usage in sorting sub menus
-       $ACTIONS[] = $content['action'];
+       $actions[] = $content['action'];
 
        // Fix weight
        $result_sort = SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_guest_menu` SET `sort`='%s WHERE `id`=%s' LIMIT 1",
                array($cnt, $content['id']), __FILE__, __LINE__);
 
        // Get updated rows
-       $REP += SQL_AFFECTEDROWS();
+       $repairedWeights += SQL_AFFECTEDROWS();
 
        // Count one up
        $cnt++;
@@ -68,7 +69,7 @@ while ($content = SQL_FETCHARRAY($result_fix)) {
 $result_sort = SQL_QUERY("UPDATE `{?_MYSQL_PREFIX?}_guest_menu` SET sort='999' WHERE `action`='logout' AND (`what`='' OR `what` IS NULL) LIMIT 1", __FILE__, __LINE__);
 
 // Now sort every each menu
-foreach ($ACTIONS as $action) {
+foreach ($actions as $action) {
        $result_fix = SQL_QUERY_ESC("SELECT `id` FROM `{?_MYSQL_PREFIX?}_guest_menu` WHERE `action`='%s' AND `what` != '' AND `what` IS NOT NULL ORDER BY `sort` ASC",
                array($action), __FILE__, __LINE__);
        $cnt = 1;
@@ -76,16 +77,16 @@ foreach ($ACTIONS as $action) {
                // Fix weight
                SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_guest_menu` SET `sort`=%s WHERE `id`=%s LIMIT 1",
                array($cnt, $content['id']), __FILE__, __LINE__);
-               $REP += SQL_AFFECTEDROWS();
+               $repairedWeights += SQL_AFFECTEDROWS();
 
                // Count one up
                $cnt++;
-       }
-}
+       } // END - while
+} // END - foreach
 
 // Repair finished
-if ($REP > 0) {
-       $message = getMaskedMessage('ADMIN_REPAIR_ENTRIES_FIXED', $REP);
+if ($repairedWeights > 0) {
+       $message = getMaskedMessage('ADMIN_REPAIR_ENTRIES_FIXED', $repairedWeights);
 } else {
        $message = '{--ADMIN_REPAIR_NOTHING_FIXED--}';
 }