Renamed function so it might be more understandable

[mailer.git] / inc / modules / admin / what-surfbar_stats.php

diff --git a/inc/modules/admin/what-surfbar_stats.php b/inc/modules/admin/what-surfbar_stats.php
index 54ff5df476f48c92f282f3778132f8dd43861973..950c472304639954a20bbfeaf811afb2a278fc94 100644 (file)
--- a/inc/modules/admin/what-surfbar_stats.php
+++ b/inc/modules/admin/what-surfbar_stats.php
@@ -14,8 +14,6 @@
  * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
  * $Author::                                                          $ *
- * Needs to be in all Files and every File needs "svn propset           *
- * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
  * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
@@ -40,13 +38,13 @@
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!isAdmin())) {
        die();
-}
+} // END - if
 
 // Add description as navigation point
-addMenuDescription('admin', __FILE__);
+addYouAreHereLink('admin', __FILE__);
 
 // Is the 'url_id' set?
-if (isGetRequestParameterSet(('url_id'))) {
+if (isGetRequestParameterSet('url_id')) {
        // Generate general statistics
        $result = SQL_QUERY_ESC("SELECT
        `stats_userid`,
@@ -61,28 +59,25 @@ ORDER BY
                array(bigintval(getRequestParameter('url_id'))), __FILE__, __LINE__);
 
        // Entries found?
-       if (SQL_NUMROWS($result) > 0) {
+       if (!SQL_HASZERONUMS($result)) {
                // Get all rows
-               $OUT = ''; $SW = 2; $cnt = '0'; $visits = '0';
+               $OUT = ''; $count = '0'; $visits = '0';
                while ($content = SQL_FETCHARRAY($result)) {
                        // Count totals
                        $visits += $content['total_visits'];
 
                        // "Translate" some data
-                       $content['stats_userid'] = generateUserProfileLink($content['stats_userid']);
-                       $content['total_visits'] = translateComma($content['total_visits']);
                        $content['last_surfed']  = generateDateTime($content['last_surfed'], 2);
-                       $content['sw']           = $SW;
 
                        // Load row template
                        $OUT .= loadTemplate('admin_surfbar_url_stats_row', true, $content);
-                       $cnt++; $SW = 3 - $SW;
+                       $count++;;
                } // END - while
 
                // Prepare content
                $content = array(
                        'rows'    => $OUT,
-                       'userids' => $cnt,
+                       'userids' => $count,
                        'visits'  => $visits
                );
 
@@ -91,7 +86,7 @@ ORDER BY
                loadTemplate('admin_surfbar_url_stats', false, $content);
        } else {
                // No statistics so far
-               loadTemplate('admin_settings_saved', false, getMessage('ADMIN_SURFBAR_NO_URL_STATS'));
+               loadTemplate('admin_settings_saved', false, '{--ADMIN_SURFBAR_NO_URL_STATS--}');
        }
 } else {
        // Generate general statistics
@@ -107,30 +102,22 @@ ORDER BY
        `stats_userid` ASC", __FILE__, __LINE__);
 
        // Entries found?
-       if (SQL_NUMROWS($result) > 0) {
+       if (!SQL_HASZERONUMS($result)) {
                // Get all rows
-               $OUT = ''; $SW = 2; $urls = '0'; $visits = '0';
+               $OUT = ''; $urlArray = '0'; $visits = '0';
                while ($content = SQL_FETCHARRAY($result)) {
                        // Count totals
-                       $urls   += $content['visited_urls'];
-                       $visits += $content['total_visits'];
-
-                       // "Translate" some data
-                       // @TODO Can't all these translation blocks moved into templates? This code looks ugly.
-                       $content['stats_userid'] = generateUserProfileLink($content['stats_userid']);
-                       $content['visited_urls'] = translateComma($content['visited_urls']);
-                       $content['total_visits'] = translateComma($content['total_visits']);
-                       $content['sw']           = $SW;
+                       $urlArray += $content['visited_urls'];
+                       $visits   += $content['total_visits'];
 
                        // Load row template
                        $OUT .= loadTemplate('admin_surfbar_stats_row', true, $content);
-                       $SW = 3 - $SW;
                } // END - while
 
                // Prepare content
                $content = array(
                        'rows'   => $OUT,
-                       'urls'   => $urls,
+                       'urls'   => $urlArray,
                        'visits' => $visits
                );
 
@@ -139,12 +126,12 @@ ORDER BY
                loadTemplate('admin_surfbar_stats', false, $content);
        } else {
                // No statistics so far
-               loadTemplate('admin_settings_saved', false, getMessage('ADMIN_SURFBAR_NO_STATS'));
+               loadTemplate('admin_settings_saved', false, '{--ADMIN_SURFBAR_NO_STATS--}');
        }
 }
 
 // Free result
 SQL_FREERESULT($result);
 
-//
+// [EOF]
 ?>