Renamed ifSqlHasZeroNums() to ifSqlHasZeroNumRows() and improved some queries.

[mailer.git] / inc / modules / admin / what-usr_online.php

diff --git a/inc/modules/admin/what-usr_online.php b/inc/modules/admin/what-usr_online.php
index 3a1043a4eef29ddeabf056f17cd0654b5f9aba8a..0ca3fc427d899ff3979a1a663b0f458a485382eb 100644 (file)
--- a/inc/modules/admin/what-usr_online.php
+++ b/inc/modules/admin/what-usr_online.php
@@ -14,12 +14,10 @@
  * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
  * $Author::                                                          $ *
- * Needs to be in all Files and every File needs "svn propset           *
- * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
- * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
- * For more information visit: http://www.mxchange.org                  *
+ * Copyright (c) 2009 - 2015 by Mailer Developer Team                   *
+ * For more information visit: http://mxchange.org                      *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
  * it under the terms of the GNU General Public License as published by *
@@ -43,63 +41,70 @@ if ((!defined('__SECURITY')) || (!isAdmin())) {
 } // END - if
 
 // Add description as navigation point
-addMenuDescription('admin', __FILE__);
+addYouAreHereLink('admin', __FILE__);
 
 // Online stats are only working if extension ext-online is installed
 if (isExtensionActive('online')) {
        // Count guests, members and admins
        // @TODO Add a filter for sponsor
-       $content['guests_online']  = countSumTotalData('N', 'online', 'id', 'is_admin', true, " AND `is_member`='N'");
-       $content['admins_online']  = countSumTotalData('N', 'online', 'id', 'is_admin', true, " AND `is_member`='Y'");
-       $content['members_online'] = countSumTotalData('N', 'online', 'id', 'is_admin', true);
+       $content['guests_online']  = countSumTotalData('N', 'online', 'id', 'is_admin', TRUE, " AND `is_member`='N'");
+       $content['admins_online']  = countSumTotalData('N', 'online', 'id', 'is_admin', TRUE, " AND `is_member`='Y'");
+       $content['members_online'] = countSumTotalData('N', 'online', 'id', 'is_admin', TRUE);
 
        // Load template
-       loadTemplate('admin_mini_online', false, $content);
+       loadTemplate('admin_mini_online', FALSE, $content);
 
        // Check for online users
-       $result = SQL_QUERY("SELECT `id`, `ip`, `userid`, `refid`, `module`, `action`, `what`, `is_member`, `is_admin`, `timestamp` FROM `{?_MYSQL_PREFIX?}_online` ORDER by `timestamp` DESC",
-               __FILE__, __LINE__);
-       if (SQL_NUMROWS($result) > 0) {
-               // List all online users
-               $OUT = ''; $SW = 2;
-               while ($row = SQL_FETCHARRAY($result)) {
-                       // Fix empty action/what
-                       if (empty($row['action'])) $row['action'] = '---';
-                       if (empty($row['what']))   $row['what']   = '---';
+       $result = sqlQuery("SELECT
+       `id`,
+       `ip`,
+       `userid`,
+       `refid`,
+       `module`,
+       `action`,
+       `what`,
+       `is_member`,
+       `is_admin`,
+       `timestamp`
+FROM
+       `{?_MYSQL_PREFIX?}_online`
+ORDER BY
+       `timestamp` DESC", __FILE__, __LINE__);
 
+       if (!ifSqlHasZeroNumRows($result)) {
+               // List all online users
+               $OUT = '';
+               while ($row = sqlFetchArray($result)) {
                        if ($row['is_admin'] == 'Y') {
                                // Is an administrator
-                               $row['userid'] = getMessage('_IS_ADMIN');
+                               $row['userid'] = '{--_IS_ADMIN--}';
                        } elseif (($row['is_member'] != 'Y') && ($row['is_admin'] != 'Y')) {
                                // Is a guest
-                               $row['userid'] = getMessage('_IS_GUEST');
-                       } elseif (isValidUserId($row['userid'])) {
+                               $row['userid'] = '{--_IS_GUEST--}';
+                       } elseif (isValidId($row['userid'])) {
                                // Add profile link to userid
                                $row['userid'] = generateUserProfileLink($row['userid']);
                        }
 
                        // Add more content
-                       $row['sw'] = $SW;
                        $row['timestamp'] = generateDateTime($row['timestamp'], 2);
 
                        // Load row template and switch color
-                       $OUT .= loadTemplate('admin_list_online_row', true, $row);
-                       $SW = 3 - $SW;
+                       $OUT .= loadTemplate('admin_list_online_row', TRUE, $row);
                } // END - while
 
                // Free memory
-               SQL_FREERESULT($result);
+               sqlFreeResult($result);
 
                // Remember rows and fancy time in array
                $content['rows']           = $OUT;
-               $content['online_timeout'] = getMessage('ONLINE_TIMEOUT_IS');
 
                // Load footer template
-               loadTemplate('admin_list_online', false, $content);
+               loadTemplate('admin_list_online', FALSE, $content);
        } // END - if
 } else {
        // Online statistics deactivated!
-       loadTemplate('admin_settings_saved', false, getMessage('ONLINE_STATISTICS_DEACTIVATED'));
+       displayMessage('{--ONLINE_STATISTICS_DEACTIVATED--}');
 }
 
 // [EOF]