Fixes for absent ext-user and misleading data removed
[mailer.git] / inc / modules / guest / what-stats.php
index 38ea6bbf473a8d561e7d32bb0f2daf5d3be44e3c..ca20611192b8a1b766402a26b5d71c8bef11a9b9 100644 (file)
  * $Date::                                                            $ *
  * $Tag:: 0.2.1-FINAL                                                 $ *
  * $Author::                                                          $ *
- * Needs to be in all Files and every File needs "svn propset           *
- * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
- * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
+ * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -43,10 +41,18 @@ if (!defined('__SECURITY')) {
 } // END - if
 
 // Add description as navigation point
-addMenuDescription('guest', __FILE__);
+addYouAreHereLink('guest', __FILE__);
 
-// Derterminate which stats we want and set mode and title for the link below stats block
-if (!isGetRequestParameterSet('mode')) setGetRequestParameter('mode', strtolower(getConfig('guest_stats')));
+// This part only works if ext-user is active
+if ((!isExtensionActive('user')) && (!isAdmin())) {
+       displayMessage(generateExtensionInactiveNotInstalledMessage('user'));
+       return;
+} // END - if
+
+// Determine which stats we want and set mode and title for the link below stats block
+if (!isGetRequestParameterSet('mode')) {
+       setGetRequestParameter('mode', strtolower(getConfig('guest_stats')));
+} // END - if
 
 // Set config temporarily
 setConfigEntry('guest_stats', strtoupper(getRequestParameter('mode')));
@@ -76,24 +82,10 @@ $ltitle = '{--GUEST_STATS_' . strtoupper($lmode) . '--}';
 // @TODO This can be rewritten in a dynamic include
 switch (getConfig('guest_stats')) {
        case 'MEMBERS': // Statistics about your members
-               // Members yesterday / today online
-               $ymem = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `last_online` >= {?START_YDAY?} AND `last_online` < {?START_TDAY?} AND `status`='CONFIRMED'", __FILE__, __LINE__));
-               $tmem = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `last_online` >= {?START_TDAY?} AND `status`='CONFIRMED'", __FILE__, __LINE__));
-
-               // Yesterday / today registered
-               $yreg = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `joined` >= {?START_YDAY?} AND `joined` < {?START_TDAY?}", __FILE__, __LINE__));
-               $treg = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `joined` >= {?START_TDAY?}", __FILE__, __LINE__));
-
                // Only males / females
                $male   = countSumTotalData('M', 'user_data', 'userid', 'gender', true, " AND `status`='CONFIRMED'");
                $female = countSumTotalData('F', 'user_data', 'userid', 'gender', true, " AND `status`='CONFIRMED'");
 
-               // Unconfirmed accounts
-               $unconfirmed = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `status` != 'CONFIRMED'", __FILE__, __LINE__));
-
-               // Total members
-               $total = $male + $female;
-
                // List every month
                $months = array();
                for ($idx = 1; $idx < 13; $idx++) {
@@ -126,21 +118,21 @@ switch (getConfig('guest_stats')) {
                } // END - foreach
 
                // Prepare data for the template
-               $content['total_users']   = $total;
-               $content['unconfirmed']   = $unconfirmed;
+               $content['total_users']   = ($male + $female);
+               $content['unconfirmed']   = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `status` != 'CONFIRMED'", __FILE__, __LINE__));
                $content['total_males']   = $male;
                $content['total_females'] = $female;
-               $content['tmem_count']    = $tmem;
-               $content['ymem_count']    = $ymem;
-               $content['treg_count']    = $treg;
-               $content['yreg_count']    = $yreg;
+               $content['tmem_count']    = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `last_online` >= {?START_TDAY?} AND `status`='CONFIRMED'", __FILE__, __LINE__));
+               $content['ymem_count']    = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `last_online` >= {?START_YDAY?} AND `last_online` < {?START_TDAY?} AND `status`='CONFIRMED'", __FILE__, __LINE__));
+               $content['treg_count']    = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `joined` >= {?START_TDAY?}", __FILE__, __LINE__));
+               $content['yreg_count']    = SQL_NUMROWS(SQL_QUERY("SELECT `userid` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `joined` >= {?START_YDAY?} AND `joined` < {?START_TDAY?}", __FILE__, __LINE__));
                $content['lmode']         = $lmode;
                $content['ltitle']        = $ltitle;
 
                // Generate monthly stats
                $SW = 2; $r2 = ' right'; $l = 'll'; $r = 'lr'; $OUT = '';
-               foreach ($months as $month => $cnt) {
-                       if ($SW == 2) $OUT .= "<tr>\n";
+               foreach ($months as $month => $count) {
+                       if ($SW == 2) $OUT .= '<tr>';
 
                        // Prepare data for template
                        $data = array(
@@ -148,7 +140,7 @@ switch (getConfig('guest_stats')) {
                                'm_descr'  => $GLOBALS['month_descr'][$month],
                                'r_class'  => $r,
                                'r2_class' => $r2,
-                               'cnt'      => $cnt
+                               'cnt'      => $count
                        );
 
                        // Load row template
@@ -158,7 +150,7 @@ switch (getConfig('guest_stats')) {
                                $r2 = '';
                                $l = 'rl'; $r = 'rr';
                        } else {
-                               $OUT .= "</tr>\n";
+                               $OUT .= '</tr>';
                                $r2 = ' right';
                                $l = 'll'; $r = 'lr';
                        }
@@ -168,11 +160,11 @@ switch (getConfig('guest_stats')) {
 
                // Generate category stats
                $OUT = '';
-               foreach ($cat_cnt as $id => $cnt) {
+               foreach ($cat_cnt as $id => $count) {
                        // Prepare data for the template
                        $data = array(
                                'cat' => $cats[$id],
-                               'cnt' => $cnt,
+                               'cnt' => $count,
                        );
 
                        // Load row template and switch colors
@@ -190,11 +182,11 @@ switch (getConfig('guest_stats')) {
                if (isAdmin()) $AND = '';
 
                // Query for guest and member menus
-               $guest_t10 = SQL_QUERY("SELECT `counter`, `title` FROM `{?_MYSQL_PREFIX?}_guest_menu` WHERE `counter` > 0".$AND." ORDER BY `counter` DESC LIMIT 0,10", __FILE__, __LINE__);
-               $mem_t10   = SQL_QUERY("SELECT `counter`, `title` FROM `{?_MYSQL_PREFIX?}_member_menu` WHERE `counter` > 0".$AND." ORDER BY `counter` DESC LIMIT 0,10", __FILE__, __LINE__);
+               $guest_t10 = SQL_QUERY('SELECT `counter`, `title` FROM `{?_MYSQL_PREFIX?}_guest_menu` WHERE `counter` > 0' . $AND . ' ORDER BY `counter` DESC LIMIT 0,10', __FILE__, __LINE__);
+               $mem_t10   = SQL_QUERY('SELECT `counter`, `title` FROM `{?_MYSQL_PREFIX?}_member_menu` WHERE `counter` > 0' . $AND . ' ORDER BY `counter` DESC LIMIT 0,10', __FILE__, __LINE__);
                $OUT = ''; 
 
-               if (SQL_NUMROWS($guest_t10) > 0) {
+               if (!SQL_HASZERONUMS($guest_t10)) {
                        // Guest clicks
                        $OUT .= loadTemplate('guest_stats_header', true, '{--GUEST_TOP_GUEST_STATS--}');
                        while ($content = SQL_FETCHARRAY($guest_t10)) {
@@ -203,7 +195,7 @@ switch (getConfig('guest_stats')) {
                        } // END - while
                } // END - if
 
-               if (SQL_NUMROWS($mem_t10) > 0) {
+               if (!SQL_HASZERONUMS($mem_t10)) {
                        // Member clicks
                        $OUT .= loadTemplate('guest_stats_header', true, '{--GUEST_TOP_MEMBER_STATS--}');
                        while ($content = SQL_FETCHARRAY($mem_t10)) {
@@ -212,7 +204,7 @@ switch (getConfig('guest_stats')) {
                        } // END - while
                } // END - if
 
-               if ((SQL_NUMROWS($guest_t10) > 0) || (SQL_NUMROWS($mem_t10) > 0)) {
+               if ((!SQL_HASZERONUMS($guest_t10)) || (!SQL_HASZERONUMS($mem_t10))) {
                        // Prepare content
                        $content = array(
                                'rows'   => $OUT,
@@ -224,12 +216,12 @@ switch (getConfig('guest_stats')) {
                        loadTemplate('guest_stats_table', false, $content);
                } else {
                        // No clicks detected
-                       loadTemplate('admin_settings_saved', false, '{--GUEST_STATS_NO_CLICKS--}');
+                       displayMessage('{--GUEST_STATS_NO_CLICKS--}');
                }
                break;
 
        case 'INACTIVE': // Deactivated stats
-               loadTemplate('admin_settings_saved', false, '{--GUEST_STATS_DEACTIVATED--}');
+               displayMessage('{--GUEST_STATS_DEACTIVATED--}');
                break;
 } // END - switch