Ref link fixed, nickname fixed, several rewrites, TODOs.txt updated:

[mailer.git] / inc / modules / member / what-nickname.php

diff --git a/inc/modules/member/what-nickname.php b/inc/modules/member/what-nickname.php
index f6802001b7e5b7371ae2a315d8034afcafa72c9a..a086dfd3fe9494c86cf50142d2da3c317528cd99 100644 (file)
--- a/inc/modules/member/what-nickname.php
+++ b/inc/modules/member/what-nickname.php
@@ -10,7 +10,12 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Nickname anstelle der ID                         *
  * -------------------------------------------------------------------- *
- *                                                                      *
+ * $Revision::                                                        $ *
+ * $Date::                                                            $ *
+ * $Tag:: 0.2.1-FINAL                                                 $ *
+ * $Author::                                                          $ *
+ * Needs to be in all Files and every File needs "svn propset           *
+ * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2008 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
@@ -32,77 +37,60 @@
  ************************************************************************/
 
 // Some security stuff...
-if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']))
-{
-       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+if (!defined('__SECURITY')) {
+       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
        require($INC);
-}
- elseif (!IS_LOGGED_IN())
-{
-       LOAD_URL("modules.php?module=index");
-}
- elseif ((!EXT_IS_ACTIVE("nickname")) && (!IS_ADMIN()))
-{
-       ADD_FATAL(EXTENSION_PROBLEM_EXT_INACTIVE, "nickname");
+} elseif (!IS_MEMBER()) {
+       redirectToUrl('modules.php?module=index');
+} elseif ((!EXT_IS_ACTIVE('nickname')) && (!IS_ADMIN())) {
+       addFatalMessage(__FILE__, __LINE__, generateExtensionInactiveNotInstalledMessage('nickname'));
        return;
 }
 
 // Add description as navigation point
-ADD_DESCR("member", basename(__FILE__));
-$VALID = false;
+ADD_DESCR('member', __FILE__);
+$isValid = false;
 
-if (isset($_POST['ok']))
-{
+if (isFormSent()) {
        // Nickname was submitted so let's check if it is not already in use
-       if (!empty($_POST['nickname']))
-       {
+       if (REQUEST_ISSET_POST('nickname')) {
                // Check if nickname is valid
-               $PATTERN = "[".__NICKNAME_PATTERN."]{".__NICKNAME_LENGTH.",}";
-               if (ereg($PATTERN, $_POST['nickname'], $array))
-               {
+               $PATTERN = '[' . getConfig('nickname_pattern') . ']{' . getConfig('nickname_len') . ',}';
+               if (ereg($PATTERN, REQUEST_POST('nickname'), $array)) {
                        // Entered nickname is valid?
-                       if ($array[0] == $_POST['nickname']) $VALID = true;
-               }
-       }
-}
+                       $isValid = ($array[0] == REQUEST_POST('nickname'));
+               } // END - if
+       } // END - if
+} // END - if
 
-if ($VALID)
-{
-       // Look for nickname in database (we only need just one entry so don't worry about the "LIMIT 1" !
-       $result = SQL_QUERY_ESC("SELECT userid FROM "._MYSQL_PREFIX."_user_data WHERE nickname='%s' AND userid != '%s' LIMIT 1",
-        array($_POST['nickname'], $GLOBALS['userid']), __FILE__, __LINE__);
-       if (SQL_NUMROWS($result) == 0)
-       {
+if ($isValid === true) {
+       // Look for nickname in database (we only need just one entry so don't worry about the "LIMIT 1" !)
+       $result = SQL_QUERY_ESC("SELECT `userid` FROM `{!_MYSQL_PREFIX!}_user_data` WHERE `nickname`='%s' AND `userid` != '%s' LIMIT 1",
+               array(REQUEST_POST('nickname'), getUserId()), __FILE__, __LINE__);
+       if (SQL_NUMROWS($result) == 0) {
                // Nickname not in use, so set it now
-               $result = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_user_data SET nickname='%s' WHERE userid=%s LIMIT 1",
-                array($_POST['nickname'], $GLOBALS['userid']), __FILE__, __LINE__);
-               $content = NICKNAME_SAVED;
-       }
-        else
-       {
+               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_user_data` SET `nickname`='%s' WHERE `userid`=%s LIMIT 1",
+                       array(REQUEST_POST('nickname'), getUserId()), __FILE__, __LINE__);
+               $content = getMessage('NICKNAME_SAVED');
+       } else {
                // Free result
                SQL_FREERESULT($result);
 
                // Nickname already in use!
-               $content = NICKNAME_ALREADY_IN_USE;
+               $content = getMessage('NICKNAME_ALREADY_IN_USE');
        }
 
        // Load template
-       LOAD_TEMPLATE("admin_settings_saved", false, $content);
-}
- else
-{
-       // Load current nickname
-       define('__NICKNAME', NICKNAME_GET_NICK($GLOBALS['userid']));
-
+       LOAD_TEMPLATE('admin_settings_saved', false, $content);
+} else {
        // Do we have already submit the form?
-       if (!empty($_POST['nickname']))
-       {
-               OUTPUT_HTML("<STRONG class=\"member_failed\">".NICKNAME_IS_INVALID."</STRONG><P></P>");
-       }
+       if (REQUEST_ISSET_POST('nickname')) {
+               LOAD_TEMPLATE('admin_settings_saved', false, "<div class=\"member_failed\">{--NICKNAME_IS_INVALID--}</div");
+       } // END - if
 
        // Load Template
-       LOAD_TEMPLATE("member_nickname_form");
+       LOAD_TEMPLATE('member_nickname_form', false, NICKNAME_GET_NICK(getUserId()));
 }
+
 //
 ?>