A lot while() conditions rewritten to SQL_FETCHARRAY(), see bug #107, @TODO tags...
[mailer.git] / inc / modules / member / what-order.php
index c82794c2506945a52fe8eff9aa4964d7daddb8e1..6cf97e29943c9c8f07cc4826610bde9625b9334f 100644 (file)
@@ -38,7 +38,7 @@ if (!defined('__SECURITY')) {
 } elseif (!IS_MEMBER()) {
        LOAD_URL("modules.php?module=index");
 } elseif ((!EXT_IS_ACTIVE("order")) && (!IS_ADMIN())) {
-       addFatalMessage(EXTENSION_PROBLEM_EXT_INACTIVE, "order");
+       addFatalMessage(__FILE__, __LINE__, getMessage('EXTENSION_PROBLEM_EXT_INACTIVE'), "order");
        return;
 }
 
@@ -49,10 +49,10 @@ $URL = ""; $id = 0;
 $whereStatement = " WHERE `visible`='Y'";
 
 // Set undefined array elements
-if (empty($_GET['msg']))       $_GET['msg']       = "";
-if (empty($_POST['zip']))      $_POST['zip']      = "";
-if (empty($_POST['html']))     $_POST['html']     = "";
-if (empty($_POST['receiver'])) $_POST['receiver'] = "";
+if (!REQUEST_ISSET_GET(('msg')))       REQUEST_SET_GET('msg'      , "");
+if (!REQUEST_ISSET_POST(('zip')))      REQUEST_SET_POST('zip'     , "");
+if (!REQUEST_ISSET_POST(('html')))     REQUEST_SET_POST('html'    , "");
+if (!REQUEST_ISSET_POST(('receiver'))) REQUEST_SET_POST('receiver', "");
 if (IS_ADMIN()) $whereStatement = "";
 
 // Minimum mails / order
@@ -86,15 +86,15 @@ $TOTAL = GET_TOTAL_DATA($GLOBALS['userid'], "user_points", "points") - GET_TOTAL
 
 if (($HOLIDAY == "Y") && (GET_EXT_VERSION("holiday") >= "0.1.3")) {
        // Holiday is active!
-       LOAD_TEMPLATE("admin_settings_saved", false, HOLIDAY_ORDER_NOT_POSSIBLE);
-} elseif ((!empty($_POST['frametester'])) && ($ALLOWED > 0) && ($_POST['receiver'] > 0)) {
+       LOAD_TEMPLATE("admin_settings_saved", false, getMessage('HOLIDAY_ORDER_NOT_POSSIBLE'));
+} elseif ((REQUEST_ISSET_POST(('frametester'))) && ($ALLOWED > 0) && (REQUEST_POST('receiver') > 0)) {
        // Continue with the frametester, we first need to store the data temporary in the pool
        //
        // First we would like to store the data and get it's pool position back...
        $result = SQL_QUERY_ESC("SELECT id, data_type
 FROM `{!_MYSQL_PREFIX!}_pool`
 WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
-               array($GLOBALS['userid'], $_POST['url'], getConfig('url_tlock')), __FILE__, __LINE__);
+               array($GLOBALS['userid'], REQUEST_POST('url'), getConfig('url_tlock')), __FILE__, __LINE__);
 
        $type = "TEMP"; $id = 0;
        if (SQL_NUMROWS($result) == 1) {
@@ -111,13 +111,13 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
                $URL = "";
                if (getConfig('test_text') == "Y") {
                        // Test submitted text against some filters (length, URLs in text etc.)
-                       if ((strpos(strtolower($_POST['text']), "https://") > -1) || (strpos(strtolower($_POST['text']), "http://") > -1) || (strpos(strtolower($_POST['text']), "www") > -1)) {
+                       if ((strpos(strtolower(REQUEST_POST('text')), "https://") > -1) || (strpos(strtolower(REQUEST_POST('text')), "http://") > -1) || (strpos(strtolower(REQUEST_POST('text')), "www") > -1)) {
                                // URL found!
                                $URL = "modules.php?module=login&what=order&msg=".constant('CODE_URL_FOUND');
                        } // END - if
 
                        // Remove new-line and carriage-return characters
-                       $TEST = str_replace("\n", "", str_replace("\r", "", $_POST['text']));
+                       $TEST = str_replace("\n", "", str_replace("\r", "", REQUEST_POST('text')));
 
                        // Text length within allowed length?
                        if (strlen($TEST) > getConfig('max_tlength')) {
@@ -129,8 +129,8 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
                // Shall I test the subject line against URLs?
                if (getConfig('test_subj') == "Y") {
                        // Check the subject line for issues
-                       $_POST['subject'] = str_replace("\\", "[nl]", substr($_POST['subject'], 0, 200));
-                       if ((strpos(strtolower($_POST['subject']), "http://") > -1) || (strpos(strtolower($_POST['subject']), "www") > -1)) {
+                       REQUEST_SET_POST('subject', str_replace("\\", "[nl]", substr(REQUEST_POST('subject'), 0, 200)));
+                       if ((strpos(strtolower(REQUEST_POST('subject')), "http://") > -1) || (strpos(strtolower(REQUEST_POST('subject')), "www") > -1)) {
                                // URL in subject found
                                $URL = "modules.php?module=login&what=order&msg=".constant('CODE_SUBJ_URL');
                        } // END - if
@@ -140,7 +140,7 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
                if (getConfig('url_blacklist') == "Y") {
                        // Ok, I do that for you know...
                        $result = SQL_QUERY_ESC("SELECT UNIX_TIMESTAMP(`timestamp`) AS tstamp FROM `{!_MYSQL_PREFIX!}_url_blacklist` WHERE `url`='%s' LIMIT 1",
-                               array($_POST['url']), __FILE__, __LINE__);
+                               array(REQUEST_POST('url')), __FILE__, __LINE__);
 
                        if (SQL_NUMROWS($result) == 1) {
                                // Jupp, we got one listed
@@ -155,13 +155,13 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
                } // END - if
 
                // Enougth receivers entered?
-               if (($_POST['receiver'] < getConfig('order_min')) && (!IS_ADMIN())) {
+               if ((REQUEST_POST('receiver') < getConfig('order_min')) && (!IS_ADMIN())) {
                        // Less than allowed receivers entered!
                        $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_MORE_RECEIVERS3');
                } // END - if
 
                // Validate URL
-               if (!VALIDATE_URL($_POST['url'])) {
+               if (!VALIDATE_URL(REQUEST_POST('url'))) {
                        // URL is invalid!
                        $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_INVALID_URL');
                } // END - if
@@ -169,15 +169,15 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
                // Probe for HTML extension
                if (EXT_IS_ACTIVE("html_mail")) {
                        // HTML or regular text mail?
-                       if ($_POST['html'] == "Y") {
+                       if (REQUEST_POST('html') == "Y") {
                                // Chek for valid HTML tags
-                               $_POST['text'] = HTML_CHECK_TAGS($_POST['text']);
+                               REQUEST_SET_POST('text', HTML_CHECK_TAGS(REQUEST_POST('text')));
 
                                // Maybe invalid tags found?
-                               if (empty($_POST['text'])) $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_INVALID_TAGS')."&amp;id=".$id;
+                               if (!REQUEST_ISSET_POST(('text'))) $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_INVALID_TAGS')."&amp;id=".$id;
                        } else {
                                // Remove any HTML code
-                               $_POST['text'] = str_replace("<", "{OPEN_HTML}", str_replace(">", "{CLOSE_HTML}", $_POST['text']));
+                               REQUEST_SET_POST('text', str_replace("<", "{OPEN_HTML}", str_replace(">", "{CLOSE_HTML}", REQUEST_POST('text'))));
                        }
                }
        } elseif (!IS_ADMIN()) {
@@ -189,9 +189,9 @@ WHERE sender=%s AND url='%s' AND timestamp > (UNIX_TIMESTAMP() - %s) LIMIT 1",
        if (empty($URL)) {
                // Check if category and number of receivers is okay
                $ADD = "";
-               if ((getConfig('order_multi_page') == "Y") && (!empty($_POST['zip']))) {
+               if ((getConfig('order_multi_page') == "Y") && (REQUEST_ISSET_POST(('zip')))) {
                        // Choose recipients by ZIP code
-                       $ADD = " AND d.zip LIKE '".bigintval($_POST['zip'])."{PER}'";
+                       $ADD = " AND d.zip LIKE '".bigintval(REQUEST_POST('zip'))."{PER}'";
                } // END - if
 
                // Check for userids
@@ -201,14 +201,14 @@ ON c.userid=d.userid
 WHERE c.cat_id=%s AND c.userid != '%s' AND d.`status`='CONFIRMED' AND d.receive_mails > 0".$ADD."
 ORDER BY d.%s %s",
  array(
-       bigintval($_POST['cat']),
+       bigintval(REQUEST_POST('cat')),
        $GLOBALS['userid'],
        getConfig('order_select'),
        getConfig('order_mode'),
  ), __FILE__, __LINE__);
 
                // Do we enougth receivers left?
-               if (SQL_NUMROWS($result) >= $_POST['receiver']) {
+               if (SQL_NUMROWS($result) >= REQUEST_POST('receiver')) {
                        // Check for holiday extensions
                        $HOLIDAY = false;
                        if (GET_EXT_VERSION("holiday") >= "0.1.3") {
@@ -218,21 +218,21 @@ ORDER BY d.%s %s",
 
                        // Load receivers from database
                        $TEST = array(); $cnt = 0;
-                       while (list($REC) = SQL_FETCHROW($result)) {
+                       while ($content = SQL_FETCHARRAY($result)) {
                                if ($HOLIDAY) {
                                        // Check for his holiday status
                                        $result_holiday = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_user_holidays`
 WHERE userid=%s AND holiday_start < UNIX_TIMESTAMP() AND holiday_end > UNIX_TIMESTAMP() LIMIT 1",
- array(bigintval($REC)), __FILE__, __LINE__);
-                                       if (SQL_NUMROWS($result_holiday) == 1) $REC = 0; // Exclude user who are in holiday
+ array(bigintval($content['userid'])), __FILE__, __LINE__);
+                                       if (SQL_NUMROWS($result_holiday) == 1) $content['userid'] = 0; // Exclude user who are in holiday
 
                                        // Free memory
                                        SQL_FREERESULT($result_holiday);
                                } // END - if
 
-                               if ($REC > 0) {
+                               if ($content['userid'] > 0) {
                                        // Add receiver
-                                       $TEST[] = $REC;
+                                       $TEST[] = $content['userid'];
                                        $cnt++;
                                } // END - if
                        } // END - while
@@ -251,13 +251,13 @@ WHERE userid=%s AND holiday_start < UNIX_TIMESTAMP() AND holiday_end > UNIX_TIME
                                array(str_replace(";", ", ", $RECEIVER), $MAX_SEND), __FILE__, __LINE__);
 
                        // Is calculated max receivers larger than wanted receivers then reset it
-                       if ($MAX_SEND > $_POST['receiver']) $MAX_SEND = $_POST['receiver'];
+                       if ($MAX_SEND > REQUEST_POST('receiver')) $MAX_SEND = REQUEST_POST('receiver');
 
                        // Calculate used points
-                       $USED = $MAX_SEND * GET_PAY_POINTS(bigintval($_POST['type']));
+                       $USED = $MAX_SEND * GET_PAY_POINTS(bigintval(REQUEST_POST('type')));
 
                        // Fix empty zip code
-                       if (empty($_POST['zip'])) $_POST['zip'] = "0";
+                       if (!REQUEST_ISSET_POST(('zip'))) REQUEST_SET_POST('zip', "0");
 
                        // Check if he has enougth points for this order and selected more than 0 receivers
                        if (($USED > 0) && ($USED <= $TOTAL) && ($MAX_SEND > 0)) {
@@ -272,16 +272,16 @@ WHERE userid=%s AND holiday_start < UNIX_TIMESTAMP() AND holiday_end > UNIX_TIME
  VALUES ('%s','%s','%s','%s','%s','TEMP','%s','%s','%s','%s','%s','%s')",
 array(
        $GLOBALS['userid'],
-       $_POST['subject'],
-       $_POST['text'],
+       REQUEST_POST('subject'),
+       REQUEST_POST('text'),
        $RECEIVER,
-       bigintval($_POST['type']),
+       bigintval(REQUEST_POST('type')),
        $TIME,
-       $_POST['url'],
-       bigintval($_POST['cat']),
+       REQUEST_POST('url'),
+       bigintval(REQUEST_POST('cat')),
        $MAX_SEND,
-       bigintval($_POST['zip']),
-       $_POST['html']
+       bigintval(REQUEST_POST('zip')),
+       REQUEST_POST('html')
 ), __FILE__, __LINE__);
                                        } else {
                                                // No HTML extension is active
@@ -289,15 +289,15 @@ array(
  VALUES ('%s','%s','%s','%s','%s','TEMP','%s','%s','%s','%s','%s')",
 array(
        $GLOBALS['userid'],
-       $_POST['subject'],
-       $_POST['text'],
+       REQUEST_POST('subject'),
+       REQUEST_POST('text'),
        $RECEIVER,
-       bigintval($_POST['type']),
+       bigintval(REQUEST_POST('type')),
        $TIME,
-       $_POST['url'],
-       bigintval($_POST['cat']),
+       REQUEST_POST('url'),
+       bigintval(REQUEST_POST('cat')),
        $MAX_SEND,
-       bigintval($_POST['zip']),
+       bigintval(REQUEST_POST('zip')),
 ), __FILE__, __LINE__);
                                        }
                                } else {
@@ -317,15 +317,15 @@ zip=%s,
 html_msg='%s'
 WHERE id=%s LIMIT 1",
 array(
-       $_POST['subject'],
-       $_POST['text'],
+       REQUEST_POST('subject'),
+       REQUEST_POST('text'),
        $RECEIVER,
-       bigintval($_POST['type']),
-       $_POST['url'],
-       bigintval($_POST['cat']),
+       bigintval(REQUEST_POST('type')),
+       REQUEST_POST('url'),
+       bigintval(REQUEST_POST('cat')),
        $MAX_SEND,
-       bigintval($_POST['zip']),
-       $_POST['html'],
+       bigintval(REQUEST_POST('zip')),
+       REQUEST_POST('html'),
        bigintval($id)
 ), __FILE__, __LINE__);
                                        } else {
@@ -342,14 +342,14 @@ target_send=%s,
 zip=%s
 WHERE id=%s LIMIT 1",
 array(
-       $_POST['subject'],
-       $_POST['text'],
+       REQUEST_POST('subject'),
+       REQUEST_POST('text'),
        $RECEIVER,
-       bigintval($_POST['type']),
-       $_POST['url'],
-       bigintval($_POST['cat']),
+       bigintval(REQUEST_POST('type')),
+       REQUEST_POST('url'),
+       bigintval(REQUEST_POST('cat')),
        $MAX_SEND,
-       bigintval($_POST['zip']),
+       bigintval(REQUEST_POST('zip')),
        bigintval($id)
 ), __FILE__, __LINE__);
                                        }
@@ -361,8 +361,8 @@ array(
                                        $result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_pool` WHERE sender=%s AND subject='%s' AND payment_id=%s AND data_type='TEMP' AND timestamp=%s LIMIT 1",
                                        array(
                                                $GLOBALS['userid'],
-                                               $_POST['subject'],
-                                               bigintval($_POST['type']),
+                                               REQUEST_POST('subject'),
+                                               bigintval(REQUEST_POST('type')),
                                                $TIME
                                        ), __FILE__, __LINE__);
 
@@ -384,7 +384,7 @@ array(
                        $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_NO_RECS_LEFT');
                }
        }
-} elseif ($_POST['receiver'] == "0") {
+} elseif (REQUEST_POST('receiver') == "0") {
        // Not enougth receivers selected
        $URL = "modules.php?module=login&amp;what=order&amp;msg=".constant('CODE_MORE_RECEIVERS1');
 } elseif (($ALLOWED == 0) && (getConfig('order_max_full') == "ORDER")) {
@@ -404,20 +404,20 @@ array(
 
                        // Enable HTML checking
                        $HTML = ""; $HOLIDAY = false; $HOL_STRING = "";
-                       if ((EXT_IS_ACTIVE("html_mail")) && ($_POST['html'] == "Y")) $HTML = " AND html='Y'";
+                       if ((EXT_IS_ACTIVE("html_mail")) && (REQUEST_POST('html') == "Y")) $HTML = " AND html='Y'";
                        if (GET_EXT_VERSION("holiday") >= "0.1.3") {
                                // Extension's version is fine
                                $HOLIDAY = true; $HOL_STRING = " AND holiday_active='N'";
                        } // END - if
 
                        // ... and begin loading stuff
-                       while (list($id, $cat) = SQL_FETCHROW($result_cats)) {
-                               $CATS['id'][]   = bigintval($id);
-                               $CATS['name'][] = $cat;
+                       while ($content = SQL_FETCHARRAY($result_cats)) {
+                               $CATS['id'][]   = bigintval($content['id']);
+                               $CATS['name'][] = $content['cat'];
 
                                // Select users in current category
                                $result_uids = SQL_QUERY_ESC("SELECT userid FROM `{!_MYSQL_PREFIX!}_user_cats` WHERE cat_id=%s AND userid != '%s' ORDER BY userid",
-                                       array(bigintval($id), $GLOBALS['userid']), __FILE__, __LINE__);
+                                       array(bigintval($content['id']), $GLOBALS['userid']), __FILE__, __LINE__);
 
                                $uid_cnt = 0;
                                while (list($ucat) = SQL_FETCHROW($result_uids)) {
@@ -445,10 +445,10 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                                $result_ver = SQL_QUERY_ESC("SELECT zip FROM `{!_MYSQL_PREFIX!}_user_data` WHERE userid=%s".$HTML." AND receive_mails > 0 AND `status`='CONFIRMED' LIMIT 1",
                                                        array(bigintval($ucat)), __FILE__, __LINE__);
 
-                                               if ((SQL_NUMROWS($result_ver) == 1) && (!empty($_POST['zip'])) && (getConfig('order_multi_page') == "Y")) {
+                                               if ((SQL_NUMROWS($result_ver) == 1) && (REQUEST_ISSET_POST(('zip'))) && (getConfig('order_multi_page') == "Y")) {
                                                        list($zip) = SQL_FETCHROW($result_ver);
                                                        SQL_FREERESULT($result_ver);
-                                                       if (substr($zip, 0, strlen($_POST['zip'])) == $_POST['zip']) {
+                                                       if (substr($zip, 0, strlen(REQUEST_POST('zip'))) == REQUEST_POST('zip')) {
                                                                // Ok, ZIP part is found
                                                                $uid_cnt++;
                                                        } // END - if
@@ -474,11 +474,11 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                        if (SQL_NUMROWS($result) > 0) {
                                // Check for message ID in URL
                                $MSG = "";
-                               switch ($_GET['msg'])
+                               switch (REQUEST_GET('msg'))
                                {
                                case constant('CODE_URL_TLOCK'):
                                        $result = SQL_QUERY_ESC("SELECT timestamp FROM `{!_MYSQL_PREFIX!}_pool` WHERE id=%s LIMIT 1",
-                                        array(bigintval($_GET['id'])), __FILE__, __LINE__);
+                                        array(bigintval(REQUEST_GET('id'))), __FILE__, __LINE__);
 
                                        // Load timestamp from last order
                                        list($LORDER) = SQL_FETCHROW($result);
@@ -498,9 +498,9 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
 
                                        // Finally contruct the message
                                        // @TODO Rewrite this old lost code to a template
-                                       $MSG = "{!MEMBER_URL_TIME_LOCK!}<br />{!CONFIG_URL_TLOCK!} ".$STD."
-                                               {!_HOURS!}, ".$MIN." {!_MINUTES!} {!_AND!} ".$SEC." {!_SECONDS!}<br />
-                                               {!MEMBER_LAST_TLOCK!}: ".$LORDER;
+                                       $MSG = "{--MEMBER_URL_TIME_LOCK--}<br />{--CONFIG_URL_TLOCK--} ".$STD."
+                                               {--_HOURS--}, ".$MIN." {--_MINUTES--} {--_AND--} ".$SEC." {--_SECONDS--}<br />
+                                               {--MEMBER_LAST_TLOCK--}: ".$LORDER;
                                        break;
 
                                case constant('CODE_OVERLENGTH'):
@@ -516,7 +516,7 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        break;
 
                                case constant('CODE_BLIST_URL'):
-                                       $MSG = "{!MEMBER_URL_BLACK_LISTED!}<br />\n{!MEMBER_BLIST_TIME!}: ".MAKE_DATETIME($_GET['blist'], "0");
+                                       $MSG = "{--MEMBER_URL_BLACK_LISTED--}<br />\n{--MEMBER_BLIST_TIME--}: ".MAKE_DATETIME(REQUEST_GET('blist'), "0");
                                        break;
 
                                case constant('CODE_NO_RECS_LEFT'):
@@ -540,7 +540,7 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        break;
 
                                case constant('CODE_MORE_RECEIVERS3'):
-                                       $MSG = "{!MEMBER_ENTER_MORE_MIN_RECEIVERS_1!}".getConfig('order_min')."{!MEMBER_ENTER_MORE_MIN_RECEIVERS_2!}";
+                                       $MSG = sprintf(getMessage('MEMBER_ENTER_MORE_MIN_RECEIVERS'), getConfig('order_min'));
                                        break;
 
                                case constant('CODE_INVALID_URL'):
@@ -551,8 +551,8 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        break;
 
                                default:
-                                       DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown error code %s detected.", $_GET['msg']));
-                                       $MSG = "{!UNKNOWN_CODE_1!}".$_GET['msg']."{!UNKNOWN_CODE_2!}";
+                                       DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown error code %s detected.", REQUEST_GET('msg')));
+                                       $MSG = sprintf(getMessage('UNKNOWN_CODE'), REQUEST_GET('msg'));
                                        break;
                                }
 
@@ -580,7 +580,7 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        break;
 
                                case "ORDER": // He is allowed to send as much as he setup the receiving value
-                                       define('ORDER_MAX_VALUE', ORDER_ALLOWED_RECEIVE_1.$ALLOWED.ORDER_ALLOWED_RECEIVE_2.$MAXI.ORDER_ALLOWED_RECEIVE_3);
+                                       define('ORDER_MAX_VALUE', sprintf(getMessage('ORDER_ALLOWED_RECEIVE'), $ALLOWED, $MAXI));
                                        break;
 
                                default: // Unknown/invalid
@@ -601,10 +601,10 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
 
                                if (SQL_NUMROWS($result) == 1) {
                                        // Old order found
-                                       list($subject, $text, $payment, $tstamp, $url, $target, $cat, $zip) = SQL_FETCHROW($result);
+                                       list($subject, $text, $payment, $tstamp, $url, $target, $content['cat'], $zip) = SQL_FETCHROW($result);
 
                                        // Fix max receivers when it is too much
-                                       if ((isset($CATS['uids'][$cat])) && ($target > $CATS['uids'][$cat])) $target = $CATS['uids'][$cat];
+                                       if ((isset($CATS['uids'][$content['cat']])) && ($target > $CATS['uids'][$content['cat']])) $target = $CATS['uids'][$content['cat']];
 
                                        // Old order is grabbed
                                        $OLD_ORDER = true;
@@ -617,13 +617,13 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                SQL_FREERESULT($result);
 
                                // 01      2              21    12                                    2    23         443    3          3210
-                               if ((!empty($_POST['data'])) || ((getConfig('order_multi_page') != "Y") && ((!IS_ADMIN()) && (!EXT_IS_ACTIVE("html_mail"))))) {
+                               if ((REQUEST_ISSET_POST(('data'))) || ((getConfig('order_multi_page') != "Y") && ((!IS_ADMIN()) && (!EXT_IS_ACTIVE("html_mail"))))) {
                                        // Pre-output categories
                                        $CAT = "";
                                        foreach ($CATS['id'] as $key => $value) {
                                                $CAT .= "      <option value=\"".$value."\"";
-                                               if (($OLD_ORDER) && ($cat == $value)) $CAT .= " selected=\"selected\"";
-                                               $CAT .= ">".$CATS['name'][$key]." (".$CATS['uids'][$key]." {!USER_IN_CAT!})</option>\n";
+                                               if (($OLD_ORDER) && ($content['cat'] == $value)) $CAT .= " selected=\"selected\"";
+                                               $CAT .= ">".$CATS['name'][$key]." (".$CATS['uids'][$key]." {--USER_IN_CAT--})</option>\n";
                                        } // END - foreach
 
                                        // Mail type
@@ -634,7 +634,7 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                                        // Output option line
                                                        $type .= "      <option value=\"".$typeS[$key][0]."\"";
                                                        if (($OLD_ORDER) && ($payment == $typeS[$key][0])) $type .= " selected=\"selected\"";
-                                                       $type .= ">".$P." {!PER_MAIL!} - ".$typeS[$key][3]." - ".round($typeS[$key][2])." {!PAYMENT!}</option>\n";
+                                                       $type .= ">".$P." {--PER_MAIL--} - ".$typeS[$key][3]." - ".round($typeS[$key][2])." {--PAYMENT--}</option>\n";
                                                } // END - if
                                        } // END - foreach
 
@@ -646,15 +646,15 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        define('TEXT', COMPILE_CODE($text));
                                        define('T_URL', $url);
 
-                                       if (!empty($_POST['zip'])) {
+                                       if (REQUEST_ISSET_POST(('zip'))) {
                                                // Output entered ZIP code
-                                               define('ZIP_OUTPUT', LOAD_TEMPLATE("member_order-zip2", true, $_POST['zip']));
+                                               define('ZIP_OUTPUT', LOAD_TEMPLATE("member_order-zip2", true, REQUEST_POST('zip')));
                                        } else {
                                                define('ZIP_OUTPUT', "<tr><td colspan=\"5\" height=\"5\" class=\"seperator\">&nbsp;</td></tr>");
                                        }
 
                                        // HTML extension
-                                       if ((EXT_IS_ACTIVE("html_mail")) && ($_POST['html'] == "Y")) {
+                                       if ((EXT_IS_ACTIVE("html_mail")) && (REQUEST_POST('html') == "Y")) {
                                                // Extension is active so output valid HTML tags
                                                define('MEMBER_HTML_EXTENSION', LOAD_TEMPLATE("member_order-html_ext", true, HTML_ADD_VALID_TAGS()));
                                        } else {
@@ -679,9 +679,9 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                        // Do we want ZIP code or not?
                                        if ((getConfig('order_multi_page') == "Y") || (IS_ADMIN())) {
                                                // Yes
-                                               if ($_POST['zip'] > 0) {
+                                               if (REQUEST_POST('zip') > 0) {
                                                        $content = array(
-                                                               'zip' => bigintval($_POST['zip']),
+                                                               'zip' => bigintval(REQUEST_POST('zip')),
                                                                'add' => $ADD
                                                        );
                                                } else {
@@ -701,22 +701,22 @@ LIMIT 1", array(bigintval($ucat)), __FILE__, __LINE__);
                                }
                        } else {
                                // No mail types defined
-                               LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{!MEMBER_NO_PAYMENTS!}</span>");
+                               LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{--MEMBER_NO_PAYMENTS--}</span>");
                        }
                } else {
-                       // No points left!
-                       LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{!MEMBER_NO_POINTS!}</span>");
+                       // No points left
+                       LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{--MEMBER_NO_POINTS--}</span>");
                }
        } else {
                // No cateogries are defined yet
-               LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{!MEMBER_NO_CATS!}</span>");
+               LOAD_TEMPLATE("admin_settings_saved", false, "<span class=\"member_failed\">{--MEMBER_NO_CATS--}</span>");
        }
 } elseif ($mmails == "0") {
-       // Please set more than 0 mails per day!
+       // Please set more than 0 mails per day
        LOAD_TEMPLATE("admin_settings_saved", false, getMessage('MEMBER_HAS_ZERO_MMAILS'));
 } else {
-       // Please confirm some mails first!
-       LOAD_TEMPLATE("admin_settings_saved", false, MEMBER_LINKS_LEFT_1.$links.MEMBER_LINKS_LEFT_2.getConfig('unconfirmed').MEMBER_LINKS_LEFT_3);
+       // Please confirm some mails first
+       LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('MEMBER_LINKS_LEFT'), $links, getConfig('unconfirmed')));
 }
 
 if (!empty($URL)) {