Ref link fixed, nickname fixed, several rewrites, TODOs.txt updated:

[mailer.git] / inc / modules / member / what-reflinks.php

diff --git a/inc/modules/member/what-reflinks.php b/inc/modules/member/what-reflinks.php
index 4e186055a9bb536dfdff9bf9f639687506c23f87..8688d2a476e98f3fc5a2a117ab32d707adc36b25 100644 (file)
--- a/inc/modules/member/what-reflinks.php
+++ b/inc/modules/member/what-reflinks.php
@@ -38,26 +38,26 @@
 
 // Some security stuff...
 if (!defined('__SECURITY')) {
-       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
        require($INC);
 } elseif (!IS_MEMBER()) {
-       LOAD_URL("modules.php?module=index");
+       redirectToUrl('modules.php?module=index');
 }
 
 // Add description as navigation point
-ADD_DESCR("member", __FILE__);
+ADD_DESCR('member', __FILE__);
 
 // Load current referal clicks
-$result = SQL_QUERY_ESC("SELECT ref_clicks FROM `{!_MYSQL_PREFIX!}_user_data` WHERE userid=%s LIMIT 1",
+$result = SQL_QUERY_ESC("SELECT `ref_clicks` FROM `{!_MYSQL_PREFIX!}_user_data` WHERE `userid`=%s LIMIT 1",
        array(getUserId()), __FILE__, __LINE__);
-list($c) = SQL_FETCHROW($result);
+$content = SQL_FETCHARRAY($result);
 SQL_FREERESULT($result);
 
 OUTPUT_HTML("<div class=\"tiny\">{--YOUR_PERSONAL_REFLINK--}:<br />
 <strong><a href=\"{!URL!}/ref.php?refid=".getUserId()."\" target=\"_blank\">{!URL!}/ref.php?ref=".getUserId()."</a></strong><br />
 <br />");
 
-if (EXT_IS_ACTIVE("nickname")) {
+if (EXT_IS_ACTIVE('nickname')) {
        // Add nickname link when nickname is entered
        $nick = NICKNAME_GET_NICK(getUserId());
 
@@ -74,63 +74,56 @@ if (EXT_IS_ACTIVE("nickname")) {
 }
 
 // Clicks on your reflink
-OUTPUT_HTML("{--YOUR_REFCLICKS--}: <strong>".$c."</strong> {--CLICKS--}</div><br /><br />");
+OUTPUT_HTML("{--YOUR_REFCLICKS--}: <strong>".$content['ref_clicks']."</strong> {--CLICKS--}</div><br /><br />");
+
 $whereStatement = " WHERE `visible`='Y'";
-if (IS_ADMIN()) $whereStatement = "";
-$result = SQL_QUERY("SELECT id, url, alternate, counter, clicks FROM `{!_MYSQL_PREFIX!}_refbanner`", __FILE__, __LINE__);
+if (IS_ADMIN()) $whereStatement = '';
+$result = SQL_QUERY("SELECT `id`, `url`, `alternate`, `counter`, `clicks` FROM `{!_MYSQL_PREFIX!}_refbanner`", __FILE__, __LINE__);
 
 if (SQL_NUMROWS($result) > 0) {
        // List available ref banners
-       $OUT = ""; $SW = 2;
+       $OUT = ''; $SW = 2;
        while ($content = SQL_FETCHARRAY($result)) {
                $test = str_replace(constant('URL'), constant('PATH'), $content['url']); $size = 0;
                if ($test == $content['url']) {
                        // Download banner (I hope you keep the banner on same server???)
-                       $fp = GET_URL($content['url']); $bannerContent = "";
-                       if ((!empty($fp)) && (is_array($fp)) && (count($fp) > 0) {
+                       $fp = sendGetRequest($content['url']); $bannerContent = '';
+                       if ((!empty($fp)) && (is_array($fp)) && (count($fp) > 0)) {
                                // Loads only found banner, when there is a 404 error this foreach() command
                                // will cause an "Invalid argument supplied for foreach()" error
                                foreach ($fp as $f) {
                                        $bannerContent .= $f;
-                               }
-                       }
+                               } // END - foreach
+                       } // END - if
                        $size = strlen($bannerContent);
-               } elseif (FILE_READABLE($test)) {
+               } elseif (isFileReadable($test)) {
                        $size = filesize($test);
                }
 
-               if ($size > 0) $content['alternate'] .= " (".TRANSLATE_COMMA(round($size/102.4)/10)." {--KBYTES--})";
+               if ($size > 0) $content['alternate'] .= ' ('  .translateComma(round($size / 102.4) / 10) . ' {--KBYTES--})';
 
-               // Load banner data
-               // @TODO Rewritings: alt->alternate,cnt->counter,cks->clicks,uid->userid in template
-               $content = array(
-                       'sw'  => $SW,
-                       'url' => $content['url'],
-                       'alt' => $content['alternate'],
-                       'cnt' => $content['counter'],
-                       'cks' => $content['clicks'],
-                       'uid' => getUserId(),
-                       'id'  => $content['id'],
-               );
+               // Add some more data
+               $content['sw']     = $SW;
+               $content['userid'] = getUserId();
 
                // Add row
-               $OUT .= LOAD_TEMPLATE("member_reflinks_row", true, $content);
+               $OUT .= LOAD_TEMPLATE('member_reflinks_row', true, $content);
 
                // Switchcolors
                $SW = 3 - $SW;
-       }
+       } // END - while
 
        define('__REFLINKS_ROWS', $OUT);
 
        // Load final template
-       LOAD_TEMPLATE("member_reflinks_table", false, getUserId());
+       LOAD_TEMPLATE('member_reflinks_table', false, getUserId());
 } else {
        // No refbanner found!
-       LOAD_TEMPLATE("admin_settings_saved", false, getMessage('MEMBER_NO_REFBANNER_FOUND'));
+       LOAD_TEMPLATE('admin_settings_saved', false, getMessage('MEMBER_NO_REFBANNER_FOUND'));
 }
 
 // Free result
 SQL_FREERESULT($result);
 
-//
+// [EOF]
 ?>