More rewrites

[mailer.git] / mailid.php

diff --git a/mailid.php b/mailid.php
index ffad34755551de02776a3253de1ee5eefebed2c8..58142edba2336e8de31e3be5713cf08b9d95b18c 100644 (file)
--- a/mailid.php
+++ b/mailid.php
@@ -68,15 +68,18 @@ if (isGetRequestElementSet('bonusid')) $url_bid    = bigintval(getRequestElement
 
 // 01           1        12            2    2            21    1                   22     10
 if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErrors() == 0)) {
+       // Init result
+       $result_link = false;
+
        // Maybe he wants to confirm an email?
        if ($url_mid > 0) {
                // Normal-Mails
-               $result = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `stats_id`=%s AND `userid`=%s LIMIT 1",
+               $result_link = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `stats_id`=%s AND `userid`=%s LIMIT 1",
                        array($url_mid, $url_userid), __FILE__, __LINE__);
                $type = 'mailid'; $urlId = $url_mid;
        } elseif ($url_bid > 0) {
                // Bonus-Mail
-               $result = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `bonus_id`=%s AND `userid`=%s LIMIT 1",
+               $result_link = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `bonus_id`=%s AND `userid`=%s LIMIT 1",
                        array($url_bid, $url_userid), __FILE__, __LINE__);
                $type = 'bonusid'; $urlId = $url_bid;
        } else {
@@ -84,16 +87,12 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
                redirectToUrl('index.php');
        }
 
-       if (SQL_NUMROWS($result) == 1) {
+       if (SQL_NUMROWS($result_link) == 1) {
                // Load the entry
-               list($ltype) = SQL_FETCHROW($result);
-
-               // Clean result
-               SQL_FREERESULT($result);
+               list($ltype) = SQL_FETCHROW($result_link);
 
                // @TODO Rewrite this to a filter
-               switch ($ltype)
-               {
+               switch ($ltype) {
                        case 'NORMAL':
                                // Is the stats ID valid?
                                $result = SQL_QUERY_ESC("SELECT pool_id, url, subject FROM `{?_MYSQL_PREFIX?}_user_stats` WHERE `id`=%s LIMIT 1",
@@ -205,6 +204,9 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
                SQL_FREERESULT($result);
                $errorCode = getCode('ALREADY_CONFIRMED');
        }
+
+       // Free result
+       SQL_FREERESULT($result_link);
 } else {
        // Nothing entered
        $errorCode = getCode('ERROR_MAILID');