Fixes for a lot bug tickets. (Sorry for lame comment)

[mailer.git] / ref.php

diff --git a/ref.php b/ref.php
index 7edc3ed7d09c6ac434b7110393415e529fb51ed6..4b34282a65e9fbc606c9057b698d6618fd81e609 100644 (file)
--- a/ref.php
+++ b/ref.php
@@ -6,9 +6,9 @@
  * -------------------------------------------------------------------- *
  * File              : ref.php                                          *
  * -------------------------------------------------------------------- *
- * Short description : Redirection for the referral link                *
+ * Short description : Redirection for the referal link                 *
  * -------------------------------------------------------------------- *
- * Kurzbeschreibung  : Weiterleitungsscript fuer die Referral-Links     *
+ * Kurzbeschreibung  : Weiterleitungsscript fuer die Referal-Links      *
  * -------------------------------------------------------------------- *
  *                                                                      *
  * -------------------------------------------------------------------- *
@@ -42,13 +42,12 @@ $GLOBALS['what'] = ""; $GLOBALS['action'] = "";
 $GLOBALS['module'] = "ref"; $CSS = -1;
 
 // Load the required file(s)
-require ("inc/config.php");
+require("inc/config.php");
 
 // Redirect only to registration page when this script is installed
-if (defined('mxchange_installed') && (isBooleanConstantAndTrue('mxchange_installed')))
-{
+if (isBooleanConstantAndTrue('mxchange_installed')) {
        // Base URL for redirection
-       switch ($_CONFIG['refid_target'])
+       switch (getConfig('refid_target'))
        {
        case "register":
                $URL = URL."/modules.php?module=index&what=register&refid=";
@@ -59,43 +58,52 @@ if (defined('mxchange_installed') && (isBooleanConstantAndTrue('mxchange_install
                break;
        }
 
-       // Get referral ID from ref or refid variable
+       // Get referal ID from ref or refid variable
        if (!empty($_GET['ref']))        $ref = secureString($_GET['ref']);
-        elseif (!empty($_GET['refid'])) $ref = bigintval($_GET['refid']);
+        elseif (!empty($_GET['refid'])) $ref = secureString($_GET['refid']);
 
-       if (!empty($ref))
-       {
-               // Test if nickname ($test == "0") or ID
-               $test = "".round($ref)."";
-               if ((EXT_IS_ACTIVE("nickname")) && ($test != $ref))
-               {
-                       // Nickname in URL, so load the ID
-                       $result = SQL_QUERY_ESC("SELECT userid FROM "._MYSQL_PREFIX."_user_data WHERE nickname='%s' LIMIT 1", array($ref), __FILE__, __LINE__);
-                       list($ref) = SQL_FETCHROW($result);
-                       SQL_FREERESULT($result);
-               }
+       if (!empty($ref)) {
+               // Test if nickname or numeric id
+               if ($ref != "".($ref + 0)."") {
+                       if (EXT_IS_ACTIVE("nickname")) {
+                               // Nickname in URL, so load the ID
+                               $result = SQL_QUERY_ESC("SELECT userid FROM `"._MYSQL_PREFIX."_user_data` WHERE nickname='%s' LIMIT 1",
+                                       array($ref), __FILE__, __LINE__);
+
+                               // Load userid
+                               list($ref) = SQL_FETCHROW($result);
+
+                               // Free result
+                               SQL_FREERESULT($result);
+                       } else {
+                               // Invalid request!
+                               $ref = 0;
+                       }
+               } // END - if
 
                // Also edit this 0 !
-               if (empty($ref)) $ref = "0";
+               if (empty($ref)) $ref = 0;
+
+               // Update session
+               set_session('refid', $ref);
 
                // We have an refid here. So we simply add it
                $URL .= bigintval($ref);
 
-               // Update ref counter
-               $result = SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_user_data SET ref_clicks=ref_clicks+1 WHERE userid=%s LIMIT 1",
-                array(bigintval($ref)), __FILE__, __LINE__);
-       }
-        else
-       {
+               // Is the refid valid?
+               if ($ref > 0) {
+                       // Update ref counter
+                       SQL_QUERY_ESC("UPDATE `"._MYSQL_PREFIX."_user_data` SET ref_clicks=ref_clicks+1 WHERE userid=%s LIMIT 1",
+                               array(bigintval($ref)), __FILE__, __LINE__);
+               } // END - if
+       } else {
                // No refid and we add our refid (don't forget to set $def_refid!)
                $URL = URL."/index.php";
        }
+
        // Load the URL
        LOAD_URL($URL);
-       // Redirection should be done here
-}
- else
-{
+} else {
        // You have to configure first!
        LOAD_URL("install.php");
 }