Fix for endless loop

[mailer.git] / view.php

diff --git a/view.php b/view.php
index 100e3e7b0c2b058c729d3d9e199701834d239363..3432fb354803a255e0241fb39e0c9c838610b3f9 100644 (file)
--- a/view.php
+++ b/view.php
@@ -17,7 +17,7 @@
  * Needs to be in all Files and every File needs "svn propset           *
  * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
- * Copyright (c) 2003 - 2008 by Roland Haeder                           *
+ * Copyright (c) 2003 - 2009 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -36,37 +36,45 @@
  * MA  02110-1301  USA                                                  *
  ************************************************************************/
 
-// Load security stuff here (Oh, I hope this is not unsecure? Am I paranoia??? ;-) )
+// Load security stuff here
 require('inc/libs/security_functions.php');
 
-// Init "action" and "what"
-$GLOBALS['what'] = '';
-$GLOBALS['action'] = '';
-
 // Set module
 $GLOBALS['module'] = 'view';
 $GLOBALS['output_mode'] = -1;
 
 // Load the required file(s)
-require('inc/config.php');
+require('inc/config-global.php');
+
+if (((isGetRequestElementSet('user')) || (isGetRequestElementSet('reseller'))) && (isGetRequestElementSet('banner'))) {
+       // For later things... ;-)
+       $result = SQL_QUERY_ESC("SELECT `url` FROM `{?_MYSQL_PREFIX?}_refbanner` WHERE `id`=%s LIMIT 1",
+               array(bigintval(getRequestElement('banner'))), __FILE__, __LINE__);
 
-if (((REQUEST_ISSET_GET(('user'))) || (REQUEST_ISSET_GET(('reseller')))) && (REQUEST_ISSET_GET(('banner')))) {
-       // for later things... ;-)
-       $result = SQL_QUERY_ESC("SELECT url FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
-               array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+       // Do we have the banner?
        if (SQL_NUMROWS($result) == 1)  {
+               // Load the URL
                list($url) = SQL_FETCHROW($result);
-               SQL_FREERESULT($result);
-               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET counter=counter+1 WHERE `id`=%s LIMIT 1",
-                       array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
 
+               // Update counter
+               SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_refbanner` SET `counter`=`counter`+1 WHERE `id`=%s LIMIT 1",
+                       array(bigintval(getRequestElement('banner'))), __FILE__, __LINE__);
+
+               // Extract type (last 3 chars should be okay)
                $type = substr($url, -3);
-               header ('Content-Type: image/' . $type);
+
+               // Set header and ...
+               sendHeader('Content-Type: image/' . $type);
+
+               // Redirect
                redirectToUrl($url, false);
        } else {
-               // Free memory
-               SQL_FREERESULT($result);
+               // @TODO No banner found, output some default banner
+               logDebugMessage(__FILE__, __LINE__, 'Banner ' . bigintval(getRequestElement('banner')) . ' not dound.');
        }
+
+       // Free memory
+       SQL_FREERESULT($result);
 } else {
        // Do nothing for now
        redirectToUrl('index.php');
@@ -75,5 +83,5 @@ if (((REQUEST_ISSET_GET(('user'))) || (REQUEST_ISSET_GET(('reseller')))) && (REQ
 // Shutdown
 shutdown();
 
-//
+// [EOF]
 ?>