TODO added

[mailer.git] / view.php

diff --git a/view.php b/view.php
index a4dae48a75e85c5c213c1d26af8b0e94b2fcec10..b102474925457cbb0cf90a9a72ae5171b4f514f2 100644 (file)
--- a/view.php
+++ b/view.php
@@ -39,10 +39,6 @@
 // Load security stuff here
 require('inc/libs/security_functions.php');
 
-// Init "action" and "what"
-$GLOBALS['what'] = '';
-$GLOBALS['action'] = '';
-
 // Set module
 $GLOBALS['module'] = 'view';
 $GLOBALS['output_mode'] = -1;
@@ -50,23 +46,35 @@ $GLOBALS['output_mode'] = -1;
 // Load the required file(s)
 require('inc/config-global.php');
 
-if (((REQUEST_ISSET_GET(('user'))) || (REQUEST_ISSET_GET(('reseller')))) && (REQUEST_ISSET_GET(('banner')))) {
-       // for later things... ;-)
-       $result = SQL_QUERY_ESC("SELECT url FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
-       array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+if (((REQUEST_ISSET_GET('user')) || (REQUEST_ISSET_GET('reseller'))) && (REQUEST_ISSET_GET('banner'))) {
+       // For later things... ;-)
+       $result = SQL_QUERY_ESC("SELECT `url` FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
+               array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+
+       // Do we have the banner?
        if (SQL_NUMROWS($result) == 1)  {
+               // Load the URL
                list($url) = SQL_FETCHROW($result);
-               SQL_FREERESULT($result);
-               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET counter=counter+1 WHERE `id`=%s LIMIT 1",
-               array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
 
+               // Update counter
+               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET `counter`=`counter`+1 WHERE `id`=%s LIMIT 1",
+                       array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+
+               // Extract type (last 3 chars should be okay)
                $type = substr($url, -3);
+
+               // Set header and ...
                sendHeader('Content-Type: image/' . $type);
+
+               // Redirect
                redirectToUrl($url, false);
        } else {
-               // Free memory
-               SQL_FREERESULT($result);
+               // @TODO No banner found, output some default banner
+               DEBUG_LOG(__FILE__, __LINE__, 'Banner ' . bigintval(REQUEST_GET('banner')) . ' not dound.');
        }
+
+       // Free memory
+       SQL_FREERESULT($result);
 } else {
        // Do nothing for now
        redirectToUrl('index.php');
@@ -75,5 +83,5 @@ if (((REQUEST_ISSET_GET(('user'))) || (REQUEST_ISSET_GET(('reseller')))) && (REQ
 // Shutdown
 shutdown();
 
-//
+// [EOF]
 ?>