X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=1c009db1b871456bc316d2ec3484d6a0790d3313;hp=346184b921335684f1774f8f94a15c042d48c396;hb=8ec82aa8ce39be68e4087a26f9763b86fc124ed4;hpb=1fd39b2564946ce7f19776abab8d65a31928fba1 diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 346184b921..1c009db1b8 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -1,8 +1,8 @@ ### WARNING: THIS FILE IS AUTO-GENERATED BY ./DOCS/todo-builder.sh (uid=/user=quix0r) ### ### DO NOT EDIT THIS FILE. ### ./autoreg.php:60:// @TODO Add processing of request here -./beg.php:172: // @TODO Opps, what is missing here??? -./birthday_confirm.php:99: // @TODO Try to rewrite the following unset() +./beg.php:165: // @TODO Opps, what is missing here??? +./birthday_confirm.php:95: // @TODO Try to rewrite the following unset() ./inc/autopurge/purge-inact.php:57: // @TODO Rewrite these if() blocks to a filter ./inc/cache/config-local.php:126:// @TODO Rewrite the following three constants, somehow... ./inc/classes/cachesystem.class.php:474: // @TODO Add support for more types which break in last else-block @@ -37,42 +37,42 @@ ./inc/extensions/ext-rallye.php:94: // @TODO Fix config_rallye_prices to list_rallye_prices ./inc/extensions/ext-yoomedia.php:123: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:56:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y'); -./inc/extensions-functions.php:143: // @TODO Do we still need this? setExtensionUpdateNotes(''); -./inc/extensions-functions.php:424:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) -./inc/extensions-functions.php:548: // @TODO Extension is loaded, what next? +./inc/extensions-functions.php:146: // @TODO Do we still need this? setExtensionUpdateNotes(''); +./inc/extensions-functions.php:427:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) +./inc/extensions-functions.php:551: // @TODO Extension is loaded, what next? ./inc/functions.php:115: // @TODO Extension 'msg' does not exist -./inc/functions.php:1483: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1506: // @TODO Rewrite this old lost code to a template -./inc/functions.php:1574: // @TODO Are these convertions still required? -./inc/functions.php:1592:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1486: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? +./inc/functions.php:1509: // @TODO Rewrite this old lost code to a template +./inc/functions.php:1577: // @TODO Are these convertions still required? +./inc/functions.php:1595:// @TODO Rewrite this function to use readFromFile() and writeToFile() ./inc/functions.php:178:// @TODO Rewrite this to an extension 'smtp' -./inc/functions.php:2245: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2251: // @TODO This is still very static, rewrite it somehow ./inc/gen_sql_patches.php:96:// @TODO Rewrite this to a filter ./inc/install-functions.php:63: // @TODO DEACTIVATED: changeDataInFile(getCachePath() . 'config-local.php', 'OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestParameter('omode'), 0); -./inc/language/de.php:1136:// @TODO Rewrite these two constants -./inc/language/de.php:1151:// @TODO Rewrite these three constants -./inc/language/de.php:302: // @TODO Following two are unused? -./inc/language/de.php:829:// @TODO Are these constants longer used? +./inc/language/de.php:1127:// @TODO Rewrite these two constants +./inc/language/de.php:1142:// @TODO Rewrite these three constants +./inc/language/de.php:301: // @TODO Following two are unused? +./inc/language/de.php:819:// @TODO Are these constants longer used? ./inc/language-functions.php:234: // @TODO These are all valid languages, again hard-coded ./inc/language-functions.php:46:// @TODO Rewrite all language constants to this function. ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:46:// @TODO Rewrite these constants to one ./inc/language/sponsor_de.php:119:// @TODO Rewrite these four constants to one and use sprintf() -./inc/libs/admins_functions.php:434: // @TODO This can be, somehow, rewritten -./inc/libs/beg_functions.php:58: // @TODO Try to rewrite the following unset() -./inc/libs/bonus_functions.php:206: // @TODO Move this HTML to a template -./inc/libs/bonus_functions.php:290: // @TODO This query isn't right, it will only update if the user was for a longer time away! +./inc/libs/admins_functions.php:432: // @TODO This can be, somehow, rewritten +./inc/libs/beg_functions.php:54: // @TODO Try to rewrite the following unset() +./inc/libs/bonus_functions.php:204: // @TODO Move this HTML to a template +./inc/libs/bonus_functions.php:288: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/libs/doubler_functions.php:46:// @TODO Lame description ./inc/libs/doubler_functions.php:94: // @TODO Can't this be moved into EL? ./inc/libs/mailid_functions.php:49: // @TODO Rewrite this to a dynamic include or so -./inc/libs/rallye_functions.php:700:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() -./inc/libs/rallye_functions.php:768: $EXPIRE = 3; // @TODO The hard-coded value... -./inc/libs/rallye_functions.php:854:// @TODO Please document this function -./inc/libs/rallye_functions.php:910: // Load count @TODO Can't we rewrite this to our API? +./inc/libs/rallye_functions.php:704:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() +./inc/libs/rallye_functions.php:769: $EXPIRE = 3; // @TODO The hard-coded value... +./inc/libs/rallye_functions.php:855:// @TODO Please document this function +./inc/libs/rallye_functions.php:911: // Load count @TODO Can't we rewrite this to our API? ./inc/libs/refback_functions.php:61: // @TODO Try to rewrite the following unset() -./inc/libs/register_functions.php:296: // @TODO Rewrite these all to a single filter -./inc/libs/register_functions.php:375: // @TODO Rewrite this to a filter -./inc/libs/register_functions.php:382: // @TODO Wether the registration bonus should only be added to user directly or through referal system should be configurable +./inc/libs/register_functions.php:292: // @TODO Rewrite these all to a single filter +./inc/libs/register_functions.php:362: // @TODO Rewrite this to a filter +./inc/libs/register_functions.php:369: // @TODO Wether the registration bonus should only be added to user directly or through referal system should be configurable ./inc/libs/surfbar_functions.php:1540: // @TODO This can be somehow rewritten ./inc/libs/surfbar_functions.php:712:// @TODO Can't we use our new expression language instead of this ugly code? ./inc/libs/surfbar_functions.php:953: // @TODO Invalid salt should be refused @@ -96,9 +96,9 @@ ./inc/modules/admin/admin-inc.php:438:// @TODO Try to rewrite this to adminAddMenuSelectionBox() ./inc/modules/admin/overview-inc.php:164: // @TODO Rewrite this to a filter ./inc/modules/admin/overview-inc.php:277: // @TODO Rewrite this to something with include files and/or filter -./inc/modules/admin/overview-inc.php:315: // @TODO This may also be rewritten to include files -./inc/modules/admin/overview-inc.php:317: default: // @TODO Unknown support mode -./inc/modules/admin/overview-inc.php:432: // @TODO Try to move this in includes +./inc/modules/admin/overview-inc.php:311: // @TODO This may also be rewritten to include files +./inc/modules/admin/overview-inc.php:313: default: // @TODO Unknown support mode +./inc/modules/admin/overview-inc.php:428: // @TODO Try to move this in includes ./inc/modules/admin/overview-inc.php:45:// @TODO This function does also check for uncompleted tasks ./inc/modules/admin/what-add_guestnl_cat.php:49: // @TODO Check if category does already exist ./inc/modules/admin/what-add_surfbar_url.php:57: // @TODO Find all convertSelectionsToTimestamp() calls and rewrite postRequestParameter() calls to $postData @@ -108,7 +108,7 @@ ./inc/modules/admin/what-adminedit.php:58: // @TODO Kill all constants in this file ./inc/modules/admin/what-admins_mails.php:61: // @TODO Can this be rewritten to an API function? ./inc/modules/admin/what-bonus.php:48:// @TODO Unused at the moment -./inc/modules/admin/what-config_admins.php:126: // @TODO Rewrite this to filter 'run_sqls' +./inc/modules/admin/what-config_admins.php:128: // @TODO Rewrite this to filter 'run_sqls' ./inc/modules/admin/what-config_mods.php:57: // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function ./inc/modules/admin/what-config_points.php:113: // @TODO Rewrite this to a filter ./inc/modules/admin/what-config_rallye_prices.php:197: // @TODO Rewrite these two constants @@ -117,10 +117,10 @@ ./inc/modules/admin/what-del_email.php:61: // @TODO Unused: cat_id, payment_id ./inc/modules/admin/what-edit_user.php:20: * @TODO Add support for ext-country * ./inc/modules/admin/what-email_stats.php:48:// @TODO Unused at the moment -./inc/modules/admin/what-extensions.php:357: // @TODO Rewrite this to a filter -./inc/modules/admin/what-guest_add.php:137: // @TODO This can be somehow rewritten to a function +./inc/modules/admin/what-extensions.php:364: // @TODO Rewrite this to a filter +./inc/modules/admin/what-guest_add.php:131: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-guest_add.php:69: // @TODO Cant this be rewritten? -./inc/modules/admin/what-guest_add.php:85: // @TODO This can be somehow rewritten to a function +./inc/modules/admin/what-guest_add.php:82: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-holiday_list.php:48:// @TODO Unused at the moment ./inc/modules/admin/what-list_autopurge.php:49:// @TODO Rewrite those lines to filter ./inc/modules/admin/what-list_bonus.php:134: // @TODO Can't this be moved into our expression language? @@ -130,9 +130,8 @@ ./inc/modules/admin/what-list_links.php:89: // @TODO Find a way to rewrite this. See some lines above for different queries ./inc/modules/admin/what-list_links.php:98: // @TODO Rewrite this to includes/filter ./inc/modules/admin/what-list_refs.php:107: // @TODO Try to rewrite some to EL -./inc/modules/admin/what-list_unconfirmed.php:100: // @TODO Rewrite this to $content = SQL_FETCHARRAY(), look some lines above for two differrent queries -./inc/modules/admin/what-list_unconfirmed.php:77: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--LIST_UNCONFIRMED_BONUS_LINKS--}'); -./inc/modules/admin/what-list_unconfirmed.php:88: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus +./inc/modules/admin/what-list_unconfirmed.php:79: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); +./inc/modules/admin/what-list_unconfirmed.php:98: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus ./inc/modules/admin/what-list_user.php:151: // @TODO Rewrite these to filters ./inc/modules/admin/what-list_user.php:257: // @TODO Rewrite this into a filter ./inc/modules/admin/what-list_user.php:300: // @TODO Rewrite this into a filter @@ -142,31 +141,28 @@ ./inc/modules/admin/what-mem_add.php:126: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-mem_add.php:65: // @TODO Cant this be rewritten? ./inc/modules/admin/what-mem_add.php:81: // @TODO This can be somehow rewritten to a function -./inc/modules/admin/what-unlock_emails.php:89: // @TODO Rewrite these if-blocks to a filter +./inc/modules/admin/what-unlock_emails.php:86: // @TODO Rewrite these if-blocks to a filter ./inc/modules/admin/what-usage.php:88: // @TODO This code is double, see loadTemplate() and loadEmailTemplate() in functions.php ./inc/modules/admin/what-usr_online.php:51: // @TODO Add a filter for sponsor ./inc/modules/guest/what-beg.php:53:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout'))); -./inc/modules/guest/what-confirm.php:120: // @TODO Try to rewrite the following unset() +./inc/modules/guest/what-confirm.php:111: // @TODO Try to rewrite the following unset() ./inc/modules/guest/what-login.php:114: // @TODO Move this HTML code into a template ./inc/modules/guest/what-mediadata.php:183:// @TODO Rewrite all these if-blocks to filters ./inc/modules/guest/what-mediadata.php:70: // @TODO Find a better formular than this one ./inc/modules/guest/what-rallyes.php:91: // @TODO Reactivate this: $content['admin'] = '' . $login . ''; -./inc/modules/guest/what-sponsor_infos.php:70: // @TODO Rewritings: conv->conv_rate,name->conv_name in template ./inc/modules/guest/what-sponsor_reg.php:290: // @TODO Swap this HTML code to templates ./inc/modules/guest/what-stats.php:116: // @TODO This can be somehow rewritten ./inc/modules/guest/what-stats.php:76:// @TODO This can be rewritten in a dynamic include ./inc/modules/member/what-beg.php:56:// @TODO Can't this be moved into EL? ./inc/modules/member/what-beg.php:65:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout'))); ./inc/modules/member/what-bonus.php:57: // @TODO Rewrite this to a filter -./inc/modules/member/what-categories.php:129: // @TODO Rewrite this to use $OUT .= ... -./inc/modules/member/what-order.php:457: // @TODO Rewrite this to a filter -./inc/modules/member/what-order.php:65:// @TODO Rewrite this to a filter -./inc/modules/member/what-payout.php:207: // @TODO Rewrite this to a filter +./inc/modules/member/what-categories.php:132: // @TODO Rewrite this to use $OUT .= ... +./inc/modules/member/what-order.php:428: // @TODO Rewrite this to a filter +./inc/modules/member/what-payout.php:196: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter? ./inc/modules/member/what-rallyes.php:91: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; ./inc/modules/member/what-refback.php:126: // @TODO UNUSED: $refRow['status'] = translateUserStatus($refRow['status']); ./inc/modules/member/what-reflinks.php:54:// @TODO Move this into a filter -./inc/modules/member/what-themes.php:116: // @TODO Move this code into a template ./inc/modules/member/what-transfer.php:132: // @TODO Rewrite this to a filter ./inc/modules/member/what-transfer.php:222: // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries ./inc/modules/member/what-transfer.php:304: // @TODO This should be somehow rewritten to $row = SQL_FETCHARRAY(), see switch() block above for SQL queries @@ -175,40 +171,40 @@ ./inc/modules/member/what-unconfirmed.php:143: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() ./inc/modules/order.php:76: // @TODO Unused: 2,4 ./inc/monthly/monthly_bonus.php:69: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1164: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1411: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/mysql-manager.php:1509: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1888: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1932:// @TODO Fix inconsistency between last_module and getWhat() +./inc/mysql-manager.php:1171: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1418: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/mysql-manager.php:1516: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1883: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1927:// @TODO Fix inconsistency between last_module and getWhat() ./inc/mysql-manager.php:370: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:46:// @TODO Can we cache this? ./inc/reset/reset_beg.php:51:// @TODO This should be converted in a daily beg rallye ./inc/reset/reset_birthday.php:91: // @TODO 4 is hard-coded here, should we move it out in config? ./inc/revision-functions.php:153:// @TODO Please describe this function -./inc/template-functions.php:1153: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1186: // @TODO Add a little more infos here -./inc/template-functions.php:1474:// @TODO Lame description for this function -./inc/template-functions.php:1493: // @TODO Move this in a filter -./inc/template-functions.php:280: // @TODO Remove this sanity-check if all is fine -./inc/template-functions.php:593:// @TODO $simple/$constants are deprecated -./inc/template-functions.php:620: // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates +./inc/template-functions.php:1132: // @TODO This can be easily moved out after the merge from EL branch to this is complete +./inc/template-functions.php:1165: // @TODO Add a little more infos here +./inc/template-functions.php:1453:// @TODO Lame description for this function +./inc/template-functions.php:1472: // @TODO Move this in a filter +./inc/template-functions.php:261: // @TODO Remove this sanity-check if all is fine +./inc/template-functions.php:572:// @TODO $simple/$constants are deprecated +./inc/template-functions.php:599: // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates ./inc/wrapper-functions.php:127:// @TODO Implement $compress ./inc/wrapper-functions.php:134:// @TODO Implement $decompress ./inc/wrapper-functions.php:455:// @TODO Do some more sanity check here -./mailid.php:138: // @TODO Rewrite this to a filter -./mailid.php:95: // @TODO Rewrite this to a filter -./mailid_top.php:132: // @TODO Rewrite this to a filter -./mailid_top.php:179: // @TODO Rewrite this to a filter -./mailid_top.php:186: // @TODO Rewrite this to a filter -./mailid_top.php:221: // @TODO Rewrite these blocks to filter +./mailid.php:140: // @TODO Rewrite this to a filter +./mailid.php:97: // @TODO Rewrite this to a filter +./mailid_top.php:101: // @TODO Rewrite this to a filter +./mailid_top.php:134: // @TODO Rewrite this to a filter +./mailid_top.php:181: // @TODO Rewrite this to a filter +./mailid_top.php:188: // @TODO Rewrite this to a filter +./mailid_top.php:223: // @TODO Rewrite these blocks to filter ./mailid_top.php:256: // @TODO Try to rewrite the following unset() -./mailid_top.php:99: // @TODO Rewrite this to a filter ./show_bonus.php:107: // @TODO No more needed? $content['points'] = translateComma($content['points']); ./view.php:70: // @TODO No banner found, output some default banner ./templates/de/html/admin/admin_add_country.tpl:23: ./templates/de/html/admin/admin_admins_contct_form.tpl:4: -./templates/de/html/admin/admin_amenu_edit.tpl:4: ./templates/de/html/admin/admin_config_other.tpl:67: +./templates/de/html/admin/admin_edit_admin_menu.tpl:4: ./templates/de/html/admin/admin_list_autopurge.tpl:2: ./templates/de/html/admin/admin_list_beg.tpl:3: ./templates/de/html/admin/admin_list_bonus.tpl:3: @@ -229,6 +225,35 @@ ./templates/de/html/surfbar/surfbar_frame_textlinks.tpl:5: ### ### DEPRECATION FOLLOWS: ### ### ./inc/modules/admin/admin-inc.php:439:// @DEPRECATED +./templates/de/html/admin/admin_add_banner.tpl:1: +./templates/de/html/admin/admin_admin_add.tpl:1: +./templates/de/html/admin/admin_admins_add_acl.tpl:1: +./templates/de/html/admin/admin_admins_add.tpl:1: +./templates/de/html/admin/admin_amenu_delete_row.tpl:1: +./templates/de/html/admin/admin_amenu_delete.tpl:1: +./templates/de/html/admin/admin_amenu_edit_form.tpl:1: +./templates/de/html/admin/admin_amenu_edit_row.tpl:1: +./templates/de/html/admin/admin_amenu_edit.tpl:1: +./templates/de/html/admin/admin_gmenu_delete_row.tpl:1: +./templates/de/html/admin/admin_gmenu_delete.tpl:1: +./templates/de/html/admin/admin_gmenu_edit_form.tpl:1: +./templates/de/html/admin/admin_gmenu_edit_row.tpl:1: +./templates/de/html/admin/admin_gmenu_edit.tpl:1: +./templates/de/html/admin/admin_guest_add.tpl:1: +./templates/de/html/admin/admin_list_task_ext2_rows.tpl:1: +./templates/de/html/admin/admin_member_add.tpl:1: +./templates/de/html/admin/admin_mmenu_delete_row.tpl:1: +./templates/de/html/admin/admin_mmenu_delete.tpl:1: +./templates/de/html/admin/admin_mmenu_edit_row.tpl:1: +./templates/de/html/admin/admin_mmenu_edit.tpl:1: +./templates/de/html/admin/admin_points_del_row.tpl:1: +./templates/de/html/admin/admin_points_del.tpl:1: +./templates/de/html/admin/admin_points_edit_row.tpl:1: +./templates/de/html/admin/admin_points_edit.tpl:1: +./templates/de/html/admin/admin_refbanner_edit_row.tpl:1: +./templates/de/html/admin/admin_refbanner_edit.tpl:1: +./templates/de/html/admin/admin_refbanner_row.tpl:1: +./templates/de/html/admin/admin_refbanner.tpl:1: ### ### template-warnings.log follows: ### ### Warning: Not parsing JavaScript templates/de/html/js/js_order_send.tpl. Warning: Not parsing JavaScript templates/de/html/js/js_cookies_disabled.tpl.