X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=1ff32ba7889b7d4eb9677c55051f79e7e6c401d5;hp=738b121c417cf9c1f2c28dae0df9d7e62bc14399;hb=ee3a0b42f93de7676fca549c866c1c2e6f3f0576;hpb=7c6a5b9e1e07dd360286130fe7e39000bfc68d4a diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 738b121c41..1ff32ba788 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -4,10 +4,10 @@ ./beg.php:175: // @TODO Opps, what is missing here??? ./inc/cache/config-local.php:124:// @TODO Rewrite the following three constants, somehow... ./inc/classes/cachesystem.class.php:510: // @TODO Add support for more types which break in last else-block -./inc/config-functions.php:136: // @TODO Make this all better... :-/ +./inc/config-functions.php:138: // @TODO Make this all better... :-/ ./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye ./inc/daily/daily_birthday.php:96: // @TODO 4 is hard-coded here, should we move it out in config? -./inc/expression-functions.php:164:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again +./inc/expression-functions.php:166:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again ./inc/expression-functions.php:46: // @TODO is escapeQuotes() enougth for strings with single/double quotes? ./inc/extensions/ext-html_mail.php:136: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu @@ -32,39 +32,38 @@ ./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Surfbar click not correct * ./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Textlink not not correct * ./inc/extensions/ext-network.php:38: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * -./inc/extensions/ext-network.php:93: // @TODO network_type_handle is an internal name and needs documentation +./inc/extensions/ext-network.php:94: // @TODO network_type_handle is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-order.php:358: // @TODO This should be moved out to inc/daily/ ./inc/extensions/ext-rallye.php:341: // @TODO Move this code into a hook ./inc/extensions/ext-rallye.php:94: // @TODO Fix config_rallye_prices to list_rallye_prices ./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y'); -./inc/extensions-functions.php:155: // @TODO Do we still need this? setExtensionUpdateNotes(''); -./inc/extensions-functions.php:1943:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' -./inc/extensions-functions.php:425:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) -./inc/extensions-functions.php:562: // @TODO Extension is loaded, what next? +./inc/extensions-functions.php:1944:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' +./inc/extensions-functions.php:423:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) +./inc/extensions-functions.php:560: // @TODO Extension is loaded, what next? ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/filter/cache_filter.php:92: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. ./inc/filter/forced_filter.php:73: // @TODO This part is unfinished -./inc/functions.php:1222: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1310: // @TODO Are these convertions still required? -./inc/functions.php:1330:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1185: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? +./inc/functions.php:1273: // @TODO Are these convertions still required? +./inc/functions.php:1293:// @TODO Rewrite this function to use readFromFile() and writeToFile() ./inc/functions.php:156:// @TODO Rewrite this to an extension 'smtp' -./inc/functions.php:1940: // @TODO Find a way to cache this -./inc/functions.php:2041: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2236: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:1903: // @TODO Find a way to cache this +./inc/functions.php:2004: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2199: // @TODO Rename column data_type to e.g. mail_status ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter ./inc/install-functions.php:57: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1071: // @TODO Rewrite these two constants -./inc/language/de.php:1087: // @TODO Rewrite these three constants -./inc/language/de.php:757:// @TODO Are these constants longer used? +./inc/language/de.php:1074: // @TODO Rewrite these two constants +./inc/language/de.php:1090: // @TODO Rewrite these three constants +./inc/language/de.php:758:// @TODO Are these constants longer used? ./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * -./inc/language/refback_de.php:53: // @TODO Rewrite these constants to one +./inc/language/refback_de.php:51: // @TODO Rewrite these constants to one ./inc/language/sponsor_de.php:117:// @TODO Rewrite these four constants to one and use sprintf() -./inc/libs/admins_functions.php:505: // @TODO This can be, somehow, rewritten +./inc/libs/admins_functions.php:495: // @TODO This can be, somehow, rewritten ./inc/libs/bonus_functions.php:194: // @TODO Move this HTML to a template ./inc/libs/doubler_functions.php:44:// @TODO Lame description ./inc/libs/doubler_functions.php:93: // @TODO Can't this be moved into EL? @@ -75,27 +74,25 @@ ./inc/libs/rallye_functions.php:912: // Load count @TODO Can't we rewrite this to our API? ./inc/libs/register_functions.php:286: // @TODO Rewrite these all to a single filter ./inc/libs/sponsor_functions.php:159: // @TODO Rewrite this to API function -./inc/libs/sponsor_functions.php:430: // @TODO Rewrite this to API function -./inc/libs/surfbar_functions.php:1624: // @TODO This can be somehow rewritten -./inc/libs/surfbar_functions.php:731:// @TODO Can't we use our new expression language instead of this ugly code? +./inc/libs/sponsor_functions.php:432: // @TODO Rewrite this to API function +./inc/libs/surfbar_functions.php:1639: // @TODO This can be somehow rewritten +./inc/libs/surfbar_functions.php:746:// @TODO Can't we use our new expression language instead of this ugly code? ./inc/libs/task_functions.php:247: // @TODO These can be rewritten to filter ./inc/libs/task_functions.php:51:// @TODO Move all extension-dependent queries into filters ./inc/libs/theme_functions.php:93: // @TODO Can't this be rewritten to an API function? ./inc/libs/user_functions.php:227:// @TODO Double-check configuration entry here ./inc/libs/user_functions.php:318: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); ./inc/libs/user_functions.php:347: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); -./inc/libs/yoomedia_functions.php:114: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script +./inc/libs/yoomedia_functions.php:108: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script ./inc/load_config.php:75: // @TODO Rewrite them to avoid this else block ./inc/loader/load-extension.php:13: * @TODO Rewrite this whole file * ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter? ./inc/module-functions.php:267: // @TODO Nothing helped??? ./inc/module-functions.php:308: // @TODO Rewrite this to a filter -./inc/modules/admin/admin-inc.php:1379: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided +./inc/modules/admin/admin-inc.php:1442: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided ./inc/modules/admin/admin-inc.php:171: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? ./inc/modules/admin/admin-inc.php:242: // @TODO This can be rewritten into a filter -./inc/modules/admin/admin-inc.php:274: // @TODO Rewrite this to $content = SQL_FETCHARRAY() -./inc/modules/admin/admin-inc.php:340: // @TODO Rewrite this to $content = SQL_FETCHARRAY() -./inc/modules/admin/admin-inc.php:444:// @TODO Try to rewrite this to adminAddMenuSelectionBox() +./inc/modules/admin/admin-inc.php:506:// @TODO Try to rewrite this to adminAddMenuSelectionBox() ./inc/modules/admin/overview-inc.php:162: // @TODO Rewrite this to a filter ./inc/modules/admin/overview-inc.php:275: // @TODO Rewrite this to something with include files and/or filter ./inc/modules/admin/overview-inc.php:309: // @TODO This may also be rewritten to include files @@ -111,6 +108,7 @@ ./inc/modules/admin/what-admins_mails.php:58: // @TODO Can this be rewritten to an API function? ./inc/modules/admin/what-bonus.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-config_mods.php:55: // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function +./inc/modules/admin/what-config_network_types.php:60: // @TODO Do something here ./inc/modules/admin/what-config_points.php:110: // @TODO Rewrite this to a filter ./inc/modules/admin/what-config_rallye_prices.php:195: // @TODO Rewrite these two constants ./inc/modules/admin/what-config_rallye_prices.php:227: // @TODO rename: start->start_time, end->end_time @@ -132,7 +130,7 @@ ./inc/modules/admin/what-list_links.php:55: // @TODO Try to rewrite this to a filter ./inc/modules/admin/what-list_links.php:85: // @TODO Find a way to rewrite this. See some lines above for different queries ./inc/modules/admin/what-list_links.php:93: // @TODO Rewrite this to includes/filter -./inc/modules/admin/what-list_refs.php:99: // @TODO Try to rewrite some to EL +./inc/modules/admin/what-list_refs.php:100: // @TODO Try to rewrite some to EL ./inc/modules/admin/what-list_unconfirmed.php:107: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus ./inc/modules/admin/what-list_unconfirmed.php:84: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); ./inc/modules/admin/what-list_user.php:247: // @TODO Rewrite this into a filter @@ -149,8 +147,8 @@ ./inc/modules/guest/what-login.php:125: // @TODO Move this HTML code into a template ./inc/modules/guest/what-mediadata.php:182:// @TODO Rewrite all these if-blocks to filters ./inc/modules/guest/what-mediadata.php:67: // @TODO Find a better formular than this one -./inc/modules/guest/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = '' . $login . ''; -./inc/modules/guest/what-sponsor_reg.php:289: // @TODO Maybe a default referal id? +./inc/modules/guest/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = '' . $login . ''; +./inc/modules/guest/what-sponsor_reg.php:289: // @TODO Maybe a default referral id? ./inc/modules/guest/what-stats.php:108: // @TODO This can be somehow rewritten ./inc/modules/guest/what-stats.php:82:// @TODO This can be rewritten in a dynamic include ./inc/modules/member/what-beg.php:54:// @TODO Can't this be moved into EL? @@ -161,29 +159,29 @@ ./inc/modules/member/what-order.php:82: // @TODO Rewrite this to SQL_FETCHARRAY() ./inc/modules/member/what-payout.php:194: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter? -./inc/modules/member/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; +./inc/modules/member/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; ./inc/modules/member/what-reflinks.php:52:// @TODO Move this into a filter ./inc/modules/member/what-transfer.php:128: // @TODO Rewrite this to a filter ./inc/modules/member/what-unconfirmed.php:162: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() ./inc/modules/member/what-unconfirmed.php:227: // @TODO This 'userid' cannot be saved because of encapsulated EL code ./inc/modules/order.php:78: // @TODO Unused: 2,4 -./inc/mysql-manager.php:1381: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1405: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1664: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1710:// @TODO Fix inconsistency between last_module and getWhat() +./inc/mysql-manager.php:1410: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1434: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1693: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1739:// @TODO Fix inconsistency between last_module and getWhat() ./inc/mysql-manager.php:387: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? ./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter ./inc/revision-functions.php:169:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1068: // @TODO Deprecate this thing ./inc/template-functions.php:1079: // @TODO Deprecate this thing -./inc/template-functions.php:1169: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1202: // @TODO Add a little more infos here -./inc/template-functions.php:1531:// @TODO Lame description for this function -./inc/template-functions.php:1553: // @TODO Move this in a filter -./inc/template-functions.php:184: * @TODO On some pages this is buggy -./inc/template-functions.php:273: // @TODO Remove this sanity-check if all is fine -./inc/template-functions.php:596:// @TODO $simple/$constants are deprecated +./inc/template-functions.php:1090: // @TODO Deprecate this thing +./inc/template-functions.php:1180: // @TODO This can be easily moved out after the merge from EL branch to this is complete +./inc/template-functions.php:1213: // @TODO Add a little more infos here +./inc/template-functions.php:1542:// @TODO Lame description for this function +./inc/template-functions.php:1564: // @TODO Move this in a filter +./inc/template-functions.php:193: * @TODO On some pages this is buggy +./inc/template-functions.php:282: // @TODO Remove this sanity-check if all is fine +./inc/template-functions.php:607:// @TODO $simple/$constants are deprecated ./inc/wrapper-functions.php:512:// @TODO Do some more sanity check here ./inc/xml-functions.php:189: // @TODO Handle characters ./mailid.php:139: // @TODO Rewrite this to a filter @@ -194,14 +192,13 @@ ./mailid_top.php:18: * @TODO Merge this script with mailid.php * ./mailid_top.php:196: // @TODO Rewrite this to a filter ./mailid_top.php:231: // @TODO Rewrite these blocks to filter -./network-check.php:54:// @TODO Add processing of request here -./view.php:68: // @TODO No banner found, output some default banner +./network-vcheck.php:57:// @TODO Add processing of request here +./view.php:71: // @TODO No banner found, output some default banner ./templates/de/html/admin/admin_add_country.tpl:23: -./templates/de/html/admin/admin_admins_contct_form.tpl:4: ./templates/de/html/admin/admin_config_other.tpl:79: ./templates/de/html/admin/admin_config_rewrite.tpl:4: ./templates/de/html/admin/admin_edit_admin_menu.tpl:4: -./templates/de/html/admin/admin_list_refs_level.tpl:21: +./templates/de/html/admin/admin_list_refs_level.tpl:20: ./templates/de/html/admin/admin_list_unconfirmed_list.tpl:3: ./templates/de/html/admin/admin_login_form.tpl:34: @TODO Doesn't work with sessions ./templates/de/html/admin/admin_login_form.tpl:37: @TODO Try to move the select box to our generic functions @@ -219,7 +216,9 @@ ./inc/autopurge/purge-tsks.php:2:// @DEPRECATED ./inc/autopurge/purge-unconfirmed.php:2:// @DEPRECATED ./inc/daily/daily_engine.php:2:// @DEPRECATED +./inc/extensions/ext-iso3166.php:2:// @DEPRECATED ./inc/gen_refback.php:2:// @DEPRECATED +./inc/js/js-jquery.php:2:// @DEPRECATED ./inc/loader/load_cache-admin.php:2:// @DEPRECATED ./inc/loader/load_cache-config.php:2:// @DEPRECATED ./inc/loader/load_cache-extension.php:2:// @DEPRECATED @@ -231,14 +230,16 @@ ./inc/loader/load_cache-revision.php:2:// @DEPRECATED ./inc/loader/load_cache-them.php:2:// @DEPRECATED ./inc/loader/load-extensions.php:2:// @DEPRECATED -./inc/modules/admin/admin-inc.php:445:// @DEPRECATED +./inc/modules/admin/admin-inc.php:507:// @DEPRECATED ./inc/modules/admin/what-chk_regs.php:2:// @DEPRECATED ./inc/modules/admin/what-config_admins.php:2:// @DEPRECATED ./inc/modules/admin/what-config_email.php:2:// @DEPRECATED +./inc/modules/admin/what-config_networks.php:2:// @DEPRECATED ./inc/modules/member/what-earnings.php:2:// @DEPRECATED ./inc/modules/member/what-surfbar_book.php:2:// @DEPRECATED ./inc/modules/member/what-surfbar_start.php:2:// @DEPRECATED ./inc/modules/member/what-surfbar_stats.php:2:// @DEPRECATED +./inc/referal-functions.php:2:// @DEPRECATED ./inc/reset/reset_100_bonus.php:2:// @DEPRECATED ./inc/reset/reset_autopurge.php:2:// @DEPRECATED ./inc/reset/reset_beg.php:2:// @DEPRECATED @@ -251,6 +252,7 @@ ./inc/reset/reset_profile.php:2:// @DEPRECATED ./inc/reset/reset_surfbar.php:2:// @DEPRECATED ./inc/reset/reset_yoomedia.php:2:// @DEPRECATED +./network-check.php:2:// @DEPRECATED ./templates/de/emails/add-points.tpl:1:@DEPRECATED ./templates/de/emails/admin/admin_coupon.tpl:1:@DEPRECATED ./templates/de/emails/admin/admin_del_surfbar_urls.tpl:1:@DEPRECATED @@ -264,6 +266,7 @@ ./templates/de/emails/del-user.tpl:1:@DEPRECATED ./templates/de/emails/done-admin.tpl:1:@DEPRECATED ./templates/de/emails/done-member.tpl:1:@DEPRECATED +./templates/de/emails/guest/guest_user_confirmed_referal.tpl:1:@DEPRECATED ./templates/de/emails/lock-user.tpl:1:@DEPRECATED ./templates/de/emails/member/member_coupon.tpl:1:@DEPRECATED ./templates/de/emails/member/member_del_surfbar_urls.tpl:1:@DEPRECATED @@ -296,6 +299,7 @@ ./templates/de/html/admin/admin_config_email.tpl:1: ./templates/de/html/admin/admin_config_home_row.tpl:1: ./templates/de/html/admin/admin_config_home_settings.tpl:1: +./templates/de/html/admin/admin_config_network.tpl:1: ./templates/de/html/admin/admin_config_order_form.tpl:1: ./templates/de/html/admin/admin_config_payouts_del_row.tpl:1: ./templates/de/html/admin/admin_config_payouts_del.tpl:1: @@ -308,20 +312,30 @@ ./templates/de/html/admin/admin_list_chk_reg.tpl:1: ./templates/de/html/admin/admin_list_country_del_row.tpl:1: ./templates/de/html/admin/admin_list_country_edit_row.tpl:1: +./templates/de/html/admin/admin_list_network_config_row.tpl:1: +./templates/de/html/admin/admin_list_network_config.tpl:1: +./templates/de/html/admin/admin_list_refs2.tpl:1: ./templates/de/html/admin/admin_list_user_sort_form.tpl:1: +./templates/de/html/admin/admin_main_header.tpl:1: ./templates/de/html/admin/admin_mods_stats2_row.tpl:1: ./templates/de/html/admin/admin_mods_stats2.tpl:1: ./templates/de/html/admin/admin_mods_stats_row.tpl:1: ./templates/de/html/admin/admin_mods_stats.tpl:1: +./templates/de/html/admin/admin_payout_add_new.tpl:1: ./templates/de/html/admin/admin_reset_pass_done.tpl:1: ./templates/de/html/admin/admin_send_reset_link.tpl:1: ./templates/de/html/beg/beg_banner.tpl:1: +./templates/de/html/ext/ext_iso3166.tpl:1: ./templates/de/html/guest/guest_active_row.tpl:1: ./templates/de/html/guest/guest_active_table.tpl:1: ./templates/de/html/guest/guest_no_rallyes.tpl:1: ./templates/de/html/guest/guest_rallye_row.tpl:1: ./templates/de/html/guest/guest_rallye_show.tpl:1: ./templates/de/html/guest/guest_rallye.tpl:1: +./templates/de/html/js/js_jquery.tpl:1: +./templates/de/html/member/member_list_referal_level.tpl:1: +./templates/de/html/member/member_list_referal_row.tpl:1: +./templates/de/html/member/member_list_referal.tpl:1: ./templates/de/html/member/member_refback_edit.tpl:1: ./templates/de/html/member/member_refback_list_level.tpl:1: ./templates/de/html/member/member_refback_list_row_deleted.tpl:1: @@ -339,6 +353,7 @@ ./templates/de/html/member/member_surfbar_list.tpl:1: ./templates/de/html/member/member_surfbar_start_dynamic.tpl:1: ./templates/de/html/member/member_surfbar_start_static.tpl:1: +./templates/de/html/menu/menu_seperator.tpl:1: ./templates/xml/admin/admin_del_do_surfbar_urls.xml:1: ./templates/xml/admin/admin_del_show_surfbar_urls.xml:1: ### ### template-warnings.log follows: ### ###