X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=a93a44a6a74991f22d7baf2f140b98a321193f86;hp=1fae91354a58c670d5262c80e13cc15fd98f8d68;hb=6560179e7c8dc565485503f374d4e31f333ffd0e;hpb=4fef71140a7d5faeaff256ab7c5bf4616c671f63

diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt
index 1fae91354a..a93a44a6a7 100644
--- a/DOCS/TODOs.txt
+++ b/DOCS/TODOs.txt
@@ -9,6 +9,7 @@
 ./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye
 ./inc/daily/daily_birthday.php:99:			// @TODO 4 is hard-coded here, should we move it out in config?
 ./inc/email-functions.php:109: * @TODO Rewrite this to an extension 'smtp'
+./inc/email-functions.php:227:// @TODO $rawUserId is currently unused
 ./inc/expression-functions.php:170:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again
 ./inc/expression-functions.php:46:	// @TODO is escapeQuotes() enougth for strings with single/double quotes?
 ./inc/extensions/ext-html_mail.php:136:		// @TODO Move these arrays into config
@@ -43,24 +44,24 @@
 ./inc/extensions/ext-rallye.php:94:		// @TODO Fix config_rallye_prices to list_rallye_prices
 ./inc/extensions/ext-yoomedia.php:121:		// @TODO Can this be moved into a database table?
 ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y');
-./inc/extensions-functions.php:2040:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable'
+./inc/extensions-functions.php:2096:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable'
 ./inc/extensions-functions.php:424:	// @TODO This redirect is still needed to register sql_patches! Please try to avoid it
 ./inc/extensions-functions.php:440:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
 ./inc/extensions-functions.php:580:		// @TODO Extension is loaded, what next?
 ./inc/filter/bonus_filter.php:56:		// @TODO This query isn't right, it will only update if the user was for a longer time away!
 ./inc/filter/cache_filter.php:94:		// @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal.
 ./inc/filter/forced_filter.php:73:		// @TODO This part is unfinished
-./inc/functions.php:1082:			// @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
-./inc/functions.php:1168:			// @TODO Are these convertions still required?
-./inc/functions.php:1189:// @TODO Rewrite this function to use readFromFile() and writeToFile()
-./inc/functions.php:1712:	// @TODO Find a way to cache this
-./inc/functions.php:1817:	// @TODO This is still very static, rewrite it somehow
-./inc/functions.php:2021:	// @TODO Rename column data_type to e.g. mail_status
+./inc/functions.php:1090:			// @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ?
+./inc/functions.php:1176:			// @TODO Are these convertions still required?
+./inc/functions.php:1197:// @TODO Rewrite this function to use readFromFile() and writeToFile()
+./inc/functions.php:1732:	// @TODO Find a way to cache this
+./inc/functions.php:1837:	// @TODO This is still very static, rewrite it somehow
+./inc/functions.php:2041:	// @TODO Rename column data_type to e.g. mail_status
 ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter
 ./inc/header.php:66:// @TODO Find a way to not use direct module comparison
 ./inc/install-functions.php:91:	// @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0);
-./inc/language/de.php:1103:	// @TODO Rewrite these two constants
-./inc/language/de.php:1119:	// @TODO Rewrite these three constants
+./inc/language/de.php:1120:	// @TODO Rewrite these two constants
+./inc/language/de.php:1136:	// @TODO Rewrite these three constants
 ./inc/language/de.php:749:// @TODO Are these constants longer used?
 ./inc/language-functions.php:255:	// @TODO These are all valid languages, again hard-coded
 ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function.
@@ -69,7 +70,7 @@
 ./inc/language/order_de.php:70:	// @TODO Find better text
 ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings             *
 ./inc/language/refback_de.php:51:	// @TODO Rewrite these constants to one
-./inc/libs/admins_functions.php:521:		// @TODO This can be, somehow, rewritten
+./inc/libs/admins_functions.php:525:		// @TODO This can be, somehow, rewritten
 ./inc/libs/bonus_functions.php:194:		// @TODO Move this HTML to a template
 ./inc/libs/doubler_functions.php:44:// @TODO Lame description
 ./inc/libs/doubler_functions.php:93:			// @TODO Can't this be moved into EL?
@@ -96,7 +97,6 @@
 ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter?
 ./inc/module-functions.php:273:			// @TODO Nothing helped???
 ./inc/module-functions.php:314:			// @TODO Rewrite this to a filter
-./inc/modules/admin/admin-inc.php:1521:				// @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
 ./inc/modules/admin/admin-inc.php:160:		// @TODO This and the next getCurrentAdminId() call might be moved into the templates?
 ./inc/modules/admin/admin-inc.php:233:		// @TODO This can be rewritten into a filter
 ./inc/modules/admin/admin-inc.php:509:// @TODO Try to rewrite this to adminAddMenuSelectionBox()
@@ -114,8 +114,7 @@
 ./inc/modules/admin/what-admins_mails.php:58:				// @TODO Can this be rewritten to an API function?
 ./inc/modules/admin/what-bonus.php:46:// @TODO Unused at the moment
 ./inc/modules/admin/what-config_mods.php:55:			// @TODO This can be moved into mysql-function.php, see checkModulePermissions() function
-./inc/modules/admin/what-config_points.php:110:			// @TODO Rewrite this to a filter
-./inc/modules/admin/what-config_points.php:133:				// @TODO Rewrite these two lines for new user_points columns (e.g. locked_order_points) with a filter
+./inc/modules/admin/what-config_points.php:130:				// @TODO Rewrite these two lines for new user_points columns (e.g. locked_order_points) with a filter
 ./inc/modules/admin/what-config_rallye_prices.php:222:			// @TODO Rewrite these two constants
 ./inc/modules/admin/what-config_register.php:75:	// @TODO Move this HTML code into a template
 ./inc/modules/admin/what-del_email.php:61:		// @TODO Unused: cat_id, payment_id
@@ -126,8 +125,7 @@
 ./inc/modules/admin/what-guest_add.php:67:		// @TODO Cant this be rewritten?
 ./inc/modules/admin/what-guest_add.php:80:		// @TODO This can be somehow rewritten to a function
 ./inc/modules/admin/what-holiday_list.php:46:// @TODO Unused at the moment
-./inc/modules/admin/what-list_admins_acls.php:101:	// @TODO Rewrite this to a filter
-./inc/modules/admin/what-list_admins_acls.php:129:	// @TODO Rewrite this to filter 'run_sqls'
+./inc/modules/admin/what-list_admins_acls.php:126:	// @TODO Rewrite this to filter 'run_sqls'
 ./inc/modules/admin/what-list_autopurge.php:47:// @TODO Rewrite those lines to filter
 ./inc/modules/admin/what-list_bonus.php:137:		// @TODO Can't this be moved into our expression language?
 ./inc/modules/admin/what-list_cats.php:54:		// @TODO No longer needed? define('__CATEGORIES_BASE'   , '<a href="{%url=modules.php?module=admin&amp;userid=');
@@ -136,8 +134,8 @@
 ./inc/modules/admin/what-list_refs.php:101:							// @TODO Try to rewrite some to EL
 ./inc/modules/admin/what-list_unconfirmed.php:107:	// @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
 ./inc/modules/admin/what-list_unconfirmed.php:84:	// @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
-./inc/modules/admin/what-list_user.php:290:		// @TODO Rewrite this into a filter
-./inc/modules/admin/what-list_user.php:355:			// @TODO Rewrite this into a filter
+./inc/modules/admin/what-list_user.php:289:		// @TODO Rewrite this into a filter
+./inc/modules/admin/what-list_user.php:354:			// @TODO Rewrite this into a filter
 ./inc/modules/admin/what-logs.php:64:			// @TODO Fix content-type here
 ./inc/modules/admin/what-logs.php:70:			// @TODO Fix content-type here
 ./inc/modules/admin/what-mem_add.php:124:				// @TODO This can be somehow rewritten to a function
@@ -158,7 +156,8 @@
 ./inc/modules/member/what-beg.php:54:// @TODO Can't this be moved into EL?
 ./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout()));
 ./inc/modules/member/what-logout.php:17: * @TODO Rewrite the code to a filter                                   *
-./inc/modules/member/what-order.php:482:			// @TODO Rewrite this to a filter
+./inc/modules/member/what-logout.php:52:	// @TODO Move this in a filter, e.g. member_logout
+./inc/modules/member/what-order.php:459:			// @TODO Rewrite this to a filter
 ./inc/modules/member/what-order.php:84:		// @TODO Rewrite this to SQL_FETCHARRAY()
 ./inc/modules/member/what-payout.php:194:					// @TODO Rewrite this to a filter
 ./inc/modules/member/what-points.php:61:// @TODO Should we rewrite this to a filter?
@@ -168,26 +167,29 @@
 ./inc/modules/member/what-unconfirmed.php:169:	// @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
 ./inc/modules/member/what-unconfirmed.php:234:				// @TODO This 'userid' cannot be saved because of encapsulated EL code
 ./inc/modules/order.php:78:		// @TODO Unused: 2,4
-./inc/mysql-manager.php:1442:		// @TODO Rewrite these lines to a filter
-./inc/mysql-manager.php:1466:	// @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1722:			// @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1437:		// @TODO Rewrite these lines to a filter
+./inc/mysql-manager.php:1461:	// @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1717:			// @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1916:				// @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided
+./inc/mysql-manager.php:2029:			// @TODO Used generic 'userid' here
 ./inc/mysql-manager.php:398:	// @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:44:// @TODO Can we cache this?
 ./inc/purge/purge-inact.php:55:	// @TODO Rewrite these if() blocks to a filter
 ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array'
-./inc/template-functions.php:1108:			// @TODO Deprecate this thing
-./inc/template-functions.php:1119:			// @TODO Deprecate this thing
-./inc/template-functions.php:1226:	// @TODO This can be easily moved out after the merge from EL branch to this is complete
-./inc/template-functions.php:1275:		// @TODO Add a little more infos here
-./inc/template-functions.php:1643:// @TODO Lame description for this function
-./inc/template-functions.php:1665:			// @TODO Move this in a filter
+./inc/template-functions.php:1126:			// @TODO Deprecate this thing
+./inc/template-functions.php:1137:			// @TODO Deprecate this thing
+./inc/template-functions.php:1244:	// @TODO This can be easily moved out after the merge from EL branch to this is complete
+./inc/template-functions.php:1293:		// @TODO Add a little more infos here
+./inc/template-functions.php:1667:// @TODO Lame description for this function
+./inc/template-functions.php:1689:			// @TODO Move this in a filter
 ./inc/template-functions.php:197:	 * @TODO On some pages this is buggy
+./inc/template-functions.php:2292:	// @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent);
 ./inc/template-functions.php:285:	// @TODO Remove these sanity checks if all is fine
-./inc/template-functions.php:599:// @TODO $simple/$constants are deprecated
-./inc/template-functions.php:697:			// @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates
-./inc/wrapper-functions.php:2980:	// @TODO Find a way to not use direct module comparison
+./inc/template-functions.php:617:// @TODO $simple/$constants are deprecated
+./inc/template-functions.php:715:			// @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates
+./inc/wrapper-functions.php:3010:	// @TODO Find a way to not use direct module comparison
 ./inc/wrapper-functions.php:494:// @TODO Do some more sanity check here
-./inc/xml-functions.php:208:	// @TODO Handle characters
+./inc/xml-functions.php:221:	// @TODO Handle characters
 ./mailid.php:102:		// @TODO Rewrite this to a filter
 ./mailid.php:145:					// @TODO Rewrite this to a filter
 ./mailid_top.php:112:		// @TODO Rewrite this to a filter/function
@@ -511,6 +513,7 @@
 ./templates/de/html/why_reg.tpl:1:<!-- @DEPRECATED //-->
 ./templates/xml/admin/admin_del_do_surfbar_urls.xml:1:<!-- @DEPRECATED //-->
 ./templates/xml/admin/admin_del_show_surfbar_urls.xml:1:<!-- @DEPRECATED //-->
+./templates/xml/member/member_add_do_subid.xml:1:<!-- @DEPRECATED //-->
 ### ### template-warnings.log follows: ### ###
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/menu/menu_what_end.tpl, line: 1 in 
 PHP Warning:  DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/menu/menu_what_end.tpl, line: 2 in