X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=d4095179a31197d53dff40335cd479c62cf4fefa;hp=f2be12a9972cc4938dfa68f2603f727e38489c5b;hb=2df9f7a53f8b1dd5164f87824a324ccb3b6634cb;hpb=da50e51b98ba0901d6251b7f36e138ac6f63518d diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index f2be12a997..d4095179a3 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -14,6 +14,7 @@ ./inc/expression-functions.php:46: // @TODO is escapeQuotes() enougth for strings with single/double quotes? ./inc/extensions/ext-html_mail.php:136: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu +./inc/extensions/ext-network.php:101: // @TODO network_type_handler is an internal name and needs documentation ./inc/extensions/ext-network.php:18: * @TODO Ad-Magnet: Layer(klick?). Layerviews.Skybannerklick/-view, * ./inc/extensions/ext-network.php:19: * @TODO Ad-Magnet: Banner-View, Textlink-Klick/-View. Page-Peel * ./inc/extensions/ext-network.php:20: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * @@ -31,15 +32,16 @@ ./inc/extensions/ext-network.php:32: * @TODO GeldSponsor.de Requires ID card copy/business reg. * ./inc/extensions/ext-network.php:33: * @TODO GolloX: Which charset? * ./inc/extensions/ext-network.php:34: * @TODO paid4ad: Which URLs for click and banner? * -./inc/extensions/ext-network.php:35: * @TODO VIPads: HTML text is send encoded with BASE64 * -./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * -./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Forced textlink not correct * -./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Layer not correct * -./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * -./inc/extensions/ext-network.php:40: * @TODO Der Werbepartner.cc: Surfbar click not correct * -./inc/extensions/ext-network.php:41: * @TODO Der Werbepartner.cc: Textlink not not correct * -./inc/extensions/ext-network.php:42: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * -./inc/extensions/ext-network.php:99: // @TODO network_type_handler is an internal name and needs documentation +./inc/extensions/ext-network.php:35: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * +./inc/extensions/ext-network.php:36: * @TODO SuperPromo24: Textlink view is a JavaScript * +./inc/extensions/ext-network.php:37: * @TODO VIPads: HTML text is send encoded with BASE64 * +./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * +./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Forced textlink not correct * +./inc/extensions/ext-network.php:40: * @TODO Der Werbepartner.cc: Layer not correct * +./inc/extensions/ext-network.php:41: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * +./inc/extensions/ext-network.php:42: * @TODO Der Werbepartner.cc: Surfbar click not correct * +./inc/extensions/ext-network.php:43: * @TODO Der Werbepartner.cc: Textlink not not correct * +./inc/extensions/ext-network.php:44: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-rallye.php:94: // @TODO Fix config_rallye_prices to list_rallye_prices ./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? @@ -60,9 +62,10 @@ ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter ./inc/header.php:66:// @TODO Find a way to not use direct module comparison ./inc/install-functions.php:91: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1112: // @TODO Rewrite these two constants -./inc/language/de.php:1128: // @TODO Rewrite these three constants -./inc/language/de.php:749:// @TODO Are these constants longer used? +./inc/language/de.php:1122: // @TODO Rewrite these two constants +./inc/language/de.php:1138: // @TODO Rewrite these three constants +./inc/language/de.php:46: // @TODO Please sort these language elements +./inc/language/de.php:751:// @TODO Are these constants longer used? ./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. ./inc/language/install_de.php:137: // @TODO Move this to e.g. ext-smtp @@ -71,24 +74,24 @@ ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:51: // @TODO Rewrite these constants to one ./inc/libs/admins_functions.php:525: // @TODO This can be, somehow, rewritten -./inc/libs/bonus_functions.php:194: // @TODO Move this HTML to a template +./inc/libs/bonus_functions.php:195: // @TODO Move this HTML to a template ./inc/libs/doubler_functions.php:44:// @TODO Lame description -./inc/libs/doubler_functions.php:93: // @TODO Can't this be moved into EL? +./inc/libs/doubler_functions.php:96: // @TODO Can't this be moved into EL? ./inc/libs/forced_functions.php:457:// @TODO Can't we use our new expression language instead of this ugly code? ./inc/libs/mailid_functions.php:47: // @TODO Rewrite this to a dynamic include or so -./inc/libs/network_functions.php:978: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/network_functions.php:1017: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine ./inc/libs/order_functions.php:46: // @TODO Move this array into a filter -./inc/libs/rallye_functions.php:769:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() -./inc/libs/rallye_functions.php:836: $EXPIRE = 3; // @TODO The hard-coded value... -./inc/libs/rallye_functions.php:925:// @TODO Please document this function -./inc/libs/rallye_functions.php:981: // Load count @TODO Can't we rewrite this to our API? +./inc/libs/rallye_functions.php:771:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() +./inc/libs/rallye_functions.php:838: $EXPIRE = 3; // @TODO The hard-coded value... +./inc/libs/rallye_functions.php:927:// @TODO Please document this function +./inc/libs/rallye_functions.php:983: // Load count @TODO Can't we rewrite this to our API? ./inc/libs/sponsor_functions.php:163: // @TODO Rewrite this to API function ./inc/libs/sponsor_functions.php:436: // @TODO Rewrite this to API function ./inc/libs/surfbar_functions.php:1672: // @TODO This can be somehow rewritten ./inc/libs/surfbar_functions.php:776:// @TODO Can't we use our new expression language instead of this ugly code? ./inc/libs/task_functions.php:253: // @TODO These can be rewritten to filter ./inc/libs/task_functions.php:51:// @TODO Move all extension-dependent queries into filters -./inc/libs/theme_functions.php:93: // @TODO Can't this be rewritten to an API function? +./inc/libs/theme_functions.php:94: // @TODO Can't this be rewritten to an API function? ./inc/libs/user_functions.php:325: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); ./inc/libs/user_functions.php:354: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); ./inc/libs/yoomedia_functions.php:108: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script @@ -100,12 +103,12 @@ ./inc/modules/admin/admin-inc.php:160: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? ./inc/modules/admin/admin-inc.php:233: // @TODO This can be rewritten into a filter ./inc/modules/admin/admin-inc.php:509:// @TODO Try to rewrite this to adminAddMenuSelectionBox() -./inc/modules/admin/overview-inc.php:169: // @TODO Rewrite this to a filter -./inc/modules/admin/overview-inc.php:282: // @TODO Rewrite this to something with include files and/or filter -./inc/modules/admin/overview-inc.php:316: // @TODO This may also be rewritten to include files -./inc/modules/admin/overview-inc.php:318: default: // @TODO Unknown support mode -./inc/modules/admin/overview-inc.php:433: // @TODO Try to move this in includes +./inc/modules/admin/overview-inc.php:176: // @TODO Rewrite this to a filter +./inc/modules/admin/overview-inc.php:289: // @TODO Rewrite this to something with include files and/or filter +./inc/modules/admin/overview-inc.php:323: // @TODO This may also be rewritten to include files +./inc/modules/admin/overview-inc.php:325: default: // @TODO Unknown support mode ./inc/modules/admin/overview-inc.php:43:// @TODO This function does also check for uncompleted tasks +./inc/modules/admin/overview-inc.php:440: // @TODO Try to move this in includes ./inc/modules/admin/what-add_guestnl_cat.php:47: // @TODO Check if category does already exist ./inc/modules/admin/what-admin_add.php:120: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-admin_add.php:61: // @TODO Cant this be rewritten? @@ -132,16 +135,17 @@ ./inc/modules/admin/what-list_cats.php:68: // @TODO Rewrite this to countSum.....() function ./inc/modules/admin/what-list_links.php:96: // @TODO Rewrite this to includes/filter ./inc/modules/admin/what-list_refs.php:101: // @TODO Try to rewrite some to EL -./inc/modules/admin/what-list_unconfirmed.php:107: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus +./inc/modules/admin/what-list_unconfirmed.php:114: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus ./inc/modules/admin/what-list_unconfirmed.php:84: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); -./inc/modules/admin/what-list_user.php:290: // @TODO Rewrite this into a filter -./inc/modules/admin/what-list_user.php:355: // @TODO Rewrite this into a filter +./inc/modules/admin/what-list_unconfirmed.php:87: // @TODO `id` has been used two times??? +./inc/modules/admin/what-list_user.php:289: // @TODO Rewrite this into a filter +./inc/modules/admin/what-list_user.php:354: // @TODO Rewrite this into a filter ./inc/modules/admin/what-logs.php:64: // @TODO Fix content-type here ./inc/modules/admin/what-logs.php:70: // @TODO Fix content-type here ./inc/modules/admin/what-mem_add.php:124: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-mem_add.php:63: // @TODO Cant this be rewritten? ./inc/modules/admin/what-mem_add.php:79: // @TODO This can be somehow rewritten to a function -./inc/modules/admin/what-unlock_emails.php:84: // @TODO Rewrite these if-blocks to a filter +./inc/modules/admin/what-unlock_emails.php:95: // @TODO Rewrite these if-blocks to a filter ./inc/modules/admin/what-usage.php:89: // @TODO This code is double, see loadTemplate() and loadEmailTemplate() in functions.php ./inc/modules/admin/what-usr_online.php:49: // @TODO Add a filter for sponsor ./inc/modules/frametester.php:95: // @TODO Rewrite this somehow @@ -150,45 +154,46 @@ ./inc/modules/guest/what-mediadata.php:186:// @TODO Rewrite all these if-blocks to filters ./inc/modules/guest/what-mediadata.php:67: // @TODO Find a better formular than this one ./inc/modules/guest/what-rallyes.php:99: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; -./inc/modules/guest/what-sponsor_reg.php:289: // @TODO Maybe a default referral id? +./inc/modules/guest/what-sponsor_reg.php:293: // @TODO Maybe a default referral id? ./inc/modules/guest/what-stats.php:110: // @TODO This can be somehow rewritten ./inc/modules/guest/what-stats.php:82:// @TODO This can be rewritten in a dynamic include ./inc/modules/member/what-beg.php:54:// @TODO Can't this be moved into EL? ./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout())); ./inc/modules/member/what-logout.php:17: * @TODO Rewrite the code to a filter * ./inc/modules/member/what-logout.php:52: // @TODO Move this in a filter, e.g. member_logout -./inc/modules/member/what-order.php:471: // @TODO Rewrite this to a filter +./inc/modules/member/what-order.php:459: // @TODO Rewrite this to a filter ./inc/modules/member/what-order.php:84: // @TODO Rewrite this to SQL_FETCHARRAY() -./inc/modules/member/what-payout.php:194: // @TODO Rewrite this to a filter +./inc/modules/member/what-payout.php:208: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:61:// @TODO Should we rewrite this to a filter? ./inc/modules/member/what-rallyes.php:99: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; ./inc/modules/member/what-reflinks.php:52:// @TODO Move this into a filter ./inc/modules/member/what-transfer.php:128: // @TODO Rewrite this to a filter -./inc/modules/member/what-unconfirmed.php:169: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/modules/member/what-unconfirmed.php:234: // @TODO This 'userid' cannot be saved because of encapsulated EL code +./inc/modules/member/what-unconfirmed.php:178: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/modules/member/what-unconfirmed.php:247: // @TODO This 'userid' cannot be saved because of encapsulated EL code ./inc/modules/order.php:78: // @TODO Unused: 2,4 ./inc/mysql-manager.php:1437: // @TODO Rewrite these lines to a filter ./inc/mysql-manager.php:1461: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1717: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1916: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided -./inc/mysql-manager.php:2029: // @TODO Used generic 'userid' here +./inc/mysql-manager.php:1767: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1966: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided +./inc/mysql-manager.php:2079: // @TODO Used generic 'userid' here ./inc/mysql-manager.php:398: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? ./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1108: // @TODO Deprecate this thing -./inc/template-functions.php:1119: // @TODO Deprecate this thing -./inc/template-functions.php:1226: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1275: // @TODO Add a little more infos here -./inc/template-functions.php:1643:// @TODO Lame description for this function -./inc/template-functions.php:1665: // @TODO Move this in a filter +./inc/template-functions.php:1126: // @TODO Deprecate this thing +./inc/template-functions.php:1137: // @TODO Deprecate this thing +./inc/template-functions.php:1244: // @TODO This can be easily moved out after the merge from EL branch to this is complete +./inc/template-functions.php:1293: // @TODO Add a little more infos here +./inc/template-functions.php:1667:// @TODO Lame description for this function +./inc/template-functions.php:1689: // @TODO Move this in a filter ./inc/template-functions.php:197: * @TODO On some pages this is buggy +./inc/template-functions.php:2292: // @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent); ./inc/template-functions.php:285: // @TODO Remove these sanity checks if all is fine -./inc/template-functions.php:599:// @TODO $simple/$constants are deprecated -./inc/template-functions.php:697: // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates +./inc/template-functions.php:617:// @TODO $simple/$constants are deprecated +./inc/template-functions.php:715: // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates ./inc/wrapper-functions.php:3010: // @TODO Find a way to not use direct module comparison ./inc/wrapper-functions.php:494:// @TODO Do some more sanity check here -./inc/xml-functions.php:209: // @TODO Handle characters +./inc/xml-functions.php:221: // @TODO Handle characters ./mailid.php:102: // @TODO Rewrite this to a filter ./mailid.php:145: // @TODO Rewrite this to a filter ./mailid_top.php:112: // @TODO Rewrite this to a filter/function @@ -258,6 +263,7 @@ ./inc/modules/admin/what-config_primera.php:2:// @DEPRECATED ./inc/modules/admin/what-list_network_api_translation.php:2:// @DEPRECATED ./inc/modules/admin/what-list_network_params.php:2:// @DEPRECATED +./inc/modules/admin/what-list_networks.php:2:// @DEPRECATED ./inc/modules/admin/what-list_primera.php:2:// @DEPRECATED ./inc/modules/admin/what-overview.php:2:// @DEPRECATED ./inc/modules/guest/action-actions.php:2:// @DEPRECATED @@ -396,6 +402,13 @@ ./templates/de/html/admin/admin_del_surfbar_urls.tpl:1: ./templates/de/html/admin/admin_edit_network_params_row.tpl:1: ./templates/de/html/admin/admin_edit_network_params.tpl:1: +./templates/de/html/admin/admin_extensions_delete_row_404.tpl:1: +./templates/de/html/admin/admin_extensions_delete_row.tpl:1: +./templates/de/html/admin/admin_extensions_delete.tpl:1: +./templates/de/html/admin/admin_extensions_edit_row.tpl:1: +./templates/de/html/admin/admin_extensions_edit.tpl:1: +./templates/de/html/admin/admin_extensions_row.tpl:1: +./templates/de/html/admin/admin_extensions.tpl:1: ./templates/de/html/admin/admin_list_cats_404.tpl:1: ./templates/de/html/admin/admin_list_chk_reg_row.tpl:1: ./templates/de/html/admin/admin_list_chk_reg.tpl:1: @@ -407,6 +420,8 @@ ./templates/de/html/admin/admin_list_network_config.tpl:1: ./templates/de/html/admin/admin_list_network_params_row.tpl:1: ./templates/de/html/admin/admin_list_network_params.tpl:1: +./templates/de/html/admin/admin_list_networks_row.tpl:1: +./templates/de/html/admin/admin_list_networks.tpl:1: ./templates/de/html/admin/admin_list_primera_main.tpl:1: ./templates/de/html/admin/admin_list_primera_row.tpl:1: ./templates/de/html/admin/admin_list_refs2.tpl:1: