X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=e261a7a3bfc41252293e2a0799a608052e4e0261;hp=cc3ed379189eec49c88abb06d52f13a389f02073;hb=87342ad9d6400e1a819d6179696da412acb7c6e7;hpb=b4784eb7267921f162d2fa90d21fa20fad700962 diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index cc3ed37918..e261a7a3bf 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -1,87 +1,136 @@ ### WARNING: THIS FILE IS AUTO-GENERATED BY ../../contrib/todo-builder.sh (uid=/user=quix0r) ### ### DO NOT EDIT THIS FILE. ### -./autoreg.php:58:// @TODO Add processing of request here -./beg.php:175: // @TODO Opps, what is missing here??? +./api.php:68:// @TODO Do stuff here +./autoreg.php:62:// @TODO Add processing of request here +./beg.php:173: // @TODO Opps, what is missing here??? +./cron.php:62:// @TODO Do stuff here ./inc/classes/cachesystem.class.php:516: // @TODO Add support for more types which break in last else-block -./inc/config-functions.php:149: // @TODO Make this all better... :-/ -./inc/config-functions.php:325: // @TODO Call setConfigEntry() somehow -./inc/config-functions.php:353: // @TODO Call setConfigEntry() somehow +./inc/config-functions.php:151: // @TODO Make this all better... :-/ +./inc/config-functions.php:329: // @TODO Call setConfigEntry() somehow +./inc/config-functions.php:359: // @TODO Call setConfigEntry() somehow ./inc/daily/daily_beg.php:52:// @TODO This should be converted in a daily beg rallye -./inc/daily/daily_birthday.php:99: // @TODO 4 is hard-coded here, should we move it out in config? +./inc/daily/daily_birthday.php:63:// @TODO Move this out to an extension ./inc/email-functions.php:113: * @TODO Rewrite this to an extension 'smtp' ./inc/email-functions.php:209:// @TODO $rawUserId is currently unused ./inc/expression-functions.php:173:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again ./inc/expression-functions.php:46: // @TODO is escapeQuotes() enough for strings with single/double quotes? -./inc/extensions/ext-html_mail.php:136: // @TODO Move these arrays into config +./inc/extensions/admins/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/autopurge/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/beg/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/bonus/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/doubler/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/doubler/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/ext-html_mail.php:91: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu -./inc/extensions/ext-network.php:100: // @TODO network_type_handler is an internal name and needs documentation -./inc/extensions/ext-network.php:18: * @TODO Ad-Magnet: Layer(klick?). Layerviews.Skybannerklick/-view, * -./inc/extensions/ext-network.php:19: * @TODO Ad-Magnet: Banner-View, Textlink-Klick/-View. Page-Peel * -./inc/extensions/ext-network.php:20: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * -./inc/extensions/ext-network.php:21: * @TODO ADCocktail: Zero array element is return code! * -./inc/extensions/ext-network.php:22: * @TODO adgain.de: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:23: * @TODO ADkracher: Textlink-View is a JavaScript URL * -./inc/extensions/ext-network.php:24: * @TODO Admono.de: highforcedbanner, traffic from abroad * -./inc/extensions/ext-network.php:25: * @TODO Affiliblatt: Layer requires script in head * -./inc/extensions/ext-network.php:26: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * -./inc/extensions/ext-network.php:27: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * -./inc/extensions/ext-network.php:28: * @TODO eu-ADS/WeltPromotion: Text for banner/buttons? * -./inc/extensions/ext-network.php:29: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * -./inc/extensions/ext-network.php:30: * @TODO Fusion-Ads: Has click/banner URL in API response * -./inc/extensions/ext-network.php:31: * @TODO GeldSponsor.de Requires ID card copy/business reg. * -./inc/extensions/ext-network.php:32: * @TODO GolloX: Which charset? * -./inc/extensions/ext-network.php:33: * @TODO paid4ad: Which URLs for click and banner? * -./inc/extensions/ext-network.php:34: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * -./inc/extensions/ext-network.php:35: * @TODO SuperPromo24: Textlink view is a JavaScript * -./inc/extensions/ext-network.php:36: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * -./inc/extensions/ext-network.php:37: * @TODO Der Werbepartner.cc: Forced textlink not correct * -./inc/extensions/ext-network.php:38: * @TODO Der Werbepartner.cc: Layer not correct * -./inc/extensions/ext-network.php:39: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * -./inc/extensions/ext-network.php:40: * @TODO Der Werbepartner.cc: Surfbar click not correct * -./inc/extensions/ext-network.php:41: * @TODO Der Werbepartner.cc: Textlink not not correct * -./inc/extensions/ext-network.php:42: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * -./inc/extensions/ext-network.php:43: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-nickname.php:52: // @TODO NOT NULL DEFAULT '' is bad practice, use NULL -./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? -./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y'); -./inc/extensions-functions.php:2201:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' -./inc/extensions-functions.php:436: // @TODO This redirect is still needed to register sql_patches! Please try to avoid it -./inc/extensions-functions.php:452:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) -./inc/extensions-functions.php:592: // @TODO Extension is loaded, what next? +./inc/extensions/ext-ranking.php:18: * @TODO Replaces ext-top10 * +./inc/extensions/ext-rewrite.php:50:// @TODO Only when 'seo' is ready: setExtensionDeprecated('Y'); +./inc/extensions/ext-top10.php:50:// @TODO Only deprecated when 'ext-ranking' is ready: setExtensionDeprecated('Y'); +./inc/extensions/ext-yoomedia.php:120: // @TODO Can this be moved into a database table? +./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready: setExtensionDeprecated('Y'); +./inc/extensions/forced/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions-functions.php:2239: // @TODO Is this really neccessary? +./inc/extensions-functions.php:2296:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' +./inc/extensions-functions.php:439: // @TODO This redirect is still needed to register sql_patches! Please try to avoid it +./inc/extensions-functions.php:455:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) +./inc/extensions-functions.php:595: // @TODO Extension is loaded, what next? +./inc/extensions/grade/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/html_mail/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/network/mode-setup.php:18: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * +./inc/extensions/network/mode-setup.php:19: * @TODO ADCocktail: Zero array element is return code! * +./inc/extensions/network/mode-setup.php:20: * @TODO adgain.de: Textlink-View is a JavaScript URL * +./inc/extensions/network/mode-setup.php:21: * @TODO ADkracher: Textlink-View is a JavaScript URL * +./inc/extensions/network/mode-setup.php:22: * @TODO Admono.de: highforcedbanner, traffic from abroad * +./inc/extensions/network/mode-setup.php:23: * @TODO Ads-AbisZ: HighForced banner, mini layer * +./inc/extensions/network/mode-setup.php:24: * @TODO Ads-Im-Netz: All APIs provide URLs/JavaScripts * +./inc/extensions/network/mode-setup.php:25: * @TODO Ads4Clicks: Some has JavaScript as output code, high forced * +./inc/extensions/network/mode-setup.php:26: * @TODO Affiliblatt: Layer requires script in head * +./inc/extensions/network/mode-setup.php:27: * @TODO Affiliblatt: Textlinks, popup, popunder, HTML mail, lead * +./inc/extensions/network/mode-setup.php:28: * @TODO AllAds4You: Traffic from abroad, High-Forced banner * +./inc/extensions/network/mode-setup.php:29: * @TODO Earn4Webbis: HighForced banner, page peel, mini layer * +./inc/extensions/network/mode-setup.php:30: * @TODO FuCoExSponsor: Textlink-View is JavaScript! * +./inc/extensions/network/mode-setup.php:31: * @TODO Fusion-Ads: Has click/banner URL in API response * +./inc/extensions/network/mode-setup.php:32: * @TODO GeldSponsor.de Requires ID card copy/business reg. * +./inc/extensions/network/mode-setup.php:33: * @TODO GolloX: Please add full support * +./inc/extensions/network/mode-setup.php:34: * @TODO LoseAds: HighForced banner, mini layer, all premium * +./inc/extensions/network/mode-setup.php:35: * @TODO Paid4Ad: HighForced banner, mini layer * +./inc/extensions/network/mode-setup.php:36: * @TODO Sponsor-Box: HighForced banner, leader board, mini layer * +./inc/extensions/network/mode-setup.php:37: * @TODO Paid-4-Webmaster: leader board, mini layer * +./inc/extensions/network/mode-setup.php:38: * @TODO Vario-Ads: HighForced banner, mini layer * +./inc/extensions/network/mode-setup.php:39: * @TODO SuperPromo24: HighForced banner, leader board, mini/page layer * +./inc/extensions/network/mode-setup.php:40: * @TODO SuperPromo24: Textlink view is a JavaScript * +./inc/extensions/network/mode-setup.php:41: * @TODO Der Werbepartner.cc: Banner click/view is JavaScript! * +./inc/extensions/network/mode-setup.php:42: * @TODO Der Werbepartner.cc: Forced textlink not correct * +./inc/extensions/network/mode-setup.php:43: * @TODO Der Werbepartner.cc: Layer not correct * +./inc/extensions/network/mode-setup.php:44: * @TODO Der Werbepartner.cc: Sky banner is JavaScript! * +./inc/extensions/network/mode-setup.php:45: * @TODO Der Werbepartner.cc: Surfbar click not correct * +./inc/extensions/network/mode-setup.php:46: * @TODO Der Werbepartner.cc: Textlink not correct * +./inc/extensions/network/mode-setup.php:47: * @TODO Xijide: Lead/Sale (together) unsupported (no target URL) * +./inc/extensions/network/mode-setup.php:48: * @TODO Yoo!Media: What is LayerAd compared to Layer click? * +./inc/extensions/network/mode-setup.php:94:// @TODO network_type_handler is an internal name and needs documentation +./inc/extensions/order/mode-update.php:43:// @TODO Remove double-tab from all lines +./inc/extensions/other/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/payout/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/rallye/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/register/mode-update.php:367: // @TODO Make configurable through web interface +./inc/extensions/register/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/sponsor/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/sql_patches/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/surfbar/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/task/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/transfer/mode-setup.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/transfer/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/user/mode-update.php:43:// @TODO Remove double tabs from all lines +./inc/extensions/user/mode-update.php:559: // @TODO Make configurable through web interface +./inc/filter/blacklist_filter.php:105: // @TODO Insert log entry +./inc/filter/blacklist_filter.php:116: // @TODO Insert log entry +./inc/filter/blacklist_filter.php:127: // @TODO Insert log entry ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! -./inc/filter/cache_filter.php:94: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. -./inc/filter/forced_filter.php:73: // @TODO This part is unfinished -./inc/filters.php:1317: // @TODO No banner found, output some default banner -./inc/functions.php:1104: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1190: // @TODO Are these convertions still required? -./inc/functions.php:1211:// @TODO Rewrite this function to use readFromFile() and writeToFile() -./inc/functions.php:1820: // @TODO Find a way to cache this -./inc/functions.php:1924: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2128: // @TODO Rename column data_type to e.g. mail_status -./inc/functions.php:2478:// @TODO cacheFiles is not yet supported -./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter +./inc/filter/forced_filter.php:75: // @TODO This part is unfinished +./inc/filter-functions.php:120: // @TODO Remove this forced removal after a year or so +./inc/filter/order_filter.php:132: // @TODO 200 is hard-coded here, swap it out to config + admin_config_order.tpl +./inc/filters.php:1394: // @TODO No banner found, output some default banner +./inc/filter/user_filter.php:279:// @TODO 0% done +./inc/filter/user_filter.php:289:// @TODO 0% done +./inc/filter/wernis_filter.php:113:// @TODO 0% done +./inc/filter/wernis_filter.php:123:// @TODO 0% done +./inc/filter/wernis_filter.php:59:// @TODO 10% done +./inc/filter/wernis_filter.php:74:// @TODO 10% done +./inc/filter/wernis_filter.php:89:// @TODO 10% done +./inc/functions.php:1216: // @TODO Are these convertions still required? +./inc/functions.php:1237:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1541: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. +./inc/functions.php:1917: // @TODO Find a way to cache this +./inc/functions.php:2021: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2225: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:2575:// @TODO cacheFiles is not yet supported +./inc/gen_sql_patches.php:97:// @TODO Rewrite this to a filter ./inc/header.php:66:// @TODO Find a way to not use direct module comparison -./inc/install-functions.php:402: // @TODO Comparing with DEFAULT_MAIN_TITLE doesn't work -./inc/install-functions.php:97: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1147: // @TODO Rewrite these two constants -./inc/language/de.php:1163: // @TODO Rewrite these three constants +./inc/install-functions.php:107: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); +./inc/install-functions.php:456: // @TODO Comparing with DEFAULT_MAIN_TITLE doesn't work +./inc/language/de.php:1150: // @TODO Rewrite these two constants +./inc/language/de.php:1166: // @TODO Rewrite these three constants ./inc/language/de.php:46: // @TODO Please sort these language elements -./inc/language/de.php:741:// @TODO Are these constants longer used? -./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded -./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. -./inc/language/install_de.php:140: // @TODO Move this to e.g. ext-smtp +./inc/language-functions.php:254: // @TODO These are all valid languages, again hard-coded +./inc/language/install_de.php:153: // @TODO Move this to e.g. ext-smtp ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * -./inc/language/order_de.php:70: // @TODO Find better text +./inc/language/order_de.php:71: // @TODO Find better text ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:51: // @TODO Rewrite these constants to one -./inc/libs/admins_functions.php:528: // @TODO This can be, somehow, rewritten -./inc/libs/bonus_functions.php:195: // @TODO Move this HTML to a template +./inc/libs/admins_functions.php:537: // @TODO This can be, somehow, rewritten +./inc/libs/bonus_functions.php:115: // @TODO Rewrite this to a filter +./inc/libs/bonus_functions.php:201: // @TODO Move this HTML to a template +./inc/libs/doubler_functions.php:130:// @TODO This could be rewritten to a filter ./inc/libs/doubler_functions.php:44:// @TODO Lame description ./inc/libs/doubler_functions.php:96: // @TODO Can't this be moved into EL? -./inc/libs/forced_functions.php:457:// @TODO Can't we use our new expression language instead of this ugly code? +./inc/libs/forced_functions.php:459:// @TODO Can't we use our new expression language instead of this ugly code? +./inc/libs/mailid_functions.php:123: // @TODO Rewrite these blocks to filter ./inc/libs/mailid_functions.php:47: // @TODO Rewrite this to a dynamic include or so -./inc/libs/network_functions.php:1124: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/mailid_functions.php:93: // @TODO Rewrite this to a filter +./inc/libs/network_functions.php:1111: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/network_functions.php:1117: // @TODO Implement this function, don't forget to set HTTP status back to '200 OK' if everything went fine +./inc/libs/network_functions.php:680: // @TODO Unfinished: } elseif ((!empty($addSql)) && ( ./inc/libs/order_functions.php:46: // @TODO Move this array into a filter ./inc/libs/rallye_functions.php:771:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() ./inc/libs/rallye_functions.php:838: $EXPIRE = 3; // @TODO The hard-coded value... @@ -89,12 +138,11 @@ ./inc/libs/rallye_functions.php:983: // Load count @TODO Can't we rewrite this to our API? ./inc/libs/sponsor_functions.php:163: // @TODO Rewrite this to API function ./inc/libs/sponsor_functions.php:436: // @TODO Rewrite this to API function -./inc/libs/surfbar_functions.php:1696: // @TODO This can be somehow rewritten +./inc/libs/surfbar_functions.php:1695: // @TODO This can be somehow rewritten ./inc/libs/surfbar_functions.php:479: // @TODO if (($urlData['url_views_allowed'] != $urlData['edit']['limit']) || ($url1 != $url2)) { ./inc/libs/surfbar_functions.php:790:// @TODO Can't we use our new expression language instead of this ugly code? -./inc/libs/task_functions.php:256: // @TODO These can be rewritten to filter ./inc/libs/task_functions.php:51:// @TODO Move all extension-dependent queries into filters -./inc/libs/theme_functions.php:96: // @TODO Can't this be rewritten to an API function? +./inc/libs/theme_functions.php:93: // @TODO Can't this be rewritten to an API function? ./inc/libs/user_functions.php:325: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); ./inc/libs/user_functions.php:354: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); ./inc/libs/yoomedia_functions.php:108: $response = YOOMEDIA_QUERY_API('out_textmail.php', TRUE); // @TODO Ask Yoo!Media for test script @@ -103,18 +151,18 @@ ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter? ./inc/module-functions.php:273: // @TODO Nothing helped??? ./inc/module-functions.php:314: // @TODO Rewrite this to a filter -./inc/modules/admin/admin-inc.php:1043:// @TODO rawUserId/content is not yet supported -./inc/modules/admin/admin-inc.php:1068:// @TODO rawUserId/cacheFiles/content is not yet supported -./inc/modules/admin/admin-inc.php:163: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? -./inc/modules/admin/admin-inc.php:236: // @TODO This can be rewritten into a filter -./inc/modules/admin/admin-inc.php:521:// @TODO Try to rewrite this to adminAddMenuSelectionBox() -./inc/modules/admin/admin-inc.php:868:// @TODO cacheFiles is not yet supported +./inc/modules/admin/admin-inc.php:1058:// @TODO rawUserId/content is not yet supported +./inc/modules/admin/admin-inc.php:1083:// @TODO rawUserId/cacheFiles/content is not yet supported +./inc/modules/admin/admin-inc.php:178: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? +./inc/modules/admin/admin-inc.php:251: // @TODO This can be rewritten into a filter +./inc/modules/admin/admin-inc.php:536:// @TODO Try to rewrite this to adminAddMenuSelectionBox() +./inc/modules/admin/admin-inc.php:883:// @TODO cacheFiles is not yet supported ./inc/modules/admin/overview-inc.php:176: // @TODO Rewrite this to a filter -./inc/modules/admin/overview-inc.php:289: // @TODO Rewrite this to something with include files and/or filter -./inc/modules/admin/overview-inc.php:323: // @TODO This may also be rewritten to include files -./inc/modules/admin/overview-inc.php:325: default: // @TODO Unknown support mode +./inc/modules/admin/overview-inc.php:285: // @TODO Rewrite this to something with include files and/or filter +./inc/modules/admin/overview-inc.php:319: // @TODO This may also be rewritten to include files +./inc/modules/admin/overview-inc.php:321: default: // @TODO Unknown support mode +./inc/modules/admin/overview-inc.php:436: // @TODO Try to move this in includes ./inc/modules/admin/overview-inc.php:43:// @TODO This function does also check for uncompleted tasks -./inc/modules/admin/overview-inc.php:440: // @TODO Try to move this in includes ./inc/modules/admin/what-add_guestnl_cat.php:47: // @TODO Check if category does already exist ./inc/modules/admin/what-admin_add.php:120: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-admin_add.php:61: // @TODO Cant this be rewritten? @@ -124,7 +172,7 @@ ./inc/modules/admin/what-bonus.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-config_points.php:90: // @TODO Rewrite these two lines for new user_points columns (e.g. locked_order_points) with a filter ./inc/modules/admin/what-config_register.php:79: // @TODO Move this HTML code into a template -./inc/modules/admin/what-del_email.php:61: // @TODO Unused: cat_id, payment_id +./inc/modules/admin/what-del_email.php:51: // @TODO Unused: cat_id ./inc/modules/admin/what-edit_user.php:18: * @TODO Add support for ext-country * ./inc/modules/admin/what-email_stats.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-extensions.php:366: // @TODO Rewrite this to a filter @@ -133,85 +181,81 @@ ./inc/modules/admin/what-guest_add.php:80: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-holiday_list.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-list_admins_acls.php:126: // @TODO Rewrite this to filter 'run_sqls' -./inc/modules/admin/what-list_autopurge.php:47:// @TODO Rewrite those lines to filter ./inc/modules/admin/what-list_bonus.php:136: // @TODO Can't this be moved into our expression language? ./inc/modules/admin/what-list_links.php:96: // @TODO Rewrite this to includes/filter ./inc/modules/admin/what-list_mods.php:55: // @TODO This can be moved into mysql-function.php, see checkModulePermissions() function ./inc/modules/admin/what-list_rallye_prices.php:222: // @TODO Rewrite these two constants ./inc/modules/admin/what-list_refs.php:101: // @TODO Try to rewrite some to EL -./inc/modules/admin/what-list_unconfirmed.php:114: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus -./inc/modules/admin/what-list_unconfirmed.php:84: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); -./inc/modules/admin/what-list_unconfirmed.php:87: // @TODO `id` has been used two times??? +./inc/modules/admin/what-list_unconfirmed.php:115: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus ./inc/modules/admin/what-list_user_cats.php:54: // @TODO No longer needed? define('__CATEGORIES_BASE' , '' . $content['login'] . ''; ./inc/modules/guest/what-sponsor_reg.php:293: // @TODO Maybe a default referral id? ./inc/modules/guest/what-stats.php:111: // @TODO This can be somehow rewritten -./inc/modules/guest/what-stats.php:120: // @TODO This does not exclude testers +./inc/modules/guest/what-stats.php:120: // @TODO This doesn't exclude tester accounts ./inc/modules/guest/what-stats.php:83:// @TODO This can be rewritten in a dynamic include ./inc/modules/member/what-beg.php:54:// @TODO Can't this be moved into EL? ./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_USERID_TIMEOUT', createFancyTime(getBegUseridTimeout())); ./inc/modules/member/what-logout.php:17: * @TODO Rewrite the code to a filter * ./inc/modules/member/what-logout.php:52: // @TODO Move this in a filter, e.g. member_logout -./inc/modules/member/what-order.php:459: // @TODO Rewrite this to a filter -./inc/modules/member/what-order.php:84: // @TODO Rewrite this to SQL_FETCHARRAY() -./inc/modules/member/what-payout.php:208: // @TODO Rewrite this to a filter +./inc/modules/member/what-mydata.php:82: // @TODO Move this to a function (for better EL code) +./inc/modules/member/what-order.php:300: // @TODO Rewrite this to a filter +./inc/modules/member/what-order.php:72: // @TODO Try to move out url_tlock to a filter for extra SQL statements +./inc/modules/member/what-payout.php:223: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:61:// @TODO Should we rewrite this to a filter? ./inc/modules/member/what-rallyes.php:99: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; ./inc/modules/member/what-reflinks.php:52:// @TODO Move this into a filter +./inc/modules/member/what-transaction_fees.php:197:// @TODO Make this working ./inc/modules/member/what-transfer.php:128: // @TODO Rewrite this to a filter -./inc/modules/member/what-unconfirmed.php:178: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/modules/member/what-unconfirmed.php:247: // @TODO This 'userid' cannot be saved because of encapsulated EL code -./inc/modules/order.php:78: // @TODO Unused: 2,4 -./inc/mysql-manager.php:1450: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1474: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1780: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1977: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided -./inc/mysql-manager.php:2100: // @TODO Used generic 'userid' here -./inc/mysql-manager.php:2321:// @TODO cacheFiles is not yet supported +./inc/modules/member/what-unconfirmed.php:124: // @TODO This call cannot be saved as EL code cannot be "framed" in other EL code +./inc/modules/member/what-unconfirmed.php:168: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/modules/member/what-unconfirmed.php:235: // @TODO cat_id is unused +./inc/modules/member/what-unconfirmed.php:238: // @TODO This 'userid' cannot be saved because of encapsulated EL code +./inc/modules/order.php:71: // @TODO Unused: timestamp +./inc/monthly/monthly_beg.php:58: // @TODO Rewrite these if() blocks to a filter +./inc/monthly/monthly_bonus.php:57: // @TODO Rewrite these if() blocks to a filter +./inc/mysql-manager.php:1518: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1542: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1858: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:2026: // @TODO If the EL sub-system can support more than one parameter, this call_user_func_array() can be avoided +./inc/mysql-manager.php:2158: // @TODO Used generic 'userid' here +./inc/mysql-manager.php:2376:// @TODO cacheFiles is not yet supported ./inc/mysql-manager.php:408: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? -./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter +./inc/pool-functions.php:44:// @TODO "Hook" ext-html_mail into this to allow column `html_msg` ./inc/revision-functions.php:168:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1134: // @TODO Deprecate this thing -./inc/template-functions.php:1145: // @TODO Deprecate this thing -./inc/template-functions.php:1252: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1301: // @TODO Add a little more infos here -./inc/template-functions.php:1667:// @TODO Lame description for this function -./inc/template-functions.php:1689: // @TODO Move this in a filter -./inc/template-functions.php:200: * @TODO On some pages this is buggy -./inc/template-functions.php:2323: // @TODO Is this needed for e.g. $GLOBALS['template_content'] ? $this->setRawTemplateData($compactedContent); -./inc/template-functions.php:288: // @TODO Remove these sanity checks if all is fine -./inc/template-functions.php:625:// @TODO $simple/$constants are deprecated -./inc/template-functions.php:723: // @TODO $userid is deprecated and should be removed from loadEmailTemplate() and replaced with $content[userid] in all templates -./inc/wrapper-functions.php:3176: // @TODO Find a way to not use direct module comparison -./inc/wrapper-functions.php:512:// @TODO Do some more sanity check here +./inc/template-functions.php:1052: // @TODO