X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=e477d96ca62dac61a3017c64d0c1ebbb98614a7d;hp=102b463296c2e31f41f8cfa6f0ff279a739208e4;hb=bc2da429e6d78668152427b7b5310268453553d8;hpb=c819b98b236c15ad0b46fc296d9a0e2c1617fee9 diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 102b463296..e477d96ca6 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -6,37 +6,39 @@ ./inc/classes/cachesystem.class.php:464: // @TODO Add support for more types which break in last else-block ./inc/config-functions.php:143: // @TODO Make this all better... :-/ ./inc/extensions/ext-html_mail.php:137: // @TODO Move these arrays into config -./inc/extensions/ext-network.php:71: // @TODO network_type_name is an internal name and needs documentation +./inc/extensions/ext-network.php:71: // @TODO network_type_handle is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:215: // @TODO Move these into configuration ./inc/extensions/ext-rallye.php:330: // @TODO Move this code into rallye_functions.php ./inc/extensions/ext-rallye.php:93: // @TODO Fix config_rallye_prices to list_rallye_prices -./inc/extensions/ext-sql_patches.php:737: // @TODO Rewrite this to a filter +./inc/extensions/ext-sql_patches.php:762: // @TODO Rewrite this to a filter ./inc/extensions/ext-sql_patches.php:94: /* @TODO SQL_ALTER_TABLE() should work now properly ./inc/extensions/ext-yoomedia.php:122: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:55:// @TODO Only deprecated when 'network' is ready! setExtensionDeprecated('Y'); ./inc/extensions-functions.php:376:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) ./inc/extensions-functions.php:489: // @TODO Extension is loaded, what next? -./inc/functions.php:1016:// @TODO $simple is deprecated -./inc/functions.php:1051: // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates -./inc/functions.php:2351:// @TODO Try to move this to inc/libs/theme_functions.php -./inc/functions.php:241: // @TODO Remove this sanity-check if all is fine -./inc/functions.php:244: // @TODO Try to rewrite all $DATA to $content -./inc/functions.php:2522:// @TODO Please describe this function -./inc/functions.php:2540: searchDirsRecursive($next_dir, $last_changed); // @TODO small change to API to $last_changed = searchDirsRecursive($next_dir, $time); -./inc/functions.php:2636: // @TODO Add a little more infos here -./inc/functions.php:2647: // @TODO This cannot be rewritten to app_die(), try to find a solution for this. -./inc/functions.php:2728: // @TODO Rewrite this old lost code to a template -./inc/functions.php:2817: // @TODO Are these convertions still required? -./inc/functions.php:2835:// @TODO Rewrite this function to use readFromFile() and writeToFile() -./inc/functions.php:3709:// @TODO Lame description for this function -./inc/functions.php:3731: // @TODO Move this in a filter -./inc/functions.php:467: // @TODO Do only use $contentn, not $DATA or raw variables -./inc/functions.php:537: // @TODO Extension 'msg' does not exist -./inc/functions.php:606:// @TODO Rewrite this to an extension 'smtp' +./inc/filters.php:473: // @TODO This whole switch-block is very static +./inc/filters.php:538: case 'config': // @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again +./inc/functions.php:1002:// @TODO $simple is deprecated +./inc/functions.php:1037: // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates +./inc/functions.php:2435:// @TODO Please describe this function +./inc/functions.php:2453: searchDirsRecursive($next_dir, $last_changed); // @TODO small change to API to $last_changed = searchDirsRecursive($next_dir, $time); +./inc/functions.php:253: // @TODO Remove this sanity-check if all is fine +./inc/functions.php:2567: // @TODO Add a little more infos here +./inc/functions.php:256: // @TODO Try to rewrite all $DATA to $content +./inc/functions.php:2668: // @TODO Rewrite this old lost code to a template +./inc/functions.php:2757: // @TODO Are these convertions still required? +./inc/functions.php:2775:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:3653:// @TODO Lame description for this function +./inc/functions.php:3675: // @TODO Move this in a filter +./inc/functions.php:3793: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:468: // @TODO Do only use $content, not $DATA or raw variables +./inc/functions.php:538: // @TODO Extension 'msg' does not exist +./inc/functions.php:607:// @TODO Rewrite this to an extension 'smtp' ./inc/install-functions.php:62: // @TODO DEACTIVATED: changeDataInFile(getConfig('CACHE_PATH') . 'config-local.php', 'OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); -./inc/language/de.php:1145:// @TODO Rewrite these two constants -./inc/language/de.php:1161:// @TODO Rewrite these five constants +./inc/language/de.php:1150:// @TODO Rewrite these two constants +./inc/language/de.php:1166:// @TODO Rewrite these five constants ./inc/language/de.php:848:// @TODO Are these constants longer used? +./inc/language-functions.php:228: // @TODO These are all valid languages, again hard-coded ./inc/language-functions.php:45:// @TODO Rewrite all language constants to this function. ./inc/language/holiday_de.php:49:// @TODO Rewrite these two constants to one ./inc/language/rallye_de.php:113:// @TODO Rewrite following two lines to one @@ -46,18 +48,20 @@ ./inc/libs/admins_functions.php:418: // @TODO This can be, somehow, rewritten ./inc/libs/beg_functions.php:57: // @TODO Try to rewrite the following unset() ./inc/libs/bonus_functions.php:215: // @TODO Try to find a way for rewriting this constant +./inc/libs/bonus_functions.php:303: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/libs/doubler_functions.php:45:// @TODO Lame description ./inc/libs/rallye_functions.php:718: $EXPIRE = 3; // @TODO The hard-coded value... ./inc/libs/rallye_functions.php:782: // @TODO Rewrite this to our API function ./inc/libs/refback_functions.php:60: // @TODO Try to rewrite the following unset() -./inc/libs/surfbar_functions.php:1497: // @TODO This can be somehow rewritten -./inc/libs/surfbar_functions.php:950: // @TODO Invalid salt should be refused +./inc/libs/surfbar_functions.php:1491: // @TODO This can be somehow rewritten +./inc/libs/surfbar_functions.php:944: // @TODO Invalid salt should be refused ./inc/libs/task_functions.php:244: // @TODO These can be rewritten to filter ./inc/libs/task_functions.php:52:// @TODO Move all extension-dependent queries into filters ./inc/libs/user_functions.php:137: // @TODO These two constants are no longer used, maybe we reactivate this code? -./inc/libs/user_functions.php:318: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); -./inc/libs/user_functions.php:341: // @TODO Make this filter working: $URL = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); -./inc/libs/user_functions.php:417: // @TODO We should try to rewrite this to fetchUserData() somehow +./inc/libs/user_functions.php:224:// @TODO Double-check configuration entry here +./inc/libs/user_functions.php:319: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); +./inc/libs/user_functions.php:342: // @TODO Make this filter working: $URL = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); +./inc/libs/user_functions.php:415: // @TODO We should try to rewrite this to fetchUserData() somehow ./inc/libs/yoomedia_functions.php:64: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script ./inc/load_config.php:76: // @TODO Rewrite them to avoid this else block ./inc/loader/load_cache-extension.php:13: * @TODO Rewrite this whole file to load_cache-extensions.php * @@ -79,7 +83,7 @@ ./inc/modules/admin/what-admin_add.php:60: // @TODO Cant this be rewritten? ./inc/modules/admin/what-admin_add.php:76: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-adminedit.php:57: // @TODO Kill all constants in this file -./inc/modules/admin/what-admins_mails.php:59: // @TODO Can this be rewritten??? +./inc/modules/admin/what-admins_mails.php:60: // @TODO Can this be rewritten??? ./inc/modules/admin/what-bonus.php:47:// @TODO Unused at the moment ./inc/modules/admin/what-config_admins.php:145: // @TODO Rewrite this to filter 'run_sqls' ./inc/modules/admin/what-config_mods.php:135: // @TODO Rewritings: mod->module in template @@ -87,16 +91,15 @@ ./inc/modules/admin/what-config_rallye_prices.php:225: // @TODO Rewrite these two constants ./inc/modules/admin/what-config_register.php:67: // @TODO Move this HTML code into a template ./inc/modules/admin/what-edit_user.php:20: * @TODO Add support for ext-country * -./inc/modules/admin/what-email_archiv.php:91: // @TODO Rewrite to SQL_FETCHARRAY() ./inc/modules/admin/what-email_stats.php:47:// @TODO Unused at the moment -./inc/modules/admin/what-extensions.php:344: // @TODO Rewrite this to a filter +./inc/modules/admin/what-extensions.php:347: // @TODO Rewrite this to a filter ./inc/modules/admin/what-guest_add.php:136: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-guest_add.php:68: // @TODO Cant this be rewritten? ./inc/modules/admin/what-guest_add.php:84: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-holiday_list.php:47:// @TODO Unused at the moment ./inc/modules/admin/what-list_autopurge.php:54:// @TODO Rewrite those lines to filter ./inc/modules/admin/what-list_autopurge.php:84: // @TODO Rewritings: surname->surname,family->family in templates -./inc/modules/admin/what-list_cats.php:55: // @TODO No longer needed? define('__CATS_BASE' , "remote_addr, created->sponsor_created in template ./inc/modules/admin/what-usage.php:87: // @TODO This code is double, see LOAD_TEMPLATE and loadEmailTemplate in functions.php -./inc/modules/admin/what-usage.php:98: // @TODO Disabled due to too much trouble ./inc/modules/admin/what-usr_online.php:50: // @TODO Add a filter for sponsor ./inc/modules/guest/what-beg.php:59:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout'))); ./inc/modules/guest/what-confirm.php:112: // @TODO Try to rewrite the following unset() ./inc/modules/guest/what-login.php:107: // @TODO Move this HTML code into a template ./inc/modules/guest/what-mediadata.php:182:// @TODO Rewrite all these if-blocks to filters ./inc/modules/guest/what-mediadata.php:69: // @TODO Find a better formular than this one -./inc/modules/guest/what-rallyes.php:90: // @TODO Reactivate this: $content['admin'] = "".$login.""; -./inc/modules/guest/what-register.php:193: // @TODO Rewrite these all to a single filter -./inc/modules/guest/what-register.php:271: // @TODO Rewrite this to a filter -./inc/modules/guest/what-register.php:287: // @TODO Rewrite this to addPointsDirectly() +./inc/modules/guest/what-rallyes.php:90: // @TODO Reactivate this: $content['admin'] = "" . $login . ""; +./inc/modules/guest/what-register.php:192: // @TODO Rewrite these all to a single filter +./inc/modules/guest/what-register.php:270: // @TODO Rewrite this to a filter +./inc/modules/guest/what-register.php:286: // @TODO Rewrite this to addPointsDirectly() ./inc/modules/guest/what-sponsor_infos.php:69: // @TODO Rewritings: conv->conv_rate,name->conv_name in template ./inc/modules/guest/what-sponsor_infos.php:89: // @TODO Rewritings: name->pay_name,min->pay_min_count,min->pay_min_count,curr->pay_currency ./inc/modules/guest/what-sponsor_reg.php:286: // @TODO Swap this HTML code to templates ./inc/modules/guest/what-stats.php:115: // @TODO This can be somehow rewritten ./inc/modules/guest/what-stats.php:75:// @TODO This can be rewritten in a dynamic include -./inc/modules/member/what-beg.php:89:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout'))); +./inc/modules/member/what-beg.php:63:// @TODO No more needed? define('__BEG_UID_TIMEOUT', createFancyTime(getConfig('beg_userid_timeout'))); ./inc/modules/member/what-bonus.php:56: // @TODO Rewrite this to a filter -./inc/modules/member/what-categories.php:129: // @TODO Rewrite this to use $OUT .= ... +./inc/modules/member/what-categories.php:128: // @TODO Rewrite this to use $OUT .= ... +./inc/modules/member/what-doubler.php:55:// @TODO The '*100' is in the way to get moved into the template ./inc/modules/member/what-order.php:443: // @TODO Rewrite this to a filter ./inc/modules/member/what-payout.php:240: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:54:// @TODO Should we rewrite this to a filter? -./inc/modules/member/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = "".$content['login'].""; -./inc/modules/member/what-reflinks.php:59:// @TODO Move this into a filter +./inc/modules/member/what-rallyes.php:90: // @TODO Reactivate this: $content['admin'] = "" . $content['login'] . ""; +./inc/modules/member/what-reflinks.php:53:// @TODO Move this into a filter ./inc/modules/member/what-stats.php:118: // @TODO Rewrite in template: clix->clicks -./inc/modules/member/what-transfer.php:141: // @TODO Rewrite this to a filter -./inc/modules/member/what-transfer.php:231: // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries -./inc/modules/member/what-transfer.php:316: // @TODO This should be somehow rewritten to $row = SQL_FETCHARRAY(), see switch() block above for SQL queries -./inc/modules/member/what-transfer.php:322: // @TODO Rewrite: tid->trans_id,stamp->time_trans -./inc/modules/member/what-transfer.php:99: // @TODO Rewrite this to a filter -./inc/modules/member/what-unconfirmed.php:144: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/modules/member/what-transfer.php:135: // @TODO Rewrite this to a filter +./inc/modules/member/what-transfer.php:225: // @TODO Try to rewrite his to $content = SQL_FETCHARRAY(), see some lines above for two different queries +./inc/modules/member/what-transfer.php:310: // @TODO This should be somehow rewritten to $row = SQL_FETCHARRAY(), see switch() block above for SQL queries +./inc/modules/member/what-transfer.php:316: // @TODO Rewrite: tid->trans_id,stamp->time_trans +./inc/modules/member/what-transfer.php:93: // @TODO Rewrite this to a filter +./inc/modules/member/what-unconfirmed.php:142: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() ./inc/modules/order.php:75: // @TODO Unused: 2,4 ./inc/monthly/monthly_bonus.php:68: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1564: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/mysql-manager.php:1788: // @TODO Rewrite this to $content = SQL_FETCHARRAY() -./inc/mysql-manager.php:2110: // @TODO This can be somehow rewritten -./inc/mysql-manager.php:2133:// @TODO Fix inconsistency between last_module and getWhat() -./inc/mysql-manager.php:220: // @TODO Nothing helped??? -./inc/mysql-manager.php:255: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:576: // @TODO Try to rewrite this to one or more functions +./inc/mysql-manager.php:1546: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/mysql-manager.php:1770: // @TODO Rewrite this to $content = SQL_FETCHARRAY() +./inc/mysql-manager.php:2098: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:2128:// @TODO Fix inconsistency between last_module and getWhat() +./inc/mysql-manager.php:224: // @TODO Nothing helped??? +./inc/mysql-manager.php:259: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:552: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:93:// @TODO Can we cache this? ./inc/reset/reset_beg.php:50:// @TODO This should be converted in a daily beg rallye -./inc/reset/reset_birthday.php:92: // @TODO 4 is hard-coded here, should we move it out in config? +./inc/reset/reset_birthday.php:91: // @TODO 4 is hard-coded here, should we move it out in config? ./inc/wrapper-functions.php:127:// @TODO Implement $compress ./inc/wrapper-functions.php:134:// @TODO Implement $decompress -./inc/wrapper-functions.php:387:// @TODO Do some more sanity check here +./inc/wrapper-functions.php:401:// @TODO Do some more sanity check here ./mailid.php:134: // @TODO Rewrite this to a filter ./mailid.php:214: // @TODO Rewrite this to a dynamic include or so ./mailid.php:94: // @TODO Rewrite this to a filter @@ -180,7 +183,7 @@ ./mailid_top.php:225: // @TODO Rewrite these blocks to filter ./mailid_top.php:260: // @TODO Try to rewrite the following unset() ./mailid_top.php:99: // @TODO Rewrite this to a filter -./view.php:72: // @TODO No banner found, output some default banner +./view.php:69: // @TODO No banner found, output some default banner ./templates/de/html/admin/admin_add_country.tpl:23: ./templates/de/html/admin/admin_admins_contct_form.tpl:3: ./templates/de/html/admin/admin_amenu_edit.tpl:4: @@ -198,9 +201,11 @@ ./templates/de/html/guest/guest_login.tpl:21: @TODO Deactivated feature, try to implement it or remove it. ./templates/de/html/guest/guest_nickname_login.tpl:21: @TODO Deactivated feature, try to find a solution for this or remove it. ./templates/de/html/guest/guest_stats_member.tpl:23: @TODO We have to fix these counters. -./templates/de/html/surfbar/surfbar_frame_top.tpl:23:// @TODO Try to rewrite this JavaScript to js.php?js=surfbar_frame_top2 (wouldn't be easy) +./templates/de/html/surfbar/surfbar_frame_textlinks.tpl:5: +./templates/de/html/surfbar/surfbar_frame_top.tpl:23:// @TODO Try to rewrite this JavaScript to js.php?js=surfbar_frame_top (wouldn't be easy) ### ### DEPRECATION FOLLOWS: ### ### ./inc/modules/admin/admin-inc.php:532:// @DEPRECATED +./templates/de/html/member/member_mydata_locked.tpl:1: ### ### template-warnings.log follows: ### ### Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/menu/menu_what_end.tpl, line: 1 in Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/menu/menu_what_end.tpl, line: 2 in @@ -208,9 +213,7 @@ Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : form in templates/de/html/member/member_cats_footer.tpl, line: 8 in Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/member/member_content_right.tpl, line: 1 in Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/member/member_content_right.tpl, line: 5 in -Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : td in templates/de/html/member/member_welcome_footer.tpl, line: 1 in -Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : tr in templates/de/html/member/member_welcome_footer.tpl, line: 2 in -Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de/html/member/member_welcome_footer.tpl, line: 3 in +Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : div in templates/de/html/member/member_welcome_footer.tpl, line: 1 in Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : table in templates/de/html/member/member_footer.tpl, line: 6 in Warning: DOMDocument::loadHTMLFile(): Document is empty in templates/de/html/header.tpl, line: 1 in /home Warning: DOMDocument::loadHTMLFile(): Unexpected end tag : div in templates/de/html/page_footer.tpl, line: 1 in /home