X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=DOCS%2FTODOs.txt;h=f2d72504b0db239b14d31ed21675bc43340557b3;hp=b7940243484c654e5e49f0eba5b1275abcaf2b54;hb=0fada672e2066043b76ed5d57f852f451a49a3a3;hpb=c6017cf76200e2a5e68bd1984fa2d31f0e3be9d8 diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index b794024348..f2d72504b0 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -2,7 +2,6 @@ ### DO NOT EDIT THIS FILE. ### ./autoreg.php:58:// @TODO Add processing of request here ./beg.php:168: // @TODO Opps, what is missing here??? -./birthday_confirm.php:93: // @TODO Try to rewrite the following unset() ./inc/cache/config-local.php:124:// @TODO Rewrite the following three constants, somehow... ./inc/classes/cachesystem.class.php:504: // @TODO Add support for more types which break in last else-block ./inc/config-functions.php:136: // @TODO Make this all better... :-/ @@ -36,68 +35,63 @@ ./inc/extensions/ext-network.php:93: // @TODO network_type_handle is an internal name and needs documentation ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-order.php:358: // @TODO This should be moved out to inc/daily/ -./inc/extensions/ext-rallye.php:329: // @TODO Move this code into a hook -./inc/extensions/ext-rallye.php:92: // @TODO Fix config_rallye_prices to list_rallye_prices +./inc/extensions/ext-rallye.php:341: // @TODO Move this code into a hook +./inc/extensions/ext-rallye.php:94: // @TODO Fix config_rallye_prices to list_rallye_prices ./inc/extensions/ext-yoomedia.php:121: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready! setExtensionDeprecated('Y'); ./inc/extensions-functions.php:155: // @TODO Do we still need this? setExtensionUpdateNotes(''); -./inc/extensions-functions.php:1947:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' +./inc/extensions-functions.php:1945:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' ./inc/extensions-functions.php:425:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) ./inc/extensions-functions.php:562: // @TODO Extension is loaded, what next? ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/filter/cache_filter.php:92: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. -./inc/functions.php:1223: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? -./inc/functions.php:1311: // @TODO Are these convertions still required? -./inc/functions.php:1329:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1222: // @TODO Move this SQL code into a function, let's say 'getTimestampFromPoolId($id) ? +./inc/functions.php:1310: // @TODO Are these convertions still required? +./inc/functions.php:1330:// @TODO Rewrite this function to use readFromFile() and writeToFile() ./inc/functions.php:156:// @TODO Rewrite this to an extension 'smtp' -./inc/functions.php:1920: // @TODO Find a way to cache this -./inc/functions.php:2021: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2201: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:1921: // @TODO Find a way to cache this +./inc/functions.php:2022: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2214: // @TODO Rename column data_type to e.g. mail_status ./inc/gen_sql_patches.php:95:// @TODO Rewrite this to a filter ./inc/install-functions.php:57: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestParameter('omode'), 0); -./inc/language/de.php:1079: // @TODO Rewrite these two constants -./inc/language/de.php:1100: // @TODO Rewrite these three constants -./inc/language/de.php:771:// @TODO Are these constants longer used? +./inc/language/de.php:1063: // @TODO Rewrite these two constants +./inc/language/de.php:1079: // @TODO Rewrite these three constants +./inc/language/de.php:758:// @TODO Are these constants longer used? ./inc/language-functions.php:255: // @TODO These are all valid languages, again hard-coded ./inc/language-functions.php:44:// @TODO Rewrite all language constants to this function. ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * ./inc/language/rallye_de.php:13: * @TODO Naming convention not applied for language strings * ./inc/language/refback_de.php:44:// @TODO Rewrite these constants to one ./inc/language/sponsor_de.php:117:// @TODO Rewrite these four constants to one and use sprintf() -./inc/libs/admins_functions.php:451: // @TODO This can be, somehow, rewritten -./inc/libs/beg_functions.php:55: // @TODO Try to rewrite the following unset() +./inc/libs/admins_functions.php:474: // @TODO This can be, somehow, rewritten ./inc/libs/bonus_functions.php:194: // @TODO Move this HTML to a template ./inc/libs/doubler_functions.php:44:// @TODO Lame description ./inc/libs/doubler_functions.php:91: // @TODO Can't this be moved into EL? ./inc/libs/mailid_functions.php:47: // @TODO Rewrite this to a dynamic include or so -./inc/libs/rallye_functions.php:703:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() -./inc/libs/rallye_functions.php:768: $EXPIRE = 3; // @TODO The hard-coded value... -./inc/libs/rallye_functions.php:854:// @TODO Please document this function -./inc/libs/rallye_functions.php:910: // Load count @TODO Can't we rewrite this to our API? -./inc/libs/refback_functions.php:59: // @TODO Try to rewrite the following unset() +./inc/libs/rallye_functions.php:439: // @TODO Deprecated variable and global statement, please try to rewrite this +./inc/libs/rallye_functions.php:704:// @TODO This function does not load min_users, min_prices, please encapsulate loading rallye data with e.g. getRallyeDataFromId() +./inc/libs/rallye_functions.php:769: $EXPIRE = 3; // @TODO The hard-coded value... +./inc/libs/rallye_functions.php:855:// @TODO Please document this function +./inc/libs/rallye_functions.php:911: // Load count @TODO Can't we rewrite this to our API? ./inc/libs/register_functions.php:290: // @TODO Rewrite these all to a single filter -./inc/libs/register_functions.php:360: // @TODO Rewrite this to a filter -./inc/libs/register_functions.php:367: // @TODO Wether the registration bonus should only be added to user directly or through referal system should be configurable ./inc/libs/sponsor_functions.php:159: // @TODO Rewrite this to API function ./inc/libs/sponsor_functions.php:430: // @TODO Rewrite this to API function -./inc/libs/surfbar_functions.php:1026: // @TODO Try to rewrite the following unset() -./inc/libs/surfbar_functions.php:1541: // @TODO This can be somehow rewritten -./inc/libs/surfbar_functions.php:710:// @TODO Can't we use our new expression language instead of this ugly code? -./inc/libs/surfbar_functions.php:951: // @TODO Invalid salt should be refused -./inc/libs/task_functions.php:240: // @TODO These can be rewritten to filter +./inc/libs/surfbar_functions.php:1621: // @TODO This can be somehow rewritten +./inc/libs/surfbar_functions.php:729:// @TODO Can't we use our new expression language instead of this ugly code? +./inc/libs/task_functions.php:247: // @TODO These can be rewritten to filter ./inc/libs/task_functions.php:51:// @TODO Move all extension-dependent queries into filters ./inc/libs/theme_functions.php:93: // @TODO Can't this be rewritten to an API function? -./inc/libs/user_functions.php:146: // @TODO These two constants are no longer used, maybe we reactivate this code? -./inc/libs/user_functions.php:234:// @TODO Double-check configuration entry here -./inc/libs/user_functions.php:329: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); -./inc/libs/user_functions.php:358: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); -./inc/libs/user_functions.php:625: // @TODO Try to rewrite the following unset() +./inc/libs/user_functions.php:159: // @TODO These two constants are no longer used, maybe we reactivate this code? +./inc/libs/user_functions.php:250:// @TODO Double-check configuration entry here +./inc/libs/user_functions.php:345: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); +./inc/libs/user_functions.php:374: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); ./inc/libs/yoomedia_functions.php:114: $response = YOOMEDIA_QUERY_API('out_textmail.php', true); // @TODO Ask Yoo!Media for test script ./inc/load_config.php:75: // @TODO Rewrite them to avoid this else block ./inc/loader/load-extension.php:13: * @TODO Rewrite this whole file * ./inc/mails/doubler_mails.php:53:// @TODO Can this be rewritten to a filter? ./inc/module-functions.php:267: // @TODO Nothing helped??? ./inc/module-functions.php:308: // @TODO Rewrite this to a filter +./inc/modules/admin/admin-inc.php:1236: // @TODO If we can rewrite the EL sub-system to support more than one parameter, this call_user_func_array() can be avoided ./inc/modules/admin/admin-inc.php:171: // @TODO This and the next getCurrentAdminId() call might be moved into the templates? ./inc/modules/admin/admin-inc.php:242: // @TODO This can be rewritten into a filter ./inc/modules/admin/admin-inc.php:274: // @TODO Rewrite this to $content = SQL_FETCHARRAY() @@ -142,8 +136,8 @@ ./inc/modules/admin/what-list_refs.php:107: // @TODO Try to rewrite some to EL ./inc/modules/admin/what-list_unconfirmed.php:107: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus ./inc/modules/admin/what-list_unconfirmed.php:84: // @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}'); -./inc/modules/admin/what-list_user.php:251: // @TODO Rewrite this into a filter -./inc/modules/admin/what-list_user.php:294: // @TODO Rewrite this into a filter +./inc/modules/admin/what-list_user.php:254: // @TODO Rewrite this into a filter +./inc/modules/admin/what-list_user.php:297: // @TODO Rewrite this into a filter ./inc/modules/admin/what-logs.php:64: // @TODO Fix content-type here ./inc/modules/admin/what-logs.php:70: // @TODO Fix content-type here ./inc/modules/admin/what-mem_add.php:124: // @TODO This can be somehow rewritten to a function @@ -170,44 +164,43 @@ ./inc/modules/member/what-payout.php:194: // @TODO Rewrite this to a filter ./inc/modules/member/what-points.php:55:// @TODO Should we rewrite this to a filter? ./inc/modules/member/what-rallyes.php:89: // @TODO Reactivate this: $content['admin'] = '' . $content['login'] . ''; -./inc/modules/member/what-refback.php:124: // @TODO UNUSED: $refRow['status'] = translateUserStatus($refRow['status']); ./inc/modules/member/what-reflinks.php:52:// @TODO Move this into a filter -./inc/modules/member/what-transfer.php:127: // @TODO Rewrite this to a filter -./inc/modules/member/what-unconfirmed.php:138: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/modules/member/what-unconfirmed.php:203: // @TODO This 'userid' cannot be saved because of encapsulated EL code +./inc/modules/member/what-transfer.php:128: // @TODO Rewrite this to a filter +./inc/modules/member/what-unconfirmed.php:144: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/modules/member/what-unconfirmed.php:209: // @TODO This 'userid' cannot be saved because of encapsulated EL code ./inc/modules/order.php:74: // @TODO Unused: 2,4 ./inc/monthly/monthly_bonus.php:64: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1223: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1485: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() -./inc/mysql-manager.php:1573: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1597: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1961: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:2005:// @TODO Fix inconsistency between last_module and getWhat() +./inc/mysql-manager.php:1249: // @TODO Try to rewrite this to $content = SQL_FETCHARRAY() +./inc/mysql-manager.php:1313: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1337: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1596: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1640:// @TODO Fix inconsistency between last_module and getWhat() ./inc/mysql-manager.php:371: // @TODO Try to rewrite this to one or more functions ./inc/mysql-manager.php:44:// @TODO Can we cache this? ./inc/purge/purge-inact.php:55: // @TODO Rewrite these if() blocks to a filter ./inc/revision-functions.php:169:// @TODO This function does also set and get in 'cache_array' -./inc/template-functions.php:1058: // @TODO Deprecate this thing -./inc/template-functions.php:1069: // @TODO Deprecate this thing -./inc/template-functions.php:1162: // @TODO This can be easily moved out after the merge from EL branch to this is complete -./inc/template-functions.php:1195: // @TODO Add a little more infos here -./inc/template-functions.php:1506:// @TODO Lame description for this function -./inc/template-functions.php:1528: // @TODO Move this in a filter +./inc/template-functions.php:1072: // @TODO Deprecate this thing +./inc/template-functions.php:1083: // @TODO Deprecate this thing +./inc/template-functions.php:1176: // @TODO This can be easily moved out after the merge from EL branch to this is complete +./inc/template-functions.php:1209: // @TODO Add a little more infos here +./inc/template-functions.php:1523:// @TODO Lame description for this function +./inc/template-functions.php:1545: // @TODO Move this in a filter ./inc/template-functions.php:189: * @TODO On some pages this is buggy -./inc/template-functions.php:265: // @TODO Remove this sanity-check if all is fine -./inc/template-functions.php:586:// @TODO $simple/$constants are deprecated -./inc/template-functions.php:612: // @TODO Do only use $content and deprecate $GLOBALS and $DATA in templates +./inc/template-functions.php:269: // @TODO Remove this sanity-check if all is fine +./inc/template-functions.php:432: // @TODO $DATA is deprecated and should be avoided and replaced with $content +./inc/template-functions.php:598:// @TODO $simple/$constants are deprecated +./inc/template-functions.php:624: // @TODO Do only use $content and deprecate $DATA in templates ./inc/wrapper-functions.php:130:// @TODO Implement $compress ./inc/wrapper-functions.php:137:// @TODO Implement $decompress ./inc/wrapper-functions.php:514:// @TODO Do some more sanity check here ./mailid.php:139: // @TODO Rewrite this to a filter ./mailid.php:96: // @TODO Rewrite this to a filter -./mailid_top.php:103: // @TODO Rewrite this to a filter -./mailid_top.php:136: // @TODO Rewrite this to a filter -./mailid_top.php:183: // @TODO Rewrite this to a filter -./mailid_top.php:190: // @TODO Rewrite this to a filter -./mailid_top.php:225: // @TODO Rewrite these blocks to filter -./mailid_top.php:261: // @TODO Try to rewrite the following unset() +./mailid_top.php:105: // @TODO Rewrite this to a filter +./mailid_top.php:138: // @TODO Rewrite this to a filter +./mailid_top.php:185: // @TODO Rewrite this to a filter +./mailid_top.php:18: * @TODO Merge this script with mailid.php * +./mailid_top.php:192: // @TODO Rewrite this to a filter +./mailid_top.php:227: // @TODO Rewrite these blocks to filter ./network-check.php:54:// @TODO Add processing of request here ./show_bonus.php:105: // @TODO No more needed? $content['points'] = translateComma($content['points']); ./view.php:68: // @TODO No banner found, output some default banner @@ -226,6 +219,7 @@ ./templates/de/html/guest/guest_nickname_login.tpl:21: @TODO Deactivated feature, try to find a solution for this or remove it. ./templates/de/html/guest/guest_stats_member.tpl:21: @TODO We have to fix these counters. ./templates/de/html/member/member_unconfirmed_table_nopoints.tpl:11: +./templates/de/html/surfbar/surfbar_frameset.tpl:4: // @TODO This redirect kills our own frameset ./templates/de/html/surfbar/surfbar_frame_textlinks.tpl:5: ### ### DEPRECATION FOLLOWS: ### ### ./inc/autopurge/purge-general.php:2:// @DEPRECATED @@ -234,6 +228,7 @@ ./inc/autopurge/purge-tsks.php:2:// @DEPRECATED ./inc/autopurge/purge-unconfirmed.php:2:// @DEPRECATED ./inc/daily/daily_engine.php:2:// @DEPRECATED +./inc/gen_refback.php:2:// @DEPRECATED ./inc/loader/load_cache-admin.php:2:// @DEPRECATED ./inc/loader/load_cache-config.php:2:// @DEPRECATED ./inc/loader/load_cache-extension.php:2:// @DEPRECATED @@ -249,6 +244,9 @@ ./inc/modules/admin/what-chk_regs.php:2:// @DEPRECATED ./inc/modules/admin/what-config_admins.php:2:// @DEPRECATED ./inc/modules/admin/what-config_email.php:2:// @DEPRECATED +./inc/modules/member/what-surfbar_book.php:2:// @DEPRECATED +./inc/modules/member/what-surfbar_start.php:2:// @DEPRECATED +./inc/modules/member/what-surfbar_stats.php:2:// @DEPRECATED ./inc/reset/reset_100_bonus.php:2:// @DEPRECATED ./inc/reset/reset_autopurge.php:2:// @DEPRECATED ./inc/reset/reset_beg.php:2:// @DEPRECATED @@ -263,6 +261,8 @@ ./inc/reset/reset_yoomedia.php:2:// @DEPRECATED ./templates/de/emails/add-points.tpl:1: ./templates/de/emails/admin/admin_coupon.tpl:1: +./templates/de/emails/admin/admin_del_surfbar_urls.tpl:1: +./templates/de/emails/admin/admin_surfbar_url_depleted.tpl:1: ./templates/de/emails/admin-del_links.tpl:1: ./templates/de/emails/back-admin.tpl:1: ./templates/de/emails/back-member.tpl:1: @@ -274,6 +274,7 @@ ./templates/de/emails/done-member.tpl:1: ./templates/de/emails/lock-user.tpl:1: ./templates/de/emails/member/member_coupon.tpl:1: +./templates/de/emails/member/member_del_surfbar_urls.tpl:1: ./templates/de/emails/new-pass.tpl:1: ./templates/de/emails/normal-mail.tpl:1: ./templates/de/emails/order-accept.tpl:1: @@ -305,11 +306,24 @@ ./templates/de/html/admin/admin_config_payouts_del.tpl:1: ./templates/de/html/admin/admin_config_payouts_edit_row.tpl:1: ./templates/de/html/admin/admin_config_payouts_edit.tpl:1: +./templates/de/html/admin/admin_del_surfbar_urls_row.tpl:1: +./templates/de/html/admin/admin_del_surfbar_urls.tpl:1: ./templates/de/html/admin/admin_list_cats_404.tpl:1: ./templates/de/html/admin/admin_list_chk_reg_row.tpl:1: ./templates/de/html/admin/admin_list_chk_reg.tpl:1: +./templates/de/html/admin/admin_list_country_del_row.tpl:1: +./templates/de/html/admin/admin_list_country_edit_row.tpl:1: ./templates/de/html/admin/admin_reset_pass_done.tpl:1: ./templates/de/html/admin/admin_send_reset_link.tpl:1: +./templates/de/html/member/member_surfbar_book_dynamic.tpl:1: +./templates/de/html/member/member_surfbar_book_static.tpl:1: +./templates/de/html/member/member_surfbar_list_form.tpl:1: +./templates/de/html/member/member_surfbar_list_row.tpl:1: +./templates/de/html/member/member_surfbar_list.tpl:1: +./templates/de/html/member/member_surfbar_start_dynamic.tpl:1: +./templates/de/html/member/member_surfbar_start_static.tpl:1: +./templates/xml/admin/admin_del_do_surfbar_urls.xml:1: +./templates/xml/admin/admin_del_show_surfbar_urls.xml:1: ### ### template-warnings.log follows: ### ### Warning: Not parsing JavaScript templates/de/html/js/js_order_send.tpl. Warning: Not parsing JavaScript templates/de/html/js/js_cookies_disabled.tpl.