X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Ffunctions.php;h=e65600e13e36994bee1d1796de5e7cea09bad849;hp=8ebb9136698b4824fcb3334260f20ab491c4452c;hb=0f3a135204757cc8750262871c8e62c42300acb4;hpb=51987bfef4e13f3a35643d1bf80a1a1d7e6aee0a

diff --git a/inc/functions.php b/inc/functions.php
index 8ebb913669..e65600e13e 100644
--- a/inc/functions.php
+++ b/inc/functions.php
@@ -594,26 +594,26 @@ function redirectToUrl ($url, $allowSpider = true) {
  *                                                                      *
  ************************************************************************/
 function array_pk_sort (&$array, $a_sort, $primary_key = '0', $order = -1, $nums = false) {
-	$dummy = $array;
+	$temporaryArray = $array;
 	while ($primary_key < count($a_sort)) {
-		foreach ($dummy[$a_sort[$primary_key]] as $key => $value) {
-			foreach ($dummy[$a_sort[$primary_key]] as $key2 => $value2) {
+		foreach ($temporaryArray[$a_sort[$primary_key]] as $key => $value) {
+			foreach ($temporaryArray[$a_sort[$primary_key]] as $key2 => $value2) {
 				$match = false;
 				if ($nums === false) {
 					// Sort byte-by-byte (also numbers will be interpreted as chars! E.g.: "9" > "10")
-					if (($key != $key2) && (strcmp(strtolower($dummy[$a_sort[$primary_key]][$key]), strtolower($dummy[$a_sort[$primary_key]][$key2])) == $order)) $match = true;
+					if (($key != $key2) && (strcmp(strtolower($temporaryArray[$a_sort[$primary_key]][$key]), strtolower($temporaryArray[$a_sort[$primary_key]][$key2])) == $order)) $match = true;
 				} elseif ($key != $key2) {
 					// Sort numbers (E.g.: 9 < 10)
-					if (($dummy[$a_sort[$primary_key]][$key] < $dummy[$a_sort[$primary_key]][$key2]) && ($order == -1)) $match = true;
-					if (($dummy[$a_sort[$primary_key]][$key] > $dummy[$a_sort[$primary_key]][$key2]) && ($order == 1))  $match = true;
+					if (($temporaryArray[$a_sort[$primary_key]][$key] < $temporaryArray[$a_sort[$primary_key]][$key2]) && ($order == -1)) $match = true;
+					if (($temporaryArray[$a_sort[$primary_key]][$key] > $temporaryArray[$a_sort[$primary_key]][$key2]) && ($order == 1))  $match = true;
 				}
 
 				if ($match) {
 					// We have found two different values, so let's sort whole array
-					foreach ($dummy as $sort_key => $sort_val) {
-						$t                       = $dummy[$sort_key][$key];
-						$dummy[$sort_key][$key]  = $dummy[$sort_key][$key2];
-						$dummy[$sort_key][$key2] = $t;
+					foreach ($temporaryArray as $sort_key => $sort_val) {
+						$t                       = $temporaryArray[$sort_key][$key];
+						$temporaryArray[$sort_key][$key]  = $temporaryArray[$sort_key][$key2];
+						$temporaryArray[$sort_key][$key2] = $t;
 						unset($t);
 					} // END - foreach
 				} // END - if
@@ -625,7 +625,7 @@ function array_pk_sort (&$array, $a_sort, $primary_key = '0', $order = -1, $nums
 	} // END - while
 
 	// Write back sorted array
-	$array = $dummy;
+	$array = $temporaryArray;
 }
 
 
@@ -676,7 +676,7 @@ function generateRandomCode ($length, $code, $userid, $extraData = '') {
 	}
 
 	// Create number from hash
-	$rcode = hexdec(substr($saltedHash, 8, 9)) / abs(getRandNo() - $a + sqrt(getConfig('_ADD'))) / pi();
+	$rcode = hexdec(substr($saltedHash, getSaltLength(), 9)) / abs(getRandNo() - $a + sqrt(getConfig('_ADD'))) / pi();
 
 	// At least 10 numbers shall be secure enought!
 	if (isExtensionActive('other')) {
@@ -689,8 +689,8 @@ function generateRandomCode ($length, $code, $userid, $extraData = '') {
 		$len = 10;
 	} // END - if
 
-	// Cut off requested counts of number
-	$return = substr(str_replace('.', '', $rcode), 0, $len);
+	// Cut off requested counts of number, but skip first digit (which is mostly a zero)
+	$return = substr($rcode, (strpos($rcode, '.') + 1), $len);
 
 	// Done building code
 	return $return;
@@ -1453,6 +1453,7 @@ function handleExtraValues ($filterFunction, $value, $extraValue) {
 
 				// Call the multi-parameter call-back
 				$ret = call_user_func_array($filterFunction, $args);
+				die('filterFunction='.$filterFunction.',args=<pre>'.print_r($args,true).',ret=<pre>'.print_r($ret,true).'</pre>');
 			} else {
 				// One parameter call
 				$ret = call_user_func($filterFunction, $value);
@@ -2251,7 +2252,7 @@ function generateAdminMailLinks ($mailType, $mailId) {
 	// Is the mail type supported?
 	if (!empty($table)) {
 		// Query for the mail
-		$result = SQL_QUERY_ESC("SELECT `id`, `%s` AS `mail_status` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `id`=%s LIMIT 1",
+		$result = SQL_QUERY_ESC("SELECT `id`,`%s` AS `mail_status` FROM `{?_MYSQL_PREFIX?}_%s` WHERE `id`=%s LIMIT 1",
 			array(
 				$statusColumn,
 				$table,