X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Flibs%2Fsecurity_functions.php;h=02b5132855095765d3d3774993e246b41ca2c5ee;hp=b46309ee9291bb8fe15e22141dcabedbb8131b39;hb=56156f6c4392510cdbe0eb4f2ccefc23b43e2672;hpb=0e899620c7a065952d6787c236fb2b33ae337d6a

diff --git a/inc/libs/security_functions.php b/inc/libs/security_functions.php
index b46309ee92..02b5132855 100644
--- a/inc/libs/security_functions.php
+++ b/inc/libs/security_functions.php
@@ -32,8 +32,7 @@
  ************************************************************************/
 
 // Some security stuff...
-if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']))
-{
+if (ereg(basename(__FILE__), $_SERVER['PHP_SELF'])) {
 	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
 	require($INC);
 }
@@ -42,10 +41,17 @@ if (ereg(basename(__FILE__), $_SERVER['PHP_SELF']))
  * Function to secure input strings
  *
  * @param	$str	The unsecured string
- * @return	$str	A (hopefully) secured string against HTML and other things
+ * @param	$strip	Strip tags
+ * @return	$str	A (hopefully) secured string against XSS and other bad things
  */
-function secureString ($str) {
-	$str = trim(strip_tags($str));
+function secureString ($str, $strip=true) {
+	// Shall we strip HTML code?
+	if ($strip) $str = strip_tags($str);
+
+	// Trim string
+	$str = trim($str);
+
+	// Encode in entities
 	$str = htmlentities($str, ENT_QUOTES);
 	return $str;
 }
@@ -53,34 +59,25 @@ function secureString ($str) {
 // Run only once this security check/exchange
 if (defined('__SECURITY')) return;
 
-// Fatal messages goes here
-global $FATAL;
-$FATAL = array();
-
-// Runtime quoting is off now...
-set_magic_quotes_runtime(false);
+// Runtime/GPC quoting is off now...
+@set_magic_quotes_runtime(false);
+@ini_set('magic_quotes_gpc', false); // This may not work on some systems
 
 // Check if important arrays are found and define them if missing
-if (!isset($_SERVER))
-{
+if (!isset($_SERVER)) {
 	global $_SERVER;
 	$_SERVER = $GLOBALS['_SERVER'];
 }
-if (!isset($_GET))
-{
+
+if (!isset($_GET)) {
 	global $_GET;
 	$_GET = $GLOBALS['_GET'];
 }
-if (!isset($_POST))
-{
+
+if (!isset($_POST)) {
 	global $_POST;
 	$_POST = $GLOBALS['_POST'];
 }
-if (!isset($_COOKIE))
-{
-	global $_COOKIE;
-	$_COOKIE = $GLOBALS['_COOKIE'];
-}
 
 // Include IP-Filter here
 //require("/usr/share/php/ipfilter.php");
@@ -89,14 +86,14 @@ if (!isset($_COOKIE))
 global $SEC_CHARS, $URL_CHARS;
 $SEC_CHARS = array(
 	// The chars we are looking for...
-	'from' => array("{", "}", "/", ".", "'", "$", "(", ")", "{--", "--}", "%", ";", "[", "]", ":", "--"),
+	'from' => array("{", "}", "/", ".", "'", "$", "(", ")", '{--', '--}', "%", ";", "[", "]", ":", "--"),
 	// ... and we will replace to.
 	'to'   => array(
 		"{OPEN_ANCHOR2}",
 		"{CLOSE_ANCHOR2}",
 		"{SLASH}",
 		"{DOT}",
-		"{QUOT}",
+		'{QUOT}',
 		"{DOLLAR}",
 		"{OPEN_ANCHOR}",
 		"{CLOSE_ANCHOR}",
@@ -124,18 +121,13 @@ $URL_CHARS = array(
 
 // Overworked security part:
 if (is_array($_GET)) {
-	foreach ($_GET as $seckey=>$secvalue)
-	{
-		if (is_array($secvalue))
-		{
+	foreach ($_GET as $seckey => $secvalue) {
+		if (is_array($secvalue)) {
 			// Throw arrays away...
 			unset($_GET[$seckey]);
-		}
-		 else
-		{
+		} else {
 			// Only variables are allowed (non-array) but we secure them all!
-			foreach ($SEC_CHARS['from'] as $key=>$char)
-			{
+			foreach ($SEC_CHARS['from'] as $key => $char) {
 				// Pass all through
 				$_GET[$seckey] = str_replace($char  , $SEC_CHARS['to'][$key], $_GET[$seckey]);
 			}
@@ -146,16 +138,12 @@ if (is_array($_GET)) {
 	}
 }
 
-if (basename($_SERVER['PHP_SELF']) != "install.php")
-{
+if (basename($_SERVER['PHP_SELF']) != "install.php") {
 	// And POST data
-	foreach ($_POST as $seckey=>$secvalue)
-	{
-		if (!is_array($secvalue))
-		{
+	foreach ($_POST as $seckey => $secvalue) {
+		if (!is_array($secvalue)) {
 			// Only variables are allowed (non-array) to be secured...
-			foreach ($SEC_CHARS['from'] as $key=>$char)
-			{
+			foreach ($SEC_CHARS['from'] as $key => $char) {
 				// Pass all through
 				$_POST[$seckey] = str_replace($char  , $SEC_CHARS['to'][$key], $_POST[$seckey]);
 			}
@@ -164,49 +152,20 @@ if (basename($_SERVER['PHP_SELF']) != "install.php")
 			$_POST[$seckey] = strip_tags($_POST[$seckey]);
 		}
 	}
-
-	// ... and finally cookies
-	foreach ($_COOKIE as $seckey=>$secvalue)
-	{
-		if (is_array($secvalue))
-		{
-			// Throw arrays away...
-			unset($_COOKIE[$seckey]);
-		}
-		 else
-		{
-			// Only variables are allowed (non-array) but we secure them all!
-			foreach ($SEC_CHARS['from'] as $key=>$char)
-			{
-				// Pass all through
-				$_COOKIE[$seckey] = str_replace($char  , $SEC_CHARS['to'][$key], $_COOKIE[$seckey]);
-			}
-
-			// Strip all other out
-			$_COOKIE[$seckey] = strip_tags($_COOKIE[$seckey]);
-		}
-	}
 }
 
 // Activate caching or transparent compressing when it is not already done
-if (!defined('_OB_CACHING'))
-{
-	if (phpversion() >= '4.0.4pl1' && (strstr(getenv('HTTP_USER_AGENT'),'compatible') || (strstr(getenv('HTTP_USER_AGENT'), "Mozilla"))))
-	{
-		if ((extension_loaded('zlib')) && (function_exists('ob_start')))
-		{
+if (!defined('_OB_CACHING')) {
+	if (phpversion() >= '4.0.4pl1' && (strstr(getenv('HTTP_USER_AGENT'),'compatible') || (strstr(getenv('HTTP_USER_AGENT'), "Mozilla")))) {
+		if ((extension_loaded('zlib')) && (function_exists('ob_start'))) {
 			// Start caching
 			define('_OB_CACHING', "on");
 			ob_start();
-		}
-		 else
-		{
+		} else {
 			// Extension not loaded or required function is missing
 			define('_OB_CACHING', "404");
 		}
-	}
-	 else
-	{
+	} else {
 		// Old PHP version
 		define('_OB_CACHING', "old");
 	}
@@ -220,8 +179,7 @@ $SELF_DIR  = dirname($_SERVER['PHP_SELF']);
 $SELF_FILE = basename($_SERVER['PHP_SELF']);
 
 // Check for a .php inside the $SELF_DIR...
-while (ereg(".php", $SELF_DIR))
-{
+while (ereg(".php", $SELF_DIR)) {
 	// Correct the dirname
 	$SELF_DIR = substr($SELF_DIR, 0, (strpos($SELF_DIR, ".php") + 4));
 	// Rewrite filename...