X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin.php;h=fde00d3fc69cc3e4c8c8e2037d8e815ed69eb232;hp=4dd0b55cf7bec103ebfca561a49ce2840a78ad9a;hb=07612d2debcc78a93678db0deed050d82df432f1;hpb=17bf2b3d87d31caef7b3de26d16a4b184a9bf975 diff --git a/inc/modules/admin.php b/inc/modules/admin.php index 4dd0b55cf7..fde00d3fc6 100644 --- a/inc/modules/admin.php +++ b/inc/modules/admin.php @@ -38,27 +38,27 @@ // Some security stuff... if (!defined('__SECURITY')) { - $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php"; + $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php'; require($INC); -} +} // END - if // Load include file -LOAD_INC_ONCE("inc/modules/admin/admin-inc.php"); +loadIncludeOnce('inc/modules/admin/admin-inc.php'); // Fix "deleted" cookies in PHP4 (PHP5 does remove them, PHP4 sets them to deleted!) -FIX_DELETED_COOKIES(array('admin_login', 'admin_md5', 'admin_last', 'admin_to')); +fixDeletedCookies(array('admin_login', 'admin_md5', 'admin_last', 'admin_to')); // Init return value -$ret = "init"; +$ret = 'init'; // Is no admin registered? if (!isAdminRegistered()) { // Admin is not registered so we have to inform the user - if ((IS_FORM_SENT()) && ((!REQUEST_ISSET_POST(('login'))) || (!REQUEST_ISSET_POST(('pass'))) || (strlen(REQUEST_POST('pass')) < 4))) { - REQUEST_SET_POST('ok', "***"); - } + if ((isFormSent()) && ((!REQUEST_ISSET_POST('login')) || (!REQUEST_ISSET_POST(('pass'))) || (strlen(REQUEST_POST('pass')) < 4))) { + REQUEST_SET_POST('ok', '***'); + } // END - if - if ((IS_FORM_SENT()) && (REQUEST_POST('ok') != "***")) { + if ((isFormSent()) && (REQUEST_POST('ok') != '***')) { // Hash the password with the old function because we are here in install mode $hashedPass = md5(REQUEST_POST('pass')); @@ -67,59 +67,60 @@ if (!isAdminRegistered()) { // Do registration $ret = REGISTER_ADMIN(REQUEST_POST('login'), $hashedPass, constant('WEBMASTER')); - switch ($ret) - { - case "done": - $done = changeDataInFile(constant('PATH')."inc/config.php", "ADMIN-SETUP", "define('admin_registered', ", ");", "true", 0); - if ($done === true) { - // Registering is done - LOAD_URL("modules.php?module=admin&register=done"); - } else { - $ret = getMessage('ADMIN_CANNOT_COMPLETE'); - } - break; - - case "failed": - $ret = getMessage('ADMIN_REGISTER_FAILED'); - break; - - case "already": - default: - if ($ret == "already") { - // Admin does already exists! - $ret = getMessage('ADMIN_LOGIN_ALREADY_REG'); - } else { - // Any other kind will be logged and interpreted as 'done' - DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_LOGIN() and interpreted as 'done'!", $ret)); - // @TODO Why is this set to 'done'? - $ret = "done"; - } - // Admin still not registered? - if (!isAdminRegistered()) { - // Write to config that registration is done - changeDataInFile(constant('PATH')."inc/config.php", "ADMIN-SETUP", "define('admin_registered', ", ");", "true", 0); - - // Load URL for login - LOAD_URL("modules.php?module=admin"); - } // END - if - break; - } + // Check if registration wents fine + switch ($ret) { + case 'done': + $done = changeDataInFile(constant('PATH') . 'inc/cache/config-local.php', "ADMIN-SETUP", "setConfigEntry('ADMIN_REGISTERED', \"", "\");", 'Y', 0); + if ($done === true) { + // Registering is done + redirectToUrl('modules.php?module=admin&register=done'); + } else { + $ret = getMessage('ADMIN_CANNOT_COMPLETE'); + } + break; + + case 'failed': + $ret = getMessage('ADMIN_REGISTER_FAILED'); + break; + + case 'already': + default: + if ($ret == 'already') { + // Admin does already exists! + $ret = getMessage('ADMIN_LOGIN_ALREADY_REG'); + } else { + // Any other kind will be logged and interpreted as 'done' + DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_LOGIN() and interpreted as 'done'!", $ret)); + // @TODO Why is this set to 'done'? + $ret = 'done'; + } + + // Admin still not registered? + if (!isAdminRegistered()) { + // Write to config that registration is done + changeDataInFile(constant('PATH') . 'inc/cache/config-local.php', "ADMIN-SETUP", "setConfigEntry('ADMIN_REGISTERED', \"", "\");", 'Y', 0); + + // Load URL for login + redirectToUrl('modules.php?module=admin'); + } // END - if + break; + } // END - switch } // Whas that action okay? - if ($ret != "done") { - // Fixes another "Notice" - if (REQUEST_ISSET_POST(('login'))) { + if ($ret != 'done') { + // Fixes another notice + if (REQUEST_ISSET_POST('login')) { define('__LOGIN_VALUE', REQUEST_POST('login')); } else { - define('__LOGIN_VALUE', ""); + define('__LOGIN_VALUE', ''); } - // Yet-another "Notice" fix - if ((IS_FORM_SENT()) && (REQUEST_POST('ok') == "***")) { + // Yet-another notice-fix + if ((isFormSent()) && (REQUEST_POST('ok') == '***')) { // No login entered? - if (!REQUEST_ISSET_POST(('login'))) $loginMessage = getMessage('ADMIN_NO_LOGIN'); + if (!REQUEST_ISSET_POST('login')) $loginMessage = getMessage('ADMIN_NO_LOGIN'); // An error comes back from registration? if (!empty($ret)) $loginMessage = $ret; @@ -131,35 +132,35 @@ if (!isAdminRegistered()) { if (strlen(REQUEST_POST('pass')) < 4) $passwdMessage = getMessage('ADMIN_SHORT_PASS'); // Output error messages - define('__MSG_LOGIN', LOAD_TEMPLATE("admin_login_msg", true, $loginMessage)); - define('__MSG_PASS', LOAD_TEMPLATE("admin_login_msg", true, $passwdMessage)); + define('__MSG_LOGIN', LOAD_TEMPLATE('admin_login_msg', true, $loginMessage)); + define('__MSG_PASS', LOAD_TEMPLATE('admin_login_msg', true, $passwdMessage)); // Reset variables - $loginMessage = ""; $passwdMessage = ""; + $loginMessage = ''; $passwdMessage = ''; } else { // Reset values to nothing - define('__MSG_LOGIN', ""); - define('__MSG_PASS' , ""); + define('__MSG_LOGIN', ''); + define('__MSG_PASS' , ''); } // Output message in seperate template - LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_NOT_REGISTERED')); + LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_NOT_REGISTERED')); // Load register template - LOAD_TEMPLATE("admin_reg_form"); + LOAD_TEMPLATE('admin_reg_form'); } -} elseif (REQUEST_ISSET_GET(('reset_pass'))) { +} elseif (REQUEST_ISSET_GET('reset_pass')) { // Is the form submitted? - if ((REQUEST_ISSET_POST(('send_link'))) && (REQUEST_ISSET_POST(('email')))) { + if ((REQUEST_ISSET_POST('send_link')) && (REQUEST_ISSET_POST('email'))) { // Try to send the link out $OUT = ADMIN_SEND_PASSWORD_RESET_LINK(REQUEST_POST('email')); // Output result - LOAD_TEMPLATE("admin_settings_saved", false, $OUT); - } elseif (REQUEST_ISSET_GET(('hash'))) { + LOAD_TEMPLATE('admin_settings_saved', false, $OUT); + } elseif (REQUEST_ISSET_GET('hash')) { // Output form for hash validation - LOAD_TEMPLATE("admin_validate_reset_hash_form", false, REQUEST_GET('hash')); - } elseif ((REQUEST_ISSET_POST(('validate_hash'))) && (REQUEST_ISSET_POST(('login'))) && (REQUEST_ISSET_POST(('hash')))) { + LOAD_TEMPLATE('admin_validate_reset_hash_form', false, REQUEST_GET('hash')); + } elseif ((REQUEST_ISSET_POST('validate_hash')) && (REQUEST_ISSET_POST('login')) && (REQUEST_ISSET_POST('hash'))) { // Validate the login data and hash $valid = ADMIN_VALIDATE_RESET_LINK_HASH_LOGIN(REQUEST_POST('hash'), REQUEST_POST('login')); @@ -172,105 +173,104 @@ if (!isAdminRegistered()) { ); // Validation okay so display form for final password change - LOAD_TEMPLATE("admin_reset_password_form", false, $content); + LOAD_TEMPLATE('admin_reset_password_form', false, $content); } else { // Cannot validate the login data and hash - LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_VALIDATION_RESET_LOGIN_HASH_FAILED')); + LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_VALIDATION_RESET_LOGIN_HASH_FAILED')); } - } elseif ((REQUEST_ISSET_POST(('reset_pass'))) && (REQUEST_ISSET_POST(('hash'))) && (REQUEST_ISSET_POST(('login'))) && (REQUEST_ISSET_POST(('pass1'))) && (REQUEST_POST('pass1') == REQUEST_POST('pass2'))) { + } elseif ((REQUEST_ISSET_POST('reset_pass')) && (REQUEST_ISSET_POST('hash')) && (REQUEST_ISSET_POST('login')) && (REQUEST_ISSET_POST('pass1')) && (REQUEST_POST('pass1') == REQUEST_POST('pass2'))) { // Okay, we shall the admin password here. So first revalidate the hash if (ADMIN_VALIDATE_RESET_LINK_HASH_LOGIN(REQUEST_POST('hash'), REQUEST_POST('login'))) { // Set the password now $OUT = ADMIN_RESET_PASSWORD(REQUEST_POST('login'), REQUEST_POST('pass1')); // Output result - LOAD_TEMPLATE("admin_reset_pass_done", false, $OUT); + LOAD_TEMPLATE('admin_reset_pass_done', false, $OUT); } else { // Validation failed - LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_VALIDATION_RESET_LOGIN_HASH_FAILED2')); + LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_VALIDATION_RESET_LOGIN_HASH_FAILED2')); } } else { // Output reset password form - LOAD_TEMPLATE("admin_send_reset_link"); + LOAD_TEMPLATE('admin_send_reset_link'); } -} elseif ((!isSessionVariableSet('admin_login')) || (!isSessionVariableSet('admin_md5')) || (!isSessionVariableSet('admin_last')) || (!isSessionVariableSet('admin_to')) || ((get_session('admin_last') + bigintval(get_session('admin_to')) * 3600 * 24) < time())) { +} elseif ((!isSessionVariableSet('admin_login')) || (!isSessionVariableSet('admin_md5')) || (!isSessionVariableSet('admin_last')) || (!isSessionVariableSet('admin_to')) || ((getSession('admin_last') + bigintval(getSession('admin_to')) * 3600 * 24) < time())) { // At leat one administrator account was created if ((isSessionVariableSet('admin_login')) && (isSessionVariableSet('admin_md5')) && (isSessionVariableSet('admin_last')) && (isSessionVariableSet('admin_to'))) { // Timeout for last login, we have to logout first! - LOAD_URL("modules.php?module=admin&logout=1"); + redirectToUrl('modules.php?module=admin&logout=1'); } // END - if if (REQUEST_ISSET_GET(('register'))) { // Registration of first admin is done - if (REQUEST_GET('register') == "done") LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_REGISTER_DONE')); + if (REQUEST_GET('register') == 'done') LOAD_TEMPLATE('admin_settings_saved', false, getMessage('ADMIN_REGISTER_DONE')); } // END - if // Check if the admin has submitted data or not - if ((IS_FORM_SENT()) && ((!REQUEST_ISSET_POST(('login'))) || (!REQUEST_ISSET_POST(('pass'))) || (strlen(REQUEST_POST('pass')) < 4))) { - REQUEST_SET_POST('ok', "***"); + if ((isFormSent()) && ((!REQUEST_ISSET_POST('login')) || (!REQUEST_ISSET_POST(('pass'))) || (strlen(REQUEST_POST('pass')) < 4))) { + REQUEST_SET_POST('ok', '***'); } // END - if - if ((IS_FORM_SENT()) && (REQUEST_POST('ok') != "***")) { + if ((isFormSent()) && (REQUEST_POST('ok') != '***')) { // All required data was entered so we check his account $ret = CHECK_ADMIN_LOGIN(REQUEST_POST('login'), REQUEST_POST('pass')); // Which status do we have? - switch ($ret) - { - case "done": // Admin and password are okay, so we log in now - // Construct URL and redirect - $URL = "modules.php?module=admin&"; - - // Rewrite overview module - if ($GLOBALS['what'] == "overview") { - $GLOBALS['action'] = GET_ACTION($GLOBALS['module'], $GLOBALS['what']); - } // END - if - - // Add data to URL - if (!empty($GLOBALS['what'])) $URL .= "what=".$GLOBALS['what']; - elseif (!empty($GLOBALS['action'])) $URL .= "action=".$GLOBALS['action']; - elseif (REQUEST_ISSET_GET('area')) $URL .= "area=".REQUEST_GET('area'); - - // Load URL - LOAD_URL($URL); - break; - - case "404": // Administrator login not found - REQUEST_SET_POST('ok', $ret); - $ret = getMessage('ADMIN_NOT_FOUND'); - destroyAdminSession(); - break; - - case "pass": // Wrong password - REQUEST_SET_POST('ok', $ret); - $ret = "{--WRONG_PASS--} [{--ADMIN_RESET_PASS--}]\n"; - destroyAdminSession(); - break; - - default: // Others will be logged - DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_LOGIN()", $ret)); - break; + switch ($ret) { + case 'done': // Admin and password are okay, so we log in now + // Construct URL and redirect + $URL = 'modules.php?module=admin&'; + + // Rewrite overview module + if (getWhat() == 'overview') { + setAction(getModeAction(getModule(), getWhat())); + } // END - if + + // Add data to URL + if (isWhatSet()) $URL .= 'what='.getWhat(); + elseif (isActionSet()) $URL .= 'action='.getAction(); + elseif (REQUEST_ISSET_GET('area')) $URL .= 'area='.REQUEST_GET('area'); + + // Load URL + redirectToUrl($URL); + break; + + case '404': // Administrator login not found + REQUEST_SET_POST('ok', $ret); + $ret = getMessage('ADMIN_NOT_FOUND'); + destroyAdminSession(); + break; + + case 'pass': // Wrong password + REQUEST_SET_POST('ok', $ret); + $ret = '{--WRONG_PASS--} [{--ADMIN_RESET_PASS--}]'; + destroyAdminSession(); + break; + + default: // Others will be logged + DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_LOGIN()", $ret)); + break; } // END - switch } // END - if // Error detected? // @TODO Rewrite all these constants - if ($ret != "done") { - if (REQUEST_ISSET_POST(('login'))) { + if ($ret != 'done') { + if (REQUEST_ISSET_POST('login')) { define('__LOGIN_VALUE', REQUEST_POST('login')); } else { - define('__LOGIN_VALUE', ""); + define('__LOGIN_VALUE', ''); } - if (IS_FORM_SENT()) { + if (isFormSent()) { // Set messages to zero - $loginMessage = ""; $passwdMessage = ""; + $loginMessage = ''; $passwdMessage = ''; // No login entered? - if (!REQUEST_ISSET_POST(('login'))) $loginMessage = getMessage('ADMIN_NO_LOGIN'); + if (!REQUEST_ISSET_POST('login')) $loginMessage = getMessage('ADMIN_NO_LOGIN'); // An error comes back from login? - if ((!empty($ret)) && (REQUEST_POST('ok') == "404")) $loginMessage = $ret; + if ((!empty($ret)) && (REQUEST_POST('ok') == '404')) $loginMessage = $ret; // No password entered? if (!REQUEST_ISSET_POST(('pass'))) $passwdMessage = getMessage('ADMIN_NO_PASS'); @@ -279,43 +279,43 @@ if (!isAdminRegistered()) { if (strlen(REQUEST_POST('pass')) < 4) $passwdMessage = getMessage('ADMIN_SHORT_PASS'); // An error comes back from login? - if ((!empty($ret)) && (REQUEST_POST('ok') == "pass")) $passwdMessage = $ret; + if ((!empty($ret)) && (REQUEST_POST('ok') == 'pass')) $passwdMessage = $ret; // Load message template - define('__MSG_LOGIN', LOAD_TEMPLATE("admin_login_msg", true, $loginMessage)); - define('__MSG_PASS' , LOAD_TEMPLATE("admin_login_msg", true, $passwdMessage)); + define('__MSG_LOGIN', LOAD_TEMPLATE('admin_login_msg', true, $loginMessage)); + define('__MSG_PASS' , LOAD_TEMPLATE('admin_login_msg', true, $passwdMessage)); // Reset variables unset($loginMessage); unset($passwdMessage); } else { // Set constants to empty for hiding them - define('__MSG_LOGIN', ""); - define('__MSG_PASS' , ""); + define('__MSG_LOGIN', ''); + define('__MSG_PASS' , ''); } // Load login form - if (!empty($GLOBALS['what'])) { + if (isWhatSet()) { // Restore old what value - $content = array('target' => "what", 'value' => $GLOBALS['what']); - } elseif (!empty($GLOBALS['action'])) { - if ($GLOBALS['action'] != "logout") { + $content = array('target' => 'what', 'value' => getWhat()); + } elseif (isActionSet()) { + if (getAction() != 'logout') { // Restore old action value - $content = array('target' => "action", 'value' => $GLOBALS['action']); + $content = array('target' => 'action', 'value' => getAction()); } else { // Set default values - $content = array('target' => "action", 'value' => "login"); + $content = array('target' => 'action', 'value' => 'login'); } } elseif (REQUEST_ISSET_GET('area')) { // Restore old area value - $content = array('target' => "area", 'value' => REQUEST_GET('area')); + $content = array('target' => 'area', 'value' => REQUEST_GET('area')); } else { // Set default values - $content = array('target' => "action", 'value' => "login"); + $content = array('target' => 'action', 'value' => 'login'); } // Load login form template - LOAD_TEMPLATE("admin_login_form", false, $content); + LOAD_TEMPLATE('admin_login_form', false, $content); } // END - if } elseif (REQUEST_ISSET_GET(('logout'))) { // Only try to remove cookies @@ -335,62 +335,62 @@ if (!isAdminRegistered()) { LOAD_TEMPLATE(sprintf("admin_logout_%s_remove", $remove)); } else { // Logged out normally - LOAD_TEMPLATE("admin_logout"); + LOAD_TEMPLATE('admin_logout'); } } else { // Something went wrong here... - LOAD_TEMPLATE("admin_settings_saved", false, "
{--ADMIN_LOGOUT_FAILED--}
"); + LOAD_TEMPLATE('admin_settings_saved', false, '
{--ADMIN_LOGOUT_FAILED--}
'); // Add fatal message addFatalMessage(__FILE__, __LINE__, getMessage('CANNOT_UNREG_SESS')); } } else { // Maybe an Admin want's to login? - $ret = CHECK_ADMIN_COOKIES(get_session('admin_login'), get_session('admin_md5')); + $ret = CHECK_ADMIN_COOKIES(getSession('admin_login'), getSession('admin_md5')); switch ($ret) { - case "done": - // Check for access control line of current menu entry - $GLOBALS['acl_allow'] = runFilterChain('check_admin_acl'); + case 'done': + // Check for access control line of current menu entry + $GLOBALS['acl_allow'] = runFilterChain('check_admin_acl'); - // When type of admin menu is not set fallback to old menu system - if (!isConfigEntrySet('admin_menu')) setConfigEntry('admin_menu', "OLD"); + // When type of admin menu is not set fallback to old menu system + if (!isConfigEntrySet('admin_menu')) setConfigEntry('admin_menu', 'OLD'); - // Check for version and switch between old menu system and new "intelligent menu system" - if ((ADMIN_CHECK_MENU_MODE() == "NEW") && (INCLUDE_READABLE("inc/modules/admin/lasys-inc.php"))) { - // Default area is the entrance, of course - $area = "entrance"; + // Check for version and switch between old menu system and new intelligent menu system + if ((ADMIN_CHECK_MENU_MODE() == 'NEW') && (isIncludeReadable('inc/modules/admin/lasys-inc.php'))) { + // Default area is the entrance, of course + $area = 'entrance'; - // Check for similar URL variable - if (REQUEST_ISSET_GET('area')) $area = REQUEST_GET('area'); + // Check for similar URL variable + if (REQUEST_ISSET_GET('area')) $area = REQUEST_GET('area'); - // Load "logical-area menu-system" file - LOAD_INC_ONCE("inc/modules/admin/lasys-inc.php"); + // Load logical-area menu-system file + loadIncludeOnce('inc/modules/admin/lasys-inc.php'); - // Create new-style menu system will "logical areas" - ADMIN_LOGICAL_AREA_SYSTEM($area, $act, $GLOBALS['what']); - } else { - // This little call constructs the whole default old and lacky menu system - // on left side. It also renders the content on right side - ADMIN_DO_ACTION($GLOBALS['what']); - } - break; - - case "404": // Administrator login not found - REQUEST_SET_POST('ok', $ret); - destroyAdminSession(); - addFatalMessage(__FILE__, __LINE__, getMessage('ADMIN_NOT_FOUND')); - break; - - case "pass": // Wrong password - REQUEST_SET_POST('ok', $ret); - destroyAdminSession(); - addFatalMessage(__FILE__, __LINE__, getMessage('WRONG_PASS')); - break; - - default: // Others will be logged - DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_COOKIES()", $ret)); - break; + // Create new-style menu system will logical areas + ADMIN_LOGICAL_AREA_SYSTEM($area, $act, getWhat()); + } else { + // This little call constructs the whole default old and lacky menu system + // on left side. It also renders the content on right side + ADMIN_DO_ACTION(getWhat()); + } + break; + + case '404': // Administrator login not found + REQUEST_SET_POST('ok', $ret); + destroyAdminSession(); + addFatalMessage(__FILE__, __LINE__, getMessage('ADMIN_NOT_FOUND')); + break; + + case 'pass': // Wrong password + REQUEST_SET_POST('ok', $ret); + destroyAdminSession(); + addFatalMessage(__FILE__, __LINE__, getMessage('WRONG_PASS')); + break; + + default: // Others will be logged + DEBUG_LOG(__FILE__, __LINE__, sprintf("Unknown return code %s from CHECK_ADMIN_COOKIES()", $ret)); + break; } }