X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Foverview-inc.php;h=a9a81337c8330f4e1f3f7ec590b4301548e72758;hp=188f07abe2d1b4e8f7736cad9a20dee8546c2362;hb=7989ec603971c0dc8dc35d8be4e72f8098b83baa;hpb=5bdeaf8b452206598b6c6cd4f941145b11a0eccc

diff --git a/inc/modules/admin/overview-inc.php b/inc/modules/admin/overview-inc.php
index 188f07abe2..a9a81337c8 100644
--- a/inc/modules/admin/overview-inc.php
+++ b/inc/modules/admin/overview-inc.php
@@ -38,7 +38,7 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 }
 
 function OUTPUT_STANDARD_OVERVIEW(&$result_tasks) {
-	global $cacheArray, $_CONFIG;
+	global $cacheArray;
 
 	// First check for solved and not assigned tasks and assign them to current admin
 	SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_task_system` SET assigned_admin='%s' WHERE assigned_admin < 1 AND status != 'NEW'",
@@ -49,7 +49,7 @@ function OUTPUT_STANDARD_OVERVIEW(&$result_tasks) {
 	$JOBS_DONE = true;
 
 	// Open the extension directory
-	$handle = opendir(PATH."inc/extensions/") or mxchange_die("Cannot read extension directory!");
+	$handle = opendir(constant('PATH')."inc/extensions/") or mxchange_die("Cannot read extension directory!");
 	while ($file = readdir($handle)) {
 		// Is this file an extension?
 		if ((substr($file, 0, 4) == "ext-") && (substr($file, -4) == ".php")) {
@@ -75,7 +75,7 @@ function OUTPUT_STANDARD_OVERVIEW(&$result_tasks) {
 				} // END - if
 			} else {
 				// Test-drive extension in update mode
-				require(sprintf("%sinc/extensions/ext-%s.php", PATH, $ext_name));
+				require(sprintf("%sinc/extensions/ext-%s.php", constant('PATH'), $ext_name));
 
 				// Update extension if extension is installed and outdated
 				//* DEBUG: */ print "ext={$ext_name},ver={$EXT_VERSION}/".GET_EXT_VERSION($ext_name)."<br />\n";
@@ -101,7 +101,7 @@ function OUTPUT_STANDARD_OVERVIEW(&$result_tasks) {
 	// At last - but not least - check for own and new unassigned tasks...
 	$result_tasks = SQL_QUERY_ESC("SELECT id, assigned_admin, userid, task_type, subject, text, task_created
 FROM `{!_MYSQL_PREFIX!}_task_system`
-WHERE assigned_admin='%s' OR (assigned_admin='0' AND status='NEW')
+WHERE assigned_admin='%s' OR (assigned_admin='0' AND `status`='NEW')
 ORDER BY userid DESC, task_type DESC, subject, task_created DESC",
 		array(GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
 
@@ -119,12 +119,12 @@ ORDER BY userid DESC, task_type DESC, subject, task_created DESC",
 
 // Outputs selected tasks
 function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
-	global $_CONFIG, $NOTES;
+	global $NOTES;
 	if ((isset($POST['assign'])) && (count($POST['task']) > 0)) {
 		// Assign / do tasks
 		$OUT = ""; $SW = 2;
 		foreach ($POST['task'] as $id => $sel) {
-			$result_task = SQL_QUERY_ESC("SELECT id, userid, task_type, subject, text, task_created, status, assigned_admin FROM `{!_MYSQL_PREFIX!}_task_system` WHERE id=%s AND (assigned_admin='%s' OR (assigned_admin='0' AND status='NEW')) LIMIT 1",
+			$result_task = SQL_QUERY_ESC("SELECT id, userid, task_type, subject, text, task_created, status, assigned_admin FROM `{!_MYSQL_PREFIX!}_task_system` WHERE id=%s AND (assigned_admin='%s' OR (assigned_admin='0' AND `status`='NEW')) LIMIT 1",
 				array(bigintval($id), GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
 			if (SQL_NUMROWS($result_task) == 1) {
 				// Task is valid...
@@ -141,7 +141,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 				if ($type == "SUPPORT_MEMBER") {
 					$mode = substr($text, 0, strpos($text, ":"));
 					$text = substr($text, strpos($text, ":") + 1);
-					$ADD = "<li>".ADMIN_TASK_SUPPORT_MODE.": <strong>".$mode."</strong></li>";
+					$ADD = "<li>{--ADMIN_TASK_SUPPORT_MODE--}: <strong>".$mode."</strong></li>";
 				} // END - if
 
 				if ($uid > 0) {
@@ -150,19 +150,19 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 					if (SQL_NUMROWS($result_user) == 1) {
 						list($gender, $sname, $fname, $email) = SQL_FETCHROW($result_user);
 						SQL_FREERESULT($result_user);
-						$ADD = "<li>".ADMIN_MEMBER_UID.": <strong>".ADMIN_USER_PROFILE_LINK($uid)." (<a href=\"".CREATE_EMAIL_LINK($email, "user_data")."\">".TRANSLATE_GENDER($gender)." ".$sname." ".$fname."</a>)</strong></li>";
+						$ADD = "<li>{--ADMIN_MEMBER_UID--}: <strong>".ADMIN_USER_PROFILE_LINK($uid)." (<a href=\"".CREATE_EMAIL_LINK($email, "user_data")."\">".TRANSLATE_GENDER($gender)." ".$sname." ".$fname."</a>)</strong></li>";
 					} // END - if
 				} // END - if
 
 				// Decode entities of the text
-				$text = html_entity_decode($text);
+				$text = decodeEntities($text);
 
 				// Compile and insert text from task into table template
 				$text = LOAD_TEMPLATE("admin_extensions_text", true, $text);
 
 				// Initialize variables (no title for SQL commands by default)
 				$ext_name = "";
-				$title = TASK_NO_TITLE;
+				$title = getMessage('TASK_NO_TITLE');
 
 				// Shall I list SQL commands assigned to an extension installation or update task?
 				if (((GET_EXT_VERSION("sql_patches") != '') && (getConfig('verbose_sql') == "Y")) || (!EXT_IS_ACTIVE("sql_patches"))) {
@@ -175,7 +175,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 						$text .= $NOTES;
 
 						// Set title
-						$title = ADMIN_SQLS_EXECUTED_ON_REGISTER;
+						$title = getMessage('ADMIN_SQLS_EXECUTED_ON_REGISTER');
 					} elseif ($type == "EXTENSION_UPDATE") {
 						// Prepare extension name and version
 						$ext_name = substr($ext_name, 7);
@@ -191,7 +191,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 						$text .= $NOTES;
 
 						// Set title
-						$title = ADMIN_SQLS_EXECUTED_ON_UPDATE;
+						$title = getMessage('ADMIN_SQLS_EXECUTED_ON_UPDATE');
 					} else {
 						// Remove extension's name
 						$ext_name = "";
@@ -230,7 +230,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 				case "EXTENSION": // Install new extensions
 					$ext_name = substr($subj, 1, strpos($subj, ":") - 1);
 					$result_lines = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_extensions` WHERE ext_name='%s' LIMIT 1",
-					 array($ext_name), __FILE__, __LINE__);
+						array($ext_name), __FILE__, __LINE__);
 					$lines = SQL_NUMROWS($result_lines);
 					SQL_FREERESULT($result_lines);
 					if ($lines == "0") {
@@ -241,7 +241,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 						));
 					} else {
 						// Task is closed so nothing is todo
-						$OUT .= "<div class=\"admin_failed\">".ADMIN_EXT_ALREADY_REGISTERED."</div>\n";
+						$OUT .= "<div class=\"admin_failed\">{--ADMIN_EXT_ALREADY_REGISTERED--}</div>\n";
 
 						// Close task but not already closes or deleted or update tasks
 						if (($status != "CLOSED") && ($status != "DELETED") && ($type != "EXTENSION_UPDATE")) {
@@ -253,7 +253,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 
 				case "EXTENSION_UPDATE": // Extension update
 					// Extension updates are installed automatically
-					$OUT .= "<div class=\"admin_failed medium\">".ADMIN_EXTENSION_UPDATED."</div>\n";
+					$OUT .= "<div class=\"admin_failed medium\">{--ADMIN_EXTENSION_UPDATED--}</div>\n";
 
 					// Close task
 					if (($status != "CLOSED") && ($status != "DELETED")) {
@@ -263,6 +263,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 					break;
 
 				case "SUPPORT_MEMBER": // Assign on member's support request
+					// @TODO This may also be rewritten to include files
 					switch ($mode)
 					{
 					default: // @TODO Unknown support mode
@@ -293,7 +294,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 						}
 					} else {
 						// Extension is not installed
-						$OUT .= "<div class=\"admin_failed medium\">".ADMIN_PAYOUT_NOT_INSTALLED."</div>\n";
+						$OUT .= "<div class=\"admin_failed medium\">{--ADMIN_PAYOUT_NOT_INSTALLED--}</div>\n";
 					}
 					break;
 
@@ -314,11 +315,11 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 							$OUT .= LOAD_TEMPLATE("admin_wernis_overview_form", true, $content);
 						} else {
 							// Problem obtaining wernis ID
-							$OUT .= "<div class=\"admin_failed medium\">".WERNIS_OBTAIN_ID_FAILED."</div>\n";
+							$OUT .= "<div class=\"admin_failed medium\">{--WERNIS_OBTAIN_ID_FAILED--}</div>\n";
 						}
 					} else {
 						// Extension is not installed
-						$OUT .= "<div class=\"admin_failed medium\">".ADMIN_WERNIS_NOT_INSTALLED."</div>\n";
+						$OUT .= "<div class=\"admin_failed medium\">{--ADMIN_WERNIS_NOT_INSTALLED--}</div>\n";
 					}
 					break;
 
@@ -378,7 +379,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 			}
 
 			// Update query
-			$result_tasks = SQL_QUERY_ESC("SELECT id, assigned_admin, userid, task_type, subject, text, task_created FROM `{!_MYSQL_PREFIX!}_task_system` WHERE assigned_admin=%s OR (assigned_admin=0 AND status='NEW') ORDER BY task_created DESC",
+			$result_tasks = SQL_QUERY_ESC("SELECT id, assigned_admin, userid, task_type, subject, text, task_created FROM `{!_MYSQL_PREFIX!}_task_system` WHERE assigned_admin=%s OR (assigned_admin=0 AND `status`='NEW') ORDER BY task_created DESC",
 			 array(GET_CURRENT_ADMIN_ID()), __FILE__, __LINE__);
 		} // END - if
 
@@ -386,21 +387,11 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 		LOAD_TEMPLATE("admin_overview_header");
 		$SW = 2;
 		while (list($id, $admin, $uid, $type, $subj, $text, $created) = SQL_FETCHROW($result_tasks)) {
+			// Init infos
 			$infos = "---";
-			if ($admin == "0") {
-				// No admin currently is assigned
-				$admin = "<div class=\"admin_note\">".ADMIN_NO_ADMIN_ASSIGNED."</div>";
-			} else {
-				// Load admin's data
-				$login = GET_ADMIN_LOGIN($admin);
-				if ($login != "***") {
-					// Admin found
-					$admin = "<a href=\"{!URL!}/modules.php?module=admin&amp;what=admins_contct&amp;admin=".$admin."\">".$login."</a>";
-				} else {
-					// Maybe deleted?
-					$admin = "<div class=\"admin_note\">".ADMIN_ID_404_1.$admin.ADMIN_ID_404_2."</div>";
-				}
-			}
+
+			// Generate assign link
+			$admin = GENERATE_AID_LINK($admin);
 
 			// Get task type
 			$type_out = constant('ADMIN_TASK_IS_'.strtoupper($type).'');
@@ -419,7 +410,7 @@ function OUTPUT_SELECTED_TASKS ($POST, $result_tasks) {
 				// Member found otherwise it's a system task
 				$uid = ADMIN_USER_PROFILE_LINK($uid);
 			} else {
-				$uid = "<em>".ADMIN_IS_SYSTEM_TASK."</em>";
+				$uid = "<em>{--ADMIN_IS_SYSTEM_TASK--}</em>";
 			}
 
 			// Prepare content