X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-add_points.php;h=250fbda8b08b756a1a7251d0e816e3424c4f43a9;hp=08019d932c4d8cf670308cfff4afb3da7041be54;hb=4001187f22197f55e5a1f211fc8defcc180f7c32;hpb=a47a9c49a7813304ac78deb3741bdd85e6d50912

diff --git a/inc/modules/admin/what-add_points.php b/inc/modules/admin/what-add_points.php
index 08019d932c..250fbda8b0 100644
--- a/inc/modules/admin/what-add_points.php
+++ b/inc/modules/admin/what-add_points.php
@@ -46,26 +46,30 @@ if (!REQUEST_ISSET_GET(('uid'))) REQUEST_SET_GET('uid', "");
 if (REQUEST_GET('uid') == "all") {
 	// Add points to all accounts
 	if ((IS_FORM_SENT()) && (REQUEST_POST('points') > 0)) {
+		// @TODO Rewrite this constant
 		define('__POINTS_VALUE', REQUEST_POST('points'));
-		$result_main = SQL_QUERY("SELECT userid FROM `{!_MYSQL_PREFIX!}_user_data` WHERE `status`='CONFIRMED' ORDER BY userid", __FILE__, __LINE__);
-		while (list($uid) = SQL_FETCHROW($result_main)) {
+
+		// Select all users
+		$result_main = SQL_QUERY("SELECT userid FROM `{!_MYSQL_PREFIX!}_user_data` WHERE `status`='CONFIRMED' ORDER BY userid",
+			__FILE__, __LINE__);
+
+		// Process all entries
+		while ($content = SQL_FETCHROW($result_main)) {
 			// Remove depth to prevent booking errors. This is a bad coding
 			// practice, thats also why we need to write this project from
 			// scratch...
 			$GLOBALS['ref_level'] = -1;
 
 			// Ok, add points and send an email to him...
-			ADD_POINTS_REFSYSTEM("admin_all", $uid, bigintval(REQUEST_POST('points')), false, "0", false, "direct");
+			ADD_POINTS_REFSYSTEM("admin_all", $content['userid'], bigintval(REQUEST_POST('points')), false, "0", false, "direct");
 
 			// Prepare content
-			$content = array(
-				'text'   => SQL_ESCAPE(REQUEST_POST('reason')),
-				'points' => bigintval(REQUEST_POST('points'))
-			);
+			$content['text']   = SQL_ESCAPE(REQUEST_POST('reason'));
+			$content['points'] = bigintval(REQUEST_POST('points'));
 
 			// Load email template and send email away
-			$msg = LOAD_EMAIL_TEMPLATE("add-points", $content, bigintval($uid));
-			SEND_EMAIL(bigintval($uid), getMessage('ADMIN_ADD_SUBJ'), $msg);
+			$msg = LOAD_EMAIL_TEMPLATE("add-points", $content, bigintval($content['userid']));
+			SEND_EMAIL(bigintval($content['userid']), getMessage('ADMIN_ADD_SUBJ'), $msg);
 		} // END - while
 
 		// Free memory
@@ -108,6 +112,7 @@ if (REQUEST_GET('uid') == "all") {
 			LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_POINTS_ADDED'));
 		} else {
 			// Opps, missing form here
+			// @TODO Rewrite these both constants
 			define('__USER_VALUE', "<a href=\"".CREATE_EMAIL_LINK($email, "user_data")."\">".$sname." ".$fname."</a>");
 			define('__UID'       , bigintval(REQUEST_GET('uid')));
 			LOAD_TEMPLATE("admin_add_points");