X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-extensions.php;h=ab36ce7cfb210141054c7bdac95a285436c30573;hp=c6cecbd8e5018277abf7d9b751f73b1224e982ba;hb=88b0ed0e2370bf171be38810aa0142a4899e2c7b;hpb=2abf1ab70c824b92934910d9f5da3c37fe089c47 diff --git a/inc/modules/admin/what-extensions.php b/inc/modules/admin/what-extensions.php index c6cecbd8e5..ab36ce7cfb 100644 --- a/inc/modules/admin/what-extensions.php +++ b/inc/modules/admin/what-extensions.php @@ -1,6 +1,6 @@ 0) && (!isDemoModeActive())) { + // The id comes from task management and it is - of course - *not* the extension's name! +} elseif ((isPostRequestElementSet('change')) && (countPostSelection() > 0) && (!isDemoModeActive())) { // De-/activate extensions foreach (postRequestElement('sel') as $ext_id => $active) { // Shall we keep the extension always active? @@ -66,28 +59,28 @@ if (isGetRequestElementSet('reg_ext')) { // Keep this extension active! } else { // De/activate extension - $ACT = 'N'; getExtensionMode('deactivate'); + $ACT = 'N'; setExtensionMode('deactivate'); if ($active != 'Y') { $ACT = 'Y'; setExtensionMode('activate'); } SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_extensions` SET `ext_active`='".$ACT."' WHERE `id`=%s AND `ext_active`='%s' LIMIT 1", - array(bigintval($ext_id), $active), __FILE__, __LINE__); + array(bigintval($ext_id), $active), __FILE__, __LINE__); // Run embeded SQL commands doExtensionSqls($ext_id, getExtensionMode()); } } -} elseif (((isPostRequestElementSet('edit')) || (isPostRequestElementSet(('modify')))) && ($SEL > 0) && (!isDemoModeActive())) { +} elseif (((isPostRequestElementSet('edit')) || (isPostRequestElementSet(('modify')))) && (countPostSelection() > 0) && (!isDemoModeActive())) { // Change settings like CSS file load if (isPostRequestElementSet(('modify'))) { // Change entries - $cache_update = 0; + $cache_update = '0'; foreach (postRequestElement('sel') as $ext_id => $sel) { - // Secure ID + // Secure id $ext_id = bigintval($ext_id); // Change this extension? if ($sel == 1) { // Load mode is modify - getExtensionMode('modify'); + setExtensionMode('modify'); // Get entry for 'active' $active = postRequestElement('active', $ext_id); @@ -105,8 +98,8 @@ if (isGetRequestElementSet('reg_ext')) { // Run SQLs on activation / deactivation switch ($active) { - case 'Y': getExtensionMode('activate'); break; - case 'N': getExtensionMode('deactivate'); break; + case 'Y': setExtensionMode('activate'); break; + case 'N': setExtensionMode('deactivate'); break; } // END - if // Run embeded SQL commands @@ -162,7 +155,7 @@ if (isGetRequestElementSet('reg_ext')) { loadTemplate('admin_extensions_edit', false, $OUT); $do = 'edit'; } -} elseif ((isPostRequestElementSet('delete')) && ($SEL > 0) && (!isDemoModeActive())) { +} elseif ((isPostRequestElementSet('delete')) && (countPostSelection() > 0) && (!isDemoModeActive())) { // List extensions and when verbose is enabled SQL statements which will be executed $OUT = ''; $SW = 2; foreach (postRequestElement('sel') as $ext_id => $sel) { @@ -213,11 +206,11 @@ if (isGetRequestElementSet('reg_ext')) { // Load template loadTemplate('admin_extensions_delete', false, $OUT); $do = 'delete'; -} elseif ((isPostRequestElementSet('remove')) && ($SEL > 0) && (!isDemoModeActive())) { +} elseif ((isPostRequestElementSet('remove')) && (countPostSelection() > 0) && (!isDemoModeActive())) { // Remove extensions from DB (you have to delete all files manually!) - $cache_update = 0; + $cache_update = '0'; foreach (postRequestElement('sel') as $ext_id => $active) { - // Secure ID number + // Secure id number $ext_id = bigintval($ext_id); // Is this extension selected and id valid? @@ -228,7 +221,7 @@ if (isGetRequestElementSet('reg_ext')) { } // END - foreach // Extensions removed - loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSIONS_REMOVED'), $SEL)); + loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSIONS_REMOVED'), countPostSelection())); } elseif ((isGetRequestElementSet('do')) && (!isDemoModeActive())) { // Other things to do $do = SQL_ESCAPE(secureString(getRequestElement('do'))); @@ -267,7 +260,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__); while ($content = SQL_FETCHARRAY($result)) { // Prepare CSS selection output $cssSelection = '---'; - if (getExtensionVersion('sql_patches') >= '0.0.6') $cssSelection = translateYesNo($content['ext_css']); + if (isExtensionInstalledAndNewer('sql_patches', '0.0.6')) $cssSelection = translateYesNo($content['ext_css']); // Prepare data for the row template $content = array( @@ -304,16 +297,16 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__); // Free result SQL_FREERESULT($result); - // Is the ID number valid and the task was found? + // Is the id number valid and the task was found? if (($ext_id > 0) && ($task_found == 1)) { - // ID is valid so begin with registration, we first want to it's real name from task management (subject column) + // id is valid so begin with registration, we first want to it's real name from task management (subject column) $result = SQL_QUERY_ESC("SELECT `subject` FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `id`=%s LIMIT 1", array(bigintval($ext_id)), __FILE__, __LINE__); list($subj) = SQL_FETCHROW($result); SQL_FREERESULT($result); // Disable cache update by default - $cache_update = 0; + $cache_update = '0'; if (!empty($subj)) { // Extract extension's name from subject... $ext_name = trim(substr($subj, 1, strpos($subj, ':') - 1)); @@ -326,7 +319,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__); // ... so we can finally register and load it in registration mode if (registerExtension($ext_name, $ext_id)) { // Errors? - if (getTotalFatalErrors() == 0) { + if (getTotalFatalErrors() == '0') { // Extension was found and successfully registered loadTemplate('admin_settings_saved', false, sprintf(getMessage('ADMIN_EXTENSION_REGISTERED'), $ext_name)); @@ -374,7 +367,7 @@ ORDER BY `ext_name` ASC", __FILE__, __LINE__); // No longer assigned or old task loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_ASSIGED')); } else { - // ID is invalid + // id is invalid loadTemplate('admin_settings_saved', false, getMessage('ADMIN_REG_FAILED_INVALID')); } break;