X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-list_holiday.php;h=a296d9f4468f5b138656578b33b9beab11ed3e1a;hp=6ad367aac8d33a5e19161628b1752938c3b71172;hb=e01fcf1ca8ddeb72af76465df3ef72301a1cdae7;hpb=963e55ca1ea79e255f235e359cde9f7862191dc5

diff --git a/inc/modules/admin/what-list_holiday.php b/inc/modules/admin/what-list_holiday.php
index 6ad367aac8..a296d9f446 100644
--- a/inc/modules/admin/what-list_holiday.php
+++ b/inc/modules/admin/what-list_holiday.php
@@ -10,7 +10,12 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Alle Urlaubsschaltungen auflisten                *
  * -------------------------------------------------------------------- *
- *                                                                      *
+ * $Revision:: 856                                                    $ *
+ * $Date:: 2009-03-06 20:24:32 +0100 (Fr, 06. March 2009)             $ *
+ * $Tag:: 0.2.1-FINAL                                                 $ *
+ * $Author:: stelzi                                                   $ *
+ * Needs to be in all Files and every File needs "svn propset           *
+ * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2008 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
@@ -38,30 +43,32 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", basename(__FILE__));
+ADD_DESCR("admin", __FILE__);
 
 // Start listing holiday requests
-$result = SQL_QUERY("SELECT h.id, h.userid, h.holiday_start, h.holiday_end, h.comments, d.status, d.last_online FROM "._MYSQL_PREFIX."_user_holidays AS h, "._MYSQL_PREFIX."_user_data AS d WHERE h.userid=d.userid ORDER BY h.userid", __FILE__, __LINE__);
+$result = SQL_QUERY("SELECT h.id, h.userid, h.holiday_start, h.holiday_end, h.comments, d.status, d.last_online
+FROM `{!_MYSQL_PREFIX!}_user_holidays` AS h
+LEFT JOIN `{!_MYSQL_PREFIX!}_user_data` AS d
+ON h.userid=d.userid
+ORDER BY h.userid", __FILE__, __LINE__);
 
-if (SQL_NUMROWS($result) > 0)
-{
+if (SQL_NUMROWS($result) > 0) {
 	// List all holiday requests
-	$SW = 2; $OUT = "";
-	while (list($id, $uid, $start, $end, $comments, $status, $last) = SQL_FETCHROW($result))
-	{
+	$OUT = ""; $SW = 2;
+	while ($content = SQL_FETCHARRAY($result)) {
 		// Add three dashes to comment when it is empty
-		if (empty($comments)) $comments = "---";
+		if (empty($content['comments'])) $content['comments'] = "---";
 
 		// Prepare data for the row template
 		$content = array(
 			'sw'       => $SW,
-			'id'       => $id,
-			'uid'      => ADMIN_USER_PROFILE_LINK($uid),
-			'start'    => MAKE_DATETIME($start, "3"),
-			'end'      => MAKE_DATETIME($end, "3"),
-			'comments' => wordwrap($comments, 15),
-			'status'   => TRANSLATE_STATUS($status),
-			'last'     => MAKE_DATETIME($last, "3"),
+			'id'       => $content['id'],
+			'uid'      => ADMIN_USER_PROFILE_LINK($content['userid']),
+			'start'    => MAKE_DATETIME($content['holiday_start'], "3"),
+			'end'      => MAKE_DATETIME($content['holiday_end'], "3"),
+			'comments' => wordwrap($content['comments'], 15),
+			'status'   => TRANSLATE_STATUS($content['status']),
+			'last'     => MAKE_DATETIME($content['last_online'], "3"),
 		);
 
 		// Load row template and switch color
@@ -71,15 +78,16 @@ if (SQL_NUMROWS($result) > 0)
 
 	// Free memory
 	SQL_FREERESULT($result);
+
+	// @TODO Rewrite this constant
 	define('__HOLIDAY_ROWS', $OUT);
 
 	// Load main template
 	LOAD_TEMPLATE("admin_list_holiday");
-}
- else
-{
+} else {
 	// No holiday requests found
-	LOAD_TEMPLATE("admin_settings_saved", false, HOLIDAY_ADMIN_NOTHING_FOUND);
+	LOAD_TEMPLATE("admin_settings_saved", false, getMessage('HOLIDAY_ADMIN_NOTHING_FOUND'));
 }
+
 //
 ?>