X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-list_links.php;h=3fe8031108deaa70e04820e6bc83407baa79d947;hp=1cb8786dab5107c7235a618a7103246a0c721aa8;hb=2b388c21a07e07317ccb065d42ef7304cfca7718;hpb=75ad748a68473ace540251427a74fb781b1145e9

diff --git a/inc/modules/admin/what-list_links.php b/inc/modules/admin/what-list_links.php
index 1cb8786dab..3fe8031108 100644
--- a/inc/modules/admin/what-list_links.php
+++ b/inc/modules/admin/what-list_links.php
@@ -10,7 +10,12 @@
  * -------------------------------------------------------------------- *
  * Kurzbeschreibung  : Unbestaetigte Mails eines Mitgliedes auflisten   *
  * -------------------------------------------------------------------- *
- *                                                                      *
+ * $Revision:: 856                                                    $ *
+ * $Date::                                                            $ *
+ * $Tag:: 0.2.1-FINAL                                                 $ *
+ * $Author::                                                          $ *
+ * Needs to be in all Files and every File needs "svn propset           *
+ * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2008 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
@@ -32,23 +37,23 @@
  ************************************************************************/
 
 // Some security stuff...
-if ((ereg(basename(__FILE__), $_SERVER['PHP_SELF'])) || (!IS_ADMIN())) {
+if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 	$INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
 	require($INC);
 } elseif (!EXT_IS_ACTIVE("mailid")) {
-	ADD_FATAL(sprintf(EXTENSION_PROBLEM_NOT_INSTALLED, "mailid"));
+	addFatalMessage(__FILE__, __LINE__, getMessage('EXTENSION_PROBLEM_EXT_INACTIVE'), "mailid");
 	return;
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", basename(__FILE__));
+ADD_DESCR("admin", __FILE__);
 
-if (empty($_GET['del'])) $_GET['del'] = "";
+if (!REQUEST_ISSET_GET('del')) REQUEST_SET_GET('del', "");
 
-if (!empty($_GET['u_id'])) {
+if (REQUEST_ISSET_GET(('uid'))) {
 	// Check if the user already exists
-	$result = SQL_QUERY_ESC("SELECT surname, family, email FROM "._MYSQL_PREFIX."_user_data WHERE userid=%d LIMIT 1",
-	 array(bigintval($_GET['u_id'])), __FILE__, __LINE__);
+	$result = SQL_QUERY_ESC("SELECT surname, family, email FROM `{!_MYSQL_PREFIX!}_user_data` WHERE userid=%s LIMIT 1",
+		array(bigintval(REQUEST_GET('uid'))), __FILE__, __LINE__);
 
 	 // Is there an entry?
 	if (SQL_NUMROWS($result) == 1) {
@@ -59,12 +64,12 @@ if (!empty($_GET['u_id'])) {
 		// Grab user's all unconfirmed mails
 		if (EXT_IS_ACTIVE("bonus")) {
 			// Load bonus ID
-			$result = SQL_QUERY_ESC("SELECT stats_id, bonus_id, link_type FROM "._MYSQL_PREFIX."_user_links WHERE userid=%d ORDER BY id",
-			 array(bigintval($_GET['u_id'])), __FILE__, __LINE__);
+			$result = SQL_QUERY_ESC("SELECT stats_id, bonus_id, link_type FROM `{!_MYSQL_PREFIX!}_user_links` WHERE userid=%s ORDER BY `id`",
+				array(bigintval(REQUEST_GET('uid'))), __FILE__, __LINE__);
 		} else {
 			// Load stats ID (2nd will be ignored later! But it is needed for the same fetchrow command)
-			$result = SQL_QUERY_ESC("SELECT stats_id, stats_id, link_type FROM "._MYSQL_PREFIX."_user_links WHERE userid=%d ORDER BY id",
-			 array(bigintval($_GET['u_id'])), __FILE__, __LINE__);
+			$result = SQL_QUERY_ESC("SELECT stats_id, stats_id, link_type FROM `{!_MYSQL_PREFIX!}_user_links` WHERE userid=%s ORDER BY `id`",
+				array(bigintval(REQUEST_GET('uid'))), __FILE__, __LINE__);
 		}
 
 		// Get number of rows from the query
@@ -72,37 +77,50 @@ if (!empty($_GET['u_id'])) {
 
 		if ($nums > 0) {
 			// Some unconfirmed mails left
-			if ($_GET['del'] == "all") {
+			if (REQUEST_GET('del') == "all") {
 				// Delete all unconfirmed mails by this user
-				$result_del = SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM "._MYSQL_PREFIX."_user_links WHERE userid=%d LIMIT %s",
-				 array(bigintval($_GET['u_id']), $nums), __FILE__, __LINE__);
+				SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_user_links` WHERE userid=%s LIMIT %s",
+					array(bigintval(REQUEST_GET('uid')), $nums), __FILE__, __LINE__);
 
 				// Prepare mail and send it away
-				$msg = LOAD_EMAIL_TEMPLATE("admin-del_links", $nums, bigintval($_GET['u_id']));
-				SEND_EMAIL($email, ADMIN_DEL_LINK_SUBJ, $msg);
+				$msg = LOAD_EMAIL_TEMPLATE("admin-del_links", $nums, bigintval(REQUEST_GET('uid')));
+				SEND_EMAIL($email, getMessage('ADMIN_DEL_LINK_SUBJ'), $msg);
 
 				// Display message
-				LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_LINKS_DELETED);
+				LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_LINKS_DELETED'));
 			} else {
+				// Init variables
+				$OUT = ""; $SW = 2;
+
 				// List all unconfirmed mails
-				$SW = 2; $OUT = "";
+				// @TODO Find a way to rewrite this. See some lines above for different queries
 				while (list($id, $id2, $type) = SQL_FETCHROW($result)) {
-					// Load data from stats table...
+					// Initializes some variables
 					$cat = "";
+					$DATA = "";
+					$PROBLEM = getMessage('GENERAL_MAIL_PROBLEM');
+					$result_data = false; // Closes Bug #58
+
+					// Load data from stats table...
 					switch ($type)
 					{
 					case "NORMAL":
-						$result_data = SQL_QUERY_ESC("SELECT subject, timestamp_ordered, cat_id FROM "._MYSQL_PREFIX."_user_stats WHERE id=%d LIMIT 1",
-						 array(bigintval($id)), __FILE__, __LINE__);
-						$TYPE = "mailid"; $DATA = $id; $PROBLEM = NORMAL_MAIL_PROBLEM;
-						$LINK = "<A href=\"".URL."/mailid.php?uid=".$_GET['u_id']."&amp;mailid=".$id."\" target=\"_blank\">".$id."</A>";
+						$result_data = SQL_QUERY_ESC("SELECT subject, timestamp_ordered, cat_id FROM `{!_MYSQL_PREFIX!}_user_stats` WHERE id=%s LIMIT 1",
+							array(bigintval($id)), __FILE__, __LINE__);
+						$type = "mailid"; $DATA = $id; $PROBLEM = getMessage('NORMAL_MAIL_PROBLEM');
+						$LINK = "<a href=\"{!URL!}/mailid.php?uid=".REQUEST_GET('uid')."&amp;mailid=".$id."\" target=\"_blank\">".$id."</a>";
 						break;
 
 					case "BONUS":
-						$result_data = SQL_QUERY_ESC("SELECT subject, timestamp, cat_id FROM "._MYSQL_PREFIX."_bonus WHERE id=%d LIMIT 1",
-						 array(bigintval($id2)), __FILE__, __LINE__);
-						$TYPE = "bonusid"; $DATA = $id2; $PROBLEM = BONUS_MAIL_PROBLEM;
-						$LINK = "<A href=\"".URL."/mailid.php?uid=".$_GET['u_id']."&amp;bonusid=".$id2."\" target=\"_blank\">".$id2."</A>";
+						$result_data = SQL_QUERY_ESC("SELECT subject, timestamp, cat_id FROM `{!_MYSQL_PREFIX!}_bonus` WHERE id=%s LIMIT 1",
+							array(bigintval($id2)), __FILE__, __LINE__);
+						$type = "bonusid"; $DATA = $id2; $PROBLEM = getMessage('BONUS_MAIL_PROBLEM');
+						$LINK = "<a href=\"{!URL!}/mailid.php?uid=".REQUEST_GET('uid')."&amp;bonusid=".$id2."\" target=\"_blank\">".$id2."</a>";
+						break;
+
+					default: // Problem in application detected!
+						// Log the error
+						DEBUG_LOG(__FILE__, __LINE__, sprintf("Invalid email type %s detected.", $type));
 						break;
 					}
 
@@ -110,7 +128,7 @@ if (!empty($_GET['u_id'])) {
 						// Mail was found!
 						list($subject, $timestamp, $cat) = SQL_FETCHROW($result_data);
 						SQL_FREERESULT($result_data);
-						if (empty($subject)) $subject = DEFAULT_SUBJECT_LINE;
+						if (empty($subject)) $subject = getMessage('DEFAULT_SUBJECT_LINE');
 
 						// Prepare data for the row template
 						$content = array(
@@ -142,21 +160,21 @@ if (!empty($_GET['u_id'])) {
 				// Remember list in constant for the template
 				define('__SNAME_VALUE', $sname);
 				define('__FNAME_VALUE', $fname);
-				define('__EMAIL_VALUE', "<A href=\"".CREATE_EMAIL_LINK($email, "user_data")."\">".$email."</A>");
+				define('__EMAIL_VALUE', "<a href=\"".CREATE_EMAIL_LINK($email, "user_data")."\">".$email."</a>");
 				define('__EMAIL_LIST' , $OUT);
 				define('__NUMS_VALUE' , $nums);
-				define('__UID_VALUE'  , $_GET['u_id']);
+				define('__UID'        , bigintval(REQUEST_GET('uid')));
 
 				// Load final template
 				LOAD_TEMPLATE("admin_list_links");
 			}
 		} else {
 			// No mails left to confirm
-			LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_MEMBER_LINKS_1.$_GET['u_id'].ADMIN_MEMBER_LINKS_2);
+			LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_MEMBER_LINKS'), REQUEST_GET('uid')));
 		}
 	} else {
 		// User not found
-		LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_MEMBER_404_1.$_GET['u_id'].ADMIN_MEMBER_404_2);
+		LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_MEMBER_404'), REQUEST_GET('uid')));
 	}
 } else {
 	// Output selection form with all confirmed user accounts listed