X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-list_payouts.php;h=d53474bca9cb97364480c757f01aa6e19aa3b8c5;hp=bef227701f8ebd4e92dcacb3e21c81817d499f3b;hb=6914ebaaae909093df86d010e4c754a43d1a1aed;hpb=648afd5e9ca91e878a755fdb5438ac6103a4ac7e

diff --git a/inc/modules/admin/what-list_payouts.php b/inc/modules/admin/what-list_payouts.php
index bef227701f..d53474bca9 100644
--- a/inc/modules/admin/what-list_payouts.php
+++ b/inc/modules/admin/what-list_payouts.php
@@ -45,7 +45,7 @@ if ((!defined('__SECURITY')) || (!isAdmin())) {
 // Add description as navigation point
 addMenuDescription('admin', __FILE__);
 
-if (isGetRequestParameterSet(('pid'))) {
+if (isGetRequestParameterSet('pid')) {
 	// First let's get the member's id
 	$result = SQL_QUERY_ESC("SELECT userid, target_account, payout_total, payout_timestamp, password FROM `{?_MYSQL_PREFIX?}_user_payouts` WHERE `id`=%s LIMIT 1",
 		array(getRequestParameter('pid')), __FILE__, __LINE__);
@@ -53,29 +53,29 @@ if (isGetRequestParameterSet(('pid'))) {
 	SQL_FREERESULT($result);
 
 	// Obtain some data
-	if (!isGetRequestParameterSet(('task')) && (!empty($userid)) && ($userid > 0)) {
+	if (!isGetRequestParameterSet('task') && (!empty($userid)) && (isValidUserId($userid))) {
 		// Get task id from database
 		$result = SQL_QUERY_ESC("SELECT `id` FROM `{?_MYSQL_PREFIX?}_task_system` WHERE `userid`=%s AND `task_type`='PAYOUT_REQUEST' AND `task_created`=%s LIMIT 1",
 			array(bigintval($userid), bigintval($tstamp)), __FILE__, __LINE__);
-		list($task) = SQL_FETCHROW($result);
+		list($taskId) = SQL_FETCHROW($result);
 		SQL_FREERESULT($result);
-		if (empty($task)) $task = '0';
+		if (empty($taskId)) $taskId = '0';
 	} elseif ((empty($userid)) || ($userid == '0')) {
 		// Cannot obtain member id!
-		loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_FAILED_OBTAIN_USERID'));
+		loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_FAILED_OBTAIN_USERID--}');
 	} else {
 		// Get task id from URL
-		$task = getRequestParameter('task');
+		$taskId = getRequestParameter('task');
 	}
 
-	if ((!empty($task)) && (!empty($userid)) && ($userid > 0)) {
+	if ((!empty($taskId)) && (!empty($userid)) && (isValidUserId($userid))) {
 		// Load user's data
 		if (!fetchUserData($userid)) {
 			// Abort here because it is not valid!
 			debug_report_bug(__FILE__, __LINE__, 'No user account ' . $userid . ' found.');
 		} // END - if
 
-		if ((getRequestParameter('do') == 'accept') && (!empty(getUserData('email')))) {
+		if ((getRequestParameter('do') == 'accept') && (getUserData('email') != '')) {
 			// Ok, now we can output the form or execute accepting
 			if (isFormSent()) {
 				// Obtain payout type and other data
@@ -117,7 +117,7 @@ LIMIT 1",
 								$data['from_pass'] = base64_encode($data['from_pass']);
 								$tpass = base64_encode($tpass);
 								break;
-						}
+						} // END - switch
 
 						// Transfer variables...
 						$reason = encodeString(getMessage('ADMIN_PAYOUT_REASON'), false);
@@ -131,8 +131,8 @@ LIMIT 1",
 
 					if ($ret[0] == $data['engine_ret_ok']) {
 						// Clear task
-						if ($task > 0) {
-							runFilterChain('solve_task', $task);
+						if ($taskId > 0) {
+							runFilterChain('solve_task', $taskId);
 						}
 
 						// Clear payout request
@@ -145,14 +145,14 @@ LIMIT 1",
 						// Output message
 						if ($data['allow_url'] == 'Y') {
 							// Banner / Textlink request
-							loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_BANNER_ACCEPTED_NOTIFIED'));
+							loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_BANNER_ACCEPTED_NOTIFIED--}');
 						} else {
 							// Normal request
-							loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_ACCEPTED_NOTIFIED'));
+							loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_ACCEPTED_NOTIFIED--}');
 						}
 
 						// Finally send mail
-						sendEmail(getUserData('email'), getMessage('MEMBER_PAYOUT_ACCEPTED_SUBJECT'), $message);
+						sendEmail(getUserData('email'), '{--MEMBER_PAYOUT_ACCEPTED_SUBJECT--}', $message);
 					} else {
 						// Something goes wrong... :-(
 						$content = implode('<br />', $ret);
@@ -160,12 +160,12 @@ LIMIT 1",
 					}
 				} else {
 					// Cannot load payout id
-					loadTemplate('admin_settings_saved', false, '<div class="admin_failed">{--ADMIN_PAYOUT_FAILED_OBTAIN_PAYOUT_ID--}</div>');
+					loadTemplate('admin_settings_unsaved', false, '{--ADMIN_PAYOUT_FAILED_OBTAIN_PAYOUT_ID--}');
 				}
 			} else {
 				// Prepare content
 				$content = array(
-					'task' => $task,
+					'task' => $taskId,
 					'pid'  => bigintval(getRequestParameter('pid')),
 					'user' => '<a href="' . generateEmailLink(getUserData('email'), 'user_data') . '">' . translateGender(getUserData('gender')) . ' ' . getUserData('surname') . ' ' . getUserData('family') . '</a>',
 				);
@@ -173,12 +173,12 @@ LIMIT 1",
 				// Load template
 				loadTemplate('admin_payout_accept_form', false, $content);
 			}
-		} elseif ((getRequestParameter('do') == 'reject') && (!empty(getUserData('email')))) {
+		} elseif ((getRequestParameter('do') == 'reject') && (getUserData('email') != '')) {
 			// Ok, now we can output the form or execute rejecting
 			if (isFormSent()) {
-				if ($task > 0) {
+				if ($taskId > 0) {
 					// Clear task
-					runFilterChain('solve_task', $task);
+					runFilterChain('solve_task', $taskId);
 				} // END - if
 
 				// Clear payout request
@@ -189,14 +189,14 @@ LIMIT 1",
 				$message = loadEmailTemplate('member_payout_rejected', postRequestParameter('text'), $userid);
 
 				// Output message
-				loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_REJECTED_NOTIFIED'));
+				loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_REJECTED_NOTIFIED--}');
 
 				// Finally send mail
-				sendEmail(getUserData('email'), getMessage('MEMBER_PAYOUT_REJECTED_SUBJECT'), $message);
+				sendEmail(getUserData('email'), '{--MEMBER_PAYOUT_REJECTED_SUBJECT--}', $message);
 			} else {
 				// Prepare content
 				$content = array(
-					'task' => $task,
+					'task' => $taskId,
 					'pid'  => bigintval(getRequestParameter('pid')),
 					'user' => '<a href="' . generateEmailLink(getUserData('email'), 'user_data') . '">' . translateGender(getUserData('gender')) . ' ' . getUserData('surname') . ' ' . getUserData('family') . '</a>',
 				);
@@ -206,11 +206,11 @@ LIMIT 1",
 			}
 		} else {
 			// Cannot load user data
-			loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_FAILED_OBTAIN_USERDATA'));
+			loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_FAILED_OBTAIN_USERDATA--}');
 		}
-	} elseif ((empty($task)) || ($task == '0')) {
+	} elseif ((empty($taskId)) || ($taskId == '0')) {
 		// Failed loading task id
-		loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_FAILED_OBTAIN_TASK_ID'));
+		loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_FAILED_OBTAIN_TASK_ID--}');
 	}
 } else {
 	if (getRequestParameter('do') == 'delete') {
@@ -233,9 +233,9 @@ ON
 ORDER BY
 	p.payout_timestamp DESC", __FILE__, __LINE__);
 
-	if (SQL_NUMROWS($result) > 0) {
+	if (!SQL_HASZERONUMS($result)) {
 		// List found payouts
-		$OUT = ''; $SW = 2;
+		$OUT = '';
 		while ($content = SQL_FETCHARRAY($result)) {
 			if ($content['status'] == 'NEW') {
 				// Generate links for direct accepting and rejecting
@@ -243,7 +243,6 @@ ORDER BY
 			} else {
 				// Translate status
 				$content['status'] = translatePayoutStatus($content['status']);
-				$content['status'] = '<div class="admin_failed">' . $content['status'] . '</div>';
 			}
 
 			// Nothing entered must be secured in member/what-payputs.php !
@@ -259,19 +258,13 @@ ORDER BY
 
 				// Admins can addionally test the URL for framekillers
 				$content['target_bank'] = '<a href="' . generateFrametesterUrl($content['url']) . '" target="_blank">{--CLICK_HERE--}</a>';
-			} else {
-				// e-currency payout request
-				if (empty($content['target_account'])) $content['target_account'] = '---';
-				if (empty($content['target_bank']))    $content['target_bank']    = '---';
-			}
+			} // END - if
 
 			// Add/Translate some data
-			$content['sw']               = $SW;
 			$content['payout_timestamp'] = generateDateTime($content['payout_timestamp'], 2);
 
 			// Add row and switch color
 			$OUT .= loadTemplate('admin_list_payouts_row', true, $content);
-			$SW = 3 - $SW;
 		} // END - while
 
 		// Free memory
@@ -281,7 +274,7 @@ ORDER BY
 		loadTemplate('admin_list_payouts', false, $OUT);
 	} else {
 		// No payout requests are sent so far
-		loadTemplate('admin_settings_saved', false, getMessage('ADMIN_PAYOUT_NO_REQUESTS_FOUND'));
+		loadTemplate('admin_settings_saved', false, '{--ADMIN_PAYOUT_NO_REQUESTS_FOUND--}');
 	}
 }