X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-list_unconfirmed.php;h=52037dd5c90163d10b11166c4182d76f0b748e1f;hp=a68fe3b08b67fcfb3ca507fef399c7d4b58e2e0d;hb=ec9f020e34a9f2029a2ea0969564dda015beca8a;hpb=e8ca54fe91872ab95a6ffdc4f1268bf18889021d

diff --git a/inc/modules/admin/what-list_unconfirmed.php b/inc/modules/admin/what-list_unconfirmed.php
index a68fe3b08b..52037dd5c9 100644
--- a/inc/modules/admin/what-list_unconfirmed.php
+++ b/inc/modules/admin/what-list_unconfirmed.php
@@ -16,7 +16,7 @@
  * $Author::                                                          $ *
  * -------------------------------------------------------------------- *
  * Copyright (c) 2003 - 2009 by Roland Haeder                           *
- * Copyright (c) 2009, 2010 by Mailer Developer Team                    *
+ * Copyright (c) 2009 - 2011 by Mailer Developer Team                   *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -44,13 +44,16 @@ if ((!defined('__SECURITY')) || (!isAdmin())) {
 addYouAreHereLink('admin', __FILE__);
 
 if (!isExtensionActive('mailid')) {
-	loadTemplate('admin_settings_saved', false, generateExtensionInactiveNotInstalledMessage('mailid'));
+	displayMessage(generateExtensionInactiveNotInstalledMessage('mailid'));
 	return;
 } // END - if
 
 // Don't load the admin_list_unconfirmed template by default
 $listed = false;
 
+// Init query
+$sql = '';
+
 // List confirmation links from normal or bonus mails
 if (isGetRequestParameterSet('mid')) {
 	// SQL query for mail data
@@ -69,10 +72,14 @@ LIMIT 1",
 	);
 
 	// Column, type and id for member's mail
-	$col = 'stats_id'; $type = 'NORMAL'; $ID = '-1';
+	$col = 'stats_id';
+	$type = 'NORMAL';
+	$ID = -1;
 
 	// Load admin_list_unconfirmed template
-	$listed = true; $DATA = getRequestParameter('mid'); $LINK = 'mailid';
+	$listed = true;
+	$DATA = getRequestParameter('mid');
+	$mailType = 'mailid';
 } elseif ((isGetRequestParameterSet('bid')) && (isExtensionActive('bonus'))) {
 	// @TODO This constant might be unused? define('__LIST_UNCON_TITLE', '{--ADMIN_LIST_UNCONFIRMED_BONUS_LINKS--}');
 
@@ -88,28 +95,38 @@ LIMIT 1",
 	);
 
 	// Column, type and id for member's mail
-	$col = 'bonus_id'; $type = 'BONUS'; $ID = getRequestParameter('bid');
+	$col = 'bonus_id';
+	$type = 'BONUS';
+	$ID = getRequestParameter('bid');
 
 	// Load admin_list_unconfirmed template
-	$listed = true; $DATA = $ID; $LINK = 'bonusid';
+	$listed = true;
+	$DATA = $ID;
+	$mailType = 'bonusid';
 } else {
 	// @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus
-	loadTemplate('admin_settings_saved', false, '{--ADMIN_CALL_NOT_DIRECTLY--}');
+	displayMessage('{--ADMIN_CALL_NOT_DIRECTLY--}');
 }
 
 // Shall I display links or not?
-if ($listed === true) {
+if (($listed === true) && (!empty($sql))) {
 	// Load mail data
 	$result_master = SQL_QUERY($sql, __FILE__, __LINE__);
 
 	// Do we have an entry?
 	if (SQL_NUMROWS($result_master) == 1) {
-		// Mail order / bonus mail found!
+		// Mail order / bonus mail found
 		$poolData = SQL_FETCHARRAY($result_master);
 
-		// Transfer data to constants for the template
-		if (($poolData['id'] > 0) && ($ID == '-1')) $ID = $poolData['id'];
-		if ($col == 'bonus_id') $poolData['sender'] = '0';
+		// If there is a pool id and $ID is not set, we take it
+		if (($poolData['id'] > 0) && ($ID == '-1')) {
+			$ID = $poolData['id'];
+		} // END - if
+
+		// Bonus mails do always have a sender 'NULL'
+		if ($col == 'bonus_id') {
+			$poolData['sender'] = null;
+		} // END - if
 
 		// Load unconfirmed mail links. Hmmm, this select query is pretty cool
 		// but it does only show unconfirmed mail links from existing user
@@ -143,7 +160,7 @@ LIMIT %s",
 					// Prepare data for the row template
 					$row = array(
 						'userid' => $row['userid'],
-						'link'   => $LINK,
+						'link'   => $mailType,
 						'id'     => $ID,
 						'email'  => '<a href="' . generateEmailLink($row['email'], 'user_data') . '">' . translateGender($row['gender']) . ' ' . $row['surname'] . ' ' . $row['family'] . '</a>',
 						'status' => $row['status'],
@@ -161,7 +178,7 @@ LIMIT %s",
 			$OUT = loadTemplate('admin_list_unconfirmed_list', true, $OUT);
 		} else {
 			// All links are confirmed... strange, you shall normally not get a link to this place in this scenario... hmmm.
-			$OUT = loadTemplate('admin_settings_saved', true, '{--ADMIN_UNCONFIRMED_NO_LINK_LEFT--}');
+			$OUT = displayMessage('{--ADMIN_UNCONFIRMED_NO_LINK_LEFT--}', true);
 		}
 
 		// Prepare content
@@ -179,17 +196,17 @@ LIMIT %s",
 		// Data in pool or in user_stats not found, so let's find out where data is missing
 		if (countSumTotalData(bigintval($ID), 'pool', 'id', 'id', true) == 1) {
 			// pool table
-			loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_UNCONFIRMED_POOL_MISSING', $ID));
+			displayMessage(getMaskedMessage('ADMIN_UNCONFIRMED_POOL_MISSING', $ID));
 		} elseif (countSumTotalData(bigintval($ID), 'user_stats', 'id', 'pool_id', true) == 1) {
 			// user_stats table
-			loadTemplate('admin_settings_saved', false, getMaskedMessage('ADMIN_UNCONFIRMED_STATS_MISSING', $ID));
+			displayMessage(getMaskedMessage('ADMIN_UNCONFIRMED_STATS_MISSING', $ID));
 		} else {
 			// both or link is invalid
-			loadTemplate('admin_settings_saved', false, '{--ADMIN_UNCONFIRMED_INVALID_LINK--}');
+			displayMessage('{--ADMIN_UNCONFIRMED_INVALID_LINK--}');
 		}
 	} elseif (isGetRequestParameterSet('bid')) {
 		// Data in bonus table not found
-		loadTemplate('admin_settings_saved', false, '{--ADMIN_UNCONFIRMED_INVALID_LINK--}');
+		displayMessage('{--ADMIN_UNCONFIRMED_INVALID_LINK--}');
 	}
 
 	// Free result