X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-list_unconfirmed.php;h=ccc74f2e1fec3b14c58048c18ba29ec397f0692e;hp=5b7b11dcfee94a70e61683b51d8673250e41d999;hb=4c83f0cc7459cad9ec9c1c68963f5365155ee935;hpb=963e55ca1ea79e255f235e359cde9f7862191dc5 diff --git a/inc/modules/admin/what-list_unconfirmed.php b/inc/modules/admin/what-list_unconfirmed.php index 5b7b11dcfe..ccc74f2e1f 100644 --- a/inc/modules/admin/what-list_unconfirmed.php +++ b/inc/modules/admin/what-list_unconfirmed.php @@ -36,60 +36,53 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) { $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php"; require($INC); } elseif (!EXT_IS_ACTIVE("mailid")) { - ADD_FATAL(sprintf(EXTENSION_PROBLEM_NOT_INSTALLED, "mailid")); + addFatalMessage(getMessage('EXTENSION_PROBLEM_EXT_INACTIVE'), "mailid"); return; } // Add description as navigation point -ADD_DESCR("admin", basename(__FILE__)); +ADD_DESCR("admin", __FILE__); // Don't load the admin_list_unconfirmed template by default $listed = false; -if (!empty($_GET['mid'])) -{ +if (REQUEST_ISSET_GET(('mid'))) { // List confirmation links from your member's mail orders - define('__LIST_UNCON_TITLE', LIST_UNCONFIRMED_MEMBER_LINKS); + define('__LIST_UNCON_TITLE', getMessage('LIST_UNCONFIRMED_MEMBER_LINKS')); // SQL query for mail data - $SQL = "SELECT DISTINCT s.id, p.sender, p.subject, p.text, p.url, p.timestamp, s.max_rec FROM "._MYSQL_PREFIX."_pool AS p -LEFT JOIN "._MYSQL_PREFIX."_user_stats AS s + $SQL = "SELECT DISTINCT s.id, p.sender, p.subject, p.text, p.url, p.timestamp, s.max_rec FROM `{!_MYSQL_PREFIX!}_pool` AS p +LEFT JOIN `{!_MYSQL_PREFIX!}_user_stats` AS s ON p.id=s.pool_id -WHERE p.id='".$_GET['mid']."' LIMIT 1"; +WHERE p.id='".REQUEST_GET('mid')."' LIMIT 1"; // Column, type and ID for member's mail $col = "stats_id"; $type = "NORMAL"; $ID = "-1"; // Load admin_list_unconfirmed template - $listed = true; $DATA = $_GET['mid']; $LINK = "mailid"; -} - elseif ((!empty($_GET['bid'])) && (EXT_IS_ACTIVE("bonus"))) -{ + $listed = true; $DATA = REQUEST_GET('mid'); $LINK = "mailid"; +} elseif ((REQUEST_ISSET_GET(('bid'))) && (EXT_IS_ACTIVE("bonus"))) { // List confirmation links from bonus mails - define('__LIST_UNCON_TITLE', LIST_UNCONFIRMED_BONUS_LINKS); + define('__LIST_UNCON_TITLE', getMessage('LIST_UNCONFIRMED_BONUS_LINKS')); // SQL query for mail data (both ids are required for compatiblity to above normal mail - $SQL = "SELECT id, id, subject, text, url, timestamp, mails_sent FROM "._MYSQL_PREFIX."_bonus WHERE id='".$_GET['bid']."' LIMIT 1"; + $SQL = "SELECT id, id, subject, text, url, timestamp, mails_sent FROM `{!_MYSQL_PREFIX!}_bonus` WHERE id='".REQUEST_GET('bid')."' LIMIT 1"; // Column, type and ID for member's mail - $col = "bonus_id"; $type = "BONUS"; $ID = $_GET['bid']; + $col = "bonus_id"; $type = "BONUS"; $ID = REQUEST_GET('bid'); // Load admin_list_unconfirmed template $listed = true; $DATA = $ID; $LINK = "bonusid"; -} - else -{ +} else { // "Please do not call me directly." - LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_CALL_NOT_DIRECTLY); + LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_CALL_NOT_DIRECTLY')); } // Shall I display links or not? -if ($listed) -{ +if ($listed === true) { // Load mail data $result = SQL_QUERY($SQL, __FILE__, __LINE__); - if (SQL_NUMROWS($result) == 1) - { + if (SQL_NUMROWS($result) == 1) { // Mail order / bonus mail found! list($stats_id, $sender, $subj, $text, $url, $stamp, $max) = SQL_FETCHROW($result); SQL_FREERESULT($result); @@ -100,7 +93,7 @@ if ($listed) define('__LIST_UNCON_SENDER' , $sender); define('__LIST_UNCON_SUBJECT', COMPILE_CODE($subj)); define('__LIST_UNCON_TEXT' , COMPILE_CODE($text)); - define('__LIST_UNCON_URL' , urlencode(base64_encode($url))); + define('__LIST_UNCON_URL' , encodeString($url)); define('__LIST_UNCON_STAMP' , MAKE_DATETIME($stamp, "2")); // Load unconfirmed mail links. Hmmm, this select query is pretty cool @@ -108,21 +101,19 @@ if ($listed) // accounts. So if you have delete one you did not see those links // $result = SQL_QUERY_ESC("SELECT DISTINCT l.userid, u.status, u.surname, u.family, u.gender, u.email -FROM "._MYSQL_PREFIX."_user_links AS l -LEFT JOIN "._MYSQL_PREFIX."_user_data AS u +FROM `{!_MYSQL_PREFIX!}_user_links` AS l +LEFT JOIN `{!_MYSQL_PREFIX!}_user_data` AS u ON l.userid=u.userid WHERE l.%s='%s' ORDER BY l.userid LIMIT %s", - array($col, $ID, bigintval($max)),__FILE__, __LINE__); + array($col, $ID, bigintval($max)),__FILE__, __LINE__); $unconfirmed = SQL_NUMROWS($result); define('__LIST_UNCO_UNCONFIRMED', $unconfirmed); - if ($unconfirmed > 0) - { + if ($unconfirmed > 0) { // At least one link left to confirm $OUT = LOAD_TEMPLATE("admin_list_unconfirmed_header", true); $SW = 2; - while(list($uid, $status, $sname, $fname, $gender, $email) = SQL_FETCHROW($result)) - { + while (list($uid, $status, $sname, $fname, $gender, $email) = SQL_FETCHROW($result)) { // Prepare data for the row template $content = array( 'sw' => $SW, @@ -130,7 +121,7 @@ WHERE l.%s='%s' ORDER BY l.userid LIMIT %s", 'uid' => $uid, 'link' => $LINK, 'id' => $ID, - 'email' => "".TRANSLATE_GENDER($gender)." ".$sname." ".$fname."", + 'email' => "".TRANSLATE_GENDER($gender)." ".$sname." ".$fname."", 'status' => TRANSLATE_STATUS($status), ); @@ -138,55 +129,45 @@ WHERE l.%s='%s' ORDER BY l.userid LIMIT %s", $OUT .= LOAD_TEMPLATE("admin_list_unconfirmed_row", true, $content); $SW = 3 - $SW; } - $OUT .= "\n"; + $OUT .= "\n"; // Free memory SQL_FREERESULT($result); // Store table rows in a constant define('__LIST_UNCON_LISTING', $OUT); - } - else - { + } else { // All links are confirmed... strange, you shall normally not get a link to this place in this scenario... hmmm. - define('__LIST_UNCON_LISTING', LOAD_TEMPLATE("admin_settings_saved", true, ADMIN_UNCONFIRMED_NO_LINK_LEFT)); + define('__LIST_UNCON_LISTING', LOAD_TEMPLATE("admin_settings_saved", true, getMessage('ADMIN_UNCONFIRMED_NO_LINK_LEFT'))); } // Load final template LOAD_TEMPLATE("admin_list_unconfirmed"); - } - elseif ($_GET['mid'] > 0) - { + } elseif (REQUEST_GET('mid') > 0) { // Data in pool or in user_stats not found, so let's find out where data is missing - $result1 = SQL_QUERY_ESC("SELECT id FROM "._MYSQL_PREFIX."_pool WHERE id=%s LIMIT 1", - array(bigintval($ID)), __FILE__, __LINE__); - $result2 = SQL_QUERY_ESC("SELECT id FROM "._MYSQL_PREFIX."_user_stats WHERE pool_id=%s LIMIT 1", - array(bigintval($ID)), __FILE__, __LINE__); - if (SQL_NUMROWS($result1) == 1) - { + $result1 = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_pool` WHERE id=%s LIMIT 1", + array(bigintval($ID)), __FILE__, __LINE__); + $result2 = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_user_stats` WHERE pool_id=%s LIMIT 1", + array(bigintval($ID)), __FILE__, __LINE__); + if (SQL_NUMROWS($result1) == 1) { // pool table - LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_UNCONFIRMED_POOL_MISSING_1.$ID.ADMIN_UNCONFIRMED_POOL_MISSING_2); - } - elseif (SQL_NUMROWS($result2) == 1) - { + LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_UNCONFIRMED_POOL_MISSING', $ID))); + } elseif (SQL_NUMROWS($result2) == 1) { // user_stats table - LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_UNCONFIRMED_STATS_MISSING_1.$ID.ADMIN_UNCONFIRMED_STATS_MISSING_2); - } - else - { + LOAD_TEMPLATE("admin_settings_saved", false, sprintf(getMessage('ADMIN_UNCONFIRMED_STATS_MISSING', $ID))); + } else { // both or link is invalid - LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_UNCONFIRMED_INVALID_LINK); + LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_UNCONFIRMED_INVALID_LINK')); } // Free memory SQL_FREERESULT($result1); SQL_FREERESULT($result2); - } - elseif (!empty($_GET['bid'])) - { + } elseif (REQUEST_ISSET_GET(('bid'))) { // Data in bonus table not found - LOAD_TEMPLATE("admin_settings_saved", false, ADMIN_UNCONFIRMED_INVALID_LINK); + LOAD_TEMPLATE("admin_settings_saved", false, getMessage('ADMIN_UNCONFIRMED_INVALID_LINK')); } } + // ?>