X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=inc%2Fmodules%2Fadmin%2Fwhat-refbanner.php;h=c60def4c5b81c47ff7b483b7aeee0bc23bc9a474;hp=7de1f9d38e6e6c960ba03093c257ca3b08798d4d;hb=4001187f22197f55e5a1f211fc8defcc180f7c32;hpb=2e68ea39a430a7217e58747b877acaa3e92ea997

diff --git a/inc/modules/admin/what-refbanner.php b/inc/modules/admin/what-refbanner.php
index 7de1f9d38e..c60def4c5b 100644
--- a/inc/modules/admin/what-refbanner.php
+++ b/inc/modules/admin/what-refbanner.php
@@ -44,28 +44,28 @@ ADD_DESCR("admin", __FILE__);
 $SEL = 0;
 
 // Some sanity-check
-if ((empty($_POST['url'])) || (empty($_POST['alternate']))) {
-	unset($_POST['ok']);
+if ((!REQUEST_ISSET_POST(('url'))) || (!REQUEST_ISSET_POST(('alternate')))) {
+	REQUEST_UNSET_POST('ok');
 }
 
 // Check selection count
-if (!empty($_POST['sel'])) $SEL = SELECTION_COUNT($_POST['sel']);
+if (REQUEST_ISSET_POST('sel')) $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
 
-if (isset($_POST['ok'])) {
+if (IS_FORM_SENT()) {
 	// Fix older calls from add-new-banner-form
-	if (empty($_GET['mode'])) $_GET['mode'] = "add";
-	$SQL = "";
-	switch ($_GET['mode'])
+	if (!REQUEST_ISSET_GET(('mode'))) REQUEST_SET_GET('mode', "add");
+	$sql = "";
+	switch (REQUEST_GET('mode'))
 	{
 	case "add":
 		// Check if banner is already added
-		$result = SQL_QUERY_ESC("SELECT id FROM "._MYSQL_PREFIX."_refbanner WHERE url='%s' LIMIT 1",
-			array($_POST['url']), __FILE__, __LINE__);
+		$result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE url='%s' LIMIT 1",
+			array(REQUEST_POST('url')), __FILE__, __LINE__);
 		if (SQL_NUMROWS($result) == 0) {
 			// Add banner
-			SQL_QUERY_ESC("INSERT INTO "._MYSQL_PREFIX."_refbanner (url, alternate, visible)
+			SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_refbanner` (url, alternate, visible)
 VALUES ('%s','%s','%s')",
-				array($_POST['url'], $_POST['alternate'], $_POST['visible']), __FILE__, __LINE__);
+				array(REQUEST_POST('url'), REQUEST_POST('alternate'), REQUEST_POST('visible')), __FILE__, __LINE__);
 		} else {
 			// Free memory
 			SQL_FREERESULT($result);
@@ -73,30 +73,35 @@ VALUES ('%s','%s','%s')",
 		break;
 
 	case "edit": // Update banner
-		foreach ($_POST['sel'] as $id => $sel) {
+		foreach (REQUEST_POST('sel') as $id => $sel) {
 			// Secure ID
 			$id = bigintval($id);
 
 			// Update entry
-			SQL_QUERY_ESC("UPDATE "._MYSQL_PREFIX."_refbanner SET url='%s', alternate='%s', visible='%s' WHERE id=%s LIMIT 1",
-				array($_POST['url'][$id], $_POST['alternate'][$id], $_POST['visible'], $id), __FILE__, __LINE__);
+			SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET url='%s', alternate='%s', `visible`='%s' WHERE id=%s LIMIT 1",
+				array(
+					REQUEST_POST('url', $id),
+					REQUEST_POST('alternate', $id),
+					REQUEST_POST('visible'),
+					$id
+				), __FILE__, __LINE__);
 		}
 		break;
 	}
 
 	if (SQL_AFFECTEDROWS() == 1) {
-		$content = SETTINGS_SAVED;
+		$content = getMessage('SETTINGS_SAVED');
 	} else {
-		$content = "<SPAN class=\"admin_failed\">".SETTINGS_NOT_SAVED."</SPAN>";
+		$content = "<span class=\"admin_failed\">{--SETTINGS_NOT_SAVED--}</span>";
 	}
 	LOAD_TEMPLATE("admin_settings_saved", false, $content);
-} elseif (($SEL > 0) && (isset($_POST['edit']))) {
+} elseif (($SEL > 0) && (REQUEST_ISSET_POST('edit'))) {
 	// Edit banner
 	$SW = ""; $OUT = "";
-	foreach ($_POST['sel'] as $id => $sel) {
+	foreach (REQUEST_POST('sel') as $id => $sel) {
 		// Load data
-		$result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM "._MYSQL_PREFIX."_refbanner WHERE id=%s LIMIT 1",
-		 array(bigintval($id)), __FILE__, __LINE__);
+		$result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
+			array(bigintval($id)), __FILE__, __LINE__);
 		list($url, $alt, $vis) = SQL_FETCHROW($result);
 		SQL_FREERESULT($result);
 
@@ -113,37 +118,38 @@ VALUES ('%s','%s','%s')",
 		$OUT .= LOAD_TEMPLATE("admin_refbanner_edit_row", true, $content);
 		$SW = 3 - $SW;
 	}
+
+	// @TODO Rewrite this constant
 	define('__BANNER_ROWS', $OUT);
 
 	// Load main template
 	LOAD_TEMPLATE("admin_refbanner_edit");
 } else {
-	if (($SEL > 0) && (isset($_POST['del'])))
-	{
+	if (($SEL > 0) && (REQUEST_ISSET_POST('del'))) {
 		// Delete banner
-		foreach ($_POST['sel'] as $id => $sel) {
-			SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM "._MYSQL_PREFIX."_refbanner WHERE id=%s LIMIT 1",
+		foreach (REQUEST_POST('sel') as $id => $sel) {
+			SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
 				array(bigintval($id)), __FILE__, __LINE__);
 		}
 	}
 
 	// Referal levels
-	$result = SQL_QUERY("SELECT id, url, alternate, visible, counter, clicks FROM "._MYSQL_PREFIX."_refbanner ORDER BY url", __FILE__, __LINE__);
-	if (SQL_NUMROWS($result) > 0)
-	{
+	$result = SQL_QUERY("SELECT id, url, alternate, visible, counter, clicks FROM `{!_MYSQL_PREFIX!}_refbanner` ORDER BY url",
+		__FILE__, __LINE__);
+	if (SQL_NUMROWS($result) > 0) {
 		// Make referal banner editable and deletable
-		$SW = 2; $OUT = "";
-		while (list($id, $url, $alt, $vis, $cntr, $clks) = SQL_FETCHROW($result))
-		{
+		$OUT = ""; $SW = 2;
+		while ($content = SQL_FETCHARRAY($result)) {
 			// Preapre data for the row
+			// @TODO Rewritings: alt->alternate,cnt->counter,clx->clicks in template
 			$content = array(
 				'sw'  => $SW,
-				'id'  => $id,
-				'url' => $url,
-				'alt' => $alt,
-				'vis' => TRANSLATE_YESNO($vis),
-				'cnt' => $cntr,
-				'clx' => $clks
+				'id'  => $content['id'],
+				'url' => $content['url'],
+				'alt' => $content['alternate'],
+				'vis' => TRANSLATE_YESNO($content['visible']),
+				'cnt' => $content['counter'],
+				'clx' => $content['clicks']
 			);
 
 			// Load row template and switch color
@@ -153,6 +159,8 @@ VALUES ('%s','%s','%s')",
 
 		// Free memory
 		SQL_FREERESULT($result);
+
+		// @TODO Rewrite this constant
 		define('__BANNER_ROWS', $OUT);
 
 		// Load main template