X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=mailid.php;h=81778853ab2c3ca209b01b62fe0a46dbcf9ed24b;hp=78c1948e26cb5de6fe988dd675d2ff2243b7d49f;hb=7bfee4bc71e5b7b741f3451b27ba0a09574dfca8;hpb=013448f0470ca36ab15b888928e2127e6da7d9b6

diff --git a/mailid.php b/mailid.php
index 78c1948e26..81778853ab 100644
--- a/mailid.php
+++ b/mailid.php
@@ -62,40 +62,39 @@ $url_bid = 0;
 $url_mid = 0;
 
 // Secure all data
-if (isGetRequestElementSet('userid'))     $url_userid = bigintval(getRequestElement('userid'));
-if (isGetRequestElementSet('mailid'))  $url_mid = bigintval(getRequestElement('mailid'));
-if (isGetRequestElementSet('bonusid')) $url_bid = bigintval(getRequestElement('bonusid'));
+if (isGetRequestElementSet('userid'))  $url_userid = bigintval(getRequestElement('userid'));
+if (isGetRequestElementSet('mailid'))  $url_mid    = bigintval(getRequestElement('mailid'));
+if (isGetRequestElementSet('bonusid')) $url_bid    = bigintval(getRequestElement('bonusid'));
 
-// 01        1        12            3    32           21    1                   22     10
+// 01           1        12            2    2            21    1                   22     10
 if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErrors() == 0)) {
+	// Init result
+	$result_link = false;
+
 	// Maybe he wants to confirm an email?
 	if ($url_mid > 0) {
 		// Normal-Mails
-		$result = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `stats_id`=%s AND `userid`=%s LIMIT 1",
+		$result_link = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `stats_id`=%s AND `userid`=%s LIMIT 1",
 			array($url_mid, $url_userid), __FILE__, __LINE__);
 		$type = 'mailid'; $urlId = $url_mid;
 	} elseif ($url_bid > 0) {
 		// Bonus-Mail
-		$result = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `bonus_id`=%s AND `userid`=%s LIMIT 1",
+		$result_link = SQL_QUERY_ESC("SELECT `link_type` FROM `{?_MYSQL_PREFIX?}_user_links` WHERE `bonus_id`=%s AND `userid`=%s LIMIT 1",
 			array($url_bid, $url_userid), __FILE__, __LINE__);
 		$type = 'bonusid'; $urlId = $url_bid;
 	} else {
-		// Problem: No ID entered
+		// Problem: No id entered
 		redirectToUrl('index.php');
 	}
 
-	if (SQL_NUMROWS($result) == 1) {
+	if (SQL_NUMROWS($result_link) == 1) {
 		// Load the entry
-		list($ltype) = SQL_FETCHROW($result);
-
-		// Clean result
-		SQL_FREERESULT($result);
+		list($ltype) = SQL_FETCHROW($result_link);
 
 		// @TODO Rewrite this to a filter
-		switch ($ltype)
-		{
+		switch ($ltype) {
 			case 'NORMAL':
-				// Is the stats ID valid?
+				// Is the stats id valid?
 				$result = SQL_QUERY_ESC("SELECT pool_id, url, subject FROM `{?_MYSQL_PREFIX?}_user_stats` WHERE `id`=%s LIMIT 1",
 					array($url_mid), __FILE__, __LINE__);
 				break;
@@ -124,7 +123,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 			// Set it
 			setExtraTitle($title);
 
-			// Is the user's ID unlocked?
+			// Is the user's id unlocked?
 			$result = SQL_QUERY_ESC("SELECT `status`, `gender`, `surname`, `family` FROM `{?_MYSQL_PREFIX?}_user_data` WHERE `userid`=%s LIMIT 1",
 				array($url_userid), __FILE__, __LINE__);
 			if (SQL_NUMROWS($result) == 1) {
@@ -172,7 +171,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 					// Was that mail a valid one?
 					if ($isValid === true) {
 						// If time is zero seconds we have a sponsor mail. 1 Second shall be set to avoid problems
-						if (($time == '0') && ($payment > 0)) { $URL = getConfig('URL'); $time = '1'; }
+						if (($time == 0) && ($payment > 0)) { $URL = getConfig('URL'); $time = 1; }
 						if (($time > 0) && (($payment > 0) || ($points > 0))) {
 							// Export data into constants for the template
 							$content = array(
@@ -194,17 +193,17 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 					$errorCode = getCode('ACCOUNT_' . $status);
 				}
 			} else {
-				SQL_FREERESULT($result);
 				$errorCode = getCode('USER_404');
 			}
 		} else {
-			SQL_FREERESULT($result);
 			$errorCode = getCode('STATS_404');
 		}
 	} else {
-		SQL_FREERESULT($result);
 		$errorCode = getCode('ALREADY_CONFIRMED');
 	}
+
+	// Free result
+	SQL_FREERESULT($result_link);
 } else {
 	// Nothing entered
 	$errorCode = getCode('ERROR_MAILID');