X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=mailid_top.php;h=927610b030de67121626f827ce3019d8f363ccd7;hp=080fc732011db534bf73e15de08824a46ce6848b;hb=8deeddb48c055d0c2483509b7cd6a95ed6d3a87a;hpb=916bba4f00ee924f0d88b8fc273dee5bfb798aed

diff --git a/mailid_top.php b/mailid_top.php
index 080fc73201..927610b030 100644
--- a/mailid_top.php
+++ b/mailid_top.php
@@ -1,7 +1,7 @@
 <?php
 /************************************************************************
- * MXChange v0.2.1                                    Start: 11/14/2003 *
- * ===============                              Last change: 11/13/2004 *
+ * Mailer v0.2.1-FINAL                                Start: 11/14/2003 *
+ * ===================                          Last change: 11/13/2004 *
  *                                                                      *
  * -------------------------------------------------------------------- *
  * File              : mailid_top.php                                   *
@@ -59,21 +59,21 @@ redirectOnUninstalledExtension('mailid');
 redirectOnUninstalledExtension('other');
 
 // Init variables
-$url_userid = 0;
-$url_bid = 0;
-$url_mid = 0;
-$code = 0;
+$url_userid = '0';
+$url_bid = '0';
+$url_mid = '0';
+$code = '0';
 $mode = '';
 
 // Secure all data
-if (isGetRequestElementSet('userid'))  $url_userid = bigintval(getRequestElement('userid'));
-if (isGetRequestElementSet('mailid'))  $url_mid    = bigintval(getRequestElement('mailid'));
-if (isGetRequestElementSet('bonusid')) $url_bid    = bigintval(getRequestElement('bonusid'));
-if (isGetRequestElementSet('code'))    $code       = bigintval(getRequestElement('code'));
-if (isGetRequestElementSet('mode'))    $mode       = getRequestElement('mode');
+if (isGetRequestParameterSet('userid'))  $url_userid = bigintval(getRequestParameter('userid'));
+if (isGetRequestParameterSet('mailid'))  $url_mid    = bigintval(getRequestParameter('mailid'));
+if (isGetRequestParameterSet('bonusid')) $url_bid    = bigintval(getRequestParameter('bonusid'));
+if (isGetRequestParameterSet('code'))    $code       = bigintval(getRequestParameter('code'));
+if (isGetRequestParameterSet('mode'))    $mode       = getRequestParameter('mode');
 
 // 01           1        12            2    2            21    1                   22     10
-if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErrors() == 0)) {
+if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErrors() == '0')) {
 	// No image? Then output header
 	if ($mode != 'img') loadIncludeOnce('inc/header.php');
 
@@ -125,7 +125,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 			SQL_FREERESULT($result_mailid);
 
 			// Set sender to 0 when we have a bonus mail
-			if ($ltype == 'BONUS') $sender = 0;
+			if ($ltype == 'BONUS') $sender = '0';
 
 			// Is the user id valid?
 			if (fetchUserData($url_userid) === true) {
@@ -171,9 +171,9 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 
 					// Is this entry valid?
 					if ($isValid === true) {
-						if (($time == 0) && ($payment > 0)) $time = 1;
+						if (($time == '0') && ($payment > 0)) $time = 1;
 						if (($time > 0) && ($payment > 0)) {
-							$img_code = 0;
+							$img_code = '0';
 							if (!empty($code)) {
 								// Generate code
 								$img_code = generateRandomCode(getConfig('code_length'), $code, $url_userid, $urlId);
@@ -183,7 +183,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 							switch ($mode) {
 								case 'add':
 									// Init stats data
-									$stats_data = 0;
+									$stats_data = '0';
 
 									// Count clicks
 									// @TODO Rewrite this to a filter
@@ -240,7 +240,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 									insertUserStatsRecord($url_userid, $type, $stats_data);
 
 									// Right code entered?
-									if (bigintval(postRequestElement('gfx_check')) == $img_code) {
+									if (bigintval(postRequestParameter('gfx_check')) == $img_code) {
 										// Add points over referal system is the default
 										$locked = false;
 										$template = 'mailid_points_done';
@@ -288,7 +288,7 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 
 										// Load template
 										loadTemplate($template, false, $content);
-									} else {
+									} elseif ($sender > 0) {
 										// Wrong image code! So add points to sender's account
 										addPointsDirectly('mailid_payback', $sender, $payment);
 
@@ -325,6 +325,9 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 
 										// Load template
 										loadTemplate($templ, false, $content);
+									} else {
+										// Cannot confirm!
+										debug_report_bug('No code given.');
 									}
 									break;
 
@@ -348,30 +351,30 @@ if (($url_userid) > 0 && (($url_mid > 0) || ($url_bid > 0)) && (getTotalFatalErr
 									break;
 							} // END - switch
 						} else {
-							loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (6)</div>");
+							loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (6)</div>');
 							$mode = 'failed';
 						}
 					} else {
-						loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (5)</div>");
+						loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (5)</div>');
 						$mode = 'failed';
 					}
 				} else {
-					loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (4)</div>");
+					loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (4)</div>');
 					$mode = 'failed';
 				}
 			} else {
 				SQL_FREERESULT($result);
-				loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (3)</div>");
+				loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (3)</div>');
 				$mode = 'failed';
 			}
 		} else {
 			SQL_FREERESULT($result);
-			loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (2)</div>");
+			loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (2)</div>');
 			$mode = 'failed';
 		}
 	} else {
 		SQL_FREERESULT($result);
-		loadTemplate('admin_settings_saved', false, "<div class=\"member_failed\">{--MAIL_ALREADY_CONFIRMED--} (1)</div>");
+		loadTemplate('admin_settings_saved', false, '<div class="member_failed">{--MAIL_ALREADY_CONFIRMED--} (1)</div>');
 		$mode = 'failed';
 	}