X-Git-Url: https://git.mxchange.org/?p=mailer.git;a=blobdiff_plain;f=view.php;h=1bfd84b869ef355154c089de42644d97427d7a50;hp=536b8257ac37c45783416bacb603071f742b7d9d;hb=c9eeea4ffb9f186fb8d5207542a0bb0da7028f83;hpb=ccc4a69ce9b17aa8d7b1554a3b2b017db091821b

diff --git a/view.php b/view.php
index 536b8257ac..1bfd84b869 100644
--- a/view.php
+++ b/view.php
@@ -1,7 +1,7 @@
 <?php
 /************************************************************************
- * MXChange v0.2.1                                    Start: 01/02/2004 *
- * ===============                              Last change: 09/04/2004 *
+ * Mailer v0.2.1-FINAL                                Start: 01/02/2004 *
+ * ===================                          Last change: 09/04/2004 *
  *                                                                      *
  * -------------------------------------------------------------------- *
  * File              : view.php                                         *
@@ -17,7 +17,7 @@
  * Needs to be in all Files and every File needs "svn propset           *
  * svn:keywords Date Revision" (autoprobset!) at least!!!!!!            *
  * -------------------------------------------------------------------- *
- * Copyright (c) 2003 - 2008 by Roland Haeder                           *
+ * Copyright (c) 2003 - 2009 by Roland Haeder                           *
  * For more information visit: http://www.mxchange.org                  *
  *                                                                      *
  * This program is free software; you can redistribute it and/or modify *
@@ -39,10 +39,6 @@
 // Load security stuff here
 require('inc/libs/security_functions.php');
 
-// Init "action" and "what"
-$GLOBALS['what'] = '';
-$GLOBALS['action'] = '';
-
 // Set module
 $GLOBALS['module'] = 'view';
 $GLOBALS['output_mode'] = -1;
@@ -50,23 +46,35 @@ $GLOBALS['output_mode'] = -1;
 // Load the required file(s)
 require('inc/config-global.php');
 
-if (((REQUEST_ISSET_GET('user')) || (REQUEST_ISSET_GET('reseller'))) && (REQUEST_ISSET_GET('banner'))) {
-	// for later things... ;-)
-	$result = SQL_QUERY_ESC("SELECT url FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
-	array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+if (((isGetRequestElementSet('user')) || (isGetRequestElementSet('reseller'))) && (isGetRequestElementSet('banner'))) {
+	// For later things... ;-)
+	$result = SQL_QUERY_ESC("SELECT `url` FROM `{?_MYSQL_PREFIX?}_refbanner` WHERE `id`=%s LIMIT 1",
+		array(bigintval(getRequestElement('banner'))), __FILE__, __LINE__);
+
+	// Do we have the banner?
 	if (SQL_NUMROWS($result) == 1) 	{
+		// Load the URL
 		list($url) = SQL_FETCHROW($result);
-		SQL_FREERESULT($result);
-		SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET counter=counter+1 WHERE `id`=%s LIMIT 1",
-		array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
 
+		// Update counter
+		SQL_QUERY_ESC("UPDATE `{?_MYSQL_PREFIX?}_refbanner` SET `counter`=`counter`+1 WHERE `id`=%s LIMIT 1",
+			array(bigintval(getRequestElement('banner'))), __FILE__, __LINE__);
+
+		// Extract type (last 3 chars should be okay)
 		$type = substr($url, -3);
+
+		// Set header and ...
 		sendHeader('Content-Type: image/' . $type);
+
+		// Redirect
 		redirectToUrl($url, false);
 	} else {
-		// Free memory
-		SQL_FREERESULT($result);
+		// @TODO No banner found, output some default banner
+		logDebugMessage(__FILE__, __LINE__, 'Banner ' . bigintval(getRequestElement('banner')) . ' not dound.');
 	}
+
+	// Free memory
+	SQL_FREERESULT($result);
 } else {
 	// Do nothing for now
 	redirectToUrl('index.php');
@@ -75,5 +83,5 @@ if (((REQUEST_ISSET_GET('user')) || (REQUEST_ISSET_GET('reseller'))) && (REQUEST
 // Shutdown
 shutdown();
 
-//
+// [EOF]
 ?>