Missing bracket fixed
authorRoland Häder <roland@mxchange.org>
Sat, 10 Oct 2009 13:15:46 +0000 (13:15 +0000)
committerRoland Häder <roland@mxchange.org>
Sat, 10 Oct 2009 13:15:46 +0000 (13:15 +0000)
DOCS/TODOs.txt
doubler.php
view.php

index 4e70731..6abc5f3 100644 (file)
@@ -3,12 +3,12 @@
 ./beg.php:195:                 // @TODO Opps, what is missing here???
 ./doubler.php:269:// @TODO Rewrite all constants
 ./inc/cache/config-local.php:120:// @TODO Rewrite the following three constants, somehow...
-./inc/config-functions.php:172:        // @TODO Make this all better... :-/
-./inc/config-functions.php:197:        // @TODO Rewrite these all to config entries, if somehow possible
+./inc/config-functions.php:178:        // @TODO Make this all better... :-/
+./inc/config-functions.php:203:        // @TODO Rewrite these all to config entries, if somehow possible
 ./inc/config-global.php:60:// @TODO These constants should be rewritten
-./inc/extensions/ext-sql_patches.php:713:                                              // @TODO Rewrite this to a filter!
-./inc/extensions/ext-sql_patches.php:751:                                      // @TODO Can we remove this? setConfigEntry('verbose_sql'        , 'N');
-./inc/extensions/ext-sql_patches.php:93:               /* @TODO SQL_ALTER_TABLE() should work now properly
+./inc/extensions/ext-sql_patches.php:714:                              // @TODO Rewrite this to a filter!
+./inc/extensions/ext-sql_patches.php:752:                      // @TODO Can we remove this? setConfigEntry('verbose_sql'        , 'N');
+./inc/extensions/ext-sql_patches.php:92:               /* @TODO SQL_ALTER_TABLE() should work now properly
 ./inc/extensions/ext-surfbar.php:238:                          // @TODO Set some constants we need???
 ./inc/extensions.php:345:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) )
 ./inc/extensions.php:427:              // @TODO Extension is loaded, what next?
 ./inc/functions.php:398:               // @TODO Extension 'msg' does not exist
 ./inc/functions.php:477:// @TODO Rewrite this to an extension 'smtp'
 ./inc/install-inc.php:20: * @TODO Rewrite all constants in this include file                     *
-./inc/language/de.php:1159:// @TODO Rewrite these two constants
-./inc/language/de.php:1175:// @TODO Rewrite these five constants
-./inc/language/de.php:756:// @TODO The template 'admin_extensions_installed' is using this. But the template is no longer used.
-./inc/language/de.php:855:// @TODO Are these constants still used?
-./inc/language/de.php:866:// @TODO Are these constants longer used?
+./inc/language/de.php:1160:// @TODO Rewrite these two constants
+./inc/language/de.php:1176:// @TODO Rewrite these five constants
+./inc/language/de.php:757:// @TODO The template 'admin_extensions_installed' is using this. But the template is no longer used.
+./inc/language/de.php:856:// @TODO Are these constants still used?
+./inc/language/de.php:867:// @TODO Are these constants longer used?
 ./inc/language-functions.php:45:// @TODO Rewrite all language constants to this function.
 ./inc/language/holiday_de.php:49:// @TODO Rewrite these two constants to one
 ./inc/language/rallye_de.php:110:// @TODO Rewrite following two lines to one
 ./inc/modules/admin/what-usr_online.php:107:           // @TODO Rewrite this constant
 ./inc/modules/admin/what-usr_online.php:51:    // @TODO Rewrite these constants
 ./inc/modules/admin/what-usr_online.php:52:    // @TODO Add a filter for sponsor
-./inc/modules/guest/what-mediadata.php:180:// @TODO Rewrite these all if-blocks to filters
+./inc/modules/guest/what-mediadata.php:181:// @TODO Rewrite these all if-blocks to filters
 ./inc/modules/guest/what-mediadata.php:49:// @TODO Rewrite all constants
 ./inc/modules/guest/what-mediadata.php:69:     // @TODO Find a better formular than this one
 ./inc/modules/guest/what-register.php:208:     // @TODO Rewrite these all to a single filter
 ./inc/monthly/monthly_bonus.php:71:    // @TODO Rewrite this to a filter
 ./inc/mysql-manager.php:1575:                  // @TODO Try to rewrite this to $content = SQL_FETCHARRAY()
 ./inc/mysql-manager.php:1618:                  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1770:  // @TODO Rewrite this to a filter
-./inc/mysql-manager.php:1798:                          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1822:          // @TODO Find a way for updating $_CONFIG here
-./inc/mysql-manager.php:1845:// @TODO Can this be rewritten to a filter?
-./inc/mysql-manager.php:1907:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
+./inc/mysql-manager.php:1785:  // @TODO Rewrite this to a filter
+./inc/mysql-manager.php:1813:                          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1837:          // @TODO Find a way for updating $_CONFIG here
+./inc/mysql-manager.php:1860:// @TODO Can this be rewritten to a filter?
+./inc/mysql-manager.php:1925:                  // @TODO Rewrite this to $content = SQL_FETCHARRAY()
 ./inc/mysql-manager.php:212:                   // @TODO Nothing helped???
-./inc/mysql-manager.php:2210:          // @TODO This can be somehow rewritten
+./inc/mysql-manager.php:2241:          // @TODO This can be somehow rewritten
 ./inc/mysql-manager.php:247:                   // @TODO Rewrite this to a filter
 ./inc/mysql-manager.php:538:   // @TODO Try to rewrite this to one or more functions
 ./inc/mysql-manager.php:567:                           // @TODO Try to rewrite this to one or more functions
 ./mailid_top.php:228:                                                                  // @TODO Rewrite these blocks to filter
 ./mailid_top.php:89:           // @TODO Rewrite this to a filter
 ./show_bonus.php:108:                  // @TODO Rewrite this constant
+./view.php:72:         // @TODO No banner found, output some default banner
 ### ### DEPRECATION FOLLOWS: ### ###
 ./inc/functions.php:238:       // @DEPRECATED Try to rewrite the if() condition
 ./inc/functions.php:252:                       // @DEPRECATED
index 03a2e58..4704569 100644 (file)
@@ -132,7 +132,7 @@ if (isFormSent()) {
                        $points = GET_TOTAL_DATA($uid, 'user_points', 'points') - GET_TOTAL_DATA($uid, 'user_data', 'used_points');
 
                        // So let's continue with probing his points amount
-                       if (($points - getConfig('doubler_left') - REQUEST_POST('points') * getConfig('doubler_charge')) >= 0)
+                       if (($points - getConfig('doubler_left') - REQUEST_POST('points') * getConfig('doubler_charge')) >= 0) {
                                // Enough points are left so let's continue with the doubling process
                                // Create doubling "account" width *DOUBLED* points
                                SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_doubler` (`userid`, `refid`, `points`, `remote_ip`, `timemark`, `completed`, `is_ref`) VALUES ('%s','%s','%s','".detectRemoteAddr()."', UNIX_TIMESTAMP(), 'N','N')",
index ce508be..b102474 100644 (file)
--- a/view.php
+++ b/view.php
@@ -47,22 +47,34 @@ $GLOBALS['output_mode'] = -1;
 require('inc/config-global.php');
 
 if (((REQUEST_ISSET_GET('user')) || (REQUEST_ISSET_GET('reseller'))) && (REQUEST_ISSET_GET('banner'))) {
-       // for later things... ;-)
+       // For later things... ;-)
        $result = SQL_QUERY_ESC("SELECT `url` FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
                array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
+
+       // Do we have the banner?
        if (SQL_NUMROWS($result) == 1)  {
+               // Load the URL
                list($url) = SQL_FETCHROW($result);
-               SQL_FREERESULT($result);
+
+               // Update counter
                SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET `counter`=`counter`+1 WHERE `id`=%s LIMIT 1",
                        array(bigintval(REQUEST_GET('banner'))), __FILE__, __LINE__);
 
+               // Extract type (last 3 chars should be okay)
                $type = substr($url, -3);
+
+               // Set header and ...
                sendHeader('Content-Type: image/' . $type);
+
+               // Redirect
                redirectToUrl($url, false);
        } else {
-               // Free memory
-               SQL_FREERESULT($result);
+               // @TODO No banner found, output some default banner
+               DEBUG_LOG(__FILE__, __LINE__, 'Banner ' . bigintval(REQUEST_GET('banner')) . ' not dound.');
        }
+
+       // Free memory
+       SQL_FREERESULT($result);
 } else {
        // Do nothing for now
        redirectToUrl('index.php');