From 389e014839913bbd7f39d984d690b60172113269 Mon Sep 17 00:00:00 2001 From: Roland Haeder Date: Mon, 28 Mar 2016 18:14:23 +0200 Subject: [PATCH] inc/stylesheet.php is now deprecated + introduced loadStyleSheets() to encapsulate that code in a nice function. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Updated TODOs.txt Signed-off-by: Roland Häder --- DOCS/TODOs.txt | 100 +++++++++++++++++----------------- css.php | 2 +- inc/filters.php | 2 +- inc/functions.php | 96 +++++++++++++++++++++++++++++++++ inc/stylesheet.php | 131 +-------------------------------------------- 5 files changed, 151 insertions(+), 180 deletions(-) diff --git a/DOCS/TODOs.txt b/DOCS/TODOs.txt index 8f041af938..5111aa3465 100644 --- a/DOCS/TODOs.txt +++ b/DOCS/TODOs.txt @@ -1,4 +1,4 @@ -### WARNING: THIS FILE IS AUTO-GENERATED BY ./contrib/todo-builder.sh (uid=1000/user=quix0r) ### +### WARNING: THIS FILE IS AUTO-GENERATED BY ./contrib/todo-builder.sh (uid=/user=quix0r) ### ### DO NOT EDIT THIS FILE. ### ./api.php:66:// @TODO Do stuff here ./autoreg.php:57:// @TODO Add processing of request here @@ -14,18 +14,13 @@ ./inc/email-functions.php:204:// @TODO $rawUserId is currently unused ./inc/expression-functions.php:168:// @TODO FILTER_COMPILE_CONFIG does not handle call-back functions so we handle it here again ./inc/expression-functions.php:41: // @TODO is escapeQuotes() enough for strings with single/double quotes? -./inc/extensions-functions.php:2234: // @TODO Is this really neccessary? -./inc/extensions-functions.php:2291:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' -./inc/extensions-functions.php:434: // @TODO This redirect is still needed to register sql_patches! Please try to avoid it -./inc/extensions-functions.php:450:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) -./inc/extensions-functions.php:590: // @TODO Extension is loaded, what next? ./inc/extensions/admins/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/autopurge/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/beg/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/bonus/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/doubler/mode-setup.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/doubler/mode-update.php:38:// @TODO Remove double tabs from all lines -./inc/extensions/ext-html_mail.php:91: // @TODO Move these arrays into config +./inc/extensions/ext-html_mail.php:90: // @TODO Move these arrays into config ./inc/extensions/ext-menu.php:52: // @TODO Convert menu-Id to one coding-standard. admin(edit|_add) => admin_menu_(edit|add), mem(edit|_add) => (edit|add)_(admin|guest|member)_menu ./inc/extensions/ext-newsletter.php:218: // @TODO Move these into configuration ./inc/extensions/ext-nickname.php:52: // @TODO NOT NULL DEFAULT '' is bad practice, use NULL @@ -35,6 +30,11 @@ ./inc/extensions/ext-yoomedia.php:120: // @TODO Can this be moved into a database table? ./inc/extensions/ext-yoomedia.php:54:// @TODO Only deprecated when 'ext-network' is ready: setExtensionDeprecated('Y'); ./inc/extensions/forced/mode-setup.php:38:// @TODO Remove double tabs from all lines +./inc/extensions-functions.php:2234: // @TODO Is this really neccessary? +./inc/extensions-functions.php:2291:// @TODO This should be rewrittten to allow, more development states, e.g. 'planing','alpha','beta','beta2','stable' +./inc/extensions-functions.php:434: // @TODO This redirect is still needed to register sql_patches! Please try to avoid it +./inc/extensions-functions.php:450:// @TODO Change from ext_id to ext_name (not just even the variable! ;-) ) +./inc/extensions-functions.php:590: // @TODO Extension is loaded, what next? ./inc/extensions/grade/mode-setup.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/html_mail/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/network/mode-setup.php:13: * @TODO ADCocktail: All request parameters, BIDausKAS, WIDausKAS??? * @@ -83,13 +83,14 @@ ./inc/extensions/transfer/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/user/mode-update.php:38:// @TODO Remove double tabs from all lines ./inc/extensions/user/mode-update.php:554: // @TODO Make configurable through web interface -./inc/filter-functions.php:115: // @TODO Remove this forced removal after a year or so ./inc/filter/blacklist_filter.php:105: // @TODO Insert log entry ./inc/filter/blacklist_filter.php:116: // @TODO Insert log entry ./inc/filter/blacklist_filter.php:127: // @TODO Insert log entry ./inc/filter/bonus_filter.php:56: // @TODO This query isn't right, it will only update if the user was for a longer time away! ./inc/filter/forced_filter.php:75: // @TODO This part is unfinished +./inc/filter-functions.php:115: // @TODO Remove this forced removal after a year or so ./inc/filter/order_filter.php:132: // @TODO 200 is hard-coded here, swap it out to config + admin_config_order.tpl +./inc/filters.php:1379: // @TODO No banner found, output some default banner ./inc/filter/user_filter.php:279:// @TODO 0% done ./inc/filter/user_filter.php:289:// @TODO 0% done ./inc/filter/wernis_filter.php:137:// @TODO 0% done @@ -97,21 +98,20 @@ ./inc/filter/wernis_filter.php:62:// @TODO 10% done ./inc/filter/wernis_filter.php:80:// @TODO 10% done ./inc/filter/wernis_filter.php:98:// @TODO 10% done -./inc/filters.php:1379: // @TODO No banner found, output some default banner -./inc/functions.php:1229: // @TODO Are these convertions still required? -./inc/functions.php:1250:// @TODO Rewrite this function to use readFromFile() and writeToFile() -./inc/functions.php:1554: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. -./inc/functions.php:1930: // @TODO Find a way to cache this -./inc/functions.php:2034: // @TODO This is still very static, rewrite it somehow -./inc/functions.php:2213: // @TODO Rename column data_type to e.g. mail_status -./inc/functions.php:2563:// @TODO cacheFiles is not yet supported +./inc/functions.php:1238: // @TODO Are these convertions still required? +./inc/functions.php:1259:// @TODO Rewrite this function to use readFromFile() and writeToFile() +./inc/functions.php:1563: // @TODO This should be rewritten not to load the cache file for just checking if it is there for save removal. +./inc/functions.php:1939: // @TODO Find a way to cache this +./inc/functions.php:2043: // @TODO This is still very static, rewrite it somehow +./inc/functions.php:2222: // @TODO Rename column data_type to e.g. mail_status +./inc/functions.php:2572:// @TODO cacheFiles is not yet supported ./inc/gen_sql_patches.php:93:// @TODO Rewrite this to a filter ./inc/install-functions.php:102: // @TODO DEACTIVATED: changeDataInLocalConfigurationFile('OUTPUT-MODE', "setConfigEntry('OUTPUT_MODE', '", "');", postRequestElement('omode'), 0); ./inc/install-functions.php:497: // @TODO Comparing with DEFAULT_MAIN_TITLE doesn't work -./inc/language-functions.php:249: // @TODO These are all valid languages, again hard-coded ./inc/language/de.php:1150: // @TODO Rewrite these two constants ./inc/language/de.php:1166: // @TODO Rewrite these three constants ./inc/language/de.php:46: // @TODO Please sort these language elements +./inc/language-functions.php:249: // @TODO These are all valid languages, again hard-coded ./inc/language/install_de.php:155: // @TODO Move this to e.g. ext-smtp ./inc/language/newsletter_de.php:13: * @TODO This language file is completely out-dated, please do no * ./inc/language/order_de.php:71: // @TODO Find better text @@ -144,8 +144,10 @@ ./inc/libs/theme_functions.php:93: // @TODO Can't this be rewritten to an API function? ./inc/libs/user_functions.php:325: // @TODO Make this filter working: $ADDON = runFilterChain('post_login_update', $content); ./inc/libs/user_functions.php:354: // @TODO Make this filter working: $url = runFilterChain('do_login', array('content' => $content, 'addon' => $ADDON)); -./inc/libs/wernis_functions.php:433:// @TODO Unused? -./inc/libs/wernis_functions.php:486: // @TODO Something more to do here? +./inc/libs/user_functions.php:673: // @TODO Rewrite this to 2 filters as a possible redirect must always come last +./inc/libs/wernis_functions.php:1000: // @TODO Should not happen??? +./inc/libs/wernis_functions.php:543:// @TODO Unused? +./inc/libs/wernis_functions.php:594: // @TODO Something more to do here? ./inc/libs/yoomedia_functions.php:108: $response = YOOMEDIA_QUERY_API('out_textmail.php', TRUE); // @TODO Ask Yoo!Media for test script ./inc/load_config.php:70: // @TODO Rewrite them to avoid this else block ./inc/loader/load-extension.php:13: * @TODO Rewrite this whole file * @@ -177,9 +179,9 @@ ./inc/modules/admin/what-edit_user.php:18: * @TODO Add support for ext-country * ./inc/modules/admin/what-email_stats.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-extensions.php:366: // @TODO Rewrite this to a filter -./inc/modules/admin/what-guest_add.php:129: // @TODO This can be somehow rewritten to a function -./inc/modules/admin/what-guest_add.php:67: // @TODO Cant this be rewritten? -./inc/modules/admin/what-guest_add.php:80: // @TODO This can be somehow rewritten to a function +./inc/modules/admin/what-guest_add.php:131: // @TODO This can be somehow rewritten to a function +./inc/modules/admin/what-guest_add.php:68: // @TODO Cant this be rewritten? +./inc/modules/admin/what-guest_add.php:81: // @TODO This can be somehow rewritten to a function ./inc/modules/admin/what-holiday_list.php:46:// @TODO Unused at the moment ./inc/modules/admin/what-list_admins_acls.php:126: // @TODO Rewrite this to filter 'run_sqls' ./inc/modules/admin/what-list_bonus.php:136: // @TODO Can't this be moved into our expression language? @@ -188,12 +190,12 @@ ./inc/modules/admin/what-list_rallye_prices.php:222: // @TODO Rewrite these two constants ./inc/modules/admin/what-list_refs.php:101: // @TODO Try to rewrite some to EL ./inc/modules/admin/what-list_unconfirmed.php:115: // @TODO "Please do not call me directly." Should be rewritten to a nice selection depending on ext-bonus +./inc/modules/admin/what-list_user_cats.php:54: // @TODO No longer needed? define('__CATEGORIES_BASE' , '' . $content['login'] . ''; -./inc/modules/guest/what-sponsor_reg.php:288: // @TODO Maybe a default referral id? +./inc/modules/guest/what-sponsor_infos.php:83: // @TODO Cache this static data +./inc/modules/guest/what-sponsor_reg.php:289: // @TODO Maybe a default referral id? ./inc/modules/guest/what-stats.php:106: // @TODO This can be somehow rewritten ./inc/modules/guest/what-stats.php:115: // @TODO This doesn't exclude tester accounts ./inc/modules/guest/what-stats.php:78:// @TODO This can be rewritten in a dynamic include @@ -231,28 +234,28 @@ ./inc/modules/order.php:71: // @TODO Unused: timestamp ./inc/monthly/monthly_beg.php:53: // @TODO Rewrite these if() blocks to a filter ./inc/monthly/monthly_bonus.php:52: // @TODO Rewrite these if() blocks to a filter -./inc/mysql-manager.php:1520: // @TODO Rewrite these lines to a filter -./inc/mysql-manager.php:1544: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:1860: // @TODO Rewrite this to a filter -./inc/mysql-manager.php:2028: // @TODO If the EL sub-system can support more than one parameter, this call_user_func_array() can be avoided -./inc/mysql-manager.php:2160: // @TODO Used generic 'userid' here -./inc/mysql-manager.php:2378:// @TODO cacheFiles is not yet supported +./inc/mysql-manager.php:1521: // @TODO Rewrite these lines to a filter +./inc/mysql-manager.php:1545: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:1861: // @TODO Rewrite this to a filter +./inc/mysql-manager.php:2029: // @TODO If the EL sub-system can support more than one parameter, this call_user_func_array() can be avoided +./inc/mysql-manager.php:2161: // @TODO Used generic 'userid' here +./inc/mysql-manager.php:2379:// @TODO cacheFiles is not yet supported ./inc/mysql-manager.php:39:// @TODO Can we cache this? ./inc/mysql-manager.php:403: // @TODO Try to rewrite this to one or more functions ./inc/pool-functions.php:39:// @TODO "Hook" ext-html_mail into this to allow column `html_msg` -./inc/template-functions.php:1060: // @TODO