From 8a9324b2d931f54f54f4319fd7234910af77012c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Wed, 13 Feb 2008 21:32:32 +0000 Subject: [PATCH] A *lot* more code-cleanups, errors in CSS fixed (missing brackets) and frameset support removed due to it will never be finished --- .gitattributes | 1 - admin.php | 2 - agb.php | 2 - birthday_confirm.php | 2 - click.php | 2 - confirm.php | 2 - css.php | 2 - doubler.php | 2 - img.php | 2 - inc/config.php | 3 - inc/db/lib-mysql3.php | 4 +- inc/extensions.php | 14 +- inc/extensions/ext-autopurge.php | 4 +- inc/extensions/ext-doubler.php | 2 +- inc/extensions/ext-mydata.php | 4 +- inc/extensions/ext-rallye.php | 4 +- inc/extensions/ext-register.php | 4 +- inc/extensions/ext-task.php | 2 +- inc/footer.php | 45 ++- inc/functions.php | 36 +-- inc/header.php | 160 +++++------ inc/install-inc.php | 25 +- inc/language/beg_de.php | 2 +- inc/language/birthday_de.php | 2 +- inc/language/de.php | 16 +- inc/language/en.php | 4 +- inc/language/install_de.php | 4 +- inc/language/payout_de.php | 4 +- inc/language/rewrite_de.php | 4 +- inc/language/task_de.php | 4 +- inc/libs/html_mail_functions.php | 4 +- inc/libs/output_functions.php | 4 +- inc/libs/payout_functions.php | 4 +- inc/libs/rallye_functions.php | 8 +- inc/libs/register_functions.php | 2 +- inc/libs/user_functions.php | 2 +- inc/load_cache.php | 143 +++------ inc/modules/admin/action-logout.php | 2 +- inc/modules/admin/admin-inc.php | 12 +- inc/modules/admin/overview-inc.php | 2 +- inc/modules/admin/what-adminedit.php | 2 +- inc/modules/admin/what-admins_mails.php | 2 +- inc/modules/admin/what-config_mods.php | 4 +- inc/modules/admin/what-del_task.php | 2 +- inc/modules/admin/what-email_details.php | 46 +-- inc/modules/admin/what-email_stats.php | 2 +- inc/modules/admin/what-extensions.php | 2 +- inc/modules/admin/what-guest_add.php | 2 +- inc/modules/admin/what-guestedit.php | 2 +- inc/modules/admin/what-holiday_list.php | 2 +- inc/modules/admin/what-holiday_remove.php | 2 +- inc/modules/admin/what-list_beg.php | 2 +- inc/modules/admin/what-list_bonus.php | 2 +- inc/modules/admin/what-list_country.php | 4 +- inc/modules/admin/what-list_payouts.php | 2 +- inc/modules/admin/what-list_rallyes.php | 2 +- inc/modules/admin/what-list_refs.php | 2 +- inc/modules/admin/what-mem_add.php | 2 +- inc/modules/admin/what-memedit.php | 2 +- inc/modules/admin/what-theme_import.php | 2 +- inc/modules/admin/what-user_online.php | 4 +- inc/modules/chk_login.php | 2 +- inc/modules/frameset.php | 47 --- inc/modules/guest/what-register.php | 22 +- inc/modules/index.php | 16 +- inc/modules/login.php | 2 +- inc/modules/member/what-beg2.php | 2 +- inc/modules/member/what-bonus.php | 2 +- inc/modules/member/what-order.php | 6 +- inc/modules/member/what-reflinks.php | 16 +- inc/modules/member/what-transfer.php | 2 +- inc/modules/member/what-welcome.php | 2 +- inc/mysql-manager.php | 155 +++------- inc/pool-update.php | 40 +-- inc/rdf.class.php | 2 +- index.php | 2 - install.php | 2 - lead-confirm.php | 2 - login.php | 2 - mailid.php | 2 - mailid_top.php | 2 - ref.php | 2 - show_bonus.php | 2 - theme/business/css/general.css | 229 ++++++++------- theme/business/css/register.css | 3 - theme/default/css/general.css | 335 +++++++++++----------- theme/default/css/register.css | 1 - theme/desert/css/general.css | 3 +- theme/desert/css/register.css | 1 - view.php | 2 - 90 files changed, 648 insertions(+), 897 deletions(-) delete mode 100644 inc/modules/frameset.php diff --git a/.gitattributes b/.gitattributes index 5977fc2a93..b9b6e70832 100644 --- a/.gitattributes +++ b/.gitattributes @@ -350,7 +350,6 @@ inc/modules/admin/what-user_contct.php -text inc/modules/admin/what-user_online.php -text inc/modules/admin/what-usr_online.php -text inc/modules/chk_login.php -text -inc/modules/frameset.php -text inc/modules/frametester.php -text inc/modules/guest/.htaccess -text inc/modules/guest/action- -text diff --git a/admin.php b/admin.php index 2320674c5e..7fcb0e8612 100644 --- a/admin.php +++ b/admin.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "admin"; $CSS = -1; diff --git a/agb.php b/agb.php index a802e0c401..4c878bc909 100644 --- a/agb.php +++ b/agb.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "agb"; $CSS = -1; diff --git a/birthday_confirm.php b/birthday_confirm.php index b65d5e1b0a..27729533e4 100644 --- a/birthday_confirm.php +++ b/birthday_confirm.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "birthday_confirm"; $CSS = -1; diff --git a/click.php b/click.php index 8a083637b4..1601300cad 100644 --- a/click.php +++ b/click.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "click"; $CSS = -1; diff --git a/confirm.php b/confirm.php index e844c6c77e..42165299f6 100644 --- a/confirm.php +++ b/confirm.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module to confirm $GLOBALS['module'] = "confirm"; $CSS = -1; diff --git a/css.php b/css.php index cdc3461e4f..ef86272f3a 100644 --- a/css.php +++ b/css.php @@ -40,8 +40,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // This is a CSS file loader! $CSS = "1"; $GLOBALS['module'] = "css"; diff --git a/doubler.php b/doubler.php index 637bd4411d..356821765a 100644 --- a/doubler.php +++ b/doubler.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "doubler"; diff --git a/img.php b/img.php index 94878c19a3..82855eee2e 100644 --- a/img.php +++ b/img.php @@ -37,8 +37,6 @@ require_once("inc/libs/security_functions.php"); // Init "action" and "what" global $what, $action; $GLOBALS['what'] = ""; $GLOBALS['action'] = ""; -if (!empty($_GET['action'])) $GLOBALS['action'] = secureString($_GET['action']); -if (!empty($_GET['what'])) $GLOBALS['what'] = secureString($_GET['what']); // Set module $GLOBALS['module'] = "img"; $CSS = -1; diff --git a/inc/config.php b/inc/config.php index 41abd29524..3e98b5af6b 100644 --- a/inc/config.php +++ b/inc/config.php @@ -104,9 +104,6 @@ define('mxchange_installed', false); // CFG: ADMIN-SETUP define('admin_registered', false); -// CFG: FRAMESET -define('frameset_active', false); - // CFG: DEBUG-MODE (if enabled all mails will be *displayed* and *not* send!) define('DEBUG_MODE', false); diff --git a/inc/db/lib-mysql3.php b/inc/db/lib-mysql3.php index c07f09aeb3..2f75170617 100644 --- a/inc/db/lib-mysql3.php +++ b/inc/db/lib-mysql3.php @@ -45,8 +45,8 @@ function SQL_QUERY($sql_string, $F, $L) // Run SQL command $result = @mysql_query($sql_string, $link) - or ADD_FATAL($F." (".$L."):".mysql_error()."
-".MYSQL_QUERY_STRING."
+ or ADD_FATAL($F." (".$L."):".mysql_error()."
+".MYSQL_QUERY_STRING."
".$sql_string); if (($CSS != "1") && ($CSS != "-1") && (DEBUG_MODE) && (DEBUG_SQL)) diff --git a/inc/extensions.php b/inc/extensions.php index c12749305c..7f43bbac09 100644 --- a/inc/extensions.php +++ b/inc/extensions.php @@ -70,17 +70,17 @@ function EXTENSION_REGISTER($ext_name, $id, $dry_run=false) if (!empty($UPDATE_NOTES)) { // Update notes found - $NOTES .= "v".$EXT_VER.":
".$UPDATE_NOTES."

\n"; + $NOTES .= "v".$EXT_VER.":
".$UPDATE_NOTES."

\n"; $UPDATE_NOTES = ""; } elseif (($EXT_VER == "0.0") || ($EXT_VER == "0.0.0")) { // Initial release - $NOTES .= "v".$EXT_VER.":
".INITIAL_RELEASE."

\n"; + $NOTES .= "v".$EXT_VER.":
".INITIAL_RELEASE."

\n"; } else { - $NOTES .= "v".$EXT_VER.":
".NO_UPDATE_NOTES."

\n"; + $NOTES .= "v".$EXT_VER.":
".NO_UPDATE_NOTES."

\n"; } } } @@ -273,7 +273,7 @@ function EXT_IS_ACTIVE ($ext_name, $ignore_admin=false, $ignore_cache=false) // Extension's file name will also be checked $file = PATH."inc/extensions/ext-".$ext_name.".php"; if ((!file_exists($file)) && (!is_readable($file))) return false; - //* DEBUG: */ echo "*".$ext_name."*
"; + //* DEBUG: */ echo "*".$ext_name."*
"; // Failed is the default $ret = false; @@ -388,17 +388,17 @@ function EXTENSION_UPDATE($file, $ext, $EXT_VER, $dry_run=false) if (!empty($UPDATE_NOTES)) { // Update notes found - $NOTES .= "v".$EXT_VER.":
".$UPDATE_NOTES."

\n"; + $NOTES .= "v".$EXT_VER.":
".$UPDATE_NOTES."

\n"; $UPDATE_NOTES = ""; } elseif ($EXT_VER == "0.0") { // Initial release - $NOTES .= "v".$EXT_VER.":
".INITIAL_RELEASE."

\n"; + $NOTES .= "v".$EXT_VER.":
".INITIAL_RELEASE."

\n"; } else { - $NOTES .= "v".$EXT_VER.":
".NO_UPDATE_NOTES."

\n"; + $NOTES .= "v".$EXT_VER.":
".NO_UPDATE_NOTES."

\n"; } } diff --git a/inc/extensions/ext-autopurge.php b/inc/extensions/ext-autopurge.php index 9ed1a8c7f2..ea4952da78 100644 --- a/inc/extensions/ext-autopurge.php +++ b/inc/extensions/ext-autopurge.php @@ -138,7 +138,7 @@ case "update": // Update an extension $SQLs[] = "ALTER TABLE "._MYSQL_PREFIX."_config ADD ap_tasks_time bigint(20) not null default '".(60*60*24*7)."'"; // Update notes (these will be set as task text!) - $UPDATE_NOTES = "Bereinigung von zu löschenden Aufgaben klappt wieder. Zeitlimit für genanntes kann eingestellt werden (Default = 7 Tage).

Bitte aktualisieren Sie auch die Admin-Templates!"; + $UPDATE_NOTES = "Bereinigung von zu löschenden Aufgaben klappt wieder. Zeitlimit für genanntes kann eingestellt werden (Default = 7 Tage).

Bitte aktualisieren Sie auch die Admin-Templates!"; break; case "0.2.0": // SQL queries for v0.2.0 @@ -147,7 +147,7 @@ case "update": // Update an extension $SQLs[] = "ALTER TABLE "._MYSQL_PREFIX."_config ADD ap_tasks_notify enum('Y', 'N') not null default 'Y'"; // Update notes (these will be set as task text!) - $UPDATE_NOTES = "Mail wird bei Löschung von Aufgaben ausgesendet.

Bitte aktualisieren Sie auch die Admin-Templates!"; + $UPDATE_NOTES = "Mail wird bei Löschung von Aufgaben ausgesendet.

Bitte aktualisieren Sie auch die Admin-Templates!"; break; case "0.2.1": // SQL queries for v0.2.1 diff --git a/inc/extensions/ext-doubler.php b/inc/extensions/ext-doubler.php index cd905390cf..6cb45a143d 100644 --- a/inc/extensions/ext-doubler.php +++ b/inc/extensions/ext-doubler.php @@ -186,7 +186,7 @@ WHERE d.completed='N'"; case "0.0.7": // SQL queries for v0.0.7 // Update notes (these will be set as task text!) - $UPDATE_NOTES = "Wörter Mailtausch, Mailtausches und Mailtauscher sind austauschbar.

Minus-Guthaben des Verdoppler-Accounts repariert und Mitgliedsmail erweitert mit Transaktionsummer und IP-Nummer."; + $UPDATE_NOTES = "Wörter Mailtausch, Mailtausches und Mailtauscher sind austauschbar.

Minus-Guthaben des Verdoppler-Accounts repariert und Mitgliedsmail erweitert mit Transaktionsummer und IP-Nummer."; break; case "0.0.8": // SQL queries for v0.0.8 diff --git a/inc/extensions/ext-mydata.php b/inc/extensions/ext-mydata.php index 8d035be2a3..7d3234322e 100644 --- a/inc/extensions/ext-mydata.php +++ b/inc/extensions/ext-mydata.php @@ -124,8 +124,8 @@ case "update": // Update an extension case "0.1.2": // SQL queries for v0.1.2 // Update notes (these will be set as task text!) - $UPDATE_NOTES = "Einbindung der Erweiterung country, die Sie sich noch optional von meiner Seite herunterladen müssen.
-
+ $UPDATE_NOTES = "Einbindung der Erweiterung country, die Sie sich noch optional von meiner Seite herunterladen müssen.
+
Wichtig: Laden Sie noch die Template member_mydata_overview und member_mydata_edit (beide zu finden unter templates/".GET_LANGUAGE()."/html/member/ !) mit hoch!"; // Depends on 'country'! diff --git a/inc/extensions/ext-rallye.php b/inc/extensions/ext-rallye.php index 26c2f713ca..600fcf0189 100644 --- a/inc/extensions/ext-rallye.php +++ b/inc/extensions/ext-rallye.php @@ -214,12 +214,12 @@ case "update": // Update an extension $SQLs[] = "ALTER TABLE "._MYSQL_PREFIX."_rallye_data ADD min_prices bigint(20) not null default '3'"; // Update notes (these will be set as task text!) - $UPDATE_NOTES = "Ablaufen der Rallyes intergriert. Bauen Sie in Ihr Template templates/de/emails/member/member_rallye_notifty.tpl folgende zwei Zeilen ein:
+ $UPDATE_NOTES = "Ablaufen der Rallyes intergriert. Bauen Sie in Ihr Template templates/de/emails/member/member_rallye_notifty.tpl folgende zwei Zeilen ein:
-Zudem sollten Sie mindestens folgende Templates (in templates/".GET_LANGUAGE()."/html/guest/ !) aktualisieren:
+Zudem sollten Sie mindestens folgende Templates (in templates/".GET_LANGUAGE()."/html/guest/ !) aktualisieren: