From de866735194863dcb31ef055f1f6e71dea1bbc43 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roland=20H=C3=A4der?= Date: Thu, 8 Jul 2010 21:59:01 +0000 Subject: [PATCH] Fixed missing action if provided module is invalid (e.g. module=http://foo-server) --- inc/libs/online_functions.php | 5 +++-- inc/libs/security_functions.php | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/inc/libs/online_functions.php b/inc/libs/online_functions.php index 73ff9147fb..ec0dffee1f 100644 --- a/inc/libs/online_functions.php +++ b/inc/libs/online_functions.php @@ -57,6 +57,7 @@ function FILTER_UPDATE_ONLINE_LIST () { $userid = '0'; $isMember = 'N'; $isAdmin = 'N'; + $action = getActionFromModuleWhat(getModule(), getWhat()); // Valid userid? if (isMember()) { @@ -94,7 +95,7 @@ WHERE LIMIT 1", array( getModule(), - getAction(), + $action, getWhat(), $userid, makeDatabaseUserId(determineReferalId()), @@ -108,7 +109,7 @@ LIMIT 1", SQL_QUERY_ESC("INSERT INTO `{?_MYSQL_PREFIX?}_online` (`module`, `action`, `what`, `userid`, `refid`, `is_member`, `is_admin`, `timestamp`, `sid`, `ip`) VALUES ('%s','%s','%s', %s, '%s', '%s','%s', UNIX_TIMESTAMP(), '%s','%s')", array( getModule(), - getAction(), + $action, getWhat(), $userid, makeDatabaseUserId(determineReferalId()), diff --git a/inc/libs/security_functions.php b/inc/libs/security_functions.php index 7fc8a5ec11..ccacc15fab 100644 --- a/inc/libs/security_functions.php +++ b/inc/libs/security_functions.php @@ -45,6 +45,9 @@ if (strpos($_SERVER['PHP_SELF'], basename(__FILE__)) !== false) { die(); } // END - if +// Include ctracker, recommended place! +//require_once('ctracker.php'); + /** * Function to secure input strings * -- 2.39.2