protected function doPreparation()
{
- try {
- $nickname_arg = $this->arg('nickname');
- $nickname = common_canonical_nickname($nickname_arg);
-
- // Permanent redirect on non-canonical nickname
-
- if ($nickname_arg != $nickname) {
- $args = array('nickname' => $nickname);
- if ($this->arg('page') && $this->arg('page') != 1) {
- $args['page'] = $this->arg['page'];
- }
- common_redirect(common_local_url($this->getActionName(), $args), 301);
+ // showstream requires a nickname
+ $nickname_arg = $this->trimmed('nickname');
+ $nickname = common_canonical_nickname($nickname_arg);
+
+ // Permanent redirect on non-canonical nickname
+ if ($nickname_arg != $nickname) {
+ $args = array('nickname' => $nickname);
+ if ($this->arg('page') && $this->arg('page') != 1) {
+ $args['page'] = $this->arg['page'];
}
- $this->user = User::getKV('nickname', $nickname);
+ common_redirect(common_local_url($this->getActionName(), $args), 301);
+ }
- if (!$this->user) {
- $group = Local_group::getKV('nickname', $nickname);
- if ($group instanceof Local_group) {
- common_redirect($group->getProfile()->getUrl());
- }
- // TRANS: Client error displayed when calling a profile action without specifying a user.
- $this->clientError(_('No such user.'), 404);
+ try {
+ $user = User::getByNickname($nickname);
+ } catch (NoSuchUserException $e) {
+ $group = Local_group::getKV('nickname', $nickname);
+ if ($group instanceof Local_group) {
+ common_redirect($group->getProfile()->getUrl());
}
- $this->target = $this->user->getProfile();
- } catch (NicknameException $e) {
- $id = (int)$this->arg('id');
- $this->target = Profile::getKV('id', $id);
+ // No user nor group found, throw the NoSuchUserException again
+ throw $e;
+ }
- if (!$this->target instanceof Profile) {
- // TRANS: Error message displayed when referring to a user without a profile.
- $this->serverError(_m('Profile ID does not exist.'));
- }
+ $this->target = $user->getProfile();
+ }
- if ($this->target->isLocal()) {
- // For local users when accessed by id number, redirect to
- // the same action but using the nickname as argument.
- common_redirect(common_local_url($this->getActionName(),
- array('nickname'=>$user->getNickname())));
- }
- }
+ protected function prepare(array $args=array())
+ {
+ // this will call ->doPreparation() which child classes use to set $this->target
+ parent::prepare($args);
- if ($this->target->hasRole(Profile_role::SILENCED) &&
- (empty($this->scoped) || !$this->scoped->hasRight(Right::SILENCEUSER))) {
+ if ($this->target->hasRole(Profile_role::SILENCED)
+ && (!$this->scoped instanceof Profile || !$this->scoped->hasRight(Right::SILENCEUSER))) {
throw new ClientException(_('This profile has been silenced by site moderators'), 403);
}
- // backwards compatibility until all actions are fixed to use $this->target
- $this->profile = $this->target;
-
$this->tag = $this->trimmed('tag');
$this->page = ($this->arg('page')) ? ($this->arg('page')+0) : 1;
common_set_returnto($this->selfUrl());
- return $this->profileActionPreparation();
+ return true;
}
- protected function profileActionPreparation()
+ public function getTarget()
{
- // No-op by default.
+ if (!$this->target instanceof Profile) {
+ throw new ServerException('No target profile in ProfileAction class');
+ }
+ return $this->target;
}
function isReadOnly(array $args=array())
$url = $lists->mainpage;
} else {
$url = common_local_url('showprofiletag',
- array('tagger' => $this->target->getNickname(),
+ array('nickname' => $this->target->getNickname(),
'tag' => $lists->tag));
}
if (!$first) {