]> git.mxchange.org Git - quix0rs-gnu-social.git/log
quix0rs-gnu-social.git
13 years agoMerge branch '0.9.x' into json-activities
Zach Copley [Fri, 18 Feb 2011 23:45:11 +0000 (15:45 -0800)]
Merge branch '0.9.x' into json-activities

* 0.9.x:
  HTML and style cleanup for EmailSummary plugin.

13 years agoMake other timeline API endpoints output Activity Streams JSON
Zach Copley [Fri, 18 Feb 2011 23:43:40 +0000 (15:43 -0800)]
Make other timeline API endpoints output Activity Streams JSON

13 years agoHTML and style cleanup for EmailSummary plugin.
Samantha Doherty [Fri, 18 Feb 2011 18:49:29 +0000 (13:49 -0500)]
HTML and style cleanup for EmailSummary plugin.

13 years agoActivity Streams JSON - express to and in-reply-to stuff as person objects
Zach Copley [Fri, 18 Feb 2011 18:02:41 +0000 (10:02 -0800)]
Activity Streams JSON - express to and in-reply-to stuff as person objects

13 years agoAdd tags to Activity Streams JSON
Zach Copley [Fri, 18 Feb 2011 17:29:49 +0000 (09:29 -0800)]
Add tags to Activity Streams JSON

13 years agoAdd context to Activity Streams JSON
Zach Copley [Fri, 18 Feb 2011 08:51:08 +0000 (00:51 -0800)]
Add context to Activity Streams JSON

13 years agoAdd PoCo to Activity Streams JSON
Zach Copley [Fri, 18 Feb 2011 06:36:14 +0000 (22:36 -0800)]
Add PoCo to Activity Streams JSON

13 years agoAdd geopoint (GeoJSON) extension to AS JSON output
Zach Copley [Fri, 18 Feb 2011 04:12:28 +0000 (20:12 -0800)]
Add geopoint (GeoJSON) extension to AS JSON output

13 years agoavatars -> avatarLinks
Zach Copley [Fri, 18 Feb 2011 03:34:39 +0000 (19:34 -0800)]
avatars -> avatarLinks

13 years agoMerge branch '0.9.x' into json-activities
Zach Copley [Fri, 18 Feb 2011 03:11:29 +0000 (19:11 -0800)]
Merge branch '0.9.x' into json-activities

* 0.9.x:
  * update translator documentation. * remove superfluous whitespace. * tab to spaces. * add FIXME for undocumented class.
  * update translator documentation. * remove superfluous whitespace. * L10n updates. * small refactoring in publicrss.php. * remove PHP4-isms
  Localisation updates from http://translatewiki.net.
  Double quotes to single quotes.
  * improve L10n consistency for English. For example proper punctuation for all button and label titles. * fix some i18n bugs (in-message variables). * update/add translator documentation. * remove superfluous whitespace.
  add path separators for Plugin::path()
  argument to send email summary to all users on all sites
  fix indentation in siteemailsummaryhandler
  fix indentation in sendemailsummary.php
  fix indentation in Email_summary_status.php
  fix indentation in EmailSummaryPlugin.php
  fix indentation in usermailsummaryhandler.php

13 years agoReinstate profile_info in author/actor
Zach Copley [Fri, 18 Feb 2011 03:02:57 +0000 (19:02 -0800)]
Reinstate profile_info in author/actor

13 years ago* update translator documentation.
Siebrand Mazeland [Thu, 17 Feb 2011 20:10:48 +0000 (21:10 +0100)]
* update translator documentation.
* remove superfluous whitespace.
* tab to spaces.
* add FIXME for undocumented class.

13 years ago* update translator documentation.
Siebrand Mazeland [Thu, 17 Feb 2011 19:58:22 +0000 (20:58 +0100)]
* update translator documentation.
* remove superfluous whitespace.
* L10n updates.
* small refactoring in publicrss.php.
* remove PHP4-isms

13 years agoLocalisation updates from http://translatewiki.net.
Siebrand Mazeland [Thu, 17 Feb 2011 11:27:14 +0000 (12:27 +0100)]
Localisation updates from http://translatewiki.net.

13 years agoDouble quotes to single quotes.
Siebrand Mazeland [Thu, 17 Feb 2011 08:58:07 +0000 (09:58 +0100)]
Double quotes to single quotes.

13 years agoAdd avatars and notice info
Zach Copley [Thu, 17 Feb 2011 02:55:13 +0000 (18:55 -0800)]
Add avatars and notice info

13 years agoRudimentary support for enclosures and some fiddling
Zach Copley [Thu, 17 Feb 2011 02:14:58 +0000 (18:14 -0800)]
Rudimentary support for enclosures and some fiddling

13 years agoUse simple relative object and verb references
Zach Copley [Thu, 17 Feb 2011 00:44:02 +0000 (16:44 -0800)]
Use simple relative object and verb references

13 years agoAdd image to JSON ActivityObject and title + links to the JSON document
Zach Copley [Thu, 17 Feb 2011 00:21:46 +0000 (16:21 -0800)]
Add image to JSON ActivityObject and title + links to the JSON document

13 years agoRemove debugging statements I accidentally left in
Zach Copley [Thu, 17 Feb 2011 00:21:31 +0000 (16:21 -0800)]
Remove debugging statements I accidentally left in

13 years ago* improve L10n consistency for English. For example proper punctuation for all button...
Siebrand Mazeland [Wed, 16 Feb 2011 23:39:53 +0000 (00:39 +0100)]
* improve L10n consistency for English. For example proper punctuation for all button and label titles.
* fix some i18n bugs (in-message variables).
* update/add translator documentation.
* remove superfluous whitespace.

13 years agoMerge branch 'master' into 0.9.x
Evan Prodromou [Wed, 16 Feb 2011 18:56:55 +0000 (13:56 -0500)]
Merge branch 'master' into 0.9.x

13 years agoadd path separators for Plugin::path()
Evan Prodromou [Wed, 16 Feb 2011 18:56:30 +0000 (13:56 -0500)]
add path separators for Plugin::path()

13 years agoargument to send email summary to all users on all sites
Evan Prodromou [Wed, 16 Feb 2011 16:58:35 +0000 (11:58 -0500)]
argument to send email summary to all users on all sites

13 years agoFirst cut at some JSON Activity Streams output
Zach Copley [Wed, 16 Feb 2011 04:25:39 +0000 (20:25 -0800)]
First cut at some JSON Activity Streams output

13 years agofix indentation in siteemailsummaryhandler
Evan Prodromou [Tue, 15 Feb 2011 21:28:20 +0000 (16:28 -0500)]
fix indentation in siteemailsummaryhandler

13 years agofix indentation in sendemailsummary.php
Evan Prodromou [Tue, 15 Feb 2011 21:27:51 +0000 (16:27 -0500)]
fix indentation in sendemailsummary.php

13 years agofix indentation in Email_summary_status.php
Evan Prodromou [Tue, 15 Feb 2011 21:26:44 +0000 (16:26 -0500)]
fix indentation in Email_summary_status.php

13 years agofix indentation in EmailSummaryPlugin.php
Evan Prodromou [Tue, 15 Feb 2011 21:26:15 +0000 (16:26 -0500)]
fix indentation in EmailSummaryPlugin.php

13 years agofix indentation in usermailsummaryhandler.php
Evan Prodromou [Tue, 15 Feb 2011 21:25:37 +0000 (16:25 -0500)]
fix indentation in usermailsummaryhandler.php

13 years agoGet correct size for default avatar in email summary
Evan Prodromou [Tue, 15 Feb 2011 17:53:02 +0000 (12:53 -0500)]
Get correct size for default avatar in email summary

13 years agoNew version, dev cycle
Evan Prodromou [Tue, 15 Feb 2011 17:26:40 +0000 (12:26 -0500)]
New version, dev cycle

13 years agoMerge remote branch 'origin/master' into 0.9.x
Evan Prodromou [Mon, 14 Feb 2011 20:42:56 +0000 (15:42 -0500)]
Merge remote branch 'origin/master' into 0.9.x

13 years agoLocalisation updates from http://translatewiki.net.
Siebrand Mazeland [Mon, 14 Feb 2011 18:43:16 +0000 (19:43 +0100)]
Localisation updates from http://translatewiki.net.

13 years agoMerge remote branch 'origin/master'
Evan Prodromou [Mon, 14 Feb 2011 17:41:52 +0000 (12:41 -0500)]
Merge remote branch 'origin/master'

13 years agobackup action is read-only
Evan Prodromou [Mon, 14 Feb 2011 17:41:20 +0000 (12:41 -0500)]
backup action is read-only

13 years agoAtom - output nickname for atom:name in atom:author
Zach Copley [Sun, 13 Feb 2011 00:40:28 +0000 (00:40 +0000)]
Atom - output nickname for atom:name in atom:author

13 years agoUpdate translator comment for the url shortener "free service" marker: free as in...
Brion Vibber [Fri, 11 Feb 2011 22:11:37 +0000 (14:11 -0800)]
Update translator comment for the url shortener "free service" marker: free as in open

13 years agoFix for failure/exception on subscription/subscriber lists when deleted profiles...
Brion Vibber [Fri, 11 Feb 2011 21:21:53 +0000 (13:21 -0800)]
Fix for failure/exception on subscription/subscriber lists when deleted profiles are stuck in cached list.

Workaround for deleted profiles still appearing in cached subscriptions/subscribers lists: if we couldn't fetch them, don't include them in the ArrayWrapper.
ArrayWrapper doesn't deal well with null entries, which aren't meant to happen in how it works. This code has recently changed from dying directly with a PHP fatal error in that case to throwing an exception, which allows tracking down the caller.

It looks like there might be some cases where profiles and their matching subscriptions get deleted, but the subscription entries don't get properly cleared from cache... that still bears further investigation. The regular code path looks ok; calls Subscription::cancel() from code called in Profile::delete(); but if they're batch-deleted instead of one row at a time, that could fail to trigger.

13 years agoMerge branch 'master' of gitorious.org:statusnet/mainline
Evan Prodromou [Fri, 11 Feb 2011 21:01:57 +0000 (16:01 -0500)]
Merge branch 'master' of gitorious.org:statusnet/mainline

13 years agoadd plugins/sslpath setting, default to site path/plugins
Evan Prodromou [Fri, 11 Feb 2011 20:58:47 +0000 (15:58 -0500)]
add plugins/sslpath setting, default to site path/plugins

13 years agoadd --all and --suspicious options for update-profile-data.php
Brion Vibber [Fri, 11 Feb 2011 20:23:03 +0000 (12:23 -0800)]
add --all and --suspicious options for update-profile-data.php

13 years agorefactor for multi....
Brion Vibber [Fri, 11 Feb 2011 20:13:33 +0000 (12:13 -0800)]
refactor for multi....

13 years agowoops
Brion Vibber [Fri, 11 Feb 2011 20:08:35 +0000 (12:08 -0800)]
woops

13 years agoWork in progress: update-profile-data.php to update ostatus profile info from the...
Brion Vibber [Fri, 11 Feb 2011 19:55:23 +0000 (11:55 -0800)]
Work in progress: update-profile-data.php to update ostatus profile info from the current feed

13 years agoMerge branch 'master' of gitorious.org:statusnet/mainline
Evan Prodromou [Fri, 11 Feb 2011 03:23:06 +0000 (22:23 -0500)]
Merge branch 'master' of gitorious.org:statusnet/mainline

13 years agoMerge remote branch 'dev/master'
Evan Prodromou [Fri, 11 Feb 2011 03:21:56 +0000 (22:21 -0500)]
Merge remote branch 'dev/master'

13 years agoget the subject first if you go to the feed
Evan Prodromou [Fri, 11 Feb 2011 03:01:24 +0000 (03:01 +0000)]
get the subject first if you go to the feed

13 years agocheck legacy <actor> and <subject> first from feed
Evan Prodromou [Fri, 11 Feb 2011 02:59:18 +0000 (02:59 +0000)]
check legacy <actor> and <subject> first from feed

13 years agoMerge branch 'master' into 0.9.x
Brion Vibber [Thu, 10 Feb 2011 20:04:13 +0000 (12:04 -0800)]
Merge branch 'master' into 0.9.x

13 years agoFix for ticket #3039: TwitterBridge was incorrectly sending repeats of Twitter-bound...
Brion Vibber [Thu, 10 Feb 2011 18:53:24 +0000 (10:53 -0800)]
Fix for ticket #3039: TwitterBridge was incorrectly sending repeats of Twitter-bound messages if the repeater has sending of things to Twitter disabled.

A repeat/retweet is roughly equivalent to an active direct post, so should follow the posting rules, rather than always sending over as we do for fave notifications.

13 years agoMerge branch 'master' of gitorious.org:statusnet/mainline
Zach Copley [Thu, 10 Feb 2011 18:26:36 +0000 (10:26 -0800)]
Merge branch 'master' of gitorious.org:statusnet/mainline

* 'master' of gitorious.org:statusnet/mainline:
  Show aside primary on settings pages for all themes.
  correct error in README on default for deletion

13 years agoFacebookBridge - remove unnecessary warning and noisy debugging statement
Zach Copley [Thu, 10 Feb 2011 18:24:38 +0000 (10:24 -0800)]
FacebookBridge - remove unnecessary warning and noisy debugging statement

13 years agoShow aside primary on settings pages for all themes.
Samantha Doherty [Thu, 10 Feb 2011 18:23:20 +0000 (13:23 -0500)]
Show aside primary on settings pages for all themes.

13 years agocorrect error in README on default for deletion
Evan Prodromou [Thu, 10 Feb 2011 15:11:30 +0000 (10:11 -0500)]
correct error in README on default for deletion

13 years agoTry not to wipe out good data with empty values in Ostatus_profile::updateProfile()
Evan Prodromou [Thu, 10 Feb 2011 14:39:40 +0000 (09:39 -0500)]
Try not to wipe out good data with empty values in Ostatus_profile::updateProfile()

Output from 0.9.6 PuSH feeds seems to have a rump <author> but no
<activity:actor>. It was overwriting valid and useful data set up at
subscribe time.

This fix tries to avoid overwriting data. However, it may prevent
updates that delete data.

Bug: 3028

13 years agoAtom output - Reinstate activity:actor and activity:subject
Zach Copley [Thu, 10 Feb 2011 07:18:14 +0000 (23:18 -0800)]
Atom output - Reinstate activity:actor and activity:subject
w/deprecation warnings. Also add statusnet:profile_info back into
author/actor.

13 years agoMerge branch 'master' of gitorious.org:statusnet/mainline
Brion Vibber [Wed, 9 Feb 2011 21:50:31 +0000 (13:50 -0800)]
Merge branch 'master' of gitorious.org:statusnet/mainline

13 years agoPartial revert of 073f3e99: restores the original non-hashbang URLs for twitter users...
Brion Vibber [Wed, 9 Feb 2011 21:46:48 +0000 (13:46 -0800)]
Partial revert of 073f3e99: restores the original non-hashbang URLs for twitter users as the remote profile.
Should fix issue #3027: twitter user avatars not getting imported.

Due to the change in URI, all twitter users that had been previously seen were getting new profile entries, which tried to save the same avatar. This would fail as Avatar.url has a unique index.
Note: now anything new seen in the last couple days in production will still potentially conflict.

13 years agoRemove executable bits from Auth_SASL files
Evan Prodromou [Wed, 9 Feb 2011 16:04:52 +0000 (11:04 -0500)]
Remove executable bits from Auth_SASL files

13 years agoinclude Auth_SASL from PEAR in extlib
Evan Prodromou [Wed, 9 Feb 2011 16:03:44 +0000 (11:03 -0500)]
include Auth_SASL from PEAR in extlib

13 years agoMerge branch 'ssltweak'
Brion Vibber [Wed, 9 Feb 2011 08:11:28 +0000 (00:11 -0800)]
Merge branch 'ssltweak'

13 years agoFurther tweak for ssl paths in plugin check (sslserver may be set but empty)
Brion Vibber [Wed, 9 Feb 2011 08:09:25 +0000 (00:09 -0800)]
Further tweak for ssl paths in plugin check (sslserver may be set but empty)

13 years agoMerge branch 'master' of gitorious.org:statusnet/mainline
Evan Prodromou [Wed, 9 Feb 2011 08:09:24 +0000 (03:09 -0500)]
Merge branch 'master' of gitorious.org:statusnet/mainline

13 years agoensure*() functions throw exceptions for errors
Evan Prodromou [Wed, 9 Feb 2011 08:08:52 +0000 (03:08 -0500)]
ensure*() functions throw exceptions for errors

13 years agoTweak to use site/server fallback when no plugins/sslserver or site/sslserver and...
Brion Vibber [Wed, 9 Feb 2011 08:04:01 +0000 (00:04 -0800)]
Tweak to use site/server fallback when no plugins/sslserver or site/sslserver and generating plugin CSS

13 years agoLOG_WARN -> LOG_WARNING
Brion Vibber [Wed, 9 Feb 2011 07:34:37 +0000 (23:34 -0800)]
LOG_WARN -> LOG_WARNING

13 years ago0.9.7beta2 (for js update)
Brion Vibber [Wed, 9 Feb 2011 06:55:15 +0000 (22:55 -0800)]
0.9.7beta2 (for js update)

13 years agoRevert jQuery Form to r2.17 -- the latest fails with our Meteor stuff the way it...
Brion Vibber [Wed, 9 Feb 2011 06:28:23 +0000 (22:28 -0800)]
Revert jQuery Form to r2.17 -- the latest fails with our Meteor stuff the way it tweaks document.domain (which also causes other AJAX-related problems and needs to be destroyed one of these days...)

13 years agoFacebookBridge plugin - allow Facebook app ID and secret to be
Zach Copley [Wed, 9 Feb 2011 04:49:39 +0000 (04:49 +0000)]
FacebookBridge plugin - allow Facebook app ID and secret to be
initialized via config.php

13 years agoMerge branch 'testing'
Evan Prodromou [Tue, 8 Feb 2011 18:39:41 +0000 (13:39 -0500)]
Merge branch 'testing'

13 years agoMerge remote branch 'origin/pluginstatic' into testing
Evan Prodromou [Tue, 8 Feb 2011 18:39:17 +0000 (13:39 -0500)]
Merge remote branch 'origin/pluginstatic' into testing

13 years agoMerge branch 'testing'
Evan Prodromou [Tue, 8 Feb 2011 16:53:37 +0000 (11:53 -0500)]
Merge branch 'testing'

13 years agochange alpha1 to beta1
Evan Prodromou [Tue, 8 Feb 2011 16:53:30 +0000 (11:53 -0500)]
change alpha1 to beta1

13 years agoMerge branch 'testing'
Evan Prodromou [Tue, 8 Feb 2011 16:52:40 +0000 (11:52 -0500)]
Merge branch 'testing'

Conflicts:
plugins/Facebook/facebookaction.php
plugins/Facebook/facebookhome.php
plugins/Facebook/facebookutil.php

13 years agoMake ShowmessageAction not be a subclass of MailboxAction
Evan Prodromou [Tue, 8 Feb 2011 16:33:36 +0000 (11:33 -0500)]
Make ShowmessageAction not be a subclass of MailboxAction

The ShowmessageAction was using the MailboxAction to do its display of
a single direct message. Since we redid the nickname management, this
was breaking (MailboxAction requires a nickname argument,
ShowmessageAction does not, and nickname validation that used to
quietly fail now throws an exception).

I've moved the message list processing to its own widget class, so the
need to subclass MailboxAction has disappeared. I've rewritten this
action to use the MessageListItem widget, and it works fine now.

13 years agocorrectly show the source of messages in a message list
Evan Prodromou [Tue, 8 Feb 2011 16:32:35 +0000 (11:32 -0500)]
correctly show the source of messages in a message list

13 years agoCreate and use MessageList widget
Evan Prodromou [Tue, 8 Feb 2011 16:11:21 +0000 (11:11 -0500)]
Create and use MessageList widget

Our mailbox actions (inbox and outbox) were doing their own display of
messages. This was causing issues with especially showmessage, which
since the more rigourous nickname checks were added, no longer works as
a mailbox subclass.

I've taken the time to rip out the message listing code from MailboxAction
and moved it to a MessageList widget. The different mailboxes now have their
own subclasses that show the correct profile in the list.

13 years agoIssue #3025: string -> boolean for profile_background_tile entry in JSON user results...
Brion Vibber [Mon, 7 Feb 2011 22:38:35 +0000 (14:38 -0800)]
Issue #3025: string -> boolean for profile_background_tile entry in JSON user results from Twitter-compat API

This entry was using the strings 'true' and 'false' instead of literal booleans, which could confuse clients expecting literal booleans as in other places and on Twitter in this place.

13 years agoAdd a brief explanation of what group inbox is at the top of the page (instructions...
Brion Vibber [Mon, 7 Feb 2011 20:39:40 +0000 (12:39 -0800)]
Add a brief explanation of what group inbox is at the top of the page (instructions section), plus a message to show when there are no private messages in the inbox.

13 years agoMerge branch 'testing' of gitorious.org:statusnet/mainline into testing
Brion Vibber [Mon, 7 Feb 2011 20:20:12 +0000 (12:20 -0800)]
Merge branch 'testing' of gitorious.org:statusnet/mainline into testing

13 years agoFix group regexes that got missed in Nickname::DISPLAY_FMT update: fixes bug where...
Brion Vibber [Mon, 7 Feb 2011 20:18:41 +0000 (12:18 -0800)]
Fix group regexes that got missed in Nickname::DISPLAY_FMT update: fixes bug where group linking happened, but not actual delivery, when using _underscores_ in the !group_name

13 years agohide feeds from group page if it's private-only
Evan Prodromou [Mon, 7 Feb 2011 19:24:35 +0000 (14:24 -0500)]
hide feeds from group page if it's private-only

13 years agoShow a little indicator for private-only groups
Evan Prodromou [Mon, 7 Feb 2011 19:21:54 +0000 (14:21 -0500)]
Show a little indicator for private-only groups

13 years agoadd hooks for Group profile information
Evan Prodromou [Mon, 7 Feb 2011 19:04:58 +0000 (14:04 -0500)]
add hooks for Group profile information

13 years agoForce notices to DMs when privacy = always
Evan Prodromou [Mon, 7 Feb 2011 17:58:42 +0000 (12:58 -0500)]
Force notices to DMs when privacy = always

13 years agoChange category and copyright year
Evan Prodromou [Mon, 7 Feb 2011 17:28:58 +0000 (12:28 -0500)]
Change category and copyright year

13 years agoMerge branch 'testing' into privategroup
Evan Prodromou [Mon, 7 Feb 2011 17:27:09 +0000 (12:27 -0500)]
Merge branch 'testing' into privategroup

13 years agopagination for group inbox
Evan Prodromou [Mon, 7 Feb 2011 17:08:18 +0000 (12:08 -0500)]
pagination for group inbox

13 years agoRename PrivateGroup to GroupPrivateMessage to be clearer
Evan Prodromou [Mon, 7 Feb 2011 16:57:34 +0000 (11:57 -0500)]
Rename PrivateGroup to GroupPrivateMessage to be clearer

13 years agoAdd group info to new group message email
Evan Prodromou [Mon, 7 Feb 2011 16:55:16 +0000 (11:55 -0500)]
Add group info to new group message email

13 years agobutton on the group page to post a new message
Evan Prodromou [Mon, 7 Feb 2011 16:51:38 +0000 (11:51 -0500)]
button on the group page to post a new message

13 years agoForm for posting a group message on group inbox
Evan Prodromou [Mon, 7 Feb 2011 16:24:00 +0000 (11:24 -0500)]
Form for posting a group message on group inbox

13 years agoAdd a hook for group action list
Evan Prodromou [Mon, 7 Feb 2011 15:23:56 +0000 (10:23 -0500)]
Add a hook for group action list

13 years agoShow group local nav on group inbox
Evan Prodromou [Mon, 7 Feb 2011 15:18:54 +0000 (10:18 -0500)]
Show group local nav on group inbox

13 years agoShow private messages to groups in a list
Evan Prodromou [Mon, 7 Feb 2011 14:46:26 +0000 (09:46 -0500)]
Show private messages to groups in a list

Shows the messages to a private group in a list. New classes for
showing a group private message and list of group private messages.

New actions for showing a stream of group private messages and a
single group private message.

13 years agomove MESSAGES_PER_PAGE to common.php
Evan Prodromou [Sat, 5 Feb 2011 21:18:59 +0000 (16:18 -0500)]
move MESSAGES_PER_PAGE to common.php

13 years agoSend a private group message with a d command
Evan Prodromou [Fri, 4 Feb 2011 20:51:59 +0000 (15:51 -0500)]
Send a private group message with a d command

13 years agocommands are always lowercased in interpreter
Evan Prodromou [Thu, 3 Feb 2011 22:06:15 +0000 (17:06 -0500)]
commands are always lowercased in interpreter

13 years agohooks for commands
Evan Prodromou [Thu, 3 Feb 2011 22:04:16 +0000 (17:04 -0500)]
hooks for commands