NPE catched, double->single converted:

[shipsimu.git] / application / ship-simu / main / class_BasePersonell.php

diff --git a/application/ship-simu/main/class_BasePersonell.php b/application/ship-simu/main/class_BasePersonell.php
index 65df945617962479b9323f096ff9c1253f228216..e79cd48c869f21f6d3a0f5663e3edbfb4decb8b6 100644 (file)
--- a/application/ship-simu/main/class_BasePersonell.php
+++ b/application/ship-simu/main/class_BasePersonell.php
@@ -4,7 +4,7 @@
  *
  * @author             Roland Haeder <webmaster@ship-simu.org>
  * @version            0.0.0
- * @copyright  Copyright(c) 2007, 2008 Roland Haeder, this is free software
+ * @copyright  Copyright (c) 2007, 2008 Roland Haeder, 2009 Ship-Simu Developer Team
  * @license            GNU GPL 3.0 or any newer version
  * @link               http://www.ship-simu.org
  *
@@ -51,17 +51,10 @@ class BasePersonell extends BaseFrameworkSystem implements Personellizer {
        protected function __construct ($className) {
                // Call parent constructor
                parent::__construct($className);
-
-               // Set description
-               $this->setObjectDescription("Personal");
        }
 
        // Remove min/max ages
        public final function removeMinMaxAge () {
-               if (defined('DEBUG_PERSONELL')) $this->getDebugInstance()->output(sprintf("[%s:%d] Minimum-/Maximum-Alter entfernt.<br />\n",
-                       __CLASS__,
-                       __LINE__
-               ));
                unset($this->MIN_AGE);
                unset($this->MAX_AGE);
        }
@@ -78,7 +71,7 @@ class BasePersonell extends BaseFrameworkSystem implements Personellizer {
                $year = mt_rand(($currYear - $this->MIN_AGE), ($currYear - $this->MAX_AGE));
                $month = 0;
                $day = 0;
-               while (!$this->isDateValid($year, $month, $day)) {
+               while ($this->isDateValid($year, $month, $day) === false) {
                        $month = mt_rand(1, 12);
                        switch ($month) {
                        case 1:
@@ -107,8 +100,8 @@ class BasePersonell extends BaseFrameworkSystem implements Personellizer {
                                        $day = mt_rand(1, 28);
                                }
                                break;
-                       } // switch - END
-               } // while - END
+                       } // END - switch
+               } // END - while
 
                // Set the new birthday
                $this->setBirthday($year, $month, $day);